Bad English grammar previously used in the error log:
"Attempt get value from non-existed value field"
After the change:
"Attempt to get value from non-existing value field"
These are quests where I have found text content issues during
my attempts to get the achievement Loremaster of Kalimdor (horde).
The quest texts contain variables like $c (class) or $r (race)
in wrong places or has missing and/or incorrect text content.
Closes#20448
Improve English text in strings and comments in UpdateFetcher.cpp
- replace incorrect text with the intended words in some output strings
- corrections in the comments to point out the intention of the code
(cherry picked from commit 186375d997caab33eee878a1e102f41939c7a688)
This PR affects the following 2 quests:
Quest ID 4001 "What Is Going On?" - part 2 (Horde)
Quest ID 4342 "Kharan's Tale" (Alliance)
Target of this PR:
Move core script npc_kharan_mighthammer to DB/SAI
(thereby removing 10 lines of hardcoded text).
* DB/conditions: extra gossip conditions
- added conditions for gossip before quest taken and after quest completed.
- removed redundant core script SAY_GET_ME_OUT_OF_HERE comment
* DB/creature: add more text to Kharan
- add all missing creature_text lines to entry 9021 Kharan Mighthammer
- add SAI duration to wait before TEXT_OVER is triggered (3000 ms)
File: zone_borean_tundra.cpp
Script: npc_hidden_cultist
Quest: The Hunt is On, 11794
NPC: Tom Hegger, 25827
Before this change, Tom Hegger does not target player when saying his
aggro text "You don't know who you're messing with, $c! Death beckons!"
and hence the text $c will be shown instead of the player class.
- remove hardcoded text from script npc_beaten_corpse
- remove OnGossipHello() hook, gossip text moved to DB
- use sGossipSelect() hook instead of OnGossipSelect()
- add npc_text 3557 and 3558 as text_id to gossip_menu
- add gossip_menu_option 2871 to NPC 10668 Beaten Corpse
- add condition for gossip_menu_option 2871 in Quest ID 4921
Tested on 4 different characters/classes, male & female.
Thanks to joschiwald for the sGossipSelect() script change.
This line is missing from authserver.conf.dist :
`# MySQL server and their own thread on the MySQL server.`
I have copied this description text line from the matching description in
`worldserver.conf.dist` (line 108 in the 3.3.5 worldserver source file).
This line is also missing in bnetserver.conf.dist , but the files are different
in line number, filename and folder, so bnetserver needs a separate commit.
@joschiwald: Fix written on 31 Jan 2014.
@Nyeriah: suggested null pointer check.
@ariel-: supplied code for null pointer check.
@ccrs: supplied code (cat && spellInfo->CategoryRecoveryTime) to replace (cat && catRec)
@Dduarte: cleanup of bad edit based on my misinterpretation
Fixes issue #11538
Replaces #13941 and #13924
tkrokli