Commit Graph
17453 Commits
Author SHA1 Message Date
Ovahlord 113202ea48 Core/Packets: converted SMSG_PLAY_MUSIC to packet class and corrected packet structure 2020-04-07 15:59:33 +02:00
Ovahlord 479437f8d6 Core/Movement: only set velocity values for follow movement if we have to rely on our follow target's speed 2020-04-06 01:25:23 +02:00
jackpoz 2de72f78d8 Scripts/Guards: Fix spell cast spam after killing npc_air_force_bots guards 2020-04-05 21:05:14 +02:00
Ovahlord d31f19265d Core/Objects:
* store liquid status lookups from UpdatePositionData in a member and draw liquid status information from it instead of doing extra vmap lookups. This also fixes collision height based liquid status states which was leading to false positive movement speed selection for creatures
* remove redundant IsUnderWater helper override from player class as our object based liquid status also considers collision height
2020-04-05 20:41:15 +02:00
Ovahlord 9bf01799f0 Core/Packets: converted SMSG_PLAY_SOUND and SMSG_PLAY_OBJECT_SOUND to packet class and corrected packet structure of
SMSG_PLAY_OBJECT_SOUND
2020-04-05 19:28:49 +02:00
Ovahlord c7f5732571 Core/Units: corrected a warning fix for gcc build 2020-04-05 00:10:53 +02:00
Ovahlord 086c3dc7f4 Scripts/BWD: Maloriak's Arcane Storm can now also be interrupted while channeling 2020-04-04 20:43:05 +02:00
Ovahlord a2b5c10446 Scripts/Mage: updated follow handling for Mirror Images 2020-04-04 20:41:19 +02:00
Ovahlord 03f20765b8 Core/Players: fixed a typo in initial world state preparation 2020-04-04 20:27:28 +02:00
Ovahlord 1281ce61b1 Core/Guilds: properly finish packet reading in guild rank switching opcode 2020-04-04 20:23:03 +02:00
Ovahlord 77cf10ee5f Core/Misc: fixed gcc warnings 2020-04-04 20:20:41 +02:00
Ovahlord 31b86c20e3 Revert "Core/Movement: Improve log when starting a spline with invalid arguments"
This reverts commit f55b15c585.
2020-04-04 19:14:30 +02:00
jackpoz d781c12b57 Core/Movement: Add support to cyclic splines to GenericMovementGenerator
GenericMovementGenerator sets the _duration to the return value of spline.Launch(). For cyclic splines, this is the duration of 1 single cycle, while the spline itself never ends.
To support this edge case in GenericMovementGenerator we just never update the _duration timer for cyclic splines.

# Conflicts:
#	src/server/game/Movement/MovementGenerators/GenericMovementGenerator.cpp
2020-04-04 19:13:21 +02:00
jackpoz 14e585d66b Scripts/Ulduar: Fix Ominous Clouds movements
Fix Ominous Clouds being only clockwise, now they move both clock and counter-clock wise.
Add a workaround for GenericMovementGenerator not handling correctly cyclic splines started by MoveCirclePath(), stopping the movement after a single round. The workaround code can be removed once the bug in GenericMovementGenerator is fixed.
2020-04-04 19:11:23 +02:00
jackpoz eba5dafada Core/Movement: Don't start a spline with just 1 point in FlightPathMovementGenerator
Don't start a spline with just 1 point in FlightPathMovementGenerator. This happens when teleporting to a BG while on a taxi after second last node but closer to last node.
In this case the Player will be teleported to the last node.
2020-04-04 19:09:48 +02:00
jackpoz f55b15c585 Core/Movement: Improve log when starting a spline with invalid arguments
Improve log when starting a spline with invalid arguments, for example when starting a spline with just 1 point.
2020-04-04 19:03:31 +02:00
ForesterDev 337aa3614b Core/Packets: Added SMSG_WORLD_STATE_UI_TIMER_UPDATE (#24312)
(cherry picked from commit 7d88f8c491837dcfd02995a32310c196102200ce)

# Conflicts:
#	src/server/game/Handlers/MiscHandler.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h
# Conflicts:
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Packets/MiscPackets.h
2020-04-04 19:02:30 +02:00
ForesterDev e2643dabb0 Core/Packets: update & enabled CMSG_SHOWING_CLOAK, CMSG_SHOWING_HELM (#24394)
(cherry picked from commit a47d57d1dbd7bc944972d7ef1773739e5019adde)

Co-authored-by: DJScias <zumbak04@gmail.com>
# Conflicts:
#	src/server/game/Server/Packets/AllPackets.h
#	src/server/game/Server/Packets/CharacterPackets.cpp
#	src/server/game/Server/Packets/CharacterPackets.h
#	src/server/game/Server/WorldSession.h
2020-04-04 18:59:02 +02:00
Shauren a853bacd1d Core/Creatures: Fixed crash when guards get killed by periodic auras whose caster is offline or despawned 2020-04-04 18:51:57 +02:00
Ovahlord 22ec89409d Core/Instances: fixed a typo in selecting the challenge reward type 2020-04-03 17:20:20 +02:00
Ovahlord fd668fbd78 Core/Instances: fixed build 2020-04-03 16:18:18 +02:00
Ovahlord 2c486e9652 Core/Instances: fixed an exploit that was causing dungeon and raid guild challenges falsely getting rewarded when a level appropriate player was in a raid with a higher level players 2020-04-03 06:53:56 +02:00
funjoker 5897d071f2 Scripts: Fix nopch build 2020-04-01 23:52:36 +02:00
Ovahlord c2a676b774 Core/Movement: rewrite formation movement
* formation members will now draw their speeds from their formation leader and increase them based on how far they are behind their leader
* added sniffed periodic movement interval which additionally helps keeping up with formation leaders
* the formation movement generator will now persist permanently instead of being a one shot type and handles everything on its own once applied
2020-04-01 01:32:24 +02:00
Ovahlord 05bdaf47fb Core/Movement: if a creature follows an npc it will now respect the target's velocity instead of running all the time 2020-03-31 17:05:13 +02:00
Ovahlord f2ee7412bc Core/Movement: implement a helper to get the velocity of a unit's ongoing spline 2020-03-31 16:56:37 +02:00
Ovahlord 60f630027f scripts/Companions: scripted Singing Sunflower 2020-03-30 19:46:00 +02:00
Ovahlord 1bac4289d7 Core/Movement: handle player sideward and backward movement cases for follow movement 2020-03-30 18:54:17 +02:00
Ovahlord 347a94f9f4 Core/GameObjects: fixed loading gameobject guid specific scriptnames 2020-03-30 17:20:01 +02:00
Ovahlord fe4ff01e30 Core/Movement: converted SMSG_MOVE_KNOCK_BACK to packet class 2020-03-29 19:12:32 +02:00
Ovahlord d4ef0b91b9 Core/Spells: removed deprecated tempfixes for several pull towards spells which are not handled correctly 2020-03-29 19:11:59 +02:00
Ovahlord dc64d9ab91 Core/Spells: fixed a possible client crash introduced in b2af17eb4a which was not covering cataclysm spell scenarios where a pull towards dest spell can indeed have a misc value of 0 2020-03-29 19:11:22 +02:00
NoName b2af17eb4a Core/Spell: Proper SPELL_EFFECT_PULL_TOWARDS_DEST implementation for players
* Core/Spell: SPELL_EFFECT_PULL_TOWARDS correction
2020-03-29 16:23:47 +02:00
Ovahlord 18605adf68 Scripts/HoO: updated Earthrager Ptah's script to new scripting model and greatly simplified handlings for Tumultous Earthstorms on heroic difficulty 2020-03-29 15:36:23 +02:00
Ovahlord 9bfe43a88a Core/Entities: remove PhaseMask
* database fields and values will remain until they have been converted to their according phase IDs
2020-03-29 04:05:43 +02:00
Ovahlord ce6093f8cd Scripts: make travis happy 2020-03-29 01:08:27 +01:00
Ovahlord 9eeb4cc6a7 Scripts/VP: Howling Gale will no now correctly apply its aurastate to players uppon hit to prevent multiple knockbacks in quick succession 2020-03-29 01:07:13 +01:00
Ovahlord dfef83ee3e Scripts/GB: correct handling for Forgemaster Throngus' Personal Phalanx damage reduction 2020-03-29 00:57:22 +01:00
DevPrime 914da12cc1 Core/Misc: fixed no pch build 2020-03-27 23:48:19 +01:00
Ovahlord 84931537fc Core/Movement: use the follow angle tolerance only for the final line up movement 2020-03-27 19:16:34 +01:00
Ovahlord 0cf82dc50b Core/Movement: added a missing change that was causing companions to not allign to their follow target's speed 2020-03-27 19:10:19 +01:00
Ovahlord c9961e6a94 Core/Movement: rewrite follow movement 2020-03-27 18:59:16 +01:00
Ovahlord 98b075cb4b Core/Spells: implement TARGET_CORPSE_SRC_AREA_RAID and updated remaining resurrection effect handlers for updated corpse targeting 2020-03-26 22:03:58 +01:00
Ovahlord df193945d9 Core/Spells: implement corpse target type support and properly fix resurrections 2020-03-26 19:54:54 +01:00
Ovahlord ded981ac59 Core/Spells: fixed all remaining T11 bonus effects for all classes 2020-03-25 20:47:45 +01:00
Ovahlord 5e5ec5c70f Core/Spells: SPELL_AURA_OVERRIDE_AUTOATTACK_WITH_MELEE_SPELL will now pull its spell ids for off-attacks from basepoints instead of misc values since there is only one case that uses it in Baleroc's encounter 2020-03-20 11:31:38 +01:00
jackpoz 359eb2bc67 Core/Spells: Fix missing "Inventory is full" with spells that create more than 1 item 2020-03-19 23:31:35 +01:00
Shauren 9ad9398f04 Core/PacketIO: Fixed SMSG_UPDATE_OBJECT packets going missing for new items
Closes #16906
2020-03-19 20:45:57 +01:00
Ovahlord 9dd475d2fc Core/Packets: converted SMSG_GUILD_COMMAND_RESULT, SMSG_GUILD_BANK_TEXT_QUERY_RESULT, SMSG_GUILD_NAME_CHANGED, SMSG_QUERY_GUILD_INFO_RESPONSE and SMSG_GUILD_RANKS to packet class 2020-03-18 23:09:35 +01:00
Ovahlord f1f00c3ec3 Core/Datastores: refactor DBC storage helpers to use a class and fixed no pch build 2020-03-18 15:24:25 +01:00