Commit Graph
2341 Commits
Author SHA1 Message Date
Shauren 1cdc2e8c2a Core/Movement: Fixed creature movement on transports 2013-12-31 14:12:02 +01:00
Nawuko 6d21d33aac Core: user defined literals need a space in front 2013-12-30 20:35:37 +01:00
Shauren 079905e29a Core/Transports
* Fixed transport orientation
* Fixed transport position desynchronization for stoppable transports
* Ignore spawnMask errors for objects spawned on transports
2013-12-29 14:59:06 +01:00
Shauren 29acf99ea6 Core/Transports: Fixed new spawned transports not being visible for players already present on map 2013-12-28 12:44:22 +01:00
Malcrom fe95371d9a Core/Scripting: Replace casted with cast as casted is not a word. 2013-12-25 14:16:55 -03:30
Shauren 293915db39 Core/Quests: Fixed icon shown above questgivers with daily quests that have already been completed once by a character
Closes #11331
2013-12-25 02:08:05 +01:00
Shauren 107af52853 Core/Chat: Refactored building chat packets
* Moved everything into one specialized method instead of being scattered all over the place
* Allow localizing creature names in chat messages (when using $N)
* Send SMSG_GM_MESSAGECHAT for gm messages
2013-12-23 14:23:49 +01:00
Malcrom b8f9442ec9 Core/Player: Fix logic for questgiver cast spell 2013-12-16 18:50:51 -03:30
jackpoz b3c810a0fb Core/Misc: Fix warning
Partially revert f0a742a8c4 to fix a warning about unhandled switch case (the same case that Coverity reported as dead code) .
2013-12-16 19:52:50 +01:00
jackpoz e90a7f82d4 Core/AI: Fix CreatureAI left uninitialized
Fix CreatureAI left uninitialized for 1 server tick for Creatures with DeathState:DEAD . This is a workaround required after c9cf2f059f changes .

Valgrind log:
 Conditional jump or move depends on uninitialised value(s)
  at : npc_draenei_survivor::npc_draenei_survivorAI::MoveInLineOfSight(Unit*) (zone_azuremyst_isle.cpp:104)
  by : CreatureAI::MoveInLineOfSight_Safe(Unit*) (CreatureAI.cpp:123)
  by : CreatureUnitRelocationWorker(Creature*, Unit*) (GridNotifiers.cpp:134)
  by : Trinity::AIRelocationNotifier::Visit(GridRefManager<Creature>&) (GridNotifiers.cpp:252)
 Uninitialised value was created by a heap allocation
  at : operator new(unsigned long) (vg_replace_malloc.c:319)
  by : npc_draenei_survivor::GetAI(Creature*) const (zone_azuremyst_isle.cpp:66)
  by : ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:792)
  by : FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
  by : Creature::AIM_Initialize(CreatureAI*) (Creature.cpp:716)
  by : Creature::AddToWorld() (Creature.cpp:190)
2013-12-15 21:14:47 +01:00
Malcrom a2e7191b26 Core/Unit: prevent COMMAND_ATTACK being added for Trained Rock Falcon.
Also added spells for Trained Rock Falcon to db.
2013-12-15 13:43:18 -03:30
jackpoz f0a742a8c4 Core/Misc: Remove unused code
Remove unused debugging code added in MaNGOS r5067.
Remove dead code from a switch found by Coverity.
2013-12-15 13:37:49 +01:00
w1sht0l1v3 89ee8cbac1 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries. 2013-12-15 14:09:49 +02:00
Malcrom dcfbe53552 Core/Player: Fix questgiver spell cast. 2013-12-14 20:22:39 -03:30
Discover- ec8e94c6ac Core/AI: Fix an issue where the OnQuestAccept hooks were not called for auto-completed quests.
Fixes #11304
2013-12-14 19:39:47 +01:00
jackpoz 1c0903e286 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
2013-12-14 18:41:26 +01:00
Malcrom dd546f073a Core/Player: Add another exception to questgiver spell casting. 2013-12-14 14:05:24 -03:30
Shauren 54fd53f7e3 Core/Movement: Fixed possible invalid memory access 2013-12-12 09:50:52 +01:00
trickerer 91ebea4a77 Don't allow units to enter combat upon death 2013-12-11 09:38:24 +07:00
jackpoz f418f4cf94 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values in scripts.
Add spell id validation in Unit::SpellNonMeleeDamageLog() .
2013-12-08 22:04:30 +01:00
Malcrom 5c15e88da9 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries. 2013-12-08 11:55:28 -03:30
Warpten 98d2dbbd3f Core/Spells: Fixed rare issues where spell modifiers would not be correctly restored.
Happens in case of a spell having more than one modifier granted by an aura.
2013-12-08 15:06:10 +01:00
Malcrom af5d3daeab Core/Vehicle: Add an extra check for required energy before setting power. 2013-12-05 13:07:15 -03:30
jackpoz 7806b7c493 Core/Chat: Fix ChatFlood.MessageCount not being handled correctly
Fix Anti-flood chat system to always allow 1 more message than the count specified in the ChatFlood.MessageCount config parameter.
2013-12-03 21:47:52 +01:00
Malcrom 3485656aee Core/Player: GetRewSpellCast & GetRewSpell should not be cast by questgiver if effect type SPELL_EFFECT_LEARN_SPELL 2013-12-01 22:00:10 -03:30
jackpoz 04cc51a6cf Core/Misc: Fix some static analysis issues
Fix some static analysis issues, mostly false positive about fields not initialized in the constructor. It's good practice anyway to always initialize them.
2013-12-01 16:19:30 +01:00
jackpoz 788c8693a4 Core/Transports: Remove unused field
Remove unused Transport::_moveTimer field, static analysis complains about it being uninitialized.
2013-11-28 20:05:36 +01:00
joschiwald 1196b93e94 Core: fix build 2013-11-26 18:14:01 +01:00
joschiwald 9a0bb93b33 Scripts: fix warning and cleanup npc_apprentice_mirveda 2013-11-24 21:49:51 +01:00
joschiwald 2c307aa67c Scripts/Oculus: cleanup a bit 2013-11-24 21:17:45 +01:00
Malcrom 6ba4d70b5c Core/Player: Allow questgiver, if npc, to cast quest RewSpellCast & RewSpell rather than player. 2013-11-23 00:17:37 -03:30
joschiwald 82d4ed5615 Core/Movement: fix player fall under ground on teleport 2013-11-21 16:13:13 +01:00
joschiwald 0a2a552b5a Core/Transports: addition to f0c4d0ac05
Core/Players: fix logic in Player::SendInitWorldStates()
2013-11-21 14:02:13 +01:00
jackpoz d2065b0e50 Core/Transports: Fix triggered assertion in Transports
Relocate only Players in world when updating transport's and its passengers' positions.
Thanks vlad852 .
Closes #11209 .
2013-11-18 20:57:02 +01:00
jackpoz 2cad987a58 Core/Misc: Fix a compile warning.
Properly fix #11229 since eacf961e72 changes didn't affect the original issue.
2013-11-18 20:35:40 +01:00
Discover- eacf961e72 Core/Misc: Fix a compile warning.
Closes #11229
2013-11-18 11:18:28 +01:00
jackpoz f0c4d0ac05 Core/Transports: Fix few transport issues on relog.
Properly save transport related data to database when saving a Player .
On Player login update the current position as relative to transport, in case the transport moved.
2013-11-17 15:17:40 +01:00
joschiwald 0790138d73 Core. fix build and some codestyle changes 2013-11-13 23:32:38 +01:00
MrSmite 79a2d6b7fc Core/Spells: Fixed Revive Pet to revive the pet near the owner
Closes #11196
2013-11-11 13:22:41 +01:00
Shauren 1966a78b9f Core/Movement: Backported spline stop fix from 4.3.4 branch - use Stop spline type for stopping movement instead of starting movement that ends in creature's current position 2013-11-10 18:52:20 +01:00
Spp 94e2b9332a Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive) 2013-11-08 10:50:51 +01:00
Malcrom 88c46a6886 Core/CreatureGroups: Calculation change requested by Shauren. 2013-11-07 19:06:20 -03:30
Malcrom b4a0533d81 Core/CreatureGroups: Add fields to creature_formations and code to prevent creature crossover in formations.
Wiki update and db values too follow.
2013-11-06 23:20:06 -03:30
Shauren ca34b701cb Core/Transports: Fixed a few mistakes in GO passenger teleports (currently unused), thanks joschiwald for spotting them 2013-11-02 16:33:39 +01:00
Shauren 0ee3093536 Fixed typo in 39175ac680 2013-11-02 13:46:10 +01:00
Shauren 39175ac680 Core/Transports
* Fixed fall damage on transports while teleporting
* Fixed packets not being received by owner if sent by a controlled minion
* Fixed an issue when a teleporting transport would attempt to reload its creature passengers on old map

Closes #11140
2013-11-02 13:22:14 +01:00
leguybrush 0a308144a8 Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }. 2013-10-28 14:36:07 -04:00
Ascathor 2607738990 Core/Code: Unify codestyle for brackets: {} to { }.
Also added missing copyright to some files.
2013-10-27 23:46:02 +01:00
Shauren f0794d7585 Core/Transports: Correct path generation for a few transports 2013-10-27 11:15:56 +01:00
Shauren b81bf7d025 Core/Spells: Implemented additional conditions for spells that start cooldown after an event instead of after cast 2013-10-26 14:39:00 +02:00