Moves the entire NPC script to the database and corrects a logic error where players who have rewarded the quest Scarlet Subterfuge and lost the disguise before taking the quest In Dreams were no longer able to get the disguise.
- Add missing const attribute on CheckBoundary arg.
- Prevent AI from attacking a target that is out of bounds. This prevents exploids such as killing Gluth/Deathbringer from out of bounds.
Replace previous script with one from sniff data, incorporated the combat spells from what @Rushor posted as did not script those as not actually needed for this quest.
(cherry picked from commit ae20b2ab561bc07d85f443ae914bc597c9d6ac6e)
(cherry picked from commit 921d893c2a82eb6ac0762bf7001df87911b44611)
(cherry picked from commit 9ab10d6e680ca835d1dfdfbceb9f18f330f994fc)
(cherry picked from commit 00c878e73a8c6b8ce3339d224ab5611df3bbd07c)
(cherry picked from commit ff9c999334d87acc3fcea9737753c30b7f1abe25)
(cherry picked from commit bc94bacce404401a480b6871eaa7bc38d766014c)
(cherry picked from commit d5b0ffbe9b0c07beb8d0dfc52a6532c2da805285)
* This fixes the height at which player is instantly killed when falling from The Frozen Throne
* Set PLAYER_FLAGS_IS_OUT_OF_BOUNDS on players under the map to enable release spirit button while still falling
Note: Extracting new maps is required
(cherry picked from commit 4f78efd4633f79285f176b61367a067b2cd90e2b)
# Conflicts:
# dep/PackageList.txt
# src/server/game/DataStores/DBCStructure.h
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Handlers/MovementHandler.cpp
# src/tools/map_extractor/CMakeLists.txt
# src/tools/map_extractor/System.cpp
# src/tools/map_extractor/adt.h
# src/tools/map_extractor/loadlib.cpp
* we are using this adding in disables for many spells. if the object edges calculation is improved this addition can be removed
* thanks to Runico for report
* closes#13600
By @xerkoss Closes#13572
Ok I was skeptical of this fix too when I fist saw it but has been proven to solve issues with this quest ie event always triggers when player obtains the Crate Disguise Subspell, this is just changing the event from been triggered on areatrigger to been triggered by event id used by spell
Correct my botched commit :-)
Only remaining issue is that when players get ejected from boats they dont get returned to land
Different waypoints are needed for stormwind for 6.x.x only you will find these in the closed issue its just a matter of replacing waypoints (which you will find in the issue and updating the on reached wp event for stormwind boats to last wp as is different.
Closes#14027
* An end to the suffering (by me) Closes#16362
* Catching up with Brann quest linking (by @velinath) Closes#15955
* Valkyrion Must Burn (by me) Closes#14584
Treeston