Commit Graph
474 Commits
Author SHA1 Message Date
joschiwald 6b52cef5bc Core/Spells: corrected implementation of SPELL_EFFECT_QUEST_START 2014-04-21 16:48:05 +02:00
joschiwald 29610b250d Core/Spells: fixed Throw Shield Visual and Clone Weapon 2014-04-05 00:37:07 +02:00
jackpoz 8c44259fae Core/Misc: Fix some static analysis issues
Fix uninitialized values, most of which are false positives, always initialized before being accessed.
Add some asserts and additional NULL checks as sanity checks. Use SpellMgr::EnsureSpellInfo() if the spell id is valid and always supposed to return a valid not-NULL SpellInfo* .
2014-03-27 21:43:59 +01:00
joschiwald b000fdca70 Core/Entities: allow interaction with gameobject questgivers if player can take or return quests
Closes #11269
Closes #8898
Closes #10204
Closes #11410
Closes #7053
Closes #6189
Closes #9474
2014-02-06 21:23:18 +01:00
joschiwald acd46085d1 Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscripts
Closes #1719
Closes #3186
2014-01-30 02:40:12 +01:00
joschiwald 6dc15294e2 Core/Spells: move paladins judgements to spellscripts 2014-01-26 23:56:53 +01:00
Discover- 735cebf7a3 Core/Commands: The .setskill command is now usable even if the player doesn't already have the skill learned. 2014-01-18 01:05:03 +01:00
Discover- ebfdeb067f Core/Spells: Rename Spell::EffectSummonDeadPet with Spell::EffectResurrectPet and get rid of two TODO's that are already done. 2014-01-17 17:54:52 +01:00
joschiwald a60ba240b7 Core/Entities: add some log messages in CheckCreatureTemplate
* Happy Error Spam
2014-01-06 20:30:11 +01:00
joschiwald cd76d32907 Core/Entities: correct creature damage, offhand damage should work too
* todo: some creatures need dmg_multiplier update in creature_template
2014-01-04 18:22:06 +01:00
Vincent_Michael 20004050bc Update copyright note for 2014.
Happy new year.
2014-01-01 00:07:53 +01:00
Shauren 9a1282aac6 Core/Spells: Fixed movement from SPELL_EFFECT_PULL_TOWARDS_DEST 2013-12-31 13:08:45 +01:00
Malcrom fe95371d9a Core/Scripting: Replace casted with cast as casted is not a word. 2013-12-25 14:16:55 -03:30
Shauren 107af52853 Core/Chat: Refactored building chat packets
* Moved everything into one specialized method instead of being scattered all over the place
* Allow localizing creature names in chat messages (when using $N)
* Send SMSG_GM_MESSAGECHAT for gm messages
2013-12-23 14:23:49 +01:00
Discover- e17af3f203 Core/Quests: Fix an issue where auto-completed quests would not be automatically completed if the quest was added through either the SmartAI action_type SMART_ACTION_ADD_QUEST, the spell effect SPELL_EFFECT_QUEST_START or the opcode CMSG_QUEST_CONFIRM_ACCEPT. Also fixes auto-complete quests in the SAI and opcode case not calling the AI hook. 2013-12-14 19:42:31 +01:00
MrSmite 79a2d6b7fc Core/Spells: Fixed Revive Pet to revive the pet near the owner
Closes #11196
2013-11-11 13:22:41 +01:00
Spp 94e2b9332a Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive) 2013-11-08 10:50:51 +01:00
Shauren b81bf7d025 Core/Spells: Implemented additional conditions for spells that start cooldown after an event instead of after cast 2013-10-26 14:39:00 +02:00
Shauren 3e12fe84c8 Core/Transports: Fixed players taking fall damage when teleporting from transports
Closes #11076
2013-10-22 17:02:01 +02:00
Spp cfaea769bc Core/RBAC: Move RBAC code to namespace rbac 2013-09-27 13:35:45 +02:00
jackpoz d0b42ee4ec Core/Spell: Fix Blood Tap array overflow
Fix Blood Tap spellid 45529 accessing the 7th element of a size 6 array.
Coverity issue id 1023095.
2013-09-15 12:31:48 +02:00
joschiwald f66120060a Scripts/Spells: drop obsolete code 2013-09-07 01:21:36 +02:00
joschiwald adef15cd0f Core/Spells: add an other condition to SpellInfo::NeedsToBeTriggeredByCaster to correct spells with are wrongly triggered by target instead of caster
- convert archavons rock shards to spellscript (now it works properly)
- add a spellscript for one spell that can't be corrected by this (and delete the sai hack, now i uses the correct spell)
2013-09-06 20:57:38 +02:00
joschiwald 7ef1f0738b Core/Battlegrounds/IoC: fix fortress teleport pads
(and replace a hack with an other hack)

Closes #5846
Closes #7993
Ref #8984
2013-09-05 00:59:22 +02:00
Shauren 16eefd18fa Scripts/Icecrown Citaldel: Fixed spells cast by Professor Putricide during heroic Festergut and Rotface encounters
Closes #7641
Closes #8243
2013-08-30 23:00:43 +02:00
Vincent-Michael c0bf535e5b Core/Spells: Convert "Summon Memory" in spell script 2013-08-11 02:07:42 +02:00
Spp b05665660a Core/Battleground: Get rid of dinamic casts BattlegroundXX outside Battleground scope by implementing generic functions (1/2)
- HandleQuestComplete, CanActivateGO and IsSpellAllowed
2013-08-07 10:31:13 +02:00
Shauren ac10589eda Core/Misc: Fixed some issues found by Coverity Scan 2013-08-01 21:31:11 +02:00
joschiwald 380cf5d241 Core/Misc: replace (Player*) casts with ToPlayer() 2013-07-21 01:38:21 +02:00
hexa- 7da727c6fe Core/Spells: Remove correct stack of Deadly Poison when using Envenom 2013-07-02 05:27:09 +02:00
Malcrom 4096c54efa Core: More Function name updates 2013-06-11 22:02:00 -02:30
Malcrom ec474a62e5 Core: More Function Renaming. 2013-06-11 21:25:12 -02:30
Malcrom 66978cfc3b Core: Some function renaming. 2013-06-11 19:54:27 -02:30
Malcrom 047608e7de Core/SAI: Add check so npc will not send text to pet. Also updated isPet() to IsPet(). 2013-06-11 18:39:51 -02:30
Shauren f8d9a8d2e9 Core/Spells: Fixed fishing broken in a recent commit 2013-06-08 23:11:18 +02:00
Shauren 9c0d69e33d Core/Items
* Updated structure of SMSG_ENCHANTMENTLOG and send it when changing enchantments on item
* Implemented SMSG_SOCKET_GEMS_RESULT sent when socketing is finished
2013-05-25 11:09:21 +02:00
Shauren 7d46703413 Core/Misc: Another batch of fixes for issues found by static analysis 2013-05-17 21:30:02 +02:00
Spp d1677b2db0 Core/Logging: Performance-related tweaks to logging system
All sLog->out* functions (except outCommand atm) are replaced with TC_LOG_* macros.
    Memleak fix
2013-05-13 15:07:36 +02:00
Shauren e2f8abd48d Core/Spells
* Removed area MiscValue check for spells with SPELL_EFFECT_BIND, it's purpose is only to be sent in packets, not determine real area player will be bound to.
* Corrected guid sent in SMSG_PLAYERBOUND, it should be caster's guid, not player's
* Also updated position for Teach: Death Gate

Closes #9661
2013-05-11 12:16:36 +02:00
Shauren 24a7a6f965 Scripts/Pit of Saron: Changed Overlord's Brand script to be safer
Closes #9125
2013-04-12 17:54:40 +02:00
Shauren 53b1f6e2e5 Core/Spells: Reimplemented SPELL_ATTR0_LEVEL_DAMAGE_CALCULATION 2013-04-04 23:31:13 +02:00
Gacko 7df4d147e3 Core/Gossips: Fix usage of PrepareGossipMenu with GOs 2013-04-04 19:57:06 +02:00
kandera abbe692d72 Core/Cleanup: cleanup tabs and change them to spaces 2013-04-03 18:22:22 -04:00
kandera bd5dcf4927 Core/Spells: add the value calculation for all three spell effects on the triggered spell. thx shauren 2013-04-03 18:15:24 -04:00
kandera e2444c04e2 Core/Spells/Auras: fix the way we handle spells that use SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE and SPELL_AURA_PERIODIC_TRIGGER_SPELL_WITH_VALUE Closes #7622 2013-04-03 18:08:25 -04:00
kandera 7fb539c0d8 Core/Spells: Fix blood-caked blade damage modifier. Author AliveShiro Closes #7831 2013-03-31 19:47:32 -04:00
Nefarion 49fd11ab5a First step of comment style refactoring to doxygen-style. 2013-03-08 21:55:37 +01:00
Spp 377cfdb560 Core/RBAC: Fix multiple permissions and remove multiple config options that are currently implementes by RBAC
- Remove config options: CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHAT, CONFIG_ALLOW_TWO_SIDE_INTERACTION_MAIL, CONFIG_GM_LOG_TRADE, CONFIG_ALLOW_TWO_SIDE_ACCOUNTS, CONFIG_ALLOW_TWO_SIDE_WHO_LIST, CONFIG_ALLOW_GM_FRIEND, CONFIG_ALLOW_TWO_SIDE_ADD_FRIEND, CONFIG_SILENTLY_GM_JOIN_TO_CHANNEL
- Fix RBAC_PERM_SKIP_CHECK_CHAT_SPAM (Was checking spam for those that had the permission)
- Only check RBAC_PERM_TWO_SIDE_INTERACTION_CHAT for sender of whispers (Restores GM being able to whisper players)
- Only check RBAC_PERM_TWO_SIDE_INTERACTION_MAIL for sender
- Fix .ticket assign <Player>, with last RBAC change it was changed by mistake from Player to Account
2013-03-08 13:15:25 +01:00
Shauren af4ac778d7 Core/Quests: Implemented quest flag forcing the player to be flagged for PvP as long as the quest is in his log. 2013-02-26 17:14:13 +01:00
Spp 8810fcb575 Core/RBAC: Add new Permission "Log gm trade". Config option still active, but will affect only to users with that permission granted 2013-02-25 15:48:18 +01:00