Commit Graph
17246 Commits
Author SHA1 Message Date
jackpoz 6e27841382 Core/Misc: Refactor scripts to fix static analysis warnings
Seventh batch of fixes targeting 100 issues reported by Coverity
2014-09-21 22:15:04 +02:00
Vincent-Michael 1d8feb271c Core:/SmartScript: Added log for item has credit spell blabla 2014-09-21 17:45:57 +02:00
jackpoz b71f8367e4 Scripts/Shadowmoon Valley: Fix static analysis issues added in cd48ee01c0
Fix static analysis issues added in cd48ee01c0 about uninitialized values and pointers possibly point to free'd memory being dereferenced.
In memory of all the developers who got banned from IRC in the process of fixing these issues.
2014-09-21 17:21:04 +02:00
Warpten e70ce42416 Merge pull request #13180 from ShinDarth/335_fix
Core/ObjectMgr: corrected error labels
2014-09-21 15:24:51 +02:00
ShinDarth 4892408ed0 Core/ObjectMgr: corrected error labels 2014-09-21 15:21:30 +02:00
Malcrom cd48ee01c0 Scripting/Shadowmoon Vally: Added scripting for Infernal Attackers. 2014-09-21 10:46:49 -02:30
Vincent-Michael c243bf96d4 DB/Spells:
- Added EffectItemType columns to spell_dbc table
- Fix "Create Bundle of Bloodthistle"
2014-09-21 04:18:31 +02:00
jackpoz a209fc30ff Core/Misc: Avoid Helgrind reporting libstdc++ false positive race conditions 2014-09-20 22:35:13 +02:00
jackpoz b5e3535dbf Core/Misc: Refactor scripts to fix static analysis warnings
Sixth batch of fixes targeting 100 issues reported by Coverity
2014-09-20 20:21:54 +02:00
joschiwald 54c195bee8 Core/Spells: fixed Intervade
Closes #13171
2014-09-20 19:15:37 +02:00
Shauren d87c23cdaf Core/Achievements: Fixed realm first kill achievement restrictions - now only the first group will be able to complete it
Closes #2957
2014-09-20 19:07:39 +02:00
Shauren 16ecf9ec5d Core/Guilds: Fixed guild rank delete framexml event params 2014-09-20 10:47:14 +02:00
Nyeriah 2c2d3a8ffc Scripts/Auchindoun: Darkweaver Syth
- Despawn minions on death/reset
- Misc clean up
2014-09-20 02:58:08 -03:00
Vincent-Michael 3b87ab4536 Revert "Core: Fix build for msvc14"
This reverts commit bd522a3853.

Meh -.-
2014-09-20 05:51:37 +02:00
Vincent-Michael bd522a3853 Core: Fix build for msvc14 2014-09-20 05:39:26 +02:00
joschiwald ac3623b316 Kill new compile warnings 2014-09-20 00:43:45 +02:00
joschiwald bf37dbfb2a Core/Battlefield/WG: fixed warnings
Ref #13169
Closes #12714
2014-09-20 00:26:58 +02:00
ShinDarth 83f82b4a04 Core/ObjectMgr: check creature.orientation and gameobject.orientation range in loading
Closes #13156
2014-09-19 22:36:50 +01:00
xjose93 0d50833d20 Core/Commands: Fix displaying in .baninfo character command. 2014-09-19 18:58:12 +02:00
Shocker 80f77977f1 Core/Grids: Replace some magic numbers with constants
(P.S.: That's why! @cs_misc.cpp)
2014-09-19 18:03:49 +03:00
DDuarte c678eaa71e Core/MapScripts: Use proper enum value for boss whisper in SCRIPT_COMMAND_TALK 2014-09-19 15:19:53 +01:00
DDuarte 878b7d3811 Core/MapScripts: Use proper source unit in SCRIPT_COMMAND_TALK
Closes #13161
2014-09-19 15:04:24 +01:00
Malcrom a32d15c4ef Scripting/Tanaris: added a few enums 2014-09-19 01:40:15 -02:30
DDuarte 256ad379dd Oops. 2014-09-19 03:39:57 +01:00
DDuarte cefcde9ba9 Core/Misc: Multiple static analysis issues fixed (small optimizations and clear code) 2014-09-19 03:30:02 +01:00
joschiwald e6b7de8c97 Fixed build 2014-09-19 04:20:01 +02:00
joschiwald 0f1f7ef401 Core/Misc: multiple changes
* fixed build
* apply tc codestyle to ObjectGuid class
* fixed warning
2014-09-19 03:16:59 +02:00
joschiwald 9d9919f6e0 Core/AreaTriggers: enable areatrigger teleports in battleground
Closes #11999
2014-09-19 01:48:35 +02:00
joschiwald e567ab9597 Core/Texts: added TextRange parameter to creature_text
Ranges:
0 - Normal (Default)
1 - Area
2 - Zone
3 - Map
4 - World

Ref #13116
2014-09-18 23:33:59 +02:00
jackpoz 08069dfba7 Shared/Logging: Use standard format specifier for size_t
Use standard format specified PRIuPTR for printing/logging size_t type that can be either uint32_t or uint64_t depending on platform/build configuration
2014-09-18 21:24:40 +02:00
Shauren 31656c0213 Core/Trade: Fixed enchanting soulbound items in trade
Closes #12850
2014-09-18 21:15:39 +02:00
Vincent-Michael ad49bd5194 SQL: Fix sql import 2014-09-18 06:05:38 +02:00
joschiwald 72ed5bfc93 Core/Misc: changed trinity string id to unsigned and removed obsolete code 2014-09-18 02:36:28 +02:00
joschiwald 60176157a7 Scripts/Gundrak: cleanup InstanceScript
* converted Gal'Darah and Moorabi to BossAI
* add and correct some texts
* fixed altar activation spell visual
2014-09-18 00:38:28 +02:00
joschiwald b08dcb1d99 Core/Scripts: implemented a guid map in InstanceScript, this way you can easier store guids and access its objects 2014-09-18 00:25:05 +02:00
joschiwald 053beae172 Core/Spells: consider spell speed in SPELL_EFFECT_CHARGE
Misc: removed some duplicate guid words in logs
2014-09-17 23:24:31 +02:00
Shauren e57a63939e Core/NetworkIO: Fixed queued packets not being properly sent causing players to be stuck during loading
Closes #13120
2014-09-17 23:06:34 +02:00
MitchesD 763a21d376 Merge pull request #13159 from ShinDarth/335_fix2
Corrected grammar of some strings
2014-09-17 19:29:21 +02:00
ShinDarth 1a068659b6 Core/Grammar: corrected grammar of some strings 2014-09-17 19:03:15 +02:00
Duarte Duarte 048e043d0d Merge pull request #13154 from Unholychick/casts
Core/Spells: Fix some -Wconversion warnings
2014-09-17 16:09:18 +01:00
Vincent-Michael 7db99ca007 Core: Fix warnings 2014-09-17 16:58:08 +02:00
DDuarte af7daba02d Core/SAI: Remove SMART_ACTION_STORE_VARIABLE_DECIMAL
It's not used.
2014-09-17 01:07:29 +01:00
Unholychick 6477e96cca Core/Spells: Fix some -Wconversion warnings
Attempt to fix #13152 by properly casting between data types during damage calculations.
2014-09-16 23:56:05 +02:00
Nyeriah 2a262aad21 Scripts/Quest: Script spell for quest "Fumping"
Updates https://github.com/TrinityCore/TrinityCore/issues/11418
2014-09-16 17:49:16 -03:00
Shauren 7d1d55124c Merge branch 'ObjectGuid' of https://github.com/TrinityCore/TrinityCore
Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
	src/server/game/Scripting/MapScripts.cpp
	src/server/scripts/Northrend/Naxxramas/instance_naxxramas.cpp
	src/server/scripts/Northrend/Nexus/EyeOfEternity/instance_eye_of_eternity.cpp
	src/server/scripts/Northrend/Nexus/Nexus/boss_anomalus.cpp
	src/server/scripts/Northrend/Nexus/Nexus/boss_magus_telestra.cpp
	src/server/scripts/Northrend/Nexus/Oculus/boss_varos.cpp
	src/server/scripts/Northrend/Ulduar/HallsOfStone/halls_of_stone.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_auriaya.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_freya.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_hodir.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_ignis.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_razorscale.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_svala.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_ymiron.cpp
2014-09-16 21:50:01 +02:00
Shauren 9b933b4a29 Core/Misc: Removed explicit qualifier from ObjectGuid uint64 conversion operator 2014-09-16 20:57:11 +02:00
Shauren 878073d516 Core/Logging: Fixed incorrect usage of guid in logs 2014-09-16 20:47:08 +02:00
Shauren bee9a3069b Core/Scripts: Fixed incorrect guid usage in logs 2014-09-16 19:56:33 +02:00
Shauren 6c1a33d62d Core/Scripts: Fixed incorrect guid usage in logs 2014-09-16 19:47:10 +02:00
Shauren 9b316fe689 Core/Scripts: Fixed PCH build 2014-09-16 00:44:56 +02:00