Commit Graph
7424 Commits
Author SHA1 Message Date
Treeston 7e42503244 Merge pull request #16264 from Treeston/3.3.5-noffalooter
Looting/Group: Do not display looter in tooltip when FFA loot is enabled
2016-01-28 11:45:17 +01:00
DDuarte 7a252fc648 Core/SAI: Typo fix of 77087db793
There's no %b, silly
2016-01-26 03:43:15 +00:00
DDuarte 77087db793 Core/SAI: Code improvements to SMART_ACTION_RANDOM_SOUND
Warning fixes and extra sanity checks

Ref #16376
2016-01-26 03:37:07 +00:00
Lopfest e4af2baa7e Core/SAI: added SMART_ACTION_RANDOM_SOUND
Closes #16376
2016-01-26 03:26:41 +00:00
Shauren 3f886025a2 Core/Spells: Ignore category cooldowns for triggered spells.
* This fixes weird issues where triggered spell fails because it has the same category as the spell triggering it

Closes #15794
Closes #15048

(cherry picked from commit 044edced9a5b8f0a53640bfea4727eb9d38eae7f)
2016-01-22 22:14:28 +01:00
DDuarte ac727ab208 Scripts: Add override to CheckInRoom() definitions
Fixes -Winconsistent-missing-override
2016-01-19 13:06:04 +00:00
DDuarte 954323d9cb Core/Instances: Fix build in older VS versions
Relax const uses in BossBoundaryEntry so the compiler can generate proper
copy assignment operator (error C2582: 'operator =' function is unavailable in 'BossBoundaryEntry')

Also renamed its members to match our coding standards
(public members should be UpperCamelCase)
2016-01-19 13:01:43 +00:00
treeston 1050b68899 Merge branch '3.3.5-boundaryagain' into 3.3.5-base (PR #16270) 2016-01-18 18:35:20 +01:00
treeston b945d01ee5 Instance boundary follow-up:
- Stop tools from complaining about leaks.
- Also, list -> vector.
- Fix an ambiguous constructor warning.
- Fix a bug with Gormok and Sindragosa (Fixes #16280).
2016-01-18 18:08:15 +01:00
treeston 17f924a031 Spell facing follow-up: Fix an issue with creatures' channeled spells not cancelling properly in certain conditions 2016-01-18 02:10:17 +01:00
[Dev]Rival fb6a7407e2 Core/BattlegroundIC: Duplicate Keep Cannons. 2016-01-17 02:05:04 +01:00
joschiwald 6b3468f48a Scripts/Spells: fixed Beacon of Light 2016-01-16 23:32:34 +01:00
treeston 10482419b7 Looting/Group: Do not display looter in tooltip when FFA loot is enabled. 2016-01-14 11:56:00 +01:00
treeston 0316dff245 Fix stuff™. 2016-01-14 11:42:12 +01:00
treeston 233297c5c8 Merge branch '3.3.5-spellfacing' into 3.3.5-base (PR #15641) 2016-01-13 18:38:54 +01:00
treeston f481ae1048 Core/Spells: Creature spellcast facing rework:
- Fixes creatures turning just before a spellcast finishes and smacking players with supposedly-unavoidable damage. Fixes and closes #15393, #10803, and probably others.
- Fixes visual effects not lining up with the correct target for spells that have their visual aligned with the caster's orientation (examples: Anub'rekhan Impale, Ingvar's Smash/Dark Smash, etc.). Fixes and closes #2947 and probably a bunch of others, including the aforementioned #15393 and #10803.
- Creatures' displayed target now properly matches the unit they are targeting with spells for a split second (blizzlike). This is necessary to get proper client-side orientation.
2016-01-13 18:35:44 +01:00
treeston 5b8b8c6530 Merge branch '3.3.5-bossboundary' into 3.3.5-base (PR #16089) 2016-01-13 15:33:17 +01:00
Kittnz 09a6516367 Core/Object: Codestyle improvements 2016-01-12 22:43:48 +01:00
treeston 2da458c56d Scripts/Instances: Complete rewrite of the boundary system.
- Migrate boundary logic to Maps/AreaBoundary instead of having it sit in InstanceScript (to possibly allow use for other purposes).
- Implement the first five boundary types in Maps/AreaBoundary.cpp.
- Add boundary checks to Creature's update logic
- Add boundary data for all Northrend raids
- Add boundary initialization structures and methods to InstanceScript
- Modify EnterEvadeMode signature. It now passes a value from the EvadeReason enum as parameter to allow special casing depending on evade reason
- Remove previous (weird) boundary code that had them linked to GO spawns
2016-01-12 22:24:23 +01:00
elecyb 38782deed0 Core/Entities: Show destroy animation for creatures and totems.
Now all pets and totems will have their proper die/destroy animation when killed.

Ported from MaNGOS.
2016-01-12 17:34:34 -03:00
Shauren 48940e292f Core/Quests: Fixed party accept quests 2016-01-12 19:41:27 +01:00
Shauren 3c3cde028c Core/Quests: Fixed quest sharing
Closes #12304
Closes #16183
2016-01-12 19:08:37 +01:00
treeston e203d78d2a Merge remote-tracking branch 'velinath/sai-migrations' into 3.3.5-base 2016-01-12 18:32:51 +01:00
ariel- b08038c8b6 Fix typo after dcb7082277 2016-01-10 23:38:57 -03:00
velinath d87f504b53 Core/Scripts/DB: Migrate specially scripted taxi NPC's to SmartAI 2016-01-09 14:39:07 -05:00
Duarte Duarte bddf9ec6fe Merge pull request #16101 from NathanHandley/3.3.5
Updated AuctionHouseSeller to have item class stack control
2016-01-09 18:46:20 +00:00
jackpoz b39216eed3 Merge pull request #16186 from ariel-/spellmodcharges
Core/Spells: Fix redundant mod charge drop and spell crit calc
2016-01-09 16:51:39 +01:00
ccrs e5d4005cc6 Core/Spells: Fixed Raise Ally
thx @Nayd for sniffs :)
thx @Shauren for helping to find all spell involved

* There is no implementation for stats update on Puppet class (only on Guardian) so same SummonProperty as Raise Dead Ghoul (non pet) is used.
(Default SummonProperties set category to SUMMON_CATEGORY_PUPPET)
* Override the Summon Effect to enable charm and stats scaling.
* PlayerAI is used to handle unaura on ghoul despawn or dead.
It's necessary due to the fact that all script hooks on ScriptedCreature are called on an unactive CreatureAI, resulting in creature being unable to handle unaura calls.
* Create UpdateAI call for Player class
* Stats scaling is based on forum and wowhead comments, they recall this ghoul as a copy of the other one (same stats).
* Spellscript for Ghoul spell Thrash

Closes #82
Closes #14830
2016-01-08 00:10:15 +01:00
jackpoz 2a50ea5cf1 Merge pull request #16193 from Goatform/3.3.5
Core/GameObjects: Fixed an issue where traps were not redirected to Grounding Totem
2016-01-07 19:27:40 +01:00
Goatform 42594c1687 Core/GameObjects: Fixed an issue where traps were not redirected to Grounding Totem
Closes #16145
2016-01-05 20:00:11 +01:00
elecyb d27b0ea8a8 Core/Player Drop deprecated code and fix bug where a player can have more than one profession specialization. 2016-01-04 22:42:11 -02:00
jackpoz 841ce54a0d Scripts/Commands: Fix ".help" command to show commands in alphabetical order 2016-01-04 23:30:46 +01:00
ariel- f810db72a9 Fix redundant calculation of spell critical chance, fix spellmods being dropped twice.
Closes #7315
2016-01-04 19:01:02 -03:00
treeston 0f0a51b87a Game/Maps: Instance handling follow-up:
- Fix a bug where a player could maintain a conflicting non-perm solo bind if they were in the instance when invited to group. Closes #16150.
- If a group is created while the leader is in an instance that nobody is bound to, the group will take over the instance and bind to it. This stops the homebind timer when reforming group after disconnects and the like.
2016-01-04 15:48:53 +01:00
joschiwald 8a0bbc3869 Core/Spells: Fixed Enrage armor reduce part 2016-01-03 00:55:50 +01:00
Rushor 923a368ac7 Update copyright note for 2016 2016-01-01 12:02:33 +01:00
treeston 43fa7d48a5 Game/Maps: Clean up instance handling.
- Rename Map::CanEnter to Map::CannotEnter. Return value changed from boolean (true means player can enter) to enum Map::EnterState (CAN_ENTER=0 means player can enter, any other value is a reason for deny).
- Move hack-y player error messages from within Map::CanEnter to the function calling CanEnter as appropriate (primarily WorldSession::HandleAreaTriggerOpcode).
- Modify WorldSession::HandleAreaTriggerOpcode to properly revive the player upon touching the portal leading to the instance they died in even if they are currently unable to zone in. Fixes and closes #15758.
- Modify Player::LoadFromDB to properly spawn players in the instance they logged off in if possible. Fixes and closes #15561.
- Modify permanent save behavior to be blizzlike: Players can always enter an instance they are saved to (assuming there are no map constraints against it), but get a homebind timer if the instance is already in use.
2015-12-31 01:02:07 +01:00
NathanHandley 1554a7dd56 Simplified stack size calculation in AuctionBotSeller 2015-12-27 10:08:15 -06:00
NathanHandley ec3a98caeb Updates in respnose to feedback from DDuarte. Including:
- Changed SetStackSizeForItem to GetStackSizeForItem in AuctionHouseBotSeller
- Added Initializer to SellerItemClassInfo.RandomStackRatio in AuctionHouseBotSeller
- Updated verbiage around AuctionHouseBot.Class.RandomStackRatio.* to be clearer
2015-12-25 19:47:38 -06:00
NathanHandley 33a75afb60 Updated AuctionHouseSeller to have item class level stack control
For each item class (consumable, glyph), you can now edit the worldserver.conf to

configure the ratio (percent) of random compared to single stack auction postings.

Example 1
AuctionHouseBot.Class.RandomStackRatio.Consumable = 0
- New consumable auctions posted by AuctionHouseSeller will always be single stack.

Example 2
AuctionHouseBot.Class.RandomStackRatio.Consumable = 100
- New consumable auctions posted by AuctionHouseSeller will always be of a random

stack size.

Example 3
AuctionHouseBot.Class.RandomStackRatio.Consumable = 20
- New consumable auctions posted by AuctionHouseSeller have a 20% chance of being a

random stack size, and an 80% chance of being single stack size.
2015-12-25 18:54:15 -06:00
Vincent-Michael dbe854cd31 Core/Objects: Fix typo in 19cab2c508 2015-12-21 17:29:04 +01:00
MitchesD 776103cfea Merge pull request #15995 from ShinDarth/mmr
Core/Arena: more arena configs
2015-12-19 11:46:32 +01:00
Francesco Borzì 850a4468b4 Merge pull request #15956 from ShinDarth/questdef
Core/Quest: code style
2015-12-16 18:58:33 +01:00
rockz1152 60311e0aae Core/Player: Fixed Weapon Skillup on low level mobs
Closes #15998

Removed block for skill up on grey level mobs.
2015-12-15 14:47:59 -05:00
jackpoz b96704774b Merge pull request #15919 from Treeston/3.3.5-razuvious 2015-12-14 20:34:12 +01:00
treeston 54d583b0fb Scripts/Naxxramas: Instructor Razuvious rework:
- Fix missing yells
- Rearrange existing yells to match live
- Sniffed positions for adds
- Improve add respawn handling
- Make adds not fight the player for control (don't use their spells on their own etc.)
- Update adds' hotbar keys to match live (this will affect other creatures with nonsequential possess keys as well)
- Fix adds' movement when mind controlled, they no longer move automatically when right-clicking (this affects all mind-controlled creatures)
- Blizzlike timers
2015-12-14 20:11:57 +01:00
ShinDarth 3d1614b622 Core/Arena: create more arena configs
- made rating modifiers configurable
- made arena points rate configurable
2015-12-14 20:09:07 +01:00
pete318 0ac442f19f Improved Auction house deposit handling.
Including the weird quirks.

Changes:
* Deposit caculated according to same rule as client. (detailed below). Should always match client deposit now
* Deposit for multiple auctions now only collected once. Deferred calculation of deposit until all auctions listed.

Deposit calculation is as follows:

Base deposit calculation = MSV x 15/75% (depending on AH). However this is not rounded. Case to int is used (so always round down)
The remainder is held in a float.
The base is then multiplied by number of items, and the time multiplier (x2 for 24 hour, x4 for 48 hour)
The nearest (no of items or lower) no of items when multiplied by the remainder that creates a whole number is then multiplied by the time multiplier (x1/x2/x4) and then added to deposit.

Example:

Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 1 = 36c. Remainder = 0.75 (n) Min = 1s. Deposit 1s
Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 2 = 72c. Remainder = 1.50 (n)  Min = 1s. Deposit 1s
Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 3 = 108c. Remainder = 2.25 (n) Min = 1s. Deposit 1s08c
Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 4 = 144c. Remainder = 3.00 (n) Min = 1s. Deposit 1s50c (144c + (3c * 2))

Horrible kludge, to re-create a very weird deposit method.

Closes #15674 (PR)
Closes #15643 (Issue)
2015-12-14 19:54:58 +01:00
Shauren b3e718dcca Removed unneeded loop from previous commit, copypaste fail from 6.x 2015-12-12 00:06:59 +01:00
Shauren f72795240a Core/Creatures: Implemented automatic detection of trigger models, their order in creature_template no longer matters
(cherry picked from commit c488fb219ab080031488593a0b86ac785a7d2cae)
2015-12-11 23:51:04 +01:00