Hooks:
- DoCheckProc: executed when aura checks if it can proc
- DoPrepareProc: executed before aura procs (possibility to prevent charge drop/cooldown)
- OnProc: executed when aura procs
- OnEffectProc: executed when aura effect procs
- AfterEffectProc: executed after aura effect proced
- AfterProc: executed after aura proced and charges removed
using PreventDefaultAction() in DoPrepareProc will prevent charge drop and cooldown
default execution of a proc can prevented in OnEffectProc with PreventDefaultAction()
Now we should be able to convert almost all procs from Unit::ProcDamageAndSpellFor to SpellScripts
Notes to old proc system:
- if a proc has a cooldown we must check it in spellscript and add it when we handle the proc
- behavior with charge drops is possible undefined (use PreventDefaultAction() in OnEffectProc to notify that the script is executed)
Sorry about troubles caused, hed reason to think formula was wrong, but it wasn't. However there is part of the code that needs to be improved I describbed in this commit as TO DO: Connected with: #8195
* Author: Horn. Please give feedback, I tested a lot stuff, but it will be appreciated.
* One of the fixes allow all creatures to cast when being passangers, researched, this doesn't involve players.
* This basically rewrittes vehicle seat formula calculated, so it fix quite stuff that will not be visible and some eye candies: #3831 and #1984 Heart part ;) (which magically fix a lot more of it and some quests), also Yog-Sarron mechanics
* Creator Subv, (thx to Shauren also who stated that this packed should be used when researchs were started)
- You all should'be thankful, that bug was a real bitch
* Fix creatures using NearTeleportTo (example Urom in Oculus, Skeram/Viscidus in AQ and Heigan in Naxxramas)
Calling UpdateObjectVisibility() will make sure that the semi-far teleports (those where the destination position is not in direct sight) will work correctly.
- Shadows Fate can now be applied by more than just one player at the same
time. So on everyone who hits the unit the credit spell with the visual
will be casted on death.
- The AOE credit spells for the three infusion quests will be casted by
the boss once. If this would be done on proc, these AOE spells could be
casted up to 25 times.
-> 25 AOE credit spells plus 25 Soul Feast credit spells equals Sh**
Originally from the VAS Autobalance script, slightly modified.
Only addresses Spells, Dots, and Melee Damage. I'll have look at the current modules on ways of doing this but, Environmental Damage(fire/lava/drowning), Fall Damage, and Potentially AoE aren't covered by these.
Closes#7867
Signed-off-by: Nay <dnpd.dd@gmail.com>
* Aggressive pets now use aggro radius check based on level diff of target
* Aggro radius limited to max 45 yards (per wowwiki)
* Pets no longer "dance" when fighting a creature
* Pets returning will defend themselves (if not passive) if owner didn't click "follow"
* Pets at stay will properly pick up their owner's attackers that pass within range
* Fix "no empty line at end of file" warning in PetAI
* Fix typo in GetAggroRange()
* Fix spell "Eyes of the Beast" - player can move pet freely
* Code style cleanup
* Update commit comment
Closes#8398, #7455
When holy paladin put beacon on someone and heal someone else, it shows up that the player with the beacon is being healed by himself, instead of the person who casting the Beacon.
This problem Can be solved by this.
Trista