Commit Graph
1493 Commits
Author SHA1 Message Date
Ovahlord 84a5437001 Core/Spells: updated Lava Surge spell scripts to new model and added db proc entry 2020-09-28 21:05:34 +02:00
Ovahlord 6594fb650d Core/Spells: fixed Relentless Strikes talent 2020-09-27 17:21:37 +02:00
Ovahlord 35b07faf2b Scripts/Quests: scripted Launch Quest spells and use them to launch the 'A Personal Summon' quests when entering Stormwind or Orgrimmar 2020-09-26 19:57:05 +02:00
Ovahlord d2790a4c32 Core/Spells: cleaned up and updated Envenom spell script to Cataclysm
* fixed the spell script not changing the dealt damage at all
2020-09-23 20:48:45 +02:00
Ovahlord c3eda5eb45 Core/Spells: updated Holy Shock spell script to Cataclysm
* fixed T11 Holy set bonus for Paladins not proccing from Holy Shock heal effects
2020-09-11 22:07:55 +02:00
Ovahlord b2bddb2921 Core/Spells: fixed an issue that was preventing Bandit's Guile's Deep Insight not getting removed when switching combat targets 2020-09-11 21:42:14 +02:00
Ovahlord 9df379b30a Core/Spells: fixed Druid's Skull Bash abilities and Brutal Impact talent
closes #97
2020-09-11 20:16:49 +02:00
Ovahlord d57332ca5d Core/Spells: Selfless Healer's damage bonus will now scale with the amount of holy power 2020-08-31 18:06:15 +02:00
Ovahlord 32cf373719 Core/Spells: updated Focus Magic spell script to Cataclysm 2020-08-30 17:28:32 +02:00
Ovahlord 27bbba32aa Core/Spells:
* fixed Protector of the Innocent talent
* fixed Tower of Radiance talent
* fixed Blessed Life talent
* fixed Gift of the Earthmother Rejuvenation instant heal effect
2020-08-29 21:33:16 +02:00
Ovahlord 89fdfd5d7f Core/Spells: corrected Furor behaivior and fixed an exploit that was allowing druids to get full energy when turning into cat form 2020-08-28 15:51:29 +02:00
Warpten 2b2fc5fb8a Core/Spells: remove PrepareSpellScript and PrepareAuraScript macros and make Hooklist use emplace behaivior (#174) 2020-08-28 15:40:26 +02:00
Ovahlord 6e257a5123 Core/Spells: Warrior's Deep Wounds periodic damage is now based on normalized weapon damage and will only use the mainhand weapon as reference 2020-08-25 15:18:44 +02:00
Ovahlord d8478b689c Core/Spells:
* fixed Glyph of Dazing Shield proc
* fixed Glyph of Colossus Smash
* fixed Glyph of Divinity
* updated Glyph of Heroic Throw to Cataclysm
2020-08-24 23:18:51 +02:00
Ovahlord 75a0e1c011 Core/Spells: updated Bloodworm's Blood Gorged behaivior to Cataclysm 2020-08-24 18:32:31 +02:00
Shauren 44e0d6c0f9 Scripts/Spells: Replace RegisterAuraScript with RegisterSpellScript and remove it 2020-08-23 17:44:48 +02:00
Ovahlord 5be03870b5 Core/Spells:
* fixed Hunter Fervor talent
* fixed Hunter Killing Streak talent
* fixed Crouching Tiger, Hidden Chimera talent
* allow controlled units to proc the auras of their owner when dealing spell damage
2020-08-23 00:51:52 +02:00
Ovahlord 9f6a7f6671 DB/Spells: added missing scriptname to Druid's bear form Vengeance proc 2020-07-26 18:23:41 +02:00
Ovahlord a31111ebbb Core/Spells: allow Rune Strike to be permanently used while in Blood Presence 2020-07-23 22:52:55 +02:00
Ovahlord 7bbc603efa Core/Spells: feign death react state cleanup 2020-07-22 17:23:58 +02:00
Treeston 942c3a77da Core: Combat/threat system rewrite (PR #19930)
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
  - They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
  - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
  - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.

Closes #7951 and #19998.
2020-07-22 16:49:37 +02:00
treeston a09db6b4ba Hi, I'm Treeston, and welcome to Combat PR Prep Refactors.
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedEscortAI.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Spells/SpellEffects.cpp
#	src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_tomb_of_seven.cpp
#	src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp
#	src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp
#	src/server/scripts/EasternKingdoms/ShadowfangKeep/instance_shadowfang_keep.cpp
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp
#	src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp
#	src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/culling_of_stratholme.cpp
#	src/server/scripts/Kalimdor/WailingCaverns/wailing_caverns.cpp
#	src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp
#	src/server/scripts/Kalimdor/zone_stonetalon_mountains.cpp
#	src/server/scripts/Kalimdor/zone_tanaris.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp
#	src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp
#	src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
#	src/server/scripts/Outland/TempestKeep/arcatraz/boss_harbinger_skyriss.cpp
2020-07-22 14:35:53 +02:00
Treeston ec04d3b2cd [3.3.5] Combat/Threat rewrite - prep & refactor (#19966)
* Combat/Threat rewrite (PR #19930) prep work. Mostly refactors, and a compatibility layer on ThreatManager/HostileReference that allows scripts to be changed already.
2020-07-22 13:43:23 +02:00
Ovahlord bd444eb6e1 Scripts/Items: fixed a warning reported by gcc 2020-07-19 14:36:37 +02:00
Ovahlord e1d74d4dc6 Core/Misc: added more fallthrough attributes and added some missing breaks reported by CI 2020-07-19 12:24:58 +02:00
Ovahlord 405569dbff Core/Spells:
* fixed Kill Command
* fixed Improved Kill Command crit chance bonus
* fixed Frenzy not triggering Focus Fire's visual effect correctly

closes #78
2020-07-17 16:21:37 +02:00
Ovahlord eedb17447a Core/Spells: Combustion will no longer pick up other Combustion effects and the eligible aura effects will now have their amount devided 2020-07-11 20:35:40 +02:00
Ovahlord 2ad3201067 Core/Spells: fixed Improved Blood Presence benefits not having any effect 2020-07-11 14:06:38 +02:00
Ovah b09d6e2330 Core/Movement: reimplement follow movement (#124) 2020-06-26 21:22:21 +02:00
Ovahlord 120a4cc983 Core/Spells: Fire Nova will no longer consume Flame Shock from its targets and will no longer deal damage to its explicit cast target 2020-06-22 20:32:06 +02:00
Warpten 0af44ccc01 Core/Spells: implement DoT clipping
* Core/Spells: Implementation of DoT clipping.
* Core/Utilities: Backport "EnumFlags v3.0" from master.
* Core/Spells: Switch AURA_REMOVE_MODE to a flag set.
2020-06-04 18:16:03 +02:00
Ovahlord 2132ed5178 Core/Spells: Power Word: Shield will now apply its Weakened Soul debuff on its target again which got broken after cleaning up hacks in db4e832fee
closes #96
2020-05-14 22:14:15 +02:00
Ovahlord db4e832fee Core/Spells: removed pre cast spell hacks from spell class and moved remnants to spell scripts
closes #81
2020-05-10 21:11:56 +02:00
Ovahlord ffc0fe829c Core/Spells: Death Grip will now use exact distances instead of comparing the melee distance between the caster and the target
closes #73
2020-05-09 15:10:19 +02:00
Ovahlord e5c98e258c Fixed build 2020-05-09 01:34:55 +02:00
Ovahlord 7ab91c9b3e Core/Spells: optimized Arcane Missile proc data 2020-05-09 01:19:11 +02:00
Ovahlord 08938e3557 Core/Spells: fixed Glyph of Power World: Shield heal effects getting triggered when the Priest had the Improved Power Word: Shield talent active 2020-05-05 00:00:50 +02:00
Ovahlord 8cc370b2e3 Core/Spells: fixed slow effect for Thunderstorm when no glyph is applied 2020-05-04 23:42:38 +02:00
Ovahlord e64a3bcd90 Scripts/HoO: implement Ammunae encounter 2020-05-04 00:14:06 +02:00
Ovahlord 92f8340da3 Core/Spells: allow Victory Rush's damage to crit but keep its healing effect non-critical 2020-04-28 01:27:47 +02:00
Ovahlord 07da39c0e1 Core/Spells: fixed Bloodsurge damage bonus for Slam 2020-04-26 00:31:45 +02:00
Ovahlord 7556f4948e Core/Spells: fixed Chug-A-Lug guild perk 2020-04-23 19:23:16 +02:00
Ovahlord bc68ecdbcc Core/Spells: fixed The Quick and the Dead guild perk 2020-04-23 17:04:32 +02:00
Ovahlord d148116ebe Scripts/Guilds: fixed Cauldron of Battle, Big Cauldron of Battle and their Flask effect 2020-04-23 14:38:21 +02:00
Ovahlord 06b983bee2 Core/Spells: fixed Mobile Banking spawning a different chest for Alliance players 2020-04-23 12:52:04 +02:00
Ovahlord a850243e89 Core/Spells: fixed Mobile Banking guild perk
*Misc: moved guild faction define to the other faction enums
2020-04-23 03:45:43 +02:00
Ovahlord 87ec7bd625 Core/Spells: fixed Healing Stream Totem heal formula and updated spell script to new model 2020-04-22 04:15:11 +02:00
Ovahlord b653f2f819 Core/Units: ported power type updates from master branch 2020-04-22 03:13:02 +02:00
Ovahlord d30c811d9e Core/Creatures: reworked tempoary summon creation
* all stats and values will now be set before summons are getting added to map
* cleaned up summon spell effect handler to reduce duplicade code
* summoner guids will no longer be set for every minion and correctly handle assigning creator guids instead. These values will serve as fallback guid if there is no summoner guid
* friendly tempsummons will now inherit the guild data of their player and pass them on to further allied summons. This fixes guild specific visuals for creatures such as Guild Battle Standards and Guild Heralds.

Todo: check for regressions
2020-04-22 00:20:18 +02:00
Ovahlord bc1a69caa3 Core/Spells: fixed Guild Battle Standard buff effects 2020-04-21 13:34:23 +02:00