Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
37,416 Commits 2 Branches 1 Tag
93259bc282c7921ed37b93c6c8a5231bc268ba30
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ariel- cb168a8e7e Core/Unit: fix crash on magic school autoattacks 
Closes #19436

(cherry picked from commit 0b50ea072e504ac7d5bf87b08d564955785f7197)
 2022-02-16 04:49:24 +01:00
ariel- 4c658cf2da Revert "Core/Spell: don't set scaleAura for some special spells" 
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.

Closes #19472

(cherry picked from commit c296d255e25a2d0eb7155f64eea32cc36fed280a)
 2022-02-16 04:49:24 +01:00
ariel- 5ad31dcf55 Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee schools 
for Keader :P

(cherry picked from commit 66ac1509ae925edc8848cdf6c370f8ed52c688ec)
 2022-02-16 04:49:24 +01:00
ariel- d441e864c4 Core/Unit: cleanup and minor fixes of miss and resist calculations 
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs

(cherry picked from commit e565b34f6d24411e210151d0d03e524f94cdff85)
 2022-02-16 04:49:24 +01:00
ariel- 0e8422c30a Core/Misc: fix static analysis issues 
CID 1373466
CID 1373481
CID 1373482

(cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
 2022-02-16 04:49:24 +01:00
ariel- 58745ed8cc Core/AHBot: fixed assert check 
(cherry picked from commit c36854677c4cef0c83a81afa23b45ba322d354cc)
 2022-02-16 04:49:24 +01:00
ariel- 14a95ff976 Core/Spell: don't set scaleAura for some special spells 
Closes #14541

(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
 2022-02-16 04:49:24 +01:00
ariel- 4a3c6b3ae5 Core/AHBot: fix a typo 
(cherry picked from commit e594c2d096c101a5b722793612febb6276b3b48e)
 2022-02-16 04:49:24 +01:00
ariel- df00319c1b Core/AHBot: Refactor of AuctionHouseBotSeller: 
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change
- Don't factor in the priority calc empty item lists:
  * Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000
  * If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill
- Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor

- Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P
- General cleanup, removal of bad voodoo and magical numbers
- Use unordered_sets for loading item lists, as they were only used to check for item presence

(cherry picked from commit 7f8bfe68d0f660643c8bd4c63d2129d220c2184c)
 2022-02-16 04:49:24 +01:00
ariel- 4ad1d377fe Core/Entities: virtualize CheckAttackFitToAuraRequirement 
- Should've been like this to begin with

(cherry picked from commit 21d95a1d767c95910d4508e0e83f34b4f89f587a)
 2022-02-16 04:49:24 +01:00
ariel- 70ecdd1511 Core/Aura: fix SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE unapply case for dead players 
Closes #19276

(cherry picked from commit e1083794cde600205c45a016e6d077d1ffa4dea9)
 2022-02-16 04:49:24 +01:00
ariel- 827fcb652a Core/Entities: Fix null-dereference crash 
Closes #19191

(cherry picked from commit d61e0f79c40681ce7675e878e0ec0bdc2294527f)
 2022-02-16 04:49:24 +01:00
ariel- b8d1bab8de Core/Spells: refactor spell_enchant_proc_data table 
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789

(cherry picked from commit f609e7a08b3b4d2d9642e5ec252e1eedad836f0f)
 2022-02-16 04:49:24 +01:00
ariel- 5e57ad6fa8 Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60 
Closes #15734

missing code
(cherry picked from commit eac9c1f0b992fd3622fd7dd864b2acc2781ec778)
 2022-02-16 04:49:24 +01:00
ariel- 4ecfc62438 Core/Achievement: fix bad lookup of ACHIEVEMENT_CRITERIA_DATA_TYPE_S_EQUIPPED_ITEM item 
Closes #19064

(cherry picked from commit 70c4a37544ade558fb79383d2668f5f0322d47b8)
 2022-01-28 22:32:59 +01:00
ariel- 35b5eaed8f Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts 
Closes #19334

(cherry picked from commit 9cfa7c752e1d61b02acb852d2fd304a80d10b60a)
 2022-01-28 22:32:59 +01:00
ariel- 8aa53f2df7 Core/Achievements: port realm first achievement handling from master 
veeeery partial cherry-pick of c75fcbe20b07fd7518be58bf02ba30d903133449

(cherry picked from commit 4596c17dae1dcb199b9301b7dcfd556bb1c0d7d5)
 2022-01-28 22:32:59 +01:00
ariel- 29166a1d0a Core/Util: avoid one useless copy when adding stuff into a HookList 
(cherry picked from commit 077b5aec9ede78034ba2ec4838b72e8121dab7ce)
 2022-01-22 20:27:51 +01:00
ariel- af98e8516c Core/Auras: reworked multiplicative AuraEffects calculation 2021-11-28 12:14:05 +01:00
ariel- 0792739a98 Core/Scripts: fixed npc immunity flags during Harbinger Skyriss encounter 
- Added missing _Reset
- Properly register Skyriss summons in SummonList

Closes #21154

Who ordered up an extra large can of whoop-ass?

(cherry picked from commit f8b148c3346e6d5017bf3b044cc36bce32c0cf45)
 2021-07-29 21:41:02 +02:00
ariel- 5c882e8788 Core/Unit: fixed Global cooldown cancelation on spell interrupt 2021-04-16 20:41:20 +02:00
ariel- dcd017bbad Core/Spell: fix LoS checks for GameObject spells 
Closes #21580
 2020-09-11 15:11:24 +02:00
ariel- d34eb1a276 Core/GameObject: kill uninitialized, unused field from GameObjectTemplateAddon struct 2020-09-11 15:10:18 +02:00
ariel- 9040070520 Core/GameObject: refactor dismounting on use 
# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
 2020-09-11 15:09:58 +02:00
ariel- 46866bad04 Core/GameObject: implement dismount on use of certain GOs 
- The fact of player dismounting was entirely client-sided, with no server code enforcing it.

Closes #19979

# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
 2020-09-11 15:08:53 +02:00
ariel- e4ba06c828 Core/Utils: restored previous behaviour of RandomResize 2020-07-24 10:31:01 +02:00
ariel- 32d189e8b7 Core/Misc: kill whitespace 
# Conflicts:
#	sql/updates/world/3.3.5/2018_01_10_04_world_335.sql
#	src/server/game/Combat/ThreatManager.h
#	src/server/game/Entities/Creature/Creature.cpp
#	src/server/game/Entities/Player/Player.cpp
#	src/server/scripts/Kalimdor/boss_azuregos.cpp
 2020-07-22 17:10:27 +02:00
ariel- 0fcc0ebca2 Core/Player: don't check quest requirements against RewardNextQuest 
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest

Closes #19515
 2020-02-20 02:20:08 +01:00
ariel- d28be94e4a Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications 
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike

thanks Cannix for the heads up
 2020-02-20 01:55:48 +01:00
ariel- 08e174549e Core/Quest: fix RewardNextQuest being used to condition previous quests in chain 2020-02-20 01:42:01 +01:00
ariel- a7484837a8 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId. 
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300
 2020-02-20 01:39:08 +01:00
ariel- d78ad034d0 Core/Quests: changed quest_template_addon.NextQuestID to unsigned 
- No reason to keep this anymore after 4349adf0f25210e5b26201523a09bc26b4a83394, this is a broken functionality.
 2020-02-20 01:33:53 +01:00
ariel- 330f399de3 Core/Globals: some changes in quest loading 
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups
 2020-02-20 01:31:29 +01:00
ariel- ef6f5abf75 Core/Globals: Fix Quest codestyle and member variable initialization 2020-02-20 01:24:47 +01:00
ariel- 00db1e6b22 Core/Creatures: Minor HasSpell method cleanup 
Cherry-picked improved from 5734788c0277d7f342d534dca63db0ce4e862bc5
 2018-03-29 00:58:17 +02:00
ariel- 9f7e1a0673 Core/Spells: fix another regression with arcane missiles being marked positive 
Closes #21670
 2018-03-29 00:51:50 +02:00
ariel- 18b04b326e Scripts/ICC: use script searchers instead of saving list of creature pointers 
Closes #21644
 2018-03-29 00:51:39 +02:00
ariel- 3303c4551b DB/Spells: fix group stacking rules for MP5 buffs (BoW and Mana Spring) 
Closes #21637
 2018-03-29 00:49:15 +02:00
ariel- dfff9d62e4 Core/Spells: autogenerate miss proc for spells with auras with hit chance -100 
Closes #21629
 2018-03-29 00:46:02 +02:00
ariel- fda47267f8 DB/Spells: Weakened soul shouldn't remove stealth 
Closes #21611
 2018-03-16 21:57:49 +01:00
ariel- e4e85ffa22 DB/Creature: root training dummies 
Closes #21513
 2018-03-12 12:20:01 +01:00
ariel- 2aa4871b20 Core/Conditions: validate object types when conditioning implicit spell targets with CONDITION_OBJECT_ENTRY_GUID 
Closes #21569
 2018-03-09 10:15:46 +01:00
ariel- 79a0d012f2 Scripts/Commands: Make Shauren happy 2018-03-06 23:48:53 +01:00
ariel- 23b2d7bcea Core/Spells: explicitly disable non proccing auras when generating default procs 
Closes #21529
 2018-03-05 14:36:32 +01:00
ariel- 2697bdf2b2 Core/Misc: fix bad dbc data for lock 'Locked ball and chain' 
Closes #12260
 2018-03-05 14:34:31 +01:00
ariel- 24413cd30f Core/Auras: travis fix 2018-03-05 14:33:25 +01:00
ariel- b795e71e6b DB/Spell: fix Hit debuff stack rule 
By Despondencyy

Closes #21367
 2018-03-05 14:33:16 +01:00
ariel- 62c114d402 Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases 
Updates #21367
 2018-03-05 14:19:32 +01:00
ariel- 0321955726 Core/Auras: added sanity checks for area auras having a different owner unit than caster 
Closes #21517
 2018-03-05 14:19:22 +01:00
ariel- 30e0c87ff9 Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load 
Closes #21472
 2018-02-24 13:13:47 +01:00
ariel- f2f574fbdd DB/Spells: fix proc regression with Missile Barrage 
Closes #21466
 2018-02-24 13:12:03 +01:00
ariel- e219b3f940 Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet 2018-02-18 17:59:30 +01:00
ariel- 3292925319 Core/Events: update holiday code and remove misleading log (event date is the one from game_event) 
- add siign to DBC struct member CalendarFilterType as it was being used as such
- kill localtime usage as it's deprecated

Closes #18542
 2018-02-17 16:14:35 +01:00
ariel- a858e9937e Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise 2018-02-17 16:00:29 +01:00
ariel- 25675405b2 Core/Auras: skip target map update for one world tick if owner is not yet in world 
Closes #21426
 2018-02-16 03:44:43 +01:00
ariel- 66334459a6 Core/Spells: fixed server being too overzealous with autoshot 
- Interrupting it when casting another spell and switching targets

Ref #21390
 2018-02-16 03:27:16 +01:00
ariel- bbe9aa23b0 Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice 2018-02-16 01:57:08 +01:00
ariel- 3a4035bb8d Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 2018-02-16 01:26:26 +01:00
ariel- e6888f72e0 Core/Scripts: implemented Combined Toxins proc only from poisons 2018-02-16 01:22:39 +01:00
ariel- 2388415edd Core/Spells: require phasemask set for periodic damage procflag 
Closes #21379
 2018-02-16 01:04:27 +01:00
ariel- bfcdb9e7f9 DB/Spell: fix Unstable Affliction and Vampiric Touch dispel double dipping from SP 
Closes #21393
 2018-02-16 01:04:18 +01:00
ariel- 9fdb4c0a4d Core/Scripts: fix non-functional Celestial Planetarium Access GO 
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982
 2018-02-10 11:52:22 +01:00
ariel- a97171c8c0 Core/ScriptSystem: AfterHit hook can't modify damage/healing, so log it 
- Also added const to getter members
 2018-02-10 11:49:40 +01:00
ariel- afed7f0425 Core/Channel: properly notify client about invalid channel names 
Closes #16190
 2018-02-10 11:49:18 +01:00
ariel- 6dc6cc7608 Core/Spells: fix logic error causing near teleports to drop combat for players 
Closes #21362
 2018-02-10 11:37:00 +01:00
ariel- 23af4f93ba Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells 
- It is already called at Unit::DealDamage
 2018-02-10 11:36:50 +01:00
ariel- 36b29d3a3d DB/Spell: remove hacky, ancient serverside spell 
Added in a687c867e9, back when proc cooldown handling was way different
 2018-01-27 16:41:06 +01:00
ariel- 8d0647da5d DB/Spell: Fix Lifebloom coefficient 
Closes #21297
 2018-01-27 16:40:58 +01:00
ariel- fd92fa7451 Core/Auras: fixed EquippedItemClass check 
follow-up to 29c3b7d8f60c18e52ec22fec6de9abc3dc468166
 2018-01-21 12:57:07 +01:00
ariel- cbb321a55e DB/Spell: Magma Totem shouldn't generate threat 
By Jildor, closes #21178
 2018-01-21 12:56:59 +01:00
ariel- c7a62f99d3 Core/Auras: Don't remove shield only dependant auras on disarm 
Closes #19782
 2018-01-21 12:56:14 +01:00
ariel- f2a3a356be Core/Auras: define and implement attribute SPELL_ATTR3_IGNORE_PROC_SUBCLASS_MASK 
Closes #20148
 2018-01-21 12:56:05 +01:00
ariel- 49c861d064 Core/Unit: check remaining instead of full duration for Bounced by DR auras 2018-01-21 12:39:28 +01:00
ariel- e6e1403b2d Core/Spells: fix casting NO_TARGET event spells 
Closes #19978
 2018-01-06 13:22:44 +01:00
ariel- 7e4d351edd DB/Spell: fix Improved Stormstrike proc when you OHKO 2018-01-03 04:40:42 +01:00
ariel- bb2eed982a DB/Spell: Potion of Petrification 
- No longer a Elixir since patch 3.2

By DanVS, closes #21162
 2018-01-03 04:36:42 +01:00
ariel- 45817f6030 Core/Scripts: fix Millhouse Manastorm resetting dialogs after Skyriss encounter 
Closes #21159
 2018-01-03 04:36:28 +01:00
ariel- 69ea734f78 Core/Scripts: cast "Trial of the Naaru: Tenacity" credit spell when criteria is achieved 2018-01-03 04:35:46 +01:00
ariel- 562a76eb41 Core/Scripts: fix issues with 'Squeeze' on Yogg-Saron encounter 
- Unassigned spell script for 25-man difficulty

- Didn't remove aura on 25-man when tentacle killed
 2018-01-03 04:09:44 +01:00
ariel- 23388c5c56 Core/Player: fix issue with SendLoot when using Disarm Trap at maximum range 2018-01-03 03:54:25 +01:00
ariel- e147e03857 DB/Spell: rewritten conditions for Plant Warmaul Ogre Banner 2018-01-03 03:53:29 +01:00
ariel- a936535075 DB/Spell: Fingers of Frost proc 
By Jildor, closes #19517
 2018-01-03 03:46:32 +01:00
ariel- a53af26ab6 Core/Entities: fix crash 
- m_currentSpells and spell would be different in case cancelation of a channeled spell would remove the aura, and aura scripted to cast another channeled spell on remove
- In the above situation, we would lose reference of currentSpell and remove reference from wrong one, this was fixed by clearing the pointer before spell cancelation.

Closes #20172
 2018-01-01 22:21:01 +01:00
ariel- 9ed3ccf6ee Remove wrong MECHANIC_SLOW_ATTACK immunity from creatures 
- Bosses need to be affected by tank debuffs (ie Thunder Clap, Judgements of the Just, Infected Wounds, Frost Fever)

Ref 8ecde2f96b
 2018-01-01 15:49:00 +01:00
ariel- 7d284b44ac Rename 2017_12_29_00_world.sql.sql to 2017_12_29_00_world.sql 2018-01-01 15:48:50 +01:00
ariel- 515735b36e Core/Scripts: fix codestyle 2018-01-01 15:46:44 +01:00
ariel- 81b86e5de0 Core/Scripts: remove Quel'Delar from player inventory during "The Halls Of Reflection" quests (24480, 24561) 2018-01-01 15:17:37 +01:00
ariel- 928a52868b DB/Spawns: fix ICC Runeforge (missing spellfocus) 2018-01-01 15:17:29 +01:00
ariel- 42d92e0e48 DB/Loot: Vanquisher's Mark of Sanctification has a slightly higher drop chance than other marks 
- This is to compensate the fact that it's shared by 4 classes instead of 3
 2018-01-01 15:17:22 +01:00
ariel- 6a56dc9151 DB/Creature: set trigger flag to Imp in a Ball 2018-01-01 15:17:15 +01:00
ariel- 7c999969c7 Core/Scripts: prevent Arthas in CoS losing his gossip flag and halting instance progress 2018-01-01 15:17:08 +01:00
ariel- 9241e345f3 Core/Scripts: fixed Festergut applying more than one stack of Inoculated at once 2018-01-01 15:17:01 +01:00
ariel- c93b2351c6 Core/Vehicles: changed flags required to mark a seat as "usable" 
Ref #3831
 2018-01-01 15:16:51 +01:00
ariel- 62fa9e086a DB/Spell: Restrict Karazhan book buffs to that raid 
Ref #16049
 2018-01-01 15:16:43 +01:00
ariel- 0d6bdb39c8 DB/LFG: Fix BRD start position 2018-01-01 15:02:09 +01:00
ariel- e69a640b52 DB/Creature: added interrupt immunities to some bosses 
Closes #12020
 2017-12-26 16:59:43 +01:00
ariel- 99044aaa3a Build: fixed finding Boost 1.66 named libraries... somewhat 2017-12-26 16:59:33 +01:00
ariel- bbeb109135 Build: fix typo in FindBoost 2017-12-26 16:59:23 +01:00
ariel- 649be219fc Build/Misc: added Boost 1.66 to FindBoost.cmake 2017-12-26 16:59:12 +01:00
ariel- 72b14ea028 Core/Spell: implement SPELL_FAILED_AURA_BOUNCED on DR spells 2017-12-26 16:58:53 +01:00