Commit Graph
483 Commits
Author SHA1 Message Date
Vincent_Michael ddada2d182 Scripted/ScarletMonastery: Fix crash for headless horseman 2013-10-18 12:25:50 +02:00
joschiwald a0c637f52a Core/Scripts: added some OVERRIDEs 2013-09-25 16:37:43 +02:00
jackpoz 9579d0a3e7 Scripts/ScarletEnclave: Fix uninitialized values in Highlord Darion Mograine
Reset() has if checks on values that are initialized after them so it's required to initialize these fields in the constructor.

Valgrind log:
 Conditional jump or move depends on uninitialised value(s)
  by 0x11CF472: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67)
  by 0x11CE36F: Creature* ObjectAccessor::GetObjectInWorld<Creature>(unsigned long, Creature*) (ObjectAccessor.h:114)
  by 0x1257C13: Creature* ObjectAccessor::GetObjectInMap<Creature>(unsigned long, Map*, Creature*) (ObjectAccessor.h:135)
  by 0x12E64F1: Map::GetCreature(unsigned long) (Map.cpp:2767)
  by 0x10AF4DE: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13021)
  by 0x16F8F81: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::Reset() (chapter5.cpp:386)
  by 0x16F8D36: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::npc_highlord_darion_mograineAI(Creature*) (chapter5.cpp:314)
  by 0x16F8CD6: npc_highlord_darion_mograine::GetAI(Creature*) const (chapter5.cpp:307)
  by 0x132AF6C: ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:796)
  by 0x1441D45: FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
2013-09-21 22:36:23 +02:00
Sebastian Valle 24f8b2b994 Core/Misc: Fixed some more issues found by code analysis tools. 2013-09-03 15:09:37 -05:00
joschiwald ae36ddefec Core/Scripts: add creature_text to pet mojo
Scripts/Karazhan/Moroes: cleanup a bit (should fixes mem leak)
2013-08-31 16:48:37 +02:00
Shauren 4f44cdf2b5 Core/Scripts: Fixed uninitialized variable and memory leaks 2013-08-26 17:38:02 +02:00
Nay 2050a36b58 SAI & Scripts: Fix unitialized values found by Valgrind
==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x19B3031: boss_skarvald_the_constructor::boss_skarvald_the_constructorAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:217)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x19B3948: boss_dalronn_the_controller::boss_dalronn_the_controllerAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:388)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x15E2FCC: SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:144)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064==    by 0x191D242: npc_shadron::npc_shadronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1122)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x19AE913: boss_ymiron::boss_ymironAI::UpdateAI(unsigned int) (boss_ymiron.cpp:215)

==3064== Use of uninitialised value of size 8
...
==3064==    by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)

==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064==    by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064==    by 0x191CE88: npc_tenebron::npc_tenebronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1027)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064==    by 0x191D5B8: npc_vesperon::npc_vesperonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1220)

==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064==    by 0x1868F59: boss_lady_vashj::boss_lady_vashjAI::Reset() (boss_lady_vashj.cpp:206)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191C14C: dummy_dragonAI::MovementInform(unsigned int, unsigned int) (boss_sartharion.cpp:802)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x1046986: Position::NormalizeOrientation(float) (Object.h:388)
...
==3064==    by 0x17D9463: boss_malchezaar::boss_malchezaarAI::SummonInfernal(unsigned int) (boss_prince_malchezaar.cpp:373)
2013-08-26 16:13:26 +01:00
Nay 12973de799 Core&Tools: Fix multiple issues found by a static code coverage tool 2013-08-24 22:57:22 +01:00
joschiwald e0f010b310 Scripts: Random script fixes and code optimizations 2013-08-19 20:03:06 +02:00
joschiwald 2b19ba1879 Misc: replace Unit::GetPlayer with ObjectAccessor::GetPlayer and some cosmetic changes 2013-08-18 01:41:10 +02:00
w1sht0l1v3 0333d22fe9 Core/Scripts: Placeholder for instance Ragefire Chasm.
It is needed for Random Dungeon Finder credit.
2013-08-17 15:25:09 +03:00
w1sht0l1v3 7b9f34afc5 Core/Scripts: Placeholder for instance The Stockade.
It is needed for Random Dungeon Finder credit.
Correct entry for last encounter in the instance.
2013-08-17 14:59:49 +03:00
Vincent-Michael 8acefbff8c Scripted: Use now override for instance scripts 2013-08-10 17:42:12 +02:00
Malcrom f5e4fd67c3 Scripting: Moved Lord Valthalak from EAI to CPP. Moved all Blackrock Instances to Blackrock Mountain Dir. 2013-08-07 10:50:06 -02:30
Shauren ac10589eda Core/Misc: Fixed some issues found by Coverity Scan 2013-08-01 21:31:11 +02:00
Shauren 3d6b88f5aa Fixed compile warnings 2013-07-21 14:17:24 +02:00
Malcrom 8462a09264 DB/Gossip: Added missing gossip for Royal Historian Archesonus. Removed cpp script. 2013-07-16 21:42:40 -02:30
Vincent-Michael 08c1a81096 Scripted/Misc: Fix random stuff 2013-07-15 01:01:37 +02:00
Vincent-Michael e464d2bd2c Scripted: Some cleanups + ninja changes 2013-07-08 21:15:23 +02:00
Nay 3561ab98ba Misc: Use override and final C++11 keywords in a few places (mostly scripts)
OVERRIDE and FINAL are TC macros (expand to nothing if compiler does not  support C++11)
2013-07-06 20:21:45 +01:00
Vincent-Michael 6079f369af Scripted/Misc: Some cleanup 2013-07-06 01:00:05 +02:00
Vincent-Michael f97cf4a1d8 Scripted/Eversong Woods: Add Missing cleanup 2013-07-05 17:32:38 +02:00
Vincent-Michael f46f7a3414 Misc:
- Fix missing newlines
- Fix some startup errors
2013-07-05 17:21:21 +02:00
Vincent-Michael b4d4e04f53 Scripts/Misc: Rename creatures with mob_ / mobs_ in npc_
Note: Have fun :P
2013-07-04 22:11:47 +02:00
Aokromes 258df112a8 Core/Scripting: Allow Headless Horseman to be attacked
Fix by digz6666.
Note: this script needs rewrite, any pull request doing it is welcome.
Closes #3568
2013-07-02 17:38:07 +02:00
Malcrom 722f7068f2 Core/Scripting: More updates for BRS instance. Added missing scripts for urok and gizrul. 2013-07-01 10:19:18 -02:30
Malcrom 1eaf3c9c9d Core/Scripting: Gyth event still not finished but completable. 2013-06-30 13:39:07 -02:30
Shauren 112bc49c9a Core/Units: Removed most calls to SendMovementFlagUpdate for creatures 2013-06-30 16:31:24 +02:00
Malcrom 4ed70c7094 Core/Scripting: A few fixes for Blackrock Spire. Emberseer now setting properly after wipe and Gyth/Rend event is getting closer to complete. 2013-06-30 00:24:01 -02:30
Krzysztof Rapacki 75f535c65e Scripts/Blackwing Lair: Fixed out of bounds array access 2013-06-27 09:45:49 +02:00
Aokromes 9ea2b218cb Core/Scripting: Typo fix 2013-06-27 03:23:23 +02:00
Malcrom 651a966e92 Core/Scripting: More BRS updates. Emberseer is still buggy if player resets. Working on it. 2013-06-26 15:38:19 -02:30
Aokromes 563c75c3e9 Core/Scripting: Typo fix 2013-06-26 10:36:10 +02:00
Malcrom caa214d396 DB/Creature_text: 2013-06-26 01:18:12 -02:30
Vincent-Michael 6c9e810a63 Core: Fix warnings 2013-06-25 20:49:51 +02:00
Vincent-Michael 711c68d3f3 Core: Fix non pch build 2013-06-25 20:16:54 +02:00
Malcrom 1149292fe1 Core/Scripting: More fixes and updates for BRS Instance. 2013-06-25 15:36:16 -02:30
Malcrom 60159297f2 Core/Scripting: Gyth / Rend Event in progress. Pushing before Vincent Micheal makes ninja changes. 2013-06-25 00:15:41 -02:30
Malcrom 2f746d929a Core/Scripting: Emberseer event will now check to see if all players in instance are clicking altar. 2013-06-24 18:06:23 -02:30
Vincent-Michael 72c2a8cfa6 Core: Fix warnings 2013-06-24 18:59:59 +02:00
Vincent-Michael b43688b684 Core: Fix non pch build 2013-06-24 18:33:40 +02:00
Malcrom c31791493f Core/Scripting: Forgot a couple line endings. 2013-06-24 13:55:03 -02:30
Malcrom eb74361470 Core/Scripting: Updated BWL Scripts. Thanks to gerripeach for the base.
Closes #4952 #9283
2013-06-24 13:48:02 -02:30
Malcrom 9726a5174e Core/Scripting: Start Scripting Gyth / Rend event for UBRS. Add creature text. 2013-06-24 03:47:44 -02:30
Vincent-Michael 7d429145eb Core: Fix non pch build 2013-06-24 06:37:56 +02:00
Malcrom fc4652964e Core/Scripting: A few updates. 2013-06-24 01:26:58 -02:30
Malcrom d791515502 Core/Scripting: Hopefully this calms tcbuid. 2013-06-24 00:34:37 -02:30
Malcrom dc55188edd Core/Scripting: I hate you tcbuild. 2013-06-23 23:34:36 -02:30
Malcrom d9c819a65d Core/Scripting: tcbuild is being a bitch and SD2 had nothing to do with this script. 2013-06-23 23:07:08 -02:30
Malcrom a6711d5232 Core/Scripting: Update to Boss Emberseer Script. 2013-06-23 22:46:44 -02:30