Commit Graph
13083 Commits
Author SHA1 Message Date
Mikhail Redko c0a1bc8c8d * Core/Misc: Improvement item durability repair logic
* Move item repair cost calculation logic from Player::DurabilityRepair to Item::CalculateDurabilityRepairCost
* Make item repair cost calculation more congruent with client logic (std::round)
* Do not repair items if player does not have enough money to pay for the repair of all items at once
* Withdrawing money from guild bank only once to avoid spam in the guild bank log and reduce number of transactions in the database
2022-06-15 14:24:35 +02:00
Intel ce79689c96 Core/Player: Prevent updating visibility if player is not in world. Closes #13659
(cherry picked from commit 3ec88b7086953685617c2ccd79207a388d20e129)

Closes #27914
2022-05-18 13:52:36 +02:00
Ovahlord c63c81ef6c Core/Packets: enable and implement SMSG_SUMMON_RAID_MEMBER_VALIDATE_FAILED
* refactored target based summoning to not longer store targets in the target map and pull the directly from the caster's target update field in the effect handler
* implement support for party based summoning and use the new opcode to send error messages when a player cannot be summoned. Note: this packet does support sending multiple reasons for multiple members but sniffs show that they are still being sent one by one instead. Just Blizzard things
2022-05-17 20:43:49 +02:00
Ovahlord edfe82b4a3 Core/Misc: refactored a couple more loops to reduce copies and speeding up things
* silenced a few more msvc suggestions while at it
2022-04-22 22:52:52 +02:00
Shauren 76fc64b038 Core/PacketIO: Stop WorldSession packet processing loop immediately when AntiDOS kicks/bans the player
# Conflicts:
#	src/server/game/Server/WorldSession.cpp
2022-04-17 01:28:59 +02:00
AG 7e343ab03b Core/Spells: Druid's Pounce bleeding effect will no longer be affected by diminishing returns (#349)
closes #76
2022-04-13 20:47:14 +02:00
Ovahlord 4e3cfe283d buildfix 2022-04-11 06:46:14 +02:00
Ovahlord eb54b5c053 Core/Packets: converted a couple combat packets to packet class 2022-04-10 23:01:15 +02:00
Ovahlord ef4d1aa7c4 Core/Packets: added missing initialization for some guid packets 2022-04-04 23:47:09 +02:00
Ovahlord c7d7eff894 Core/Packets: use the correct opcode for GuildCommandResult packet as the JAM opcode has not been used yet according to sniffs and has a different packet structure 2022-04-04 23:39:18 +02:00
Ovahlord e5f09705c1 Core/Spells: fixed typos which have been added in 77158594ff 2022-04-01 14:03:45 +02:00
Ovahlord 367c120231 Core/Spells: make SpellInfo::CausesInitialThreat respect SPELL_ATTR0_CU_NO_INITIAL_THREAT as well 2022-04-01 12:21:11 +02:00
Ovahlord ea6898483e Core/Packets: send CHARACTER_FLAG_HIDE_HELM and CHARACTER_FLAG_HIDE_CLOAK in EnumCharactersResult packet
ref #342
closes #94
2022-03-31 18:38:57 +02:00
Ovahlord 2443d48081 Core/Creatures: no longer restore stored orientation values after a spell focus expires since there is no evidence, that this is ever being used on retail 2022-03-29 21:46:16 +02:00
Ovahlord 82c9e10a2a Core/Spells: restore handling for src_area_x channel target selection 2022-03-28 22:51:41 +02:00
Ovahlord a82fe54bb7 Core/Skills: assign loaded skills that have been marked as forbidden to a proper skill position to avoid interfering with legit skills
closes #332
2022-03-25 11:37:52 +01:00
Ovahlord f573f1f8e3 Core/Packets: converted CMSG_LOADING_SCREEN_NOTIFY to packet class 2022-03-22 12:41:48 +01:00
Ovahlord ca9f34574d Core/Misc: fixed a bunch of GCC warnings 2022-03-21 21:32:41 +01:00
Ovahlord 5f2b1e45e4 Core/Spells: improve integer to float conversions and checks for spell proc entries 2022-03-10 20:43:12 +01:00
Ovahlord fd22ea32e6 Core/Spells: merged master version of checking for cast immunities 2022-03-10 20:41:47 +01:00
Ovahlord 2aee19fc86 Core/Movement: ported MotionMaster::MoveJumpWithGravity implementation from master branch and cut off post Cataclsym features 2022-02-24 19:37:05 +01:00
Ovahlord 1534ede45a Core/Spells: updated proc flags for Cataclysm 2022-02-23 21:17:52 +01:00
Ovahlord f641bcb2d1 Core/Spells: resolved a cherrypick error 2022-02-22 21:51:21 +01:00
Shauren c307969695 Core/Spells: Changed channel triggered spells to inherit positive/negative status from main spells 2022-02-22 21:24:49 +01:00
Ovahlord 78896a132f Core/Spells: ported proc flag updates from master branch 2022-02-22 21:19:09 +01:00
Ovahlord e83c5955b4 Core/Spells: moved Improved Devouring Plague to spell script and fixed the damage effect 2022-02-22 12:57:29 +01:00
Ovahlord 1c56faaa2c Core/Guids: refactored more range based loops to reduce copying elements of containers 2022-02-21 20:36:49 +01:00
Ovahlord 80881f898c build fix 2022-02-21 14:55:09 +01:00
Ovahlord 7bf3379df5 warning fixes 2022-02-21 14:43:50 +01:00
Ovahlord a204e9c61a Core/Units: some minor refactors to reduce the amount of container element copies and improved some array initializations 2022-02-21 14:31:46 +01:00
Ovahlord 6506e71a23 Core/Units: added a helper to check if a limited target aura exists without creating an empty element in the container 2022-02-21 13:44:24 +01:00
Ovahlord 6e412b16de Core/Spells: correctly implement Elemental Oath 2022-02-21 11:17:41 +01:00
Ovahlord d712a12f1c Core/Spells: use correct macro for tree of life stance requirement 2022-02-21 10:53:32 +01:00
Ovahlord 97a79175fc Core/Spells: added a bunch of default ctors for several spellMgr structs to silence uninitialized member warnings 2022-02-21 10:50:00 +01:00
Ovahlord 06f6987e2a Core/Spells: allow Rupture's damage to scale with combo points as well 2022-02-21 10:21:43 +01:00
Ovahlord f01012aac9 Core/Spells: corrected the finishing move spell attributes for Rupture and Expose Armor 2022-02-21 10:16:30 +01:00
Ovahlord d53fb14cbb Core/Creatures: no longer initialize CharmInfo for minions on creation. Unit::SetCharmed takes care of non-guardian initialization
closes #334
2022-02-21 09:42:41 +01:00
ccrs 3499ffa187 Core/Petition: add missing increment on RemovePetitionsByOwnerAndType iteration
(cherry picked from commit aa86dfddca8f1fcb6b77fc1a37f367978c593018)
2022-02-16 05:00:59 +01:00
xinef1 e5f3de026f Core/Misc: implemented petition manager (#19010)
- Implemented manager for petitions to perform all petition related tasks and synchronize data with database.
- This kills ugly synchronous querys on packet handlers

(cherry picked from commit a4aa95a5a39d75b9e38fe03aac57ceb7d9bba90f)
2022-02-16 04:59:12 +01:00
ariel- cb168a8e7e Core/Unit: fix crash on magic school autoattacks
Closes #19436

(cherry picked from commit 0b50ea072e504ac7d5bf87b08d564955785f7197)
2022-02-16 04:49:24 +01:00
ariel- 4c658cf2da Revert "Core/Spell: don't set scaleAura for some special spells"
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.

Closes #19472

(cherry picked from commit c296d255e25a2d0eb7155f64eea32cc36fed280a)
2022-02-16 04:49:24 +01:00
ariel- 5ad31dcf55 Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee schools
for Keader :P

(cherry picked from commit 66ac1509ae925edc8848cdf6c370f8ed52c688ec)
2022-02-16 04:49:24 +01:00
ariel- d441e864c4 Core/Unit: cleanup and minor fixes of miss and resist calculations
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs

(cherry picked from commit e565b34f6d24411e210151d0d03e524f94cdff85)
2022-02-16 04:49:24 +01:00
ariel- 0e8422c30a Core/Misc: fix static analysis issues
CID 1373466
CID 1373481
CID 1373482

(cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
2022-02-16 04:49:24 +01:00
ariel- 58745ed8cc Core/AHBot: fixed assert check
(cherry picked from commit c36854677c4cef0c83a81afa23b45ba322d354cc)
2022-02-16 04:49:24 +01:00
ariel- 14a95ff976 Core/Spell: don't set scaleAura for some special spells
Closes #14541

(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2022-02-16 04:49:24 +01:00
ariel- 4a3c6b3ae5 Core/AHBot: fix a typo
(cherry picked from commit e594c2d096c101a5b722793612febb6276b3b48e)
2022-02-16 04:49:24 +01:00
ariel- df00319c1b Core/AHBot: Refactor of AuctionHouseBotSeller:
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change
- Don't factor in the priority calc empty item lists:
  * Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000
  * If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill
- Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor

- Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P
- General cleanup, removal of bad voodoo and magical numbers
- Use unordered_sets for loading item lists, as they were only used to check for item presence

(cherry picked from commit 7f8bfe68d0f660643c8bd4c63d2129d220c2184c)
2022-02-16 04:49:24 +01:00
Chaouki Dhib 17c4d8f6d9 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c145f6ad9c4baeffeff32618e71ff537c)
2022-02-16 04:49:24 +01:00
ariel- 4ad1d377fe Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d767c95910d4508e0e83f34b4f89f587a)
2022-02-16 04:49:24 +01:00