Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
35,781 Commits 2 Branches 1 Tag
c2913e608f62cc5bbd8c90ca5df3676512c358c7
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ariel- 0fcc0ebca2 Core/Player: don't check quest requirements against RewardNextQuest 
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest

Closes #19515
 2020-02-20 02:20:08 +01:00
ariel- d28be94e4a Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications 
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike

thanks Cannix for the heads up
 2020-02-20 01:55:48 +01:00
ariel- 08e174549e Core/Quest: fix RewardNextQuest being used to condition previous quests in chain 2020-02-20 01:42:01 +01:00
ariel- a7484837a8 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId. 
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300
 2020-02-20 01:39:08 +01:00
ariel- d78ad034d0 Core/Quests: changed quest_template_addon.NextQuestID to unsigned 
- No reason to keep this anymore after 4349adf0f25210e5b26201523a09bc26b4a83394, this is a broken functionality.
 2020-02-20 01:33:53 +01:00
ariel- 330f399de3 Core/Globals: some changes in quest loading 
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups
 2020-02-20 01:31:29 +01:00
ariel- ef6f5abf75 Core/Globals: Fix Quest codestyle and member variable initialization 2020-02-20 01:24:47 +01:00
ariel- 00db1e6b22 Core/Creatures: Minor HasSpell method cleanup 
Cherry-picked improved from 5734788c0277d7f342d534dca63db0ce4e862bc5
 2018-03-29 00:58:17 +02:00
ariel- 9f7e1a0673 Core/Spells: fix another regression with arcane missiles being marked positive 
Closes #21670
 2018-03-29 00:51:50 +02:00
ariel- 18b04b326e Scripts/ICC: use script searchers instead of saving list of creature pointers 
Closes #21644
 2018-03-29 00:51:39 +02:00
ariel- 3303c4551b DB/Spells: fix group stacking rules for MP5 buffs (BoW and Mana Spring) 
Closes #21637
 2018-03-29 00:49:15 +02:00
ariel- dfff9d62e4 Core/Spells: autogenerate miss proc for spells with auras with hit chance -100 
Closes #21629
 2018-03-29 00:46:02 +02:00
ariel- fda47267f8 DB/Spells: Weakened soul shouldn't remove stealth 
Closes #21611
 2018-03-16 21:57:49 +01:00
ariel- e4e85ffa22 DB/Creature: root training dummies 
Closes #21513
 2018-03-12 12:20:01 +01:00
ariel- 2aa4871b20 Core/Conditions: validate object types when conditioning implicit spell targets with CONDITION_OBJECT_ENTRY_GUID 
Closes #21569
 2018-03-09 10:15:46 +01:00
ariel- 79a0d012f2 Scripts/Commands: Make Shauren happy 2018-03-06 23:48:53 +01:00
ariel- 23b2d7bcea Core/Spells: explicitly disable non proccing auras when generating default procs 
Closes #21529
 2018-03-05 14:36:32 +01:00
ariel- 2697bdf2b2 Core/Misc: fix bad dbc data for lock 'Locked ball and chain' 
Closes #12260
 2018-03-05 14:34:31 +01:00
ariel- 24413cd30f Core/Auras: travis fix 2018-03-05 14:33:25 +01:00
ariel- b795e71e6b DB/Spell: fix Hit debuff stack rule 
By Despondencyy

Closes #21367
 2018-03-05 14:33:16 +01:00
ariel- 62c114d402 Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases 
Updates #21367
 2018-03-05 14:19:32 +01:00
ariel- 0321955726 Core/Auras: added sanity checks for area auras having a different owner unit than caster 
Closes #21517
 2018-03-05 14:19:22 +01:00
ariel- 30e0c87ff9 Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load 
Closes #21472
 2018-02-24 13:13:47 +01:00
ariel- f2f574fbdd DB/Spells: fix proc regression with Missile Barrage 
Closes #21466
 2018-02-24 13:12:03 +01:00
ariel- e219b3f940 Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet 2018-02-18 17:59:30 +01:00
ariel- 3292925319 Core/Events: update holiday code and remove misleading log (event date is the one from game_event) 
- add siign to DBC struct member CalendarFilterType as it was being used as such
- kill localtime usage as it's deprecated

Closes #18542
 2018-02-17 16:14:35 +01:00
ariel- a858e9937e Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise 2018-02-17 16:00:29 +01:00
ariel- 25675405b2 Core/Auras: skip target map update for one world tick if owner is not yet in world 
Closes #21426
 2018-02-16 03:44:43 +01:00
ariel- 66334459a6 Core/Spells: fixed server being too overzealous with autoshot 
- Interrupting it when casting another spell and switching targets

Ref #21390
 2018-02-16 03:27:16 +01:00
ariel- bbe9aa23b0 Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice 2018-02-16 01:57:08 +01:00
ariel- 3a4035bb8d Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 2018-02-16 01:26:26 +01:00
ariel- e6888f72e0 Core/Scripts: implemented Combined Toxins proc only from poisons 2018-02-16 01:22:39 +01:00
ariel- 2388415edd Core/Spells: require phasemask set for periodic damage procflag 
Closes #21379
 2018-02-16 01:04:27 +01:00
ariel- bfcdb9e7f9 DB/Spell: fix Unstable Affliction and Vampiric Touch dispel double dipping from SP 
Closes #21393
 2018-02-16 01:04:18 +01:00
ariel- 9fdb4c0a4d Core/Scripts: fix non-functional Celestial Planetarium Access GO 
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982
 2018-02-10 11:52:22 +01:00
ariel- a97171c8c0 Core/ScriptSystem: AfterHit hook can't modify damage/healing, so log it 
- Also added const to getter members
 2018-02-10 11:49:40 +01:00
ariel- afed7f0425 Core/Channel: properly notify client about invalid channel names 
Closes #16190
 2018-02-10 11:49:18 +01:00
ariel- 6dc6cc7608 Core/Spells: fix logic error causing near teleports to drop combat for players 
Closes #21362
 2018-02-10 11:37:00 +01:00
ariel- 23af4f93ba Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells 
- It is already called at Unit::DealDamage
 2018-02-10 11:36:50 +01:00
ariel- 36b29d3a3d DB/Spell: remove hacky, ancient serverside spell 
Added in a687c867e9, back when proc cooldown handling was way different
 2018-01-27 16:41:06 +01:00
ariel- 8d0647da5d DB/Spell: Fix Lifebloom coefficient 
Closes #21297
 2018-01-27 16:40:58 +01:00
ariel- fd92fa7451 Core/Auras: fixed EquippedItemClass check 
follow-up to 29c3b7d8f60c18e52ec22fec6de9abc3dc468166
 2018-01-21 12:57:07 +01:00
ariel- cbb321a55e DB/Spell: Magma Totem shouldn't generate threat 
By Jildor, closes #21178
 2018-01-21 12:56:59 +01:00
ariel- c7a62f99d3 Core/Auras: Don't remove shield only dependant auras on disarm 
Closes #19782
 2018-01-21 12:56:14 +01:00
ariel- f2a3a356be Core/Auras: define and implement attribute SPELL_ATTR3_IGNORE_PROC_SUBCLASS_MASK 
Closes #20148
 2018-01-21 12:56:05 +01:00
ariel- 49c861d064 Core/Unit: check remaining instead of full duration for Bounced by DR auras 2018-01-21 12:39:28 +01:00
ariel- e6e1403b2d Core/Spells: fix casting NO_TARGET event spells 
Closes #19978
 2018-01-06 13:22:44 +01:00
ariel- 7e4d351edd DB/Spell: fix Improved Stormstrike proc when you OHKO 2018-01-03 04:40:42 +01:00
ariel- bb2eed982a DB/Spell: Potion of Petrification 
- No longer a Elixir since patch 3.2

By DanVS, closes #21162
 2018-01-03 04:36:42 +01:00
ariel- 45817f6030 Core/Scripts: fix Millhouse Manastorm resetting dialogs after Skyriss encounter 
Closes #21159
 2018-01-03 04:36:28 +01:00
ariel- 69ea734f78 Core/Scripts: cast "Trial of the Naaru: Tenacity" credit spell when criteria is achieved 2018-01-03 04:35:46 +01:00
ariel- 562a76eb41 Core/Scripts: fix issues with 'Squeeze' on Yogg-Saron encounter 
- Unassigned spell script for 25-man difficulty

- Didn't remove aura on 25-man when tentacle killed
 2018-01-03 04:09:44 +01:00
ariel- 23388c5c56 Core/Player: fix issue with SendLoot when using Disarm Trap at maximum range 2018-01-03 03:54:25 +01:00
ariel- e147e03857 DB/Spell: rewritten conditions for Plant Warmaul Ogre Banner 2018-01-03 03:53:29 +01:00
ariel- a936535075 DB/Spell: Fingers of Frost proc 
By Jildor, closes #19517
 2018-01-03 03:46:32 +01:00
ariel- a53af26ab6 Core/Entities: fix crash 
- m_currentSpells and spell would be different in case cancelation of a channeled spell would remove the aura, and aura scripted to cast another channeled spell on remove
- In the above situation, we would lose reference of currentSpell and remove reference from wrong one, this was fixed by clearing the pointer before spell cancelation.

Closes #20172
 2018-01-01 22:21:01 +01:00
ariel- 9ed3ccf6ee Remove wrong MECHANIC_SLOW_ATTACK immunity from creatures 
- Bosses need to be affected by tank debuffs (ie Thunder Clap, Judgements of the Just, Infected Wounds, Frost Fever)

Ref 8ecde2f96b
 2018-01-01 15:49:00 +01:00
ariel- 7d284b44ac Rename 2017_12_29_00_world.sql.sql to 2017_12_29_00_world.sql 2018-01-01 15:48:50 +01:00
ariel- 515735b36e Core/Scripts: fix codestyle 2018-01-01 15:46:44 +01:00
ariel- 81b86e5de0 Core/Scripts: remove Quel'Delar from player inventory during "The Halls Of Reflection" quests (24480, 24561) 2018-01-01 15:17:37 +01:00
ariel- 928a52868b DB/Spawns: fix ICC Runeforge (missing spellfocus) 2018-01-01 15:17:29 +01:00
ariel- 42d92e0e48 DB/Loot: Vanquisher's Mark of Sanctification has a slightly higher drop chance than other marks 
- This is to compensate the fact that it's shared by 4 classes instead of 3
 2018-01-01 15:17:22 +01:00
ariel- 6a56dc9151 DB/Creature: set trigger flag to Imp in a Ball 2018-01-01 15:17:15 +01:00
ariel- 7c999969c7 Core/Scripts: prevent Arthas in CoS losing his gossip flag and halting instance progress 2018-01-01 15:17:08 +01:00
ariel- 9241e345f3 Core/Scripts: fixed Festergut applying more than one stack of Inoculated at once 2018-01-01 15:17:01 +01:00
ariel- c93b2351c6 Core/Vehicles: changed flags required to mark a seat as "usable" 
Ref #3831
 2018-01-01 15:16:51 +01:00
ariel- 62fa9e086a DB/Spell: Restrict Karazhan book buffs to that raid 
Ref #16049
 2018-01-01 15:16:43 +01:00
ariel- 0d6bdb39c8 DB/LFG: Fix BRD start position 2018-01-01 15:02:09 +01:00
ariel- e69a640b52 DB/Creature: added interrupt immunities to some bosses 
Closes #12020
 2017-12-26 16:59:43 +01:00
ariel- 99044aaa3a Build: fixed finding Boost 1.66 named libraries... somewhat 2017-12-26 16:59:33 +01:00
ariel- bbeb109135 Build: fix typo in FindBoost 2017-12-26 16:59:23 +01:00
ariel- 649be219fc Build/Misc: added Boost 1.66 to FindBoost.cmake 2017-12-26 16:59:12 +01:00
ariel- 72b14ea028 Core/Spell: implement SPELL_FAILED_AURA_BOUNCED on DR spells 2017-12-26 16:58:53 +01:00
ariel- c4d135fc03 Core/Globals: validate creature_template mingold and maxgold fields 2017-12-26 16:29:45 +01:00
ariel- cc03f7b5cd DB/Spell: fix Magic Absorption 
Closes #20570
 2017-12-17 10:50:56 +01:00
ariel- d8cc18e70b Core/Spells: allow auras to proc from partial blocks 
Closes #21065
 2017-12-17 10:50:16 +01:00
ariel- 00628e94b0 Dep/gSOAP: Update gSOAP to 2.8.49 
Closes #20039
 2017-07-19 20:26:34 +02:00
ariel- 698697d9e8 Core/Tools: fix whitespace 2017-07-19 20:26:20 +02:00
ariel- 5e37e99ffa Core/Scripts: fix array out of bounds in Pit of Saron doorData 2017-06-18 10:43:37 +02:00
ariel- 85c9907b07 Core/Spell: fix some spells that shouldn't allow stealth or invisibility 
- Touch of Zanzil
- Glowing Blood
- Lambent Blood
- Vibrant Blood
- Black Blood
- Perpetual Instability
 2017-06-11 17:50:32 +02:00
ariel- 206c82ead4 Core/SmartAI: implemented SMART_EVENT_EVENT_PHASE_CHANGE 
- Use instead of Update + event_phase_mask when action needs to be synchronized
 2017-06-11 17:50:24 +02:00
ariel- e05083ad4b Core/Scripts: remove non-player objects (ie corpses) from Sindragosa's Fury targetlist 2017-06-11 17:50:11 +02:00
ariel- 987f0bda82 Core/Vmaps: build fix mk II 2017-06-09 13:30:07 +02:00
ariel- 3914ace3ba Core/Vmaps: build fix 2017-06-09 13:30:01 +02:00
ariel- 307cc1e36f Core/Scripts: filter out corpses from Sindragosa's Fury targetlist 
- This would incur in a crash after attempting to convert the Corpse object into Player

Closes #19227
Closes #19862
 2017-06-09 13:22:40 +02:00
ariel- c7e617b689 DB/Spell: prevent Vile Gas (H Rotface version) from hitting non-players 2017-06-06 08:42:48 +02:00
ariel- 2e3197f944 Core/Globals: add more AIName and MovementType checks to ObjectMgr 
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)

Closes #19831
 2017-06-02 10:23:44 +02:00
ariel- 8ebe95f3ac DB/Spell: fix Deep Freeze proc 
Closes #19780
 2017-05-30 09:21:19 +02:00
ariel- e778c4c628 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit 2017-05-30 09:21:03 +02:00
ariel- 3d5584fb86 Core/Pools: fix VS dynamic linking 2017-05-28 03:18:59 +02:00
ariel- da65d89129 Core/Misc: fix some clang 5 warnings 2017-05-28 03:18:50 +02:00
ariel- 8082b3165e Core/Spell: abort channeling if no valid targets are found after searching 
Closes #17624
 2017-05-28 03:11:57 +02:00
ariel- f8a222aab9 Scripts/VioletHold: fix stack overflow when reflecting 'Splash' 
Closes #19514
 2017-05-28 03:11:40 +02:00
ariel- 70f3879c32 Core/Player: update interaction checks, some info taken from client 2017-05-26 14:26:43 +02:00
ariel- ddb787482c Core/Unit: don't clear low health aura states on death 
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening

Closes #19754
 2017-05-16 06:50:39 +02:00
ariel- 4eaa6b50b6 Core/Entities: allow guardian pets to inherit spellmods 2017-05-07 06:06:34 +02:00
ariel- 1e475a6942 Core/Scripts: implemented enchant Blade Warding 2017-05-05 04:02:32 +01:00
ariel- ea20370fce Core/Scripts: kill a warning 2017-05-05 03:59:01 +01:00
ariel- e2ac33fdc2 Core/Scripts: Victory Rush and Rune Strike proc correction 
(d0f760420a671bc255c0d3ebec75e6837507a541 follow up)
Closes #19192
 2017-05-05 03:58:50 +01:00
ariel- 07a182f1d3 Core/Spell: register spell mod owner properly on spell cast 
- This fixes pets and totems getting mods from owner
 2017-05-04 05:04:19 +01:00