xinef1
d6e7cc52a8
Various quest system fixes (seasonal quests, timed quests and more) ( #18940 )
...
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone
Closes #18913
Closes #11187
Closes #15279
2020-02-20 01:51:14 +01:00
Ovahlord
e0d610e79b
Scripts/BWD: reworked handlings for riding and damage phase of Magmaw
...
* cleaned up unneeded members and move initialization to a more fitting place
* minor corrections to timer layouts
* fixed passengers not getting ejected from Magmaw's Pincers when Magmaw is about to impale himself
* handle missing whisper message for players that have been mangled
2020-02-10 14:57:25 +01:00
Ovahlord
b95d367f8d
Core/Auras: define and implement SPELL_AURA_MOD_MELEE_DAMAGE_FROM_CASTER
2020-02-04 22:34:44 +01:00
Ovahlord
318e58aa42
Core/Spells:
...
* fixed Combat Potency talent
* fixed Restless Blades talent
* corrected Blade Twisting spell range
* fixed Bandit's Guile
* fixed startup errors
2020-02-04 22:17:55 +01:00
Ovahlord
2ad22015ad
Core/Spells: another followup for the summon number logic
2020-02-03 08:37:38 +01:00
Ovahlord
c0ff73467f
Core/Spells: corrected logic in 494404a549
2020-02-02 15:54:40 +01:00
Ovahlord
494404a549
Core/Spells: added another attribute for summon number restrictions
2020-02-02 15:48:58 +01:00
Ovahlord
6c74be5dfa
Core/Spells: added another summon number restriction based on spell attribute research
2020-02-02 15:45:12 +01:00
Ovahlord
5b8e441b40
Core/Spells: f04a20d717 followup
2020-02-02 12:38:15 +01:00
Ovahlord
f04a20d717
Core/Spells: set ownerGUID only under certain circumstances instead of setting it always
...
* The number of summons is now entirely determined by the effect value of the summon spell and only skipped for totems
2020-02-02 12:23:59 +01:00
jackpoz
183789053e
Core/Misc: Fix GCC 8 warnings
2020-01-31 21:19:25 +01:00
Ovahlord
638d368130
Core/Creatures: re-organized default summoning behaivior to make sure that all fields are set before the summon gets sent out to clients
2020-01-31 11:29:58 +01:00
Ovahlord
66a4a9617c
Core/Spells: restore player caster check when trying to hit personal summons with spells
2020-01-31 08:00:45 +01:00
Ovahlord
86d479a087
Core/Spells: expand personal spawn handling for summons to all kind of summons
...
* personal summon target checks for spells will now always happen instead of only if a player is the caster
2020-01-31 07:46:43 +01:00
Ovahlord
eaa635ab32
Core/Movement: backported cleanup for determining follow movement on appearing instead of calling evade modes right away
2020-01-31 07:34:11 +01:00
Ovahlord
6bd0412f73
Core/Spells: do not set a beacon guid for channeled spells to match sniff behaivior
2020-01-27 12:48:35 +01:00
Ovahlord
2dd295a603
Core/Spells: updated MSG_CHANNEL_START to packet class and fixed its heal prediction
2020-01-27 11:22:30 +01:00
Ovahlord
a1c415c658
Core/Spells: implement power cost level scaling
2020-01-26 16:04:42 +01:00
Ovahlord
fcb79fee07
Core/Datastores: updated DBC structure names to generated member format
2020-01-25 12:36:32 +01:00
Ovahlord
266e2f1895
Core/Spells: defined unknown field in spell start and spell go packet struct
2020-01-21 22:26:46 +01:00
Ovahlord
2374163cbb
Core/Spells: make Travis happy
2020-01-21 06:54:43 +01:00
Ovahlord
744ac00469
Core/Spells: converted SMSG_SPELL_START and SMSG_SPELL_GO to packet class
2020-01-21 06:03:02 +01:00
Ovahlord
05fcab82d8
Core/Spells: corrected implementation of SPELL_AURA_BLOCK_SPELL_FAMILY and implement trigger cast flag to ignore blocked spells
2020-01-18 16:21:17 +01:00
Ovahlord
d4c12df4a7
Core/Misc: make travis happy
2020-01-16 05:17:47 +01:00
Ovahlord
b210320df0
Core/Spells: unify successful spell cast and interrupt AI hooks into one helper with different cast results to reduce duplicate code
...
* fixed position update logic that was responsible for interrupting channeled spells because of a missing movement generator update call that was kicking in after the interrupt already happened
* improved Baron Ashburys timer layout
2020-01-16 05:01:39 +01:00
Ovahlord
7760d95962
Core/Creatures: backported trainer update and skill initialization
2020-01-12 23:53:35 +01:00
funjoker
590ad14856
Core/Spells: Allow skipping automatic removal of auras from spell_area when condition is no longer met (mostly used for cosmetic cutscenes after quest completion)
2020-01-11 03:38:28 +01:00
jackpoz
131986d1c2
Core/Misc: Replace time(nullptr) with GameTime::GetGameTime()
2020-01-11 03:30:41 +01:00
Ovahlord
029b61761c
Scripts/SFK: rewrite Lord Walden encounter
...
* updated script to new model
* removed hacks
* added out of combat talk events and movement
* scripted missing abilities
2020-01-10 04:20:53 +01:00
Aokromes
d6d3f06f06
New year
2020-01-04 18:32:38 +01:00
Warpten
c69627f4b4
Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. ( #23 )
...
Original research by @xvwyh.
2020-01-04 15:05:22 +01:00
funjoker
6c56916b29
Misc: Update copyright information
...
Happy new year
2020-01-01 18:47:28 +01:00
Ovahlord
ffeb6002b5
Core/Spells: corrected another case of sending the too close spell error message when trying to cast a destination based spell
2019-12-13 23:22:49 +01:00
Ovahlord
0cdddca210
Core/Spells: corrected haste rune cooldown reduction behaivior
...
* the haste regeneration modifier will now act multiplicative on the base regeneration rate rather than modifying it directly
* renamed some functions for clarification
2019-12-10 15:23:43 +01:00
Ovahlord
abb62cc76f
Core/Spells: reverted proc behaivior for pets and fixed applying spell mods for hunter pets and minions
2019-12-09 16:10:54 +01:00
Ovahlord
0c2cdee7a0
Core/Spells: allow more proc hooks to trigger when a owned unit casts a spell
2019-12-08 23:24:36 +01:00
Ovahlord
7ec720ef22
Core/Spells: spells of controlled units will now trigger their owner's proc auras as well and benefit from their proc chance modifiers
2019-12-08 23:05:41 +01:00
Ovahlord
0dd5fdafbd
Core/Spells:
...
* corrected crit chance bonus for Last Word Talent
* fixed Improved Searing Pain talent
* removed hackfix for Improved Mind Blast
* moved Incerate damage bonus hack into proper spell script
* updated and fixed Afterpath proc
* fixed Shadow and Fame proc
* updated Backdraft proc
* fixed Burning Embers talent
* fixed Empowered Imp talent
* fixed Fire and Brimstone damage bonus for Incenerate and Chaos Bolt
* updated several spell scripts to new model
2019-12-08 20:23:51 +01:00
Warpten
cbb5f9132f
Core/Spells: Death Strike will now always consume its runes even when not hitting the target
2019-12-08 11:34:45 +01:00
Ovahlord
398a42c917
Core/Spells: Totems will now get their hit result from their owner instead of doing it on their own
2019-12-08 11:29:29 +01:00
Warpten
2047d4c4b2
Core/Spells: define and implement UNIT_FLAG2_IGNORE_SPELL_MIN_RANGE_RESTRICTIONS and corrected sending the correct spell failed message when being too close to a spell cast target
2019-12-08 01:55:23 +01:00
Ovahlord
3dc4c6d5bc
Core/Spells: fixed Blood in the Water talent
2019-12-05 15:29:26 +01:00
Ovahlord
c66e194f23
Core/Spells: updated skinning required level values to Cataclysm
...
* hi @warpten
2019-12-03 21:26:15 +01:00
Ovahlord
51a5db0010
Core/Spells: ported more cleanups for periodic health leech effects
2019-12-03 15:45:58 +01:00
Ovahlord
5717f52195
Core/Spells: ported some cleanups for periodic damage aura ticks
2019-12-03 15:42:59 +01:00
Ovahlord
b8ffc464d6
Core/Spells: hardcoded weapon damage percent bonuses will no longer get applied twice
...
* use correct combo point spell for Mangle
2019-12-03 15:09:53 +01:00
Ovahlord
ce213bf581
Core/Spells: Fulmination will no longer benefit from damage bonuses as it gets its damage values from Lightning Shield already
2019-12-02 21:16:27 +01:00
Ovahlord
b889384e37
Core/Spells: allow Execute to trigger procs
...
*lol...
2019-12-01 19:58:59 +01:00
Ovahlord
386160d359
Core/Spells: define and implement PROC_FLAG_JUMP
...
* added forward leap exception for Thermal Jump
2019-11-30 01:07:38 +01:00
Ovahlord
dfd75a24e2
Core/Spells:
...
* fixed Shatter not granting its crit chance properly
* fixed Last Word crit chance bonus
2019-11-26 18:28:38 +01:00