Commit Graph
1549 Commits
Author SHA1 Message Date
joschiwald ef9b4aea5e Core/InstanceScript: refactored load and save methods 2014-09-07 00:42:14 +02:00
jackpoz 6df2ff5efa Core/Misc: Refactor scripts to fix static analysis warnings
Third batch of fixes targeting 100 issues reported by Coverity
2014-09-05 22:44:24 +02:00
joschiwald 681cf8f27c Core/Scripts: rename files, remove whitespace and some other small changes after recent pull requests 2014-08-31 20:33:46 +02:00
joschiwald c671b8e04b Merge pull request #12992 from Nyeriah/patch-uk
Scripts/UtgardeKeep: Update Skarvald & Dalronn scripts to EventMaps
2014-08-31 20:09:56 +02:00
Nyeriah 50b8ee22c7 Scripts/UtgardeKeep: Update Skarvald & Dalronn scripts to EventMaps
* Simplified creature_texts enum that was sort of confusing
* Removed hack to spawn ghosts using the proper spells
2014-08-31 14:56:52 -03:00
Duarte Duarte abc0380e7f Merge pull request #12953 from Golrag/master
Scripts/ICC: Fix Mutated Plague.

Closes #12492
2014-08-29 23:23:53 +01:00
Golrag 96ba36b9ce Scripts/ICC: Fix Mutated Plague. 2014-08-29 22:26:41 +02:00
Shauren f5115328c5 Merge pull request #12970 from Golrag/marrowgar
Scripts/ICC: Fixed Impale (Lord Marrowgar)
2014-08-29 21:12:17 +02:00
Golrag 6658d41575 Scripts/ICC: Fixed Impale (Lord Marrowgar) 2014-08-29 19:00:11 +02:00
joschiwald 01380c66bf Core/Misc: some random changes after recent pull requests 2014-08-29 17:46:55 +02:00
DDuarte c14283d484 Scripts/Hodir: Initialize variables
==9458== 1 errors in context 1 of 1:
==9458== Conditional jump or move depends on uninitialised value(s)
==9458==    at 0x1D2857B: boss_hodir::boss_hodirAI::DamageTaken(Unit*, unsigned int&) (boss_hodir.cpp:367)
==9458==    by 0x14A41E9: Unit::DealDamage(Unit*, unsigned int, CleanDamage const*, DamageEffectType, SpellSchoolMask, SpellInfo const*, bool) (Unit.cpp:562)
==9458==    by 0x1ABCEB3: misc_commandscript::HandleDamageCommand(ChatHandler*, char const*) (cs_misc.cpp:2138)
2014-08-28 22:28:41 +01:00
Unholychick 7c13b383cd Scripts/Ulduar: Implement Mimiron
Closes #12894
Fixes #7652
Fixes #4736

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-08-28 22:04:01 +01:00
DDuarte 430b3adfe8 Scripts: Correct despawn time of multiple objects
WorldObject::SummonGameObject respawn time is in seconds and not milliseconds
2014-08-26 13:37:55 +01:00
joschiwald bc42c48d97 DB/Spells: added a few spells to spelldifficulty_dbc 2014-08-26 04:35:37 +02:00
jackpoz 7fa49c8d62 Scripts/Ruby Sanctum: Fix Halion event ai not being updated
Fix Halion event ai not being updated due to private member hiding base class member.
Fixes #12835
2014-08-24 20:35:44 +02:00
Vincent-Michael 79b954a349 Core: meh, remove again whitespace :( 2014-08-24 02:46:14 +02:00
jackpoz 7fe7f30521 Core/Misc: Fix some -Wconversion warnings 2014-08-23 19:56:41 +02:00
Dr-J 0c1587cc91 Remove Injured rainspeaker oracle cpp script
Unneeded script
2014-08-21 21:19:36 +01:00
Unholychick 377f385c81 Scripts/Ulduar: Spellscripts for Mimiron
Closes #12579

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-08-18 22:01:47 +01:00
Jared P. Jones 1b65cda948 Scripts/Icecrown Citadel: The Teleporters in ICC are now Blizzlike *Upon entering the raid, the Lights Hammer teleporter is no longer immediately active. Both the Light's Hammer and the Oratory Portal will pop up after the completion of Lord Marrowgar as it does on official during 3.3.5a. *A teleporter in ICC can no longer teleport you to itself. *There is no longer a reason to allow GMs to use portals without available GOSSIP text and teleport locations. Therefore the teleports now use GO_FLAG_NOT_SELECTABLE when they are unavailable. In the future we can enable GMs to use portals without bosses defeated, however for now all it does is break the instance if some bosses are done out of order. *Currently the Upper Spire teleporter cannot be visited unless the event ColdFlameTraps is completed. This isn't blizz-like. During WotLK retail, the teleporter in the upper spire can be visited once any member has walked over an AreaTrigger which is located the moment you enter the UpperSpire Facade. The cold flame event has nothing to do with the teleporter, the cold flame event instead should be triggered to "DONE" when a rogue instead disarms it. *A bug has been addressed that causes the ColdFlameTraps event to not start back up after a server restart. The event will now restart as long as the player goes through the Saurfang->Upper Spire doorway; I'm not sure who required the doorway to be an area trigger, but it's hacky and not blizzlike. I have not yet addressed the area trigger problem with the doorway in this commit, mainly because the point of this commit is to make the ICC teleporters extremely Blizz-Like. *The "Conspicuous Lever" will now spawn inside of ICC. (From Sniff on Retail) While the lever currently doesn't do anything, in the future it will turn off the ColdFlame Traps. *The teleporter near Saurfang is not supposed to disable during the Intro. It disables whenever Saurfang enters combat with the players. The teleporter then enablers again when combat stops.
Closes #12834
2014-08-14 14:35:47 +02:00
jackpoz 8402570bb8 Scripts/Misc: Fix static analysis issues
Replace CAST_AI() macro with ENSURE_AI() when dynamic_cast is not supposed to return NULL.
2014-08-09 00:12:20 +02:00
Vincent-Michael 296956e06e Revert "Core/Spells: Death and Decay"
This reverts commit 02d56e00bc.
2014-07-24 16:14:25 +02:00
DDuarte 73df8f8381 Scripts/IoC: Rename spell_gen_* spells to spell_ioc_*
(Additions to 6bb63ab7db679d9c)

Closes #12414 (PR)
2014-07-24 03:49:30 +01:00
karn 26496375f8 Script/IoC: Move some spell scripts from spell_generic to isle_of_conquest cpp
Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 03:49:07 +01:00
Trisjdc c541f4f5de Scripts/Four Horsemen: Horsemen's main spells should only explicitly target players 2014-07-24 03:48:35 +01:00
Foldy 9e81b23a57 Scripts/ICC: Summon Sealed Chest quest npc's upon the Lich King's Death
TODO: template updates for these npcs and gossips

Closes #10554
Closes #12591 (PR)

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-24 01:23:45 +01:00
jackpoz 3388587b7a Core/Misc: Replace rand() calls with SFMT 2014-07-22 21:43:19 +02:00
Duarte Duarte 1b6ac4ac3a Scripts/ICC: Fix non-pch build 2014-07-21 23:25:14 +01:00
Golrag 1a391e9fbd Scripts/ICC: Added Orange/Green Blight Residue
Closes #5920
Closes #12464 (PR)

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-21 03:11:55 +01:00
Vincent-Michael 0531f52008 Core: Fix non pch build (gcc) 2014-07-20 02:54:12 +02:00
karn 26aaf2384c Core/Creature: Minigob Manabonk
Closes #11097

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-07-19 22:50:32 +01:00
joschiwald 35f5a78a43 Merge pull request #12166 from MitchesD/hor
Scripts/HoR: fixed possible exploit with taunt during escape event
2014-07-19 21:23:18 +02:00
MitchesD 35d508cd6d Scripts/HoR: fixed possible exploit with taunt during escape event 2014-07-19 21:05:59 +02:00
joschiwald 297e63da36 Scripts/AhnKahet: Elder Nadox
* replaced egg core script with db content
* removed useless spellscript for Guardian Aura
* fixed Swarm aura
* Patch 3.3.2 (2010-01-02): Elder Nadox now only gets one Ahn'Kahar Guardian during the encounter.

Closes #12506
2014-07-19 20:30:13 +02:00
Shauren 7532864264 Buildsystem/MSVC: Warning fixes
C4800 'type' : forcing value to bool 'true' or 'false' (performance warning)
C4127 conditional expression is constant
2014-07-17 15:42:57 +02:00
Shauren 232eaae69c Scripts/Icecrown Citadel: Fixed a possibility to start the encounter again if Tirion evades during outro RP
Closes #10060
2014-06-18 00:00:41 +02:00
Shauren d60f959fce Core/Pets: Fixed pet power regeneration
Closes #12292
2014-06-17 17:23:30 +02:00
Trisjdc f27821486b DB/SpellGroups: Completely review of WotLK Stack Rules
Closes https://github.com/TrinityCore/TrinityCore/issues/4313, https://github.com/TrinityCore/TrinityCore/issues/1626, https://github.com/TrinityCore/TrinityCore/issues/5173, https://github.com/TrinityCore/TrinityCore/issues/5822, https://github.com/TrinityCore/TrinityCore/issues/12212, https://github.com/TrinityCore/TrinityCore/issues/3814, and probably others
2014-06-15 23:22:53 +01:00
Vincent-Michael 1c80e441a0 Core: Fix non pch build 2014-06-14 23:33:20 +02:00
Vincent-Michael 53caf7959e Core/Ulduar: Added IsInCombat check for ulduar teleporter 2014-06-14 22:01:50 +02:00
Vincent-Michael cd3977edf9 DB/Misc: Convert ulduar teleporter in sql 2014-06-14 20:03:55 +02:00
MitchesD 86b3298a47 Scripts/Misc: random fixes 2014-06-14 17:48:47 +02:00
Shauren e9c9e36265 Scripts/Icecrown Citadel: Fixed possible crash in blood nova target selection 2014-06-14 11:48:07 +02:00
Vincent-Michael 1d39db16b9 Core/Misc: Kill Whitespace ... 2014-06-07 23:58:08 +02:00
Sebastian Valle Herrera 36102bea64 Merge pull request #12039 from Trisjdc/creature_ai_talk
Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs
2014-06-05 10:50:23 -05:00
Trisjdc d4bdfebd9e Scripts/ToCr: Bosses shouldn't despawn so quickly 2014-06-05 11:37:24 +01:00
Trisjdc 8db02c52ac Core/Util: A couple useful new functions for EventMap, as well as getting rid of some old junk 2014-06-02 23:59:35 +01:00
joschiwald 3c97735056 Scripts/PoS: fixed rimefang icy blast
Closes #632
2014-05-23 16:16:31 +02:00
jackpoz 1083dbb993 Core/Misc: Remove Unit::Get* wrappers for ObjectAccessor::Get* 2014-05-20 21:21:33 +02:00
joschiwald 37073a8817 Merge pull request #12082 from MitchesD/misc_2
Scripts/Krystallus: converted to EventMap, removed useless code
2014-05-19 02:48:41 +02:00