Commit Graph
2178 Commits
Author SHA1 Message Date
ariel- 0e8422c30a Core/Misc: fix static analysis issues
CID 1373466
CID 1373481
CID 1373482

(cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
2022-02-16 04:49:24 +01:00
ariel- 4ad1d377fe Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d767c95910d4508e0e83f34b4f89f587a)
2022-02-16 04:49:24 +01:00
xinef1 df9738aaa9 Core/Misc: Fixed player corpse looting, added player corpse loot and some more (#19122)
* Fixed corpse looting in wintergrasp
Added corpse loot for wintergrasp quests and To the Looter Go the Spoils (1166) achievement
Don't generate money for loot if no loot mode is available
Simplified few things

(cherry picked from commit 2412886ef69d305df1bd6e6422ca3134c0ab1449)
2022-02-16 04:49:24 +01:00
xinef1 f431459063 Core/Creatures: Various fixes for creatures, regarding combat conditions, despawning, and few others (#18998)
* Made some changes to kiting mechanics, simplified code and made taunt auras prolong combat no matter the distance from the spawn
Unified some creature despawning code, removed some brutal direct calls in scripts
Don't play death anim on forced despawn
Removed some redundant visibility changes on creature despawn
Fixed possible problem with pet initializing template info from difficulty greater than normal
Properly keep UNIT_FLAG_IN_COMBAT on UpdateEntry call
Moved RegenerateMana function to general Regenerate(Power) function
Fixed increased health regeneration from polymorph for pets
Implemented CREATURE_TYPE_FLAG_GHOST_VISIBLE, those creatures will be properly seen when player is dead also
Removed hackfix from Gaeriyan and Franclorn Forgewright, fixed properly
Simplified ForcedRespawnTime code in ForcedDespawn
Do not allow to assist unit while evading or when enemy is evading
Do not allow to attack other units when evading or when the unit is evading
Corrected distance checking code before creature is allowed to evade, should fix some common problems
Properly return summon position for summoned creatures as their respawn position
Properly stop all moving units on gossip hello, no matter their npc flags

(cherry picked from commit e1f14215d86fc9f0cd041f0e87bf0a689c086329)
2022-02-16 04:49:24 +01:00
Ovahlord bea6e6dcea fixed build 2022-02-05 07:22:16 +01:00
Ovahlord f2d651f6a9 Core/Units: no longer normalize melee basic attacks of feral druids 2022-02-05 00:00:55 +01:00
Ovahlord db769f5e52 Core/Units: safeguard Unit::CancelSpellMissiles against triggering an assert in BasicEvent::ScheduleAbort when trying to cancel spell events that already are about to the aborted 2022-01-17 10:59:41 +01:00
Ovahlord 009e1dba37 Core/Spells: coefficient scaling will no longer affect attack power multipliers 2022-01-09 15:09:21 +01:00
Ovahlord e84bb6e6ba Core/Units: no longer send debug hitInfo flags as these have no clientside effect at all
closes #261
2022-01-05 22:35:30 +01:00
Ovahlord 7dc29ee9c1 Core/Spells: skip unnecessary coefficient scaling lookups when no coefficient is provided 2022-01-05 22:32:05 +01:00
Ovahlord 2dc07876ea Core/Spells: implement spellpower and attackpower coefficient scaling 2022-01-05 20:19:06 +01:00
Ovahlord 01d0a0b09c Core/Spells: use the correct getter for school mask 2022-01-05 15:03:42 +01:00
Ovahlord fa378dc870 Core/Spells: Unit::MeleeDamageBonusTaken will now use the SchoolMask of melee attack spells when spellInfo is provided
ref https://github.com/TrinityCore/TrinityCore/issues/27523
2022-01-05 13:11:58 +01:00
Ovahlord 7f62463f36 Core/Movement: no longer blindy rely on ack messages to change movementstatus values as the client can and will sometimes ignore packets such as when receiving movement packets while not being sent out via update object (changing maps via teleport) 2022-01-04 15:04:49 +01:00
Ovahlord 91516e155f Core/Units: ported another crashfix from TC 2022-01-04 11:48:42 +01:00
Shauren 8acf90d115 Core/Units: Sync ProcessTerrainStatusUpdate code with master branch 2022-01-01 16:49:48 +01:00
Ovahlord 8202480a93 Core/Units: corrected calculations for dodge, parry and spell hit chances 2021-12-29 19:37:47 +01:00
Ovahlord efc94b46f4 Core/Units: corrected melee miss chance calculation 2021-12-29 19:12:37 +01:00
Giacomo Pozzoni adde43e965 Core/AI: Fix crashes caused by charmed Creatures having null AI for 1 map update tick (#27434)
Implement using ScheduledChangeAI instead of nullptr to signal a required AI change
# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Entities/Unit/Unit.h
2021-12-27 22:25:11 +01:00
Ovahlord 9d4218f6d4 Core/Units: corrected armor damage reduction calculation 2021-12-26 22:08:57 +01:00
Ovahlord a8301ba5f6 Core/Units: fixed a crash when creatures are having their attack speed increased via aura 2021-11-28 15:11:23 +01:00
Lucas Nascimento 336ed5ce54 Core/Combat: Fixed combat after remove charm (#27248)
https://github.com/TrinityCore/TrinityCore/pull/27038#issuecomment-958784361
# Conflicts:
#	src/server/game/Combat/CombatManager.h
2021-11-28 12:21:59 +01:00
Shauren 34c2da7bd9 Core/Auras: Properly clean up partial charm applications
Ref #24876
2021-11-28 12:19:38 +01:00
ariel- af98e8516c Core/Auras: reworked multiplicative AuraEffects calculation 2021-11-28 12:14:05 +01:00
Ovahlord 27d9726dc3 Core/Units: no longer send collision height change packets when a player has not been added to the world yet 2021-11-22 14:15:38 +01:00
Ovahlord 373a296b8d Core/Units: removed deprecated fake attacker state update from the core 2021-11-17 17:18:05 +01:00
Ovahlord 7840a8f529 Core/Spells: implemented SpellAuraInterruptFlags2::AbandonVehicle and removed unused definitions which have not been used in Cataclysm yet 2021-11-17 17:02:06 +01:00
Seyden 4c870d1e88 Core/Auras: Implement SpellAuraInterruptFlags2::Ground and SpellAuraInterruptFlags2::Swimming (#27193)
# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
2021-11-17 16:30:51 +01:00
Ovahlord 631b499414 Core/Movement: updated collision height packet handling to ack handling 2021-11-16 07:11:00 +01:00
Ovahlord 4b56a7b9a3 Core/Movement: converted SMSG_MOVE_SET_CAN_TRANSITION_BETWEEN_SWIM_AND_FLY and SMSG_MOVE_UNSET_CAN_TRANSITION_BETWEEN_SWIM_AND_FLY to new ack handling 2021-11-12 19:29:00 +01:00
Ovahlord c220644db1 warning fix 2021-11-10 16:56:54 +01:00
Ovahlord 5ca475a764 Core/Movement: split SetCanFly for player and creature class and handle their part accordingly 2021-11-10 13:53:14 +01:00
Ovahlord fbc1b8565a fixed build 2021-11-10 13:33:17 +01:00
Ovahlord a689446e56 Core/Units: disarmed another overzealous assert 2021-11-10 13:30:46 +01:00
Ovahlord df38c26f92 Core/Units: re-added a few capability fixups that got removed in 0a7dfc15e2 and allow auras to send their amount values when changing amount via RecalculateAmount 2021-11-10 13:16:25 +01:00
Ovahlord 56813fd186 Core/Movement: refactored pending movement change queue to be a unordered map instead so we no longer ARE overzealous with kicks when counters or ack receiving order mismatches 2021-11-10 12:19:00 +01:00
Ovahlord 0a7dfc15e2 Core/Movement: ported mount capability updating from master branch and replaced old implementation with it 2021-11-09 18:13:23 +01:00
Ovahlord 3d8762297c Core/Movement: converted CanFly and DisableGravity ack handling to new system 2021-11-08 22:23:54 +01:00
Ovahlord 9faf867f34 Core/Movement: ported movement speed change acknowledge packet handling from 335 branch 2021-11-08 12:44:49 +01:00
Ovahlord edbbeba5a2 Core/Movement: ported client control logic updates from 335 branch 2021-11-06 23:41:34 +01:00
Lucas Nascimento 22fecb6d1b Entities/Unit: Fixed wrong combat stop when remove charm (#27038) 2021-10-20 18:52:12 +02:00
Ovahlord 069684ffa5 Core/Spells: SPELL_AURA_MOD_CASTING_SPEED_NOT_STACK will no longer affect spell haste when its amount is too extreme to fix several exploits with instant cast auras causing haste affected dots and hots dealing insane amounts of damage 2021-09-19 14:33:02 +02:00
Ovahlord 949f92e0a1 Core/AI: ported charm updates from 335 2021-09-16 16:48:07 +02:00
Ovahlord b03fe81f68 Revert "Core/Spells: no longer round PPM chance calculation results and stay more faithful to the original formula"
This reverts commit 1b91ed5424.
2021-09-11 18:16:18 +02:00
Ovahlord 1b91ed5424 Core/Spells: no longer round PPM chance calculation results and stay more faithful to the original formula 2021-09-11 17:13:03 +02:00
Ovahlord 60c68dacca Core/Spells: moved avoidance bonus handling to Unit::SpellDamageBonusTaken as it does affect all area attacks instead of periodic auras only 2021-09-01 21:26:12 +02:00
Ovahlord 3506dae653 Core/Spells: ported PROC_FLAG_ENTER_COMBAT implementation from master branch and handle the Worgen transformation via its proc aura 2021-08-30 19:24:36 +02:00
Ovahlord 7ac3d6fca9 Core/Players: Worgen will now transform into their altered form at engage instead of at dealing or taking damage 2021-08-29 18:36:33 +02:00
Ovahlord a5caf1af95 Core/Units: removed now unused attacker argument from Unit::GetUnitCriticalChanceTaken 2021-08-29 02:13:16 +02:00
Ovahlord fd815dfe33 Core/Units: remove an incorrect check for SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER from Unit::GetUnitCriticalChanceTaken as that aura is only being involved for increasing crit chance values for spells with a class mask value 2021-08-29 01:52:39 +02:00