Ovahlord
d8753ef5d7
Core/Vendors: allow players to interact with vendors that do not have any items to sell
2021-09-10 10:04:14 +02:00
Ovahlord
60c68dacca
Core/Spells: moved avoidance bonus handling to Unit::SpellDamageBonusTaken as it does affect all area attacks instead of periodic auras only
2021-09-01 21:26:12 +02:00
Ovahlord
3506dae653
Core/Spells: ported PROC_FLAG_ENTER_COMBAT implementation from master branch and handle the Worgen transformation via its proc aura
2021-08-30 19:24:36 +02:00
Ovahlord
7ac3d6fca9
Core/Players: Worgen will now transform into their altered form at engage instead of at dealing or taking damage
2021-08-29 18:36:33 +02:00
Ovahlord
a5caf1af95
Core/Units: removed now unused attacker argument from Unit::GetUnitCriticalChanceTaken
2021-08-29 02:13:16 +02:00
Ovahlord
fd815dfe33
Core/Units: remove an incorrect check for SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER from Unit::GetUnitCriticalChanceTaken as that aura is only being involved for increasing crit chance values for spells with a class mask value
2021-08-29 01:52:39 +02:00
Ovahlord
4c6cfee2dd
Core/Units: normalize melee damage while in bear or cat form
2021-08-29 00:19:06 +02:00
Ovahlord
5ed7516280
Core/Transports: fixed a logic mistake introduced in be614ded97
2021-08-19 06:20:05 +02:00
Ovahlord
be614ded97
Core/Misc: fixed issues reported by pvs studio
...
closes #281
2021-08-18 21:11:20 +02:00
Ovahlord
8186f9d450
make CI happy
2021-08-17 15:38:13 +02:00
Ovahlord
da5564fa47
Core/Packets: converted SMSG_CLEAR_COOLDOWN and SMSG_CLEAR_COOLDOWNS to packet class
2021-08-16 11:02:22 +02:00
Ovahlord
8ac7e71690
Core/Spells: implement summon properties parameter types based on the leaked enumerated strings values
...
Summon spells can now be commanded to interpret their basepoints depending on the parameter type that has been assigned to the summon properties dbc record Id
* implemented SummonCreatureExtraArgs to reduce the amount of arguments in Map::SummonCreature
2021-08-15 10:35:02 +02:00
Gildor
a91f7a3ef3
Core/Quest: When removing an item required for a quest, update every quest in the quest log instead of stopping at the first objective that matches the removed item. ( #26760 )
...
Closes #25662
Closes #10586
2021-07-29 17:31:54 +02:00
Gildor
1466176aef
Core/Quests: Improve ItemRemovedQuestCheck logic ( #26758 )
...
Closes #25603
2021-07-29 17:31:23 +02:00
Ovahlord
c58d2752d3
Core/Creatures: fixed build and clamp the damage pct limit instead of blindy relying on arguments
2021-07-26 15:57:29 +02:00
Ovahlord
0dfa919f09
Core/Creatures: optimized sparring checks by handling them via variable instead of map lookups and expose its value to helpers to allow manipulation during runtime
2021-07-26 15:48:16 +02:00
Ovahlord
ae13da2159
fixed build
2021-07-25 15:03:43 +02:00
Ovahlord
7648eff6db
Core/Quests: check if a player can take the next quest provided by its query data before trying to request its details
2021-07-25 14:57:41 +02:00
Ovahlord
7bd1afe406
Core/Units: corrected check for SPELL_ATTR7_CANT_MISS in Unit::MagicSpellHitResult
...
thx to @Jildor for the headsup
2021-07-23 19:44:14 +02:00
Ovahlord
81098f738f
fixed nopch build
2021-07-12 09:01:53 +02:00
Ovahlord
1a5c06b61a
Core/Packets: several updates to trading
...
* converted CMSG_INITIATE_TRADE, SMSG_TRADE_STATUS, SMSG_TRADE_UPDATED and CMSG_ACCEPT_TRADE to packet class
* fixed enchanting items via trade
* handle unknown fields in SMSG_TRADE_UPDATED
2021-07-11 23:48:50 +02:00
Giacomo Pozzoni
d83cd33bd4
Core/Pools: Fix pools with 1 member never spawning anything anymore ( #26620 )
...
* Core/Pools: Fix pools with 1 member never spawning anything anymore
Attempts to fix a 6 years old bug and never fixed by the original author.
* Remove respawn times from db once a respawn has been handled
* Allow to specify if Despawn1Object() should save or not the respawn time. We don't need to do that when respawning an object.
* Apply the same fix to GameObjects too
# Conflicts:
# src/server/game/Pools/PoolMgr.h
2021-06-27 06:33:19 +02:00
funjoker
b64983d753
Fix build after cherry-pick
2021-06-26 01:07:04 +02:00
AlιAѕѕaѕѕιN
338c1e28ae
[3.3.5] Fix spell_area not checking for zoneID for quests ( #23719 )
...
* Fix spell_area not checking for zoneID for quests
* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8
* Fix spell_area handle same spell with the same quests
Also fix not checking for quest_end at all.
* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d
* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7
* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d
(cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-06-26 00:58:18 +02:00
funjoker
a7b20bc156
Revert "Core/Misc: Fix zonewide spell_area not being updated on quest update"
...
This reverts commit 107fbf5aa2 .
2021-06-26 00:54:25 +02:00
funjoker
107fbf5aa2
Core/Misc: Fix zonewide spell_area not being updated on quest update
2021-06-26 00:47:02 +02:00
funjoker
2d78058a19
Core/Packets: Remove incorrect if clause blocking InCompleteEmote being sent
2021-06-22 23:42:12 +02:00
Ovahlord
5fd77a3b28
Core/World: implement database support for default map and realm wide world states
2021-06-13 16:07:38 +02:00
Ovahlord
be239e4458
Core/Maps: implement map based world states and implemented support for required world states in achievement criterias
...
*converted Erduax' conditional achievement to world state based handling as example
2021-06-13 10:48:41 +02:00
Ovahlord
8011d2de29
Core/Spells: ported resistance and immunity updates from 3.3.5 branch
2021-06-12 14:10:44 +02:00
Ovahlord
6617ce0ffd
Core/Spells: fixed an UI visual glitch that was showing a spell as still being processed when it has been queued up and replaced by a 2nd request
2021-05-24 17:55:41 +02:00
Ovahlord
4430863a1e
Core/Spells: Implement spell queue
...
As of patch 4.1 spell casts can now be queued up 400ms before a ongoing cast finishes or the global cooldown expires to deliver a smooth transitions between casts though emulators do not really benefit from it.
closes #224
2021-05-24 17:14:55 +02:00
Ovahlord
1325c8cb97
fixed a warning
2021-05-23 13:49:54 +02:00
Ovahlord
254b4eb011
Core/Spells: Drain Life's healing effect will no longer benefit from Soul Siphon and updated Soul Siphon's bonus check to Cataclysm
2021-05-23 12:59:39 +02:00
Ovahlord
f56c3945d8
Core/Vendors: added for now unused PlayerConditionID field to npc_vendor table as it's being used since 4.2
2021-05-15 20:59:14 +02:00
Ovahlord
6446541738
Core/Skills: ported master branch handling for learning skills on levelup
2021-05-14 14:52:52 +02:00
Ovahlord
b5994ec6c5
Core/Units: improved logic for determining when a power update shall happen
2021-04-30 16:48:26 +02:00
Ovahlord
c764cce4a3
Core/Player: fixed an exploit that was causing seasonal currency counter to increase from refunding currency based items
2021-04-30 13:17:18 +02:00
Ovahlord
0ae695908c
Core/Loot: converted SMSG_LOOT_RESPONSE to packet class and properly incorporate currency loot into loot generation
2021-04-30 12:50:14 +02:00
Shauren
22eaf31bfa
Core/Spells: Only interrupt spells with interrupt flag Combat when spell also has SPELL_ATTR0_CANT_USED_IN_COMBAT attribute
2021-04-29 20:37:18 +02:00
Shauren
f3e0650886
Core/PacketIO: Reduce size of SMSG_UPDATE_OBJECT by trimming trailing zeros in values updatemask
2021-04-25 17:22:58 +02:00
Ovahlord
9ff4bbd085
Core/Spells: ported implementations of SPELL_AURA_DISABLE_CASTING_EXCEPT_ABILITIES and SPELL_AURA_DISABLE_ATTACKING_EXCEPT_ABILITIES from master branch
...
closes #93
2021-04-21 18:51:34 +02:00
Roc13x
abb5164f55
Core/Channel: Implement use of CHANNEL_DBC_FLAG_INITIAL ( #256 )
...
Reduces differences with TC
2021-04-20 16:06:10 +02:00
Roc13x
57b4f7e51b
Core/Items: Prevent broken items from applying reforge effects ( #257 )
2021-04-20 16:05:39 +02:00
Ovahlord
1a6f62d660
Core/Packets: converted SMSG_GUILD_NEWS, SMSG_GUILD_EVENT_LOG_QUERY_RESULTS and SMSG_GUILD_BANK_LOG_QUERY_RESULTS to packet class
2021-04-19 14:49:48 +02:00
ariel-
5c882e8788
Core/Unit: fixed Global cooldown cancelation on spell interrupt
2021-04-16 20:41:20 +02:00
Ovahlord
974f3163bc
Core/Packets: converted SMSG_CORPSE_RECLAIM_DELAY to packet class
2021-04-16 18:09:08 +02:00
Ovahlord
b82943eab0
Core/Spells: renamed SPELL_ATTR5_HASTE_AFFECT_DURATION to SPELL_ATTR5_SPELL_HASTE_AFFECTS_PERIODIC and renamed SPELL_ATTR8_UNK17 to SPELL_ATTR8_HASTE_AFFECTS_DURATION
2021-04-16 16:12:58 +02:00
Ovahlord
eca1b5bcaa
Core/Units: fixed comma based calculations for rewarding rage
2021-04-09 19:27:44 +02:00
Ovahlord
c77c435363
Core/Spells: check enchantment and item procs for SPELL_ATTR3_CANT_TRIGGER_CASTER_PROCS as well to fix potential endless loops such as Rune of Razorice which can proc themselves over and over again
2021-04-09 14:37:04 +02:00