Commit Graph
100 Commits
Author SHA1 Message Date
ariel- ddb787482c Core/Unit: don't clear low health aura states on death
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening

Closes #19754
2017-05-16 06:50:39 +02:00
ariel- 4eaa6b50b6 Core/Entities: allow guardian pets to inherit spellmods 2017-05-07 06:06:34 +02:00
ariel- f3246f835c Core/Scripts: remove OnDummyEffect hook/sOnDummyEffect ai hook
- Duplicated logic never used, sometimes only ScriptMgr version was called, sometimes only AI
- They only encourage bad scripting practices
- You can still use OnSpellHit or a SpellScript
2017-05-02 02:04:45 +02:00
ariel- 4e9ab055c9 DB/Spell: fix Glyph of Shadow proc
- Fixes not proccing with Imp. Devouring Plague/Mind Flay/Mind Sear
2017-04-28 12:58:53 +02:00
ariel- e53e8b8437 Core/AI: some tweaks on boundary functionality:
- Moved SetBoundary to public scope to allow for greater flexibility (ie set from external script)
- Extended to allow checking inverted boundaries
2017-04-26 13:08:01 +02:00
ariel- 8070e6ad29 Core/AI: added a function to allow 0 damage attacks (sparring) depending on target 2017-04-26 13:07:54 +02:00
ariel- 04466823e1 Core/Scripts: fix gaseous bloat proc (again)
- UNIT_STATE_CASTING removal not needed for movement now, but it's needed for melee attacking
2017-04-25 13:33:38 +02:00
ariel- c697a9de2e Core/Spell: don't make creature change orientation to 0 if channeling self 2017-04-25 13:31:11 +02:00
ariel- 8e16897073 Core/Spell: define channels without movement interrupt flags as allowed move
- Remove script hacks no longer needed
2017-04-25 13:30:58 +02:00
ariel- 2e27a1f64e Core/AI: prevent launching a new MoveChase if victim didn't change
Thanks ccrs for feedback :P
2017-04-25 13:30:44 +02:00
ariel- 469be111cd Core/Spell: implement pvp trinket immunity against Judgement of Justice
By Riztazz, closes #19484
2017-04-25 13:27:41 +02:00
ariel- e6580ad922 Core/Player: don't randomly change temporary spell status
- They shouldn't be saved in db
- Prevented temporary spell removal after a save

Closes #14373
2017-04-25 13:27:28 +02:00
ariel- 8b8bf5399d Revert "Core/Spell: don't set scaleAura for some special spells"
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.

Closes #19472
2017-04-25 13:22:41 +02:00
ariel- 3b718833c5 DB/Misc: populated version table with missing data from TDB file (again) 2017-04-20 20:01:05 +02:00
ariel- 8053766776 Core/Scripts: fix dereferencing invalid iterator
Closes #19464
2017-04-16 11:48:27 +02:00
ariel- a3538f4dbe Core/Auras: don't skip stack rule check whenever spells have same ID
- The auras might not have the same amounts due to spellmods

Closes #1626
2017-04-16 11:46:11 +02:00
ariel- dcdc9f25fa DB/Spell: Egg of mortal essence should proc with HoTs
Closes #19441
2017-04-14 13:50:34 +02:00
ariel- c17fa0bcc5 Core/Instance: stop updating the instance resettimes based on creature respawns 2017-04-14 13:50:13 +02:00
ariel- 0d6c2978ae Core/Creature: fix integer overflow in Creature::Update leading to endless thrashing of characters database
Closes #19182
2017-04-14 13:45:57 +02:00
ariel- ca900fe2b4 Core/Player: fix weapon dependent aura talents not applied on talent learn 2017-04-09 18:15:49 +02:00
ariel- 33b2ceefb1 Core/Auction: wrap item deletions from AHBot auction on a transaction
This speeds up the query execution time tremendously
Refs #19182
2017-04-09 18:11:45 +02:00
ariel- 30075e8575 Core/AHBot: fix price calc
- priceRatio is already a factor
2017-04-09 18:11:29 +02:00
ariel- a6ff258ace DB/Spells: remove some wrong spells from trainer tables
Refs #19394
2017-04-09 18:11:02 +02:00
ariel- 975ef8d8d9 Core/Spell: don't set scaleAura for some special spells
Closes #14541
2017-04-09 18:10:51 +02:00
ariel- 20af61b777 DB/Schema: add unsigned to some guid fields in characters 2017-04-09 18:06:54 +02:00
ariel- db582949b5 DB/Spell: fix Darkmoon Card: Berserker from proccing off everything 2017-04-09 18:00:00 +02:00
ariel- f7b50f51fc DB/Spell: Fix Living seed proc from non-damaging spells 2017-04-09 17:59:51 +02:00
ariel- 84cba8496c DB/Creature: fix regenerating health for vehicles in Wintergrasp and BGs
Closes #950
2017-04-01 07:11:46 +02:00
ariel- 66c0c634ad Core/AI: Build fix
- Stop exposing DoublePosition constructor versions, they're only used for internal representation
- Moved IsInBounds function to public scope
2017-04-01 07:06:53 +02:00
ariel- d3151fed8c Core/AI: AreaBoundary refactor
- Added an auxiliary function IsInBounds to base CreatureAI
- Changed container to vector. Set had no sense because we're storing new pointers, they have different addresses even if the boundary is the same
2017-04-01 07:06:35 +02:00
ariel- 661e150038 Core/Creature: added CREATURE_FLAG_EXTRA_GHOST_VISIBILITY to allowed db flags_extra mask
- Cleaned up the mask to be a much nicer enum definition
2017-04-01 07:06:12 +02:00
ariel- a3e41a3df6 Core/Global: reserve storage for script names vector 2017-04-01 07:06:02 +02:00
ariel- 402ad3dad7 Core/Auras: fix a deleted memory access crash
Closes #19319
2017-03-26 06:15:52 +02:00
ariel- 828101aa2b Core/Scripts: Updated Ulduar instance model
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)
2017-03-26 05:46:04 +02:00
ariel- d1382c5f23 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234
2017-03-20 16:55:01 +01:00
ariel- 2ce8cf4863 DB/Gameobject: add missing gameobjects to Zul'Aman
Taken from UDB
2017-03-20 16:54:53 +01:00
ariel- 35e9c27c4a Core/Entities: don't finalize movesplines before deleting.
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324
2017-03-20 16:53:54 +01:00
ariel- 5f7ac85dca Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319
2017-03-20 16:53:13 +01:00
ariel- cb8f052a65 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275
2017-03-20 16:45:17 +01:00
ariel- f2c7c5cf0c Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309
2017-03-20 16:45:09 +01:00
ariel- 045307cd6e Core/Auras: unregister AuraEffect from target list before changing amount, forces recalculation at stack change
Closes #19301
2017-03-15 23:37:08 +01:00
ariel- 7802e88ace Core/Auras: use vectors and remove HasEffect check
- Already checked in GetApplicationList
2017-03-15 23:36:56 +01:00
ariel- fc91921241 Core/Scripts: add condition check for npc_wyrmrest_defender
minor code refactors

Closes #19299
2017-03-15 23:36:36 +01:00
ariel- 553ae42111 Core/Creature: restore previous behavior of random gender on respawn
Little regression added with 253c0f3d07e05557daa3ffdd4e2a2af4256fb65e
2017-03-13 10:10:08 +01:00
ariel- 7871583016 Core/Auras: tidy up one little hack 2017-03-13 10:09:59 +01:00
ariel- d99739cd8c Core/Creature: remove some redundant code
- Display Ids are already initialized in InitEntry, no need to duplicate logic
- ModelInfo is already checked too
2017-03-13 10:09:33 +01:00
ariel- eb2526c8e2 Core/Auras: implement correct model for Bear Form (used by npcs)
Closes #7337
2017-03-13 10:09:16 +01:00
ariel- c3aaf501ab Core/Creature: don't override display id if addon tables load a morph aura
Ref #7337
2017-03-13 10:09:07 +01:00
ariel- 68c4606725 Core/Scripts: converted Argent Tournament pennants to AI
Closes #14616
2017-03-13 10:08:59 +01:00
ariel- d9c5065acc Core/Auras: Implement Roc form shapeshift
Closes #16164
2017-03-13 10:08:50 +01:00
ariel- 4a54bf7ab9 Core/Auras: make transform auras honor creature_template trigger flag and choose always invisible models
Closes #19211
2017-03-13 10:08:41 +01:00
ariel- 6d39a1db40 Core/Creatures: disabled "automatic" monster sparring
- Faction template flags weren't correct.

Closes #19245
2017-03-13 10:08:03 +01:00
ariel- 4602724be6 Core/SmartAI: Allow scripting GameObjects by spawn id too 2017-03-13 10:06:40 +01:00
ariel- 7fbe0cb1ae DB/Conditions: fix Sablemane's Sleeping Powder exploit 2017-03-13 10:05:26 +01:00
ariel- 96816e1e76 Core/Creature: redo some logical checks in _IsTargetAcceptable
- Check against current creature victim, don't check potential victim attacking list.
- Neutral creatures with aggressive reactstate were triggered to attack from MoveInLineOfSight because of this check
- Prevents attack from a distance after right clicking an npc

Closes #19235
2017-03-13 10:04:00 +01:00
ariel- 39ad9d81ae DB/Spell: fix stack rules for some groups
- Haste % (Improved Moonkin Aura, Swift Retribution)
- Damage % (Arcane Empowerment, Sanctified Retribution, Ferocious Inspiration)
- Healing % (Tree of Life, Improved Devotion Aura)

Closes #16331
Closes #17175
2017-03-13 10:03:51 +01:00
ariel- 936ddbff9b Core/Spell: disable proc for magnet auras, they're handled differently
Closes #19208
2017-03-03 01:33:07 +01:00
ariel- 22c4d86dfe Core/Database: Prepared statement parameter preallocation (#18999)
- Pass prepared statement size to the helper class to prevent runtime resizing.
- Rename CheckValidIndex -> AssertValidIndex
- Cached prepared size on the worker pool as it's shared among all connections
- Cached query data only for each connection, done lookup in map instead of possibly creating a new element
- Kill the prepared statement map, and store raw sql string on the MySQLPreparedStatement class
(This info is only used for logging, and there is no need of keeping a second container just for it)
2017-03-03 01:32:12 +01:00
ariel- 04d3783664 Core/Scripts: Change null-check to assert
- ToPlayer() should never be null in this context
2017-03-03 01:31:04 +01:00
ariel- d93be13e6e Core/Misc: always output client cache version on loading 2017-03-03 01:30:46 +01:00
ariel- 66e856fc50 DB/Misc: populated version table with missing data from TDB file
Closes #18274
2017-03-03 01:30:36 +01:00
ariel- 7544544cf1 Core/Entities: spawned movementtype should override template movementtype
Core/SmartAI: pass the CreatureData pointer (if any) on updating template

Closes #19223
2017-03-03 01:30:25 +01:00
ariel- 3ceeffde86 Core/Movement: Corrected all speed checks after 23b6991273bac4ee9d7cf1b4ac3b9a92e0a7300e
Ref issue #19210
2017-03-03 01:30:15 +01:00
ariel- 2acac2c9f7 Core/Scripts: implement Moss Covered Feet
Closes #19022
2017-03-03 01:30:02 +01:00
ariel- 277cdfdff8 Core/Auras: fix more unused parameter warnings 2017-03-03 01:28:48 +01:00
ariel- 45bbcd1d9b Core/Auras: fix unused parameter warning 2017-03-03 01:28:20 +01:00
ariel- c777589d70 Core/Scripts: kill a warning 2017-03-03 01:26:22 +01:00
ariel- 891b8369e6 Core/Scripts: Thrusting Hodir's Spear
- Everything is sniffed, enjoy this hell of a quest!

Closes #12808
2017-03-03 01:26:12 +01:00
ariel- ce6df00019 Core/Dep: update zlib to 1.2.11
Changelog:

Changes in 1.2.11 (15 Jan 2017)
- Fix deflate stored bug when pulling last block from window
- Permit immediate deflateParams changes before any deflate input

Changes in 1.2.10 (2 Jan 2017)
- Avoid warnings on snprintf() return value
- Fix bug in deflate_stored() for zero-length input
- Fix bug in gzwrite.c that produced corrupt gzip files
- Remove files to be installed before copying them in Makefile.in
- Add warnings when compiling with assembler code

Changes in 1.2.9 (31 Dec 2016)
- Fix contrib/minizip to permit unzipping with desktop API [Zouzou]
- Improve contrib/blast to return unused bytes
- Assure that gzoffset() is correct when appending
- Improve compress() and uncompress() to support large lengths
- Fix bug in test/example.c where error code not saved
- Remedy Coverity warning [Randers-Pehrson]
- Improve speed of gzprintf() in transparent mode
- Fix inflateInit2() bug when windowBits is 16 or 32
- Change DEBUG macro to ZLIB_DEBUG
- Avoid uninitialized access by gzclose_w()
- Allow building zlib outside of the source directory
- Fix bug that accepted invalid zlib header when windowBits is zero
- Fix gzseek() problem on MinGW due to buggy _lseeki64 there
- Loop on write() calls in gzwrite.c in case of non-blocking I/O
- Add --warn (-w) option to ./configure for more compiler warnings
- Reject a window size of 256 bytes if not using the zlib wrapper
- Fix bug when level 0 used with Z_HUFFMAN or Z_RLE
- Add --debug (-d) option to ./configure to define ZLIB_DEBUG
- Fix bugs in creating a very large gzip header
- Add uncompress2() function, which returns the input size used
- Assure that deflateParams() will not switch functions mid-block
- Dramatically speed up deflation for level 0 (storing)
- Add gzfread(), duplicating the interface of fread()
- Add gzfwrite(), duplicating the interface of fwrite()
- Add deflateGetDictionary() function
- Use snprintf() for later versions of Microsoft C
- Fix *Init macros to use z_ prefix when requested
- Replace as400 with os400 for OS/400 support [Monnerat]
- Add crc32_z() and adler32_z() functions with size_t lengths
- Update Visual Studio project files [AraHaan]
2017-03-03 01:25:52 +01:00
ariel- 1106eadac6 Core/Conditions: CONDITION_SOURCE_TYPE_QUEST_ACCEPT should not prevent completed question mark from showing (#18151 follow up)
Closes #19188
2017-03-03 01:24:23 +01:00
ariel- 823f96953f Core/Players: fix 2 Seal of Righteousness spells on paladins
Closes #14239
2017-03-03 01:24:09 +01:00
ariel- 12d7e6c3b6 DB/Spell: add some proc entries to spells that should proc on cast
Closes #19124
2017-03-03 01:23:18 +01:00
ariel- c6443aa2ca DB/Spell: fix armor reduction (and spell hit debuff) stack rules
- All auras will now properly show but only the strongest one will be active

Refs #19187
2017-03-03 01:22:53 +01:00
ariel- 5ad94a5529 DB/Spell: correct Deathfrost level restriction 2017-03-03 01:22:16 +01:00
ariel- f5220ee4c2 DB/Spell: fix some enchants proc chances and reduced effects for levels > 60
- Deathfrost:  Slow effect should not work on targets 73 or higher.
- Icy Weapon: proc chance reduced, made to a %-per-hit, should only proc on white hits
- Unholy Weapon: proc chance increased to 3 PPM (based on comments data)
- Battlemaster: should only proc on white hits
- Crusader: effect reduced for players above 60

Closes #7789
2017-03-03 01:22:06 +01:00
ariel- 6cd253ff8f Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h 2017-03-03 01:19:28 +01:00
ariel- 5ff56097c0 DB/Loot: remove some incorrect drops of three quest reward items
- Items reward of the Hakkari Urn, it must always contain the 3 items (previous had a very little chance of being less than 3)
- Hakkari Urn is the reward from "Secret of the Circle (3447)"
2017-03-03 01:18:56 +01:00
ariel- 9aa3dd4881 Core/Scripts: fix dynamic build 2017-02-10 05:25:24 +01:00
ariel- 79e6325716 Core/SmartAI: Delay SMART_ACTION_FORCE_DESPAWN by at least one world tick
- Restore old despawn behavior of SmartAI despawning (without reintroducing the run time logs caused by IsSmart)
- Some SAIs relied on this to function (for example #1249)

Partial reverts commit 4fc4c81e89
2017-02-10 05:24:35 +01:00
ariel- 904bbf9f5a DB/Spell: fix interaction of mage armor spells with absorption effects
Closes #18680
2017-02-01 01:30:17 +01:00
ariel- 6ceb407273 Core/Scripts: fix penance procs with Unchained magic
Closes #19005
2017-02-01 01:29:50 +01:00
ariel- b5d32cd2b4 Core/Scripts: remove GMs from Sindragosa's Fury's targetlist
By Keader
Ref #18452
2017-02-01 01:27:13 +01:00
ariel- 2876fd015f DB/Spell: Recently Bandaged debuff shouldn't break stealth
Closes #18951
By Noryad
2017-02-01 01:18:48 +01:00
ariel- a2a3fd538f DB/Spell: added conditions for Argent Squire/Gruntling Pennant spells
- Should only target the pet, according to sniffs
2017-02-01 01:18:34 +01:00
ariel- 44426e76ea Core/SpellScript: Pass vector to ValidateSpellInfo by reference 2017-02-01 01:18:25 +01:00
ariel- f5822c589b Core/EscortAI: fix invalid iterator dereference 2017-02-01 01:18:17 +01:00
ariel- 2149957ecf DB/Spell: kill charge drop from Light's Grace
Cast time reduction should remain active

Closes #18927
By Eliminationzx
2017-02-01 01:09:49 +01:00
ariel- 191e277741 Core/Creature: revert turning state apply
partial revert of 6b55faba065cd5d0519fb6e3e070a4a41d305cca

Simply removing the unit state in Creature::ReleaseFocus causes #18549 again
2017-01-23 00:17:08 +01:00
ariel- 04df42ba78 Core/Creature: don't allow turning if spell would cancel due to turning to face target
Closes #18549
2017-01-23 00:16:58 +01:00
ariel- 247168b12f DB/Spell: Impact proc
Closes #18817
2017-01-23 00:16:38 +01:00
ariel- 4edbb2d633 Core/Collision: fix no-PCH build 2017-01-21 18:46:40 +01:00
ariel- 0c97c46361 Core/Spell: perform charmer check against player controlling unit. Fixes spellcasts while charmed 2017-01-18 14:19:11 +01:00
ariel- f2ffa22ac7 Core/Spell: fix typo
Closes #18248
2017-01-18 14:18:53 +01:00
ariel- fb44395dca Core/Script: PCH issues 2017-01-09 08:03:56 +01:00
ariel- e6b1b3d9f0 DB/Script: The Only Cure is More Green Glow
Closes #1723

SQL by Staleness89, corrections by Killyana
Script by Keader, corrections by sirikfoll and me
2017-01-09 08:03:40 +01:00
ariel- 17278b9b42 Core/Scripts: added command to move characters across accounts 2017-01-07 07:34:11 +01:00
ariel- 6586615d1f Core/Scripts: kill one ugly char buffer 2017-01-07 07:23:35 +01:00
ariel- 001e7f8212 Core/Player: Recast lost by death item obtain spells of any items held in the inventory when resurrecting
I HAS BUKKIT

Closes #5184
2017-01-01 13:35:15 +01:00
ariel- c5d9f07a2a Core/Vehicles: make vehicles immune to Cyclone
Closes #18489
2017-01-01 13:35:06 +01:00
ariel- e250236da3 DB/Spell: Glyph of Totem of Wrath proc
by Eliminationzx

Closes #18514
2017-01-01 13:34:26 +01:00