Commit Graph
11625 Commits
Author SHA1 Message Date
Ovahlord a13dc7013d Core/Vehicles: Fix accessories disappearing on reset (ported commit: 6dae4a747da558ca46a777186d4519c32fc1bf04) 2019-05-12 01:28:09 +02:00
Shauren 96faf78409 Core/Movement: Use correct root check 2019-05-12 01:26:20 +02:00
Shauren e610b8440c Core/Movement: Prevent rooted units from falling
* Fixes a client freeze

Closes #23042
2019-05-12 01:26:00 +02:00
Wyrserth e037332035 Core/Quest: improve source item deletion logic for items that give quests (#23250)
* Core/Quest: improve source item deletion logic for items that give quests.

Prevent deletion of items that aren't supposed to be destroyed (like Demon Scarred Cloak).

* Whoops.
2019-05-12 01:25:01 +02:00
Wyrserth 75edb60b79 Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. (#23252) 2019-05-12 01:24:13 +02:00
Wyrserth 3a28edf84b Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. (#23249) 2019-05-12 01:23:53 +02:00
jackpoz 836e52479b Core/Misc: Apply fatigue when flying too
Fix #22856
2019-05-12 01:21:36 +02:00
Ovahlord b001670d78 Core/Spells: fixed application order for spell mods when calculating damage and heal values 2019-05-11 01:42:12 +02:00
Ovahlord 6aa51873a3 Core/Units: removed a debug message from last commit 2019-05-10 23:54:57 +02:00
Ovahlord ab1d57d21d Core/Spells: fixed remaing issues with calculation correct numbers for HOTs and DOTs 2019-05-10 21:28:23 +02:00
Ovahlord 8d58dc87aa Scripts/BWD: initial work on Arcanotron's abilities 2019-05-10 20:38:43 +02:00
Ovahlord cf1a3d2d64 Core/Spells: corrected more spell bonus calculations 2019-05-10 06:57:23 +02:00
Ovahlord fa7df8b081 Core/Spells: fixed a logic error in calculating spell coefficient bonuses that was causing many spells doing less damage than intended 2019-05-10 06:09:34 +02:00
Ovahlord 05c6279052 Core/Spells: implement SPELL_AURA_PROC_TRIGGER_SPELL_COPY
* fixed proc for Dragonwrath, Tarecgosa's Rest
2019-05-10 05:38:07 +02:00
Ovahlord 5e56bf085d Scripts/BWD: scripted Electron and Magmatron abilities for Omnotron Defense System encounter 2019-05-09 02:43:01 +02:00
Ovahlord 96565412ee Core/Vehicles: correct start power amount for energy types for Omnotron Defense System encounter 2019-05-08 03:35:53 +02:00
Ovahlord 50ca9f7f9f Scripts/BWD: scripted heroic mechanics for Magmaw's encounter 2019-05-07 22:04:10 +02:00
Ovahlord c5241401ca Core/Players: fixed logic for good. I really need to go to bed. 2019-05-06 06:28:23 +02:00
Ovahlord 0804fa59eb Core/Players: fixed logic from last commit 2019-05-06 03:19:22 +02:00
Ovahlord 65b326ca08 Core/Players: since patch 4.0.3a any Justice Points above the hard cap will now convert to 47 silver and 50 copper per point 2019-05-06 03:06:33 +02:00
Ovahlord ab95871811 Core/Objects: replaced another IsFlying check with CanFly to make sure that hovering creatures will get their ground height returned properly
*also fixed a small typo in path generator
2019-05-06 02:30:24 +02:00
Ovahlord 1e3d9c5fff fixed build 2019-05-05 00:44:46 +02:00
Ovahlord 69907a6d6d * Core/Object: Range check vol. 2 (#23226) (ported commit: 78070163dc6b9bb34ab2d006e9cc218548e861b7)
* Core/Object: Fix all missing parts for #23062
2019-05-05 00:34:40 +02:00
jackpoz 950eff5fda Core/LFG: Remove dungeon cooldown when completing random dungeons 2019-05-05 00:26:13 +02:00
Ovahlord 57e78f3bc5 Core/Spells: fixed Atonement talent 2019-05-05 00:11:37 +02:00
Ovahlord 4a3ef30d91 Core/Spells:
* fixed Revealing Strike damage bonus
* convert Envenom to spellscript
2019-05-04 23:14:48 +02:00
Ovahlord 1ed5a11b79 Core/Spells:
* updated Concussion Blow spellscript and use proper calculation for damage values
* fixed Eviscerate and Ferocious Bite damage bonus calculation
* converted Warrior's Shockwave and Victory Rush damage bonus to spellscript and calculate values properly
* fixed Death and Decay threat generation amount
2019-05-02 03:26:31 +02:00
Ovahlord 9c1b87c32f Core/Spells: removed attack power bonus from hunter pet's Growl ability 2019-05-01 22:41:14 +02:00
Shauren 28da58ea8b Core/Misc: Fixed -Wcast-function-type warning 2019-04-29 08:45:26 +02:00
jackpoz 4da12422eb Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ChaseMovementGenerator in 386b5a6fd948b4866cbd9a8a9892e8777922e9c9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned.
The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.

# Conflicts:
#	src/server/game/Movement/MovementGenerators/ChaseMovementGenerator.cpp
2019-04-29 08:44:37 +02:00
Ovahlord eefa94a5fe Core/Creatures: refactored sparring handling and added all data for 85% health sparring 2019-04-28 23:18:48 +02:00
Ovahlord cd55e1742b fixed build² 2019-04-27 21:17:02 +02:00
jackpoz a730e17a37 Core/Commands: Fix .cheat god command letting you die
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
2019-04-27 21:09:46 +02:00
jackpoz 0020ea9f92 Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon()
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).
2019-04-27 21:08:52 +02:00
Ovahlord 1681889fdd Fixed build 2019-04-27 21:05:48 +02:00
Ovahlord 5258dc74d1 Core/Spells: do not allow root auras to bypass the root movement data for creatures when getting removed 2019-04-27 20:10:03 +02:00
Ovahlord 1c7a520095 Revert "Core/SmartAI: Remove duplicate OnReset() call"
This reverts commit 73345b0d7f.
2019-04-27 17:38:06 +02:00
Ovahlord 3d08987773 Core/Creatures: reduced a difference between 434 and 335 2019-04-27 17:36:41 +02:00
Killyana 22e34861bd Core: Restore reset in EscortAI::InitializeAI (#23197)
Closes  #23008
2019-04-26 18:59:11 +02:00
Ovahlord d9c809d828 Core/SAI: more cherrypick followups 2019-04-26 18:58:58 +02:00
Treeston 1f15fe5096 oops, now it builds (and a bonus refactor that annoyed me)
# Conflicts:
#	src/server/game/AI/SmartScripts/SmartAI.cpp
#	src/server/game/AI/SmartScripts/SmartAI.h
#	src/server/game/AI/SmartScripts/SmartScript.cpp
#	src/server/game/AI/SmartScripts/SmartScript.h
2019-04-26 18:56:31 +02:00
Ovahlord 28b33663e7 Core/SAI: cherry pick followup 2019-04-26 18:52:38 +02:00
Treeston 99a2c24116 Scripts/SmartAI: Forward invoker to invoked action list actions. Also JustAppeared -> InitializeAI.
# Conflicts:
#	src/server/game/AI/SmartScripts/SmartScript.h
2019-04-26 18:51:19 +02:00
Treeston 7c025ee803 Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent.
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.

Tagging #20310.

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedEscortAI.h
2019-04-26 18:49:47 +02:00
sirikfoll 73345b0d7f Core/SmartAI: Remove duplicate OnReset() call
It is already called for every creature in SmartAI::InitializeAI(), removing the one from SmartAI::JustAppeared to keep as much as possible of the old behavior, because JustAppeared is called on the next tick after InitializeAI

Closes #20881
Closes #20771
2019-04-26 18:46:55 +02:00
Ovahlord e5d59d5f98 Core/Object: Range check (#23179) (ported commit: 32e1de39a26628dcb64bc21ad415afb2ad938925) 2019-04-26 18:41:31 +02:00
jackpoz 738aa92782 Core/Spells: Adjust range checks to GameObject targets 2019-04-26 18:01:19 +02:00
jackpoz 85bf4daf45 Core/Spells: Adjust range checks to GameObject targets 2019-04-26 18:01:12 +02:00
jackpoz d99de4db33 Core/Spells: Add range checks to GameObject targets
Close #23062
Patch by robinsch
2019-04-26 18:01:05 +02:00
jackpoz 5ef08fa5e8 Core/GameObject: Code cleanup
(cherry picked from commit 16a154c4e87ff1ff89323a8960bf601e6c18589b)
2019-04-26 17:53:43 +02:00