Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
32,061 Commits 2 Branches 1 Tag
3df0ed0d8963e1cea75ef8a3d98dab9cb97b4ed9
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jackpoz a693169a7e Dep/Jemalloc: Enable MADV_FREE if available 2017-11-30 08:44:33 +01:00
jackpoz 05b568813f Dep/Jemalloc: Temporarily disable MADV_FREE 
Temporarily disable MADV_FREE until CMake file is modified to check if MADV_FREE is available on the current system.
This fixes the build on older systems.
 2017-11-30 08:44:16 +01:00
jackpoz 52a53ea2ab Core/Maps: Fix memory leak in BoundaryUnionBoundary 
Add missing destructor in BoundaryUnionBoundary to avoid reporting a memory leak (even if it's used only in a global variable)
 2017-11-26 12:31:36 +01:00
jackpoz 55637dc00d Core/Quests: Fix memory leak in Quest Greeting 2017-11-26 11:53:49 +01:00
jackpoz 41469a4161 Dep/Jemalloc: Update to Jemalloc 5.0.1 2017-11-25 14:03:02 +01:00
jackpoz 5dee28845c Dep/Jemalloc: Update to Jemalloc 4.0.4 2017-11-19 19:24:08 +01:00
jackpoz 259e534cca Tools/MMaps: Improve MMaps quality 
Lower Detail Sample Distance and Detail Sample Max Error to get more accurate MMap data, in particular mmap height.
More info about Detail Mesh at http://digestingduck.blogspot.it/2009_07_01_archive.html and http://digestingduck.blogspot.it/2009_08_01_archive.html
 2017-11-19 18:03:35 +01:00
jackpoz c62b81dd8b Dep/Recast: Update recastnavigation to recastnavigation/recastnavigation@2c85309 2017-11-19 18:03:17 +01:00
jackpoz 67dc6a7576 Core/Misc: Fix static analysis issues 2017-11-12 13:24:42 +01:00
jackpoz 790c2b6e80 Dep/G3D: Add static assert checks for Array functions being used with non-POD types 2017-11-12 13:20:51 +01:00
jackpoz 3410edfdae Core/Misc: Fix static analysis issues 2017-07-17 18:51:56 +02:00
jackpoz 2102bd28a3 Core/Scripts: Simplify code 
Partially revert 753e7074d84b5a2e8d3c3e92d25c54bb25ba477e and 12c680f9b1f1068099c3b19443d93d456690ac56 to simplify the code and to only remove GMs from the target list.
 2017-06-09 13:25:59 +02:00
jackpoz 1664c1bd2e Core/Misc: Fix static analysis issues 2017-04-26 05:09:44 +02:00
jackpoz d01f1d31bd Core/Misc: Fix static analysis issues 2017-04-26 05:09:21 +02:00
jackpoz 53939cd14e Core/Misc: Fix static analysis issues 2017-04-09 18:17:51 +02:00
jackpoz d64db19d82 Core/Crash: Refactor and fixes 
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.
 2017-03-20 16:53:22 +01:00
jackpoz e36790b312 Core/Misc: Fix static analysis issues 2017-03-03 01:26:40 +01:00
jackpoz 175339c9d2 Dep/G3D: Backport warning fix from G3D10 2016-10-24 11:08:18 +02:00
jackpoz 2dfa3298c8 Scripts/Azjol-Nerub: fix static analysis issues 2016-10-22 10:50:37 +02:00
jackpoz 71d4d34d33 Scripts/ICC: Fix chest loot exploit 
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.
 2016-09-25 10:10:57 +02:00
jackpoz 58e4568c36 Core/Commands: Code cleanup 
Remove commented out code
 2016-08-21 13:14:27 +02:00
jackpoz 8fcb5ace9d Core/Battleground: Fix crash happening when reporting afk a nonexistent player 2016-08-20 14:43:15 +02:00
jackpoz bb2db482da Revert "Core/Battlegrounds: Properly readd player to Battleground containers after a login." 
This reverts commit fbc521084cdd57d8e33071961aa3100e0fab2596.
Fixes #17810
 2016-08-20 06:15:27 +02:00
jackpoz 90b22c6cd4 Core/MMAPs: Update recast 
Update recast to recastnavigation/recastnavigation@64385e9
 2016-08-18 09:46:18 +02:00
jackpoz e6c7894be1 Tools/MMapGenerator: Avoid saving uninitialized padding bytes to disk 
Initialize padding bytes in MmapTileHeader struct to avoid saving uninitialized data to disk, causing issues when binary-comparing *.mmtile files.
 2016-08-18 09:35:04 +02:00
jackpoz 1d6adef396 Common/Common: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-12 11:58:55 +02:00
jackpoz 0f965a530e Common/Threading: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-04 23:48:39 +02:00
jackpoz 44165712ca Common/Logging: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-04 21:56:30 +02:00
jackpoz e8bc203651 Common/Debugging: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-04 20:57:38 +02:00
jackpoz 5dcb395e90 Common/Crypto: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-03 23:35:34 +02:00
jackpoz 3c66feafcc Common/Maps: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-03 22:39:59 +02:00
jackpoz 8cd5cefaf6 Common/Maps: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-03 19:48:38 +02:00
jackpoz 242917e461 Core/Group: Do not allow a player to invite himself 
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix #17664
 2016-08-03 11:56:29 +02:00
jackpoz 648b8859d5 Core/Crash reporting: Better handle max nesting level setting 
Fix wheaty exception report counting reference symbols as 2 nesting levels, not logging child objects in some cases, i.e. spell id in SpellEvent crash.
 2016-07-20 18:30:50 +02:00
jackpoz d255975122 Core/Creature: Fix assertion triggered 
Fix assertion triggered when a Creature was summoned at an invalid position with Auras loaded as Creature addons.
Fix #17415
 2016-07-20 18:13:32 +02:00
jackpoz 4aa993607a Core/Player: Fix duel edge case crash 
Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.
 2016-07-20 15:50:04 +02:00
jackpoz d9f485273c Core/VMaps: Fix some vmap height edge cases 
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.
 2016-07-20 15:45:05 +02:00
jackpoz 5fa4faac38 Core/Creatures: Fix dead creatures spawn position on restart 
Fix dead flying creatures ignoring being spawned below the floor in instances on server restart because of not taking into account vmap height.
Fix #16777
 2016-05-12 00:19:58 +02:00
jackpoz 510bb30b2c Scripts/Misc: Fix issues reported by static analysis 2016-03-06 16:11:55 +01:00
jackpoz 31cd082833 Scripts/Ulduar: Fix crash 
Change an assert to a NULL check on Flame Leviathan vehicle kit, it can be NULL on map unload.
Close #16662
 2016-02-27 12:02:32 +01:00
jackpoz d75469e31f Scripts/Deadmines: Fix issues reported by static analysis 
Fix Coverity issue id 1022474
 2016-01-30 00:13:22 +01:00
jackpoz 0e76d67e49 Scripts/Misc: Fix issues reported by static analysis 2016-01-23 17:42:37 +01:00
jackpoz 1a5b0067a3 Core/Commands: Fix NULL dereference crash 
Closes #15833

(cherry picked from commit abd4e2e0f1)

Conflicts:
	src/server/game/Chat/Chat.cpp
 2016-01-11 01:51:49 -03:00
jackpoz 5ebfe5a297 Scripts/EyeOfEternity: Fix crash 
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900

(cherry picked from commit 6e296ddaa2)
 2016-01-11 01:51:46 -03:00
jackpoz 308d30417c Core/Player: Fix crash related to vehicles 
Fix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix #15953

(cherry picked from commit 2cb54d5606)
 2016-01-11 01:51:42 -03:00
jackpoz 9fe26765b4 Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login 
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.

(cherry picked from commit 5f917e2286)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
 2016-01-11 01:51:28 -03:00
jackpoz e59b4324b8 Merge pull request #15977 from tkrokli/landmine_knockback_achievement 
Scripts/Spells: Mine Sweeper achievement
 2016-01-09 23:19:09 +01:00
jackpoz 4191bb868a Scripts/ICC: Fix static analysis issue 
Fix an issue reported by static analysis
 2016-01-09 21:53:53 +01:00
jackpoz e138e094a9 Scripts/Commands: Modify ".setskill" command to target current Player by default 2016-01-09 18:37:17 +01:00
jackpoz b39216eed3 Merge pull request #16186 from ariel-/spellmodcharges 
Core/Spells: Fix redundant mod charge drop and spell crit calc
 2016-01-09 16:51:39 +01:00
jackpoz b1d0855624 Core/Spells: Fix static analysis issues and a crash 
Fix confusing NULL checks in Raise Ally check cast.
Fix a crash in Raise Ally triggered by executing ".cast back 61999" command targeting a pet in raid while being dead.
 2016-01-08 23:13:15 +01:00
jackpoz 2a50ea5cf1 Merge pull request #16193 from Goatform/3.3.5 
Core/GameObjects: Fixed an issue where traps were not redirected to Grounding Totem
 2016-01-07 19:27:40 +01:00
jackpoz 1c89b4dcdf Merge pull request #16188 from Asterc/3.3.5 
Core/Player: Fix profession specialization being re-learnt on login after unlearning it
 2016-01-05 22:10:20 +01:00
jackpoz 841ce54a0d Scripts/Commands: Fix ".help" command to show commands in alphabetical order 2016-01-04 23:30:46 +01:00
jackpoz f22b1938db Scripts/Commands: Modify ".learn" command to target current Player by default 2016-01-04 22:44:19 +01:00
jackpoz e6903fdffa Merge pull request #15852 from Golrag/icc_boss_aggro 2015-12-15 21:29:10 +01:00
jackpoz bf5419e28e Merge pull request #16006 from rockz1152/3.3.5 
Core/Player: Fix Weapon Skillup on low level mobs

Remove check for skill up on grey level mobs
 2015-12-15 21:07:05 +01:00
jackpoz b96704774b Merge pull request #15919 from Treeston/3.3.5-razuvious 2015-12-14 20:34:12 +01:00
jackpoz 263f127d07 Merge pull request #14896 from Ofinka/dupl 2015-12-12 17:43:35 +01:00
jackpoz 80ed03a84d Merge pull request #15402 from chaodhib/taunt_player 2015-12-09 22:08:43 +01:00
jackpoz 187e45d24b Merge pull request #15910 from Treeston/3.3.5-maexxna 2015-12-08 12:40:04 +01:00
jackpoz 2cb54d5606 Core/Player: Fix crash related to vehicles 
Fix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix #15953
 2015-12-07 23:34:00 +01:00
jackpoz 5b8b32dac7 Core/Quest: Fix issues reported by static analysis 2015-12-07 20:55:33 +01:00
jackpoz 3267c90102 Core/Unit: Add Unit::KillSelf() overload 
Add Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.
 2015-12-07 20:06:02 +01:00
jackpoz ee12982008 Merge pull request #15933 from Asterc/3.3.5 
Core/Spells: Fix Misdirection exploit
 2015-12-07 19:11:48 +01:00
jackpoz 1ddf44caf3 Core/Quest: Fix issues reported by static analysis 2015-12-07 18:31:53 +01:00
jackpoz bffaa92633 Core/Quest: Fix issues reported by static analysis 2015-12-06 22:43:15 +01:00
jackpoz f1f4005ad8 Core/Quest: Fix issues reported by static analysis 2015-12-06 21:37:58 +01:00
jackpoz 39a77effd7 Merge pull request #15947 from ShinDarth/duel-exploit 
Core/Spell: Fix exploit in duel cooldown reset handling
 2015-12-06 19:47:13 +01:00
jackpoz c703e01471 Merge pull request #15920 from Treeston/3.3.5-MCHotkeyPos 
Unit/PossessBar: Fix spell ordering on possess bar
 2015-11-30 20:24:15 +01:00
jackpoz c1b4cd21f3 Merge pull request #15912 from Treeston/3.3.5-urandms 
Core/Util: Add urandms(minMS, maxMS) helper
 2015-11-29 00:07:35 +01:00
jackpoz f8a3fa28bb Merge pull request #15907 from ShinDarth/fix 
Core/Spells: Fix Arcane Missiles
 2015-11-28 21:55:45 +01:00
jackpoz a67f378f10 Merge pull request #15904 from 'ForesterDev/instance_login_cleanup' 2015-11-28 21:45:41 +01:00
jackpoz 9020790db2 Merge pull request #15903 from tkrokli/remove_script_npc_anchorite_truuen 
Core/Scripts: Remove deprecated script npc_anchorite_truuen

Remove deprecated script npc_anchorite_truuen replaced by SAI in 2cecc7b1f7
 2015-11-27 15:25:03 +01:00
jackpoz 5f917e2286 Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login 
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.
 2015-11-26 21:54:22 +01:00
jackpoz 6e296ddaa2 Scripts/EyeOfEternity: Fix crash 
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900
 2015-11-26 21:47:50 +01:00
jackpoz 981b871d2f Tools/MMapGenerator: Fix an edge case of infinite loop 
Fix a (pseudo) infinite loop happening when generating mmaps for single tile maps (like 249) but with vmaps not present in the correct folder. This would trigger a 18446744065119600000 (uint32 max ^ 2) iterations loop.
 2015-11-25 21:49:27 +01:00
jackpoz 1511855fea Merge PR #14824 'tkrokli/spell_mod_stealth_stand_state' into 3.3.5 2015-11-22 15:37:32 +01:00
jackpoz 0e9f714a09 Core/Items: Fix crash 
Fix crash happening if item_template.StatsCount field in the database was higher than 10.
Fixes #15868
 2015-11-19 20:23:09 +01:00
jackpoz fbaed38b5e Core/Quest: Fix issues reported by static analysis 
Coverity defect IDs: 1339309, 1339310
 2015-11-15 16:17:12 +01:00
jackpoz 63f2675076 Core/Player: Fix issue reported by static analysis 
Coverity defect IDs: 1010154
 2015-11-15 16:01:14 +01:00
jackpoz abd4e2e0f1 Core/Commands: Fix NULL dereference crash 
Closes #15833
 2015-11-10 21:14:18 +01:00
jackpoz ea9c112b30 Merge pull request #15804 from Tonghost/3.3.5 
Core/Misc: Remove unneeded files
 2015-11-03 22:52:35 +01:00
jackpoz da0671f4fe Scripts/Naxxramax: Fix clang warning 2015-11-01 18:40:35 +01:00
jackpoz aee4c29670 Merge pull request #15533 from Tomatodev/3.3.5 
Core/AuctionHouse: fix config value RATE_AUCTION_DEPOSIT < 1 ignored by deposit formula
 2015-10-04 14:20:00 +02:00
jackpoz fcc6ef6b18 Core/DBLayer: Build fix in addition to 25c0303976 2015-09-27 17:19:49 +02:00
jackpoz 3f24853e29 Merge pull request #15473 from Treeston/3.3.5-fixplayerdamagereq 
Core/Unit: Player-summoned creature damage counts towards quest credit
 2015-09-25 22:51:42 +02:00
jackpoz 4cdab0cdcb Scripts/Ulduar: Fix issue reported by static analysis 
Coverity defect ID: 1316690
 2015-09-12 16:44:34 +02:00
jackpoz 4013500d24 Core/Quests: Fix issue reported by static analysis 
Coverity defect ID: 1323839
 2015-09-12 16:24:09 +02:00
jackpoz 166e66cc06 Core/Spells: Fix crash happening when using items to cast spells 
Fix a crash happening when using items casting spells like Item ID 37198
Fix #14900
 2015-09-05 22:45:15 +02:00
jackpoz 42a71133fa Core/Dungeon Finder: Fix groups queuing broken by 1e71aba2ee 
Fix queuing in LFG with 5-men groups leaving the party in queue forever, caused by group GUID being added to list of party members.
 2015-09-05 21:18:52 +02:00
jackpoz 16e9882aa8 Core/Dungeon Finder: Improve ".lfg queue debug" command 
Log roles of every combinations in ".lfg queue debug" output
 2015-09-05 17:08:37 +02:00
jackpoz 7c91984a64 Core/Chat: Allow to sanitize | characters when sending messages to clients 
Add an optional parameter "escapeCharacters" to ChatHandler::SendSysMessage() to properly escape | character, otherwise it might freeze the client.
 2015-09-05 13:54:44 +02:00
jackpoz b7f9836d22 Core/Dungeon Finder: Remove disconnected players from LFG queue 
Fix LFG queue issues by removing disconnected players from LFG queue and their party with them.
 2015-09-01 22:33:55 +02:00
jackpoz 1e71aba2ee Core/Dungeon Finder: Add LFG roles of group members in LFG logs 
This changes logs like "(1|18)" to "(1 Healer, Dps|18 Tank, Healer, Dps)"
 2015-08-31 22:45:45 +02:00
jackpoz 4940072102 Core/Spells: Skip spell category additional cooldown check added in 43e8c841f5 for SPELL_CATEGORY_FOOD. 
Workaround for #15278 till spell cooldown system properly supports spells with spell category triggering spells with same spell category.
Fixes #15278.
 2015-08-27 20:41:57 +02:00
jackpoz c67118f909 Core/Battleground: Fix issue reported by static analysis 
Coverity defect IDs: 1193415
 2015-08-26 22:59:03 +02:00
jackpoz 562e82928f Core/Battleground: Fix "Call to Arms: Isle of Conquest!" not giving Holiday Weekend honor 2015-08-26 22:55:21 +02:00
jackpoz 95bae7143f Scripts/VioletHold: Fix issue reported by static analysis 
Coverity defect IDs: 1318019
 2015-08-24 22:37:59 +02:00
jackpoz f50df72820 Scripts/VioletHold: Fix crash in Xevozz boss fight 
Fix crash happening during Xevozz boss fight caused by passing a local list by reference to a lambda expression
Closes #15345
 2015-08-24 14:52:18 +02:00