Commit Graph
4070 Commits
Author SHA1 Message Date
ariel- 4e61ff8c9c Core/Unit: consistency fix 2016-11-02 03:12:25 +01:00
ariel- 469870a141 Core/Player: cleanup single target auras on spec switch
Closes #806
2016-11-02 03:12:09 +01:00
ariel- 7a0647ec46 Core/Unit: fix warning reported by VS2015
C4146: unary minus operator applied to unsigned type, result still unsigned
2016-11-02 03:01:30 +01:00
Aokromes 6e191748ab Core/Conditions: merge CONDITION_SOURCE_TYPE_QUEST_SHOW_MARK with CONDITION_SOURCE_TYPE_QUEST_ACCEPT 2016-11-02 03:01:05 +01:00
ariel- c0ef2ba55c Core/Unit: fix logic error in DamageInfo::ModifyDamage.
Previous code did not protect against m_damage underflow, rather only allow up to duplicate damage.
It now should work as intended.

Closes #18154
2016-11-02 02:56:40 +01:00
Aokromes f88d3935fc Core/Unit: fix chain cc's not being diminished properly 2016-11-02 02:45:27 +01:00
Aokromes 4ad4326c53 another compile try fix 2016-10-24 16:53:19 +02:00
Aokromes 4b541233da More compile fix try 2016-10-24 16:49:33 +02:00
Aokromes eaa2533ded another compile fix try 2016-10-24 16:44:16 +02:00
Aokromes cb052ff0f3 another compile fix try 2016-10-24 16:29:25 +02:00
Aokromes 1792e6f138 Core/Misc: Partial compile fix 2016-10-24 15:12:50 +02:00
Aokromes 7763d40846 Core/Unit: prematurely abort GetFactionTemplateEntry instead of retur…
…ning a null pointer

Factions should never be invalid for players/spawned creatures anyways
2016-10-24 14:06:59 +02:00
Gustavo a7ea5be3f0 Core/GameObject Also spawn trap for GAMEOBJECT_TYPE_BUTTON (#18083) 2016-10-24 14:03:34 +02:00
SnapperRy 4f313746e0 Core/Quest: show DIALOG_STATUS_AVAILABLE instead of DIALOG_STATUS_REWARD for non-repeatable autocomplete quests. 2016-10-24 13:55:18 +02:00
SnapperRy 51c6209922 Core/Quest: send correct packet when a quest cannot be rewarded for item-related errors. 2016-10-24 13:55:04 +02:00
treeston 5d0a5951a1 Entities/Creature: Fix an edge case issue where creatures would re-acquire target after respawn if they despawned while spell focusing.
Instance/AzjolNerub: Fix Anub'arak wall and add sequence break info. Fixes and closes #18013.
2016-10-24 13:54:20 +02:00
SnapperRy d77b366703 Core/Quest: do not set a quest to failed if it's rewarded or has no status at all (not taken). 2016-10-24 13:47:32 +02:00
treeston 0ba8f4c955 Core/Creature: Fix respawn logic to call reset react state BEFORE calling Reset(). Fixes Krik'thir behavior after a wipe (and maybe some others).
Fixes and closes #18011.
2016-10-24 13:44:08 +02:00
ariel- b4ceb798e0 Core/AI: initial support for monster sparring (#17673) 2016-10-24 13:30:22 +02:00
Keader 1e60c73ad9 Core/Unit: Remove incorrect check that dont allow units attack your vehicle/passenger (#17932) 2016-10-24 13:27:40 +02:00
SnapperRy adb3889885 Core/Item: fix wrong error message triggered when trying to equip two items with the same ItemLimitCategory. 2016-10-24 13:12:58 +02:00
Aokromes 3a4b951299 Core/Entities: extend available containers for WorldObject::GetxxxInGrid 2016-10-24 13:10:01 +02:00
Aokromes 2057e6de4a Core/Items: Defined all item flags
(cherry picked from commit ef29f32)
2016-10-24 13:01:00 +02:00
ariel- 3944dc25b9 Core/Creature: Call SetSpawnHealth after JustReachedHome in HomeMovementGenerator
Fixes issues with quests that rely on this behaviour (eg Free your Mind)

Also updated SetSpawnHealth so it doesn't do anything in case spawn is manual (SetHealth(GetHealth()) does modify things depending on deathstate)
2016-10-24 11:10:41 +02:00
SnapperRy a6eb8d9b11 Core/Wintergrasp: cleanup and codestyle. 2016-10-22 10:53:40 +02:00
Aokromes 7315052d34 Core/Channel: revamp channel system (#17980)
* Core/Channel: change the way channels are stored and sent to client.

- Fixes multiple channels per zone when using different locales
- Connected clients will receive locally the name of the channel for their apropiate locale (if available)
- In other cases default locale name will be sent, so as to prevent breaking channel chat for those players
2016-10-22 10:21:18 +02:00
Kittnz f5364cc5aa Core/Event: Add Brewfest Music during the event
Note: Dark Iron invasion music can be added with a trigger at a later stage
2016-10-21 08:46:21 +02:00
Aokromes 114db3b9a4 Revert "Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures"
This reverts commit a3e5afc027.
2016-10-21 07:27:15 +02:00
Aokromes 57d0a5d16d Revert "Core/Spells: Implementation of QAston proc system"
This reverts commit a70e4e26b3.
2016-10-21 07:27:04 +02:00
Aokromes f9ebb50a8a Revert "Typo fix"
This reverts commit 32277391cc.
2016-10-21 07:26:42 +02:00
Aokromes 06fff9a83f Revert "Core/Unit: Remove unused code as for 4.3.4"
This reverts commit 42e74822b8.
2016-10-21 07:26:23 +02:00
Aokromes 16813bdb8c Revert "Missing changes"
This reverts commit 456065bad1.
2016-10-21 07:26:01 +02:00
Aokromes 456065bad1 Missing changes 2016-10-11 08:32:41 +02:00
Aokromes 42e74822b8 Core/Unit: Remove unused code as for 4.3.4
By Girip_Dragos
2016-10-09 15:46:41 +02:00
Aokromes 32277391cc Typo fix 2016-10-05 17:16:30 +02:00
Aokromes a70e4e26b3 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-05 13:19:51 +02:00
Shauren a3e5afc027 Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures 2016-10-05 08:01:38 +02:00
Shauren f5a980be9b Core/Units: Clear UNIT_NPC_EMOTESTATE on death (blizzlike)
Closes #15263
Closes #18027
2016-10-04 18:07:59 +02:00
SnapperRy 1a29f04e00 Core/Unit: don't reset offhand timer for players when starting attack.
Creatures are unaffected by this change. Not sure how they should behave in this case, so leaving it alone for now.

Closes #945.
2016-10-04 06:36:39 +02:00
SnapperRy 828026bede Core/Quest: send INVALIDREASON_QUEST_ALREADY_DONE if player tries to accept a quest that is already rewarded. 2016-10-04 06:35:17 +02:00
ariel- 6ee820afe4 Core/Player: correct logic for IsUsingTwoHandedWeaponInOneHand
Fixes penalty not being applied when we are using a 2H in offhand, and a unarmed MH.
MH may do unarmed attacks in this case. (reciprocal of 2H MH, unarmed OH, only uses MH normally, OH doesn't unarmed attack)
2016-10-03 14:57:51 +02:00
Aokromes 576cfa8328 Core/Player: unconditionally remove Titan's grip penalty aura on Spel…
…l removal

Was causing an issue when switching spec, because off hand weapon was still equipped
2016-10-03 14:53:39 +02:00
Aokromes d9ae70396b Core/Player: Implemented Titan's Grip damage reduction 2016-10-03 14:51:20 +02:00
joschiwald 4ed2cd9500 Core/Spells: use spellinfo helper methods
(cherry picked from commit 12a52595edf9ca284d9253a96396ef3321c4c094)
2016-10-03 14:42:37 +02:00
joschiwald de1322f134 Core/Player: fixed math error
(cherry picked from commit cc1e2fd452e83281a6fe4c60ed1ee277a0e7a16d)
2016-10-03 14:42:19 +02:00
SnapperRy 83dafd5886 Core/Spell: set quest to rewarded instead of complete when targeted by SPELL_EFFECT_QUEST_COMPLETE. (#18021)
Prevents people from ending up with strange quests in their quest logs.
2016-10-01 16:47:49 +02:00
jackpoz 71d4d34d33 Scripts/ICC: Fix chest loot exploit
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.
2016-09-25 10:10:57 +02:00
SnapperRy 7dff45e2af Core/Gossip: improve gossips related to Dual Talent Specialization 2016-09-24 07:01:49 +02:00
SnapperRy 7155428435 Core/Creature: update health/mana/damage/armor when changing a creature's entry while keeping the original level.
Fixes an issue introduced in a6ef9d4.
2016-09-24 07:00:27 +02:00
treeston 8a402b9f6b Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true 2016-09-20 20:28:45 +02:00