Commit Graph
17060 Commits
Author SHA1 Message Date
Aokromes f8d9d954d1 Get zone/area IDs from vmap data in the liquid update
* Add new method Map::getFullVMapDataForPosition to get area info and liquid info in a single vmap lookup
* Use this lookup in Map:: relocation methods to update m_areaId and m_zoneId fields on WorldObject
* Adjust GetZoneId/GetAreaId on WorldObject to always return these cached fields
* Clean up liquid state handling on Unit and Player
* Hand floor's Z coord up through GetFullTerrainStatusForPosition, use it to update a new field in WorldObject, and use that to feed a new GetFloorZ call on WorldObject.
2017-06-09 13:20:37 +02:00
Aokromes ac3dbcb880 Core/Utilities: Rename RandomResizeList->RandomResize as it is no longer restricted to a list 2017-06-07 09:53:04 +02:00
Aokromes 0bb27ecd4b Pet/Guardian AI hook re-organizing (#19824)
* Pet/Guardian AI hook re-organizing:
- Adjust OwnerAttacked/OwnerAttackedBy hooks on CreatureAI to fire for all owned units, not just player pets. This should allow guardians to more reliably recognize valid targets.
- Kill off the AttackedBy hook. While it was defined in CreatureAI.h as virtual, it was only ever invoked for player pets in specific situations. This makes it classic developer bait.
  - Adjust PetAI to use DamageTaken instead of AttackedBy.
  - Adjust behavior of AttackStart on PetAI to compensate.
2017-06-07 02:50:14 +02:00
treeston 2b721ca16c SAI fixes follow-up: I missed one. 2017-06-06 22:22:01 +02:00
treeston 3cc2419c2f Fix a whole set of possible infinite loop crashes in SAI (events triggering themselves even with cooldown set). 2017-06-06 22:14:22 +02:00
treeston 24c89fba76 Re-check target evade state on projectile impact and adjust accordingly. This fixes the incorrect message ("Absorb" instead of "Evade"), and also removes the root cause of the original evade follow bug (that was prevented in 1945874). 2017-06-06 19:32:18 +02:00
Aokromes 71fe37a55b build fix 2017-06-06 11:29:00 +02:00
Shauren 900a2da03d Core/Instances: Fixed and optimized instance id reuse 2017-06-06 08:00:10 +02:00
Keader bc1887c5df Core/Spells: Allows Dispersion under Freeze (stun by hunter trap) 2017-06-06 07:55:49 +02:00
TecDian 25ba21f85e Core/Scripts: simplify speech for DK races quests 2017-06-06 07:55:36 +02:00
Keader 1051412e50 Core/Spells: Allows Dispersion and Barkskin to be used under death coil 2017-06-06 07:53:19 +02:00
treeston a6b393c2af clang is dumb 2017-06-06 07:49:31 +02:00
treeston 68c500f020 Some improvements to .debug raidreset command. Now supports heroic difficulty 5-man dungeons and outputs sensible text, as opposed to silently doing (or not doing) stuff. 2017-06-06 07:49:02 +02:00
Aokromes 80c0d0ce8a Merge branch 'broadcast_text_fix' into '4.3.4'
Use sound id from BroadcastText template if one is specified in creature_text

See merge request !46
2017-06-04 22:32:33 +00:00
Krudor 206af48400 Use BroadcastText sound id if one was found 2017-06-04 20:50:07 +02:00
Aokromes a68dd40235 tabs 2017-06-02 17:28:38 +02:00
Aokromes 214b5a65e3 DB/Misc: Misc fixes for Dun Morogh
By Malcrom
2017-06-02 16:07:06 +02:00
ariel- 2e3197f944 Core/Globals: add more AIName and MovementType checks to ObjectMgr
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)

Closes #19831
2017-06-02 10:23:44 +02:00
Keader 58747b0037 Core/Scripts: Fixed some events that not should triggered by non-players on Illidan encounter 2017-06-02 10:23:28 +02:00
Shauren 0a61a3ffb5 Core/Groups: Fixed calculating canReset attribute
Broken in d6df19cd99.
2017-06-02 00:23:00 +02:00
Shauren 080fd33e13 Revert "Core/Groups: fix wrong query for loading group instance data. canReset attribute was calculated in the wrong way"
This reverts commit 0c1dd398bd.

Closes #19745
2017-06-02 00:22:46 +02:00
Aokromes 123c10a395 Scripts/Stockades - Add scripts to instance
By Artamedes
2017-06-01 23:55:52 +02:00
Keader 4292ac7039 Core/Spells: Removed duplicated check again followup 3a0417f7128292995a4085a0114ed59fbfa64325
to send some info to client
2017-06-01 14:05:32 +02:00
Keader 52551be039 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt
2017-06-01 14:05:14 +02:00
Aokromes 1c6021ba96 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code
2017-06-01 13:22:24 +02:00
treeston aef568cdd1 Fix an issue where CanSpawn would never get invoked on creatures without per-guid script. 2017-05-31 16:10:04 +02:00
treeston a83b77485a Add another helper to ScriptedGossip.h for resolving listId -> action. 2017-05-31 16:09:56 +02:00
Aokromes 2d94972577 missing part 2017-05-30 10:20:27 +02:00
sirikfoll 519af6e6e6 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823
2017-05-30 09:57:03 +02:00
Aokromes dff1518ac2 Scripts/Command: implement .debug play music command 2017-05-30 09:55:45 +02:00
Treeston 16e60ba408 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)
2017-05-30 09:21:38 +02:00
ariel- e778c4c628 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit 2017-05-30 09:21:03 +02:00
Treeston e80602f048 Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.
2017-05-30 09:20:49 +02:00
Aokromes 6021c8d29c typo fix on previous commit 2017-05-29 19:20:32 +02:00
Ryan 25eabf2471 Core/Bnet: Fix battlenet login 2017-05-28 20:42:10 +01:00
Ryan 79661eeb39 Fix build 2017-05-28 20:19:48 +01:00
Ryan e054036742 Fix SMSG_POWER_UPDATE 2017-05-28 20:19:33 +01:00
Ryan a289acff81 Core/Spells: Fix SPELL_AURA_FIXATE 2017-05-28 20:14:31 +01:00
Ryan cc9c363b00 Core/Instance: Reset FAIL to NOT_STARTED on load 2017-05-28 20:13:42 +01:00
Ryan b1de58c7f8 Core/Phases: Fix area phase handling
Now honors the zone id as well as area id
2017-05-28 20:01:36 +01:00
Ryan f29874d7ad Core/Player: Add missing return 2017-05-28 19:58:44 +01:00
Ryan be1ca945c7 Core/Player: Fixed gem activation requirements
Not sure if the structure is totally correct, but it can now properly read all the data we actually use
2017-05-28 19:55:25 +01:00
Ryan 1442984686 Merge branch '4.3.4' of https://gitlab.com/trinitycore/TrinityCore_434 into 4.3.4 2017-05-28 19:10:00 +01:00
Ryan 5e50bb9481 Fix warning and whitespace 2017-05-28 18:39:41 +01:00
ariel- 3d5584fb86 Core/Pools: fix VS dynamic linking 2017-05-28 03:18:59 +02:00
ariel- da65d89129 Core/Misc: fix some clang 5 warnings 2017-05-28 03:18:50 +02:00
treeston e361682377 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast. 2017-05-28 03:18:35 +02:00
treeston 3fa862ab38 Instances/Ulduar: Fix a super edge case bug where Algalon would evade if his tank successfully tanked a Cosmic Smash and got knocked up. Shadow priests everywhere rejoiced. 2017-05-28 03:18:18 +02:00
ariel- 8082b3165e Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624
2017-05-28 03:11:57 +02:00
ariel- f8a222aab9 Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
Closes #19514
2017-05-28 03:11:40 +02:00