Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
23,887 Commits 2 Branches 1 Tag
5ceb3fd0ab3644f9515e11dea36f7b00316e4136
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jackpoz fae8269589 Core/Instances: Fix some Instance Lock chat messages 
Always send a Welcome type Instance Lock chat message when entering an instance instead of changing type based on remaining time.
Fix scheduled warning message to always send "Your instance lock for ... will expire in 0 minutes." even if there are hours left, issue added in 4193806dba , closes #11519 .
Update warning messages based on remaining time so that the most meaning is always used (6 hours left, 59 minutes left, etc).
 2015-07-08 23:32:04 +02:00
jackpoz b574c99549 Scripts/Ulduar: Fix Flame Leviathan instance lock 
Fix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005
 2015-07-05 17:16:35 +02:00
jackpoz e5258f92c8 Core/Spells: Normalize Z for last point in a charge path 
Normalize the new point that 124398feef adds to a charge path.
 2015-07-05 11:49:05 +02:00
jackpoz 6681b3600c Core/Misc: Fix build warnings 
Fix build warning reported by clang 3.6
 2015-07-04 19:28:11 +02:00
jackpoz 37b157746e Scripts/Commands: ".mmap path line" now uses raycast pathfinding 
Add "line" optional parameter to ".mmap path" command to use raycast implementation of recast, useful to simulate charge paths.
 2015-07-03 23:21:09 +02:00
jackpoz a328a11978 Core/Spells: Fix Charge "no path" error with huge targets 
Fix Charge returning "no path found" error when targeting targets with Object Size of 8 like Festergut by changing how the target Z coordinate is set, using only half object size.
It is unclear why the CalculatePath() call in Charge handler is using target object size, maybe for corner cases where the target is slightly below the ground.
 2015-07-03 23:16:34 +02:00
jackpoz 275bb93034 Scripts/EyeOfEternity: Fix crash added in d1853f693b 
Close https://github.com/TrinityCore/TrinityCore/issues/14984#issuecomment-118044904
 2015-07-02 22:08:19 +02:00
jackpoz b9d5b194df Dep/G3D: Backport fix from G3D10 2015-07-02 22:05:36 +02:00
jackpoz 2b6ddce59b CI/Travis: Report travis build as broken if new build warnings get added to the sources 2015-07-02 20:34:54 +02:00
jackpoz 77f7f56268 Dep/gsoap: Turn off build warnings 
Disable -Wunused-parameter warnings in gsoap library to have a 0-warning build till the library gets updated
 2015-07-01 22:03:36 +02:00
jackpoz 55681666b3 Core/Misc: Fix build warnings 2015-07-01 20:57:20 +02:00
jackpoz 879af88d21 Buildsystem/Clang: Suppress warning 
Suppress -Wmismatched-tags warnings on clang to avoid false positive warnings reported using gcc 4.8
 2015-06-29 22:29:28 +02:00
jackpoz c86cf03dce Core/Dependencies: Fix some warnings in G3D 2015-06-28 22:55:19 +02:00
jackpoz 80761849cc Tools/Misc: Fix build warnings 2015-06-28 22:01:47 +02:00
jackpoz dfa556aaa2 Core/Dependencies: Update recast 
Update recast to https://github.com/memononen/recastnavigation/commit/1dd5cf1883d61e723fef3d4957cf758c50e7a52b
Fix 2 warnings.

These changes have no effect on MMAPs and it's not needed to re-extact them.
 2015-06-28 21:20:01 +02:00
jackpoz cb4d1574e0 Core/Instances: Make achievements and loot rolls instance-wide 
Make achievements, loot rolls, master loot at money loot instance-wide, removing the previous limit for 74.f yards
 2015-06-24 22:40:57 +02:00
jackpoz 6a303caffd Core/Misc: Update helgrind suppressions 2015-06-21 18:33:16 +02:00
jackpoz 60a29f7614 Core/Misc: Add valgrind support for jemalloc 
Set CMake option VALGRIND to add valgrind support to jemalloc. Set CMake parameter VALGRIND_INCLUDE_DIR to the valgrind include directory.
 2015-06-20 23:01:53 +02:00
jackpoz c6c09423fd Scripts/Commands: Fix memory leak in ".reload command" 
Free commandTableCache object before assigning it the result of malloc()
 2015-06-20 22:42:30 +02:00
jackpoz c544e88437 Core/Players: Fix converting quests on faction change 
Fix quests not being converted on faction change due to table world.player_factionchange_quests not loaded on startup
 2015-06-17 21:36:04 +02:00
jackpoz 91c399cad2 Core/Spells: Fix Charge pathing 
Fix charge allowing to run to unreachable places
Close #13847
 2015-06-17 19:39:37 +02:00
jackpoz 0b9cd22a6b Core/ChatCommands: Allow to use "tele" command inside of a battleground 
Allow GameMasters with ".gm on" tag to use ".tele" command inside of a battleground to tele around.
 2015-06-15 21:35:05 +02:00
jackpoz 6d7339e7a3 Merge pull request #14728 from kelno/fixes 
Core/SAI: Fixed a math error overflow in SmartScript::DecPhase(int32)
 2015-06-14 18:34:11 +02:00
jackpoz 5b666ee393 Merge pull request #14611 from ariel-/spells 
Core/Spell: Spell logging corrections
 2015-06-14 18:09:22 +02:00
jackpoz 81cec13a58 Merge pull request #14250 from xjose93/SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED 
Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED

Fix SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED modifying speeds of bosses that are immune to changes of speeds.
 2015-06-14 16:34:49 +02:00
jackpoz 718c238524 Dep/libmpq: Update libmpq to https://github.com/mbroemme/libmpq/commit/d59b4cf1d107b5f6a0f67d6bc545c6c6ebef3d74 
Update libmpq to https://github.com/mbroemme/libmpq/commit/d59b4cf1d107b5f6a0f67d6bc545c6c6ebef3d74 and add some custom change to fix additional build warnings, diff is included.

Extracting dbcs, maps, vmaps and mmaps is not required.
 2015-06-13 19:16:10 +02:00
jackpoz d123c81162 Core/Texts: Fix race conditions in CreatureTextMgr repeat group 
Fix race conditions in CreatureTextMgr repeat group happening with MapThreads > 1 reported by helgrind by moving Creature-GUID-base data from CreatureTextMgr to Creature.
Issues added in bbf86641a1
 2015-06-13 12:27:19 +02:00
jackpoz abda6840e1 Core/Misc: Update helgrind suppressions 2015-06-08 21:25:36 +02:00
jackpoz d78eae1eaf Core/Misc: Disable G3D buffer pools if jemalloc is enabled 2015-06-08 20:49:54 +02:00
jackpoz 239f0b4ad0 Core/Player: Don't allow to join bg/lfg when frozen by a GM 2015-06-03 22:08:01 +02:00
jackpoz a7847728a5 Scripts/Auchindoun: Fix distance check in boss Shirrak 
Issue added in 88137c07b9
 2015-06-03 20:40:08 +02:00
jackpoz 83cf1e6aec Core/Player: Fix resurrection exploit 
Fix an exploit that allowed to resurrect even if corpse was not in range (teleport hack was required too)
 2015-06-02 19:16:42 +02:00
jackpoz 1a5051a9c3 Core/CrashHandler: Make crashhandler tread-safe 
Handle only 1 exception in the whole process lifetime and create only 1 crash report.
 2015-06-01 21:43:57 +02:00
jackpoz 1e429f3b4c Core/Misc: Fix build warning 
Fix build warning
 2015-05-31 00:04:26 +02:00
jackpoz 391c81d86c Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1023115
 2015-05-31 00:01:31 +02:00
jackpoz 25881ca95f Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1022861, 1022862, 1022863, 1302435, 1302439, 1302440
 2015-05-30 23:09:34 +02:00
jackpoz ec4b08e3cf Core/CrashHandler: Log STACK_OVERFLOW crashes 
Try to log STACK_OVERFLOW crashes by allocating log buffer on the heap which should still be in a valid state with a stack overflow exception.
This will probably still not produce a complete crash report with details about all stackframes.
 2015-05-23 23:15:56 +02:00
jackpoz d1efb90ae8 Scripts/Commands: Change few commands to target current Player by default 2015-05-17 16:16:32 +02:00
jackpoz b5cc8c5b17 Scripts/ToC: Fix doors opening/closing during Dreadscale fight 
Fix doors opening/closing during Dreadscale fight by sending a CloseDoor command instead of toggling the door state when Dreadscale resets its movement.
Note that bounding the door state to boss movement makes poor sense and should be changed. Other bosses in ToC have this logic and should be updated if they show the same bug.
 2015-05-17 14:50:30 +02:00
jackpoz 5bd7c295c0 Core/NetworkIO: Adjust more packet throttling values 
Adjust more packet throttling values by increasing some limits, this might fix some random kicks.
Close #14659
 2015-05-13 22:29:49 +02:00
jackpoz 1161295f4f Merge pull request #14641 from tkrokli/Fix_cast_on_fear_while_rooted 
Core/Spells: Fix being able to cast while feared and rooted at same time

Disallow to cast if feared and rooted at same time
 2015-05-06 20:21:21 +02:00
jackpoz 09aed25659 Scripts/VioletHold: Fix crash 
Fix crash in Violet Hold happening when crystals were activated without killing trash mobs.
Crash added in cba6515acb and f4531c5a58 .
Closes #14629
 2015-05-03 11:57:04 +02:00
jackpoz c3b8800cf7 Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1023036, 1022620
 2015-04-19 17:45:55 +02:00
jackpoz 5b5c0938da Core/Misc: Fix issues reported by static analysis 
Properly fix Coverity defect ID 1227434
 2015-04-18 17:33:14 +02:00
jackpoz d23538ce56 Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1227510, 1227434, 1023036, 1062426, 1062425, 1062424, 1062423, 1062422
 2015-04-04 20:20:04 +02:00
jackpoz 76986880c9 Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1267938, 1267937, 1267933, 1267932, 1267929
 2015-04-04 16:40:01 +02:00
jackpoz 2dc97e3f3d Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1292769, 1292768, 1292765, 1292763, 1267939
 2015-04-04 15:28:13 +02:00
jackpoz c38d4f57b3 Core/Dungeon Finder: Add additional logs for SMSG_LFG_QUEUE_STATUS 
Log the current LfgState of the target player when sending SMSG_LFG_QUEUE_STATUS packet.
 2015-04-04 14:01:11 +02:00
jackpoz 25e86f75f8 Core/Misc: Fix issues reported by static analysis 
Coverity defect IDs: 1292760, 1292761, 1292762, 1292771, 1292770
 2015-04-04 12:44:56 +02:00
jackpoz 1a2c20f95d Scripts/Misc: Fix warning 2015-04-03 23:06:34 +02:00
jackpoz de1cbf716d Core/Dungeon Finder: Allow to execute "lfg" commands from console 2015-03-29 20:50:17 +02:00
jackpoz be9294dc09 Core/Dungeon Finder: Restore ".lfg queue debug" logging additional information 
Restore ".lfg queue" behavior to print additional debug informations when an additional argument is passed (any character/word will work).
 2015-03-29 18:11:26 +02:00
jackpoz d888e4c7ad Scripts/Ulduar: Fix some Flame Leviathan issues 
Fix some Flame Leviathan issues:
- Fix boss evading all the time due to bad Doors check
- Opened "Lightning Door" to other bosses only after boss dies
- Eject players from the vehicles when boss dies, make them untargetable and despawn them after 5 minutes (adjust the time to the blizzlike time of choice)
 2015-03-21 23:57:49 +01:00
jackpoz f1ae2c7b73 Revert "*Do not allow players to use vehicles to go further than 1st boss in Ulduar." 
This reverts commit a009e53049.
Remove hackfix for Ulduar vehicles, it should be handled in Ulduar script
 2015-03-13 21:48:42 +01:00
jackpoz 9948e633ab Revert "Core/Server: Catch exceptions in int main()" 
This reverts commit 958999ff5c.

Closes #14329
 2015-03-11 20:59:21 +01:00
jackpoz 22403121fe Core/Dungeon Finder: Fix Vote Kick breaking LFG queue 
Fix Vote Kick started with party in queue breaking the whole LFG queue. The status of Vote Kick is now storing in a bool variable in LfgGroupData, separated from LfgState of the group/members.
If a Vote Kick started with party in queue, the members were not removed from queue correctly and would cause LFG matching system to match these "broken" players but not allowing to start a dungeon.

Closes #10191
 2015-03-10 21:11:54 +01:00
jackpoz 5e7d4a44e0 Core/PacketLog: Avoid unneeded calls with disabled packet logs 
Avoid calling GetOpcodeNameForLogging() when packet logs are disabled.
 2015-03-03 23:09:42 +01:00
jackpoz 43f74fd8cf Shared/Logs: Add support to .server set loglevel command after 003d67708b 
Update the lowest log level when using ".server set loglevel" command.
 2015-03-03 21:11:08 +01:00
jackpoz 003d67708b Shared/Logs: Improve log performances 
Improve Log::ShouldLog() performances by saving the lowest log level across all loggers and discarding any log with lower level than that.
 2015-03-02 22:32:36 +01:00
jackpoz 49ececf038 Core/Player: Optimize Player::HaveAtClient() performance 
Change m_clientGUIDs from std::set to std::unordered_set to reduce by 2.7x times the cpu usage in Player::HaveAtClient()
 2015-03-01 18:40:46 +01:00
jackpoz 3035a4218b Core/Collision: Fix crash when loading invalid vmap data 
Fix array overflow when loading Models from vmap tiles with wrong/outdated/bad data.
Try extracting again vmaps if you see this error.
Closes #14255
 2015-02-27 22:56:29 +01:00
jackpoz fd844e3d7e Core/CrashHandler: Fix char[] without '\0' handling 
Fix char[] without a NULL character '\0' in the array reading over the char[] bounds
 2015-02-27 21:31:30 +01:00
jackpoz b89f3be8d5 Core/Config: Force SaveRespawnTimeImmediately config to Enabled 
Force SaveRespawnTimeImmediately config to Enabled to avoid assertions triggered at runtime when Disabled. It will be possible to Disable this config again only when all issues will be fixed.
 2015-02-20 22:44:04 +01:00
jackpoz dcb500388c Core/LFG: Fix assertion triggered 
Fix assertion triggered since 9582b32d22
 2015-02-17 19:51:55 +01:00
jackpoz 9582b32d22 Core/LFG: Fix LFG issue when player was teleporting 
Fix a LFG issue that would kick a player out of a just-formed LFG party if player was being teleported.
Fix a log warning "Player: GUID Full: 0x0000000000000001 Type: Player Low: 1 not ingame while retrieving his LockedDungeons" if player was being teleported.

Refers to #14039 , #10191
 2015-02-15 14:22:01 +01:00
jackpoz 2eee1b349f Core/AHBot: Fix AHBot bidding and correct logged AH type 
Correct AuctionHouseType definition to log the right AH type.
Handle auctions without bidder but with a bid as bought by the AH Bot
Closes #14124
 2015-02-13 23:39:58 +01:00
jackpoz 62001360dd Shared/Database: Improve dead-lock error handling 
Improve dead-lock error handling by making sure only 1 thread at time retries to execute a transaction so they don't keep dead-locking each other.
 2015-02-12 22:48:57 +01:00
jackpoz b69fd4ac68 Merge PR #14059 from 'Rochet2/ahbot_buyer' into 3.3.5 2015-02-07 21:32:17 +01:00
jackpoz d4db0c15c7 Shared/Database: Fix transactions not being recommitted on dead-lock error 
Fix transactions not being recommitted on dead-lock error (error code 1213) because of calling http://dev.mysql.com/doc/refman/5.0/en/mysql-errno.html after sending the ROLLBACK command. This way the returned error code was related to the ROLLBACK command, not the failed transaction.
 2015-02-04 19:42:39 +01:00
jackpoz 2ec6844666 Core/Misc: Fix static analysis issues 
Fix some static analysis issues reported by Coverity

(cherry picked from commit c8999449816d4fd4f72c7cdb3b1515e8e244ba5f)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/scripts/Northrend/IcecrownCitadel/boss_professor_putricide.cpp
 2015-02-02 01:47:59 +00:00
jackpoz 7b05b0cb81 Core/Misc: Fix static analysis issues 
Fix some static analysis issues reported by Coverity

(cherry picked from commit 89c535cf2a960ccc03cd1a032310984f9b4e1d47)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
 2015-02-02 01:45:38 +00:00
jackpoz 4c0476bfd7 Core/Misc: Properly sanitize ReputationSpillover data 
Fix an issue added in 024b57bb74 that didn't properly skip ReputationSpillover rows with invalid data.
Fix also a static analysis issue reported by Coverity.

(cherry picked from commit 95b1204798d3ab2a141f81b294b064255c335b8a)

Conflicts:
	src/server/game/Globals/ObjectMgr.cpp
 2015-01-31 22:24:12 +00:00
jackpoz 7870ca8fdc Core/VMaps: Fix debug assert caused by invalid vmaps 
Fix debug assert thrown by G3D caused by models with empty bounding box being exported by vmap4assembler and imported by worldserver. This change will skip those models, proper investigation on the issue of why the bounding box is empty is still required.

(cherry picked from commit a7ca78b2fe12c68e561782416bf5726410a3c01b)
 2015-01-31 22:21:53 +00:00
jackpoz 9ea93eae33 Core/Aura: Replace assert with logged error for invalid AuraRemoveMode 
Fix AuraScript::Remove() triggering an assert with default parameter and log an error when Aura is removed with invalid mode AURA_REMOVE_NONE instead of triggering an assert deep down in the call tree.
Fix https://github.com/TrinityCore/TrinityCore/issues/714 , triggered by spell 50240 "Evasive Maneuvers" script
 2015-01-07 22:48:34 +01:00
jackpoz 6390e6a4cc Core/Dep: Remove unneeded recast files 2014-12-31 21:14:53 +01:00
jackpoz cdf6c88462 Shared/Networking: Fix buffer overflow in Socket handling 
Fix a buffer overflow caused by Boost trying to store too much data in a buffer too small.
 2014-12-27 14:03:54 +01:00
jackpoz 1bb2bdfe6d Merge PR https://github.com/TrinityCore/TrinityCore/pull/13702 into 3.3.5 
Core/RBAC: Add two side trade to RBAC
 2014-12-21 20:26:46 +01:00
jackpoz ce5226dc55 Merge pull request #13558 from MrSmite/3.3.5 
Fix spell cooldown for guardian pets
Fixes https://github.com/TrinityCore/TrinityCore/issues/13450 , closes https://github.com/TrinityCore/TrinityCore/pull/13452 and https://github.com/TrinityCore/TrinityCore/pull/13558
 2014-12-08 21:09:18 +01:00
jackpoz d8c3115bbd Core/NetworkIO: Skip AntiDoS checks for queued packets 2014-11-30 22:08:09 +01:00
jackpoz 064b47eccf Core/LFG: Allow group bound to LFG instance to re-queue if someone leaves the party 2014-11-09 20:41:22 +01:00
jackpoz c2a69e748e Core/LFG: Fix being unable to re-queue after leaving queue 2014-11-08 22:52:09 +01:00
jackpoz 1802fb3e1e Core/LFG: Fix party members not being able to vote to kick Leader 2014-11-07 22:17:04 +01:00
jackpoz 248847290a Merge pull request #13440 from Rochet2/ahbot 
Core/AH: AHBot related fixes
 2014-10-28 20:57:18 +01:00
jackpoz 8d39ad435a Core/AH: Code cleanup 
Remove unused paramters from RemoveAuction(), kept till now for compatibility with ahbot patch.
Reverts 28dffbee11
 2014-10-26 19:37:07 +01:00
jackpoz d924553002 Merge pull request #13455 Rochet2/ah 
AH related fixes
 2014-10-26 18:23:45 +01:00
jackpoz 361d285ba3 Core/AHBot: Filter out from AHBot items that can't be looted 2014-10-20 21:20:35 +02:00
jackpoz 183a0c59e0 Core/Misc: Remove unsafe not thread-safe localtime() calls 
Replace not thread-safe localtime() calls with thread-safe localtime_r().

(cherry picked from commit 5b08387792dae0afbf91ab74808dc978bf418bca)
 2014-10-19 15:14:45 +02:00
jackpoz 2cd4ea9b6b Core/Misc: Remove dead code 
Remove a double check on result of same function, with the 2nd being always true.

(cherry picked from commit e2c2bce90f1713136c2a256e423e5d136dab2389)
 2014-10-19 14:39:36 +02:00
jackpoz e3ab58ce4e Build/CMake: CMake options cleanup after febb26d4b7 2014-10-19 12:17:00 +02:00
jackpoz a147770702 Core/Player: Additional fixes related to https://github.com/TrinityCore/TrinityCore/commit/ee5eaab598e445e3926edf6e12b1b2b4477c2594 
Fix whispers to players on loading screen and few other cases.
 2014-10-17 22:59:53 +02:00
jackpoz ee5eaab598 Core/Players: Fix players not being notified if on loading screen 
Fix packets not being sent to players on loading screen even if the system supports these packets to be queued and sent till the player is in world.
There might be additional cases where this applies, please report back if you find any.

Fixes #11339
 2014-10-17 22:35:28 +02:00
jackpoz c3276ed27c Merge pull request #13327 from Nyeriah/patch-3 
Scripts/ICC: Register Rotface's summons so they can be despawned later
 2014-10-14 17:52:56 +02:00
jackpoz 86e3737d11 Core/Movement: Fix evade issue 
Fix evade issue happening when an evading creature assists another one, causing it to stay in evading state forever.
Fix #4943
 2014-10-13 22:38:59 +02:00
jackpoz bb046ce4ed Core/Maps: Apply const-correctness to GridMap::loadData() 2014-10-12 20:01:27 +02:00
jackpoz db88bf02b5 Core/LFG: Fix Leader flag being ignored 
Fix bug added in 5ca00bc14d that removed Leader flag of LFG without ever adding it back, giving leadership to players who didn't want it.
 2014-10-07 22:15:01 +02:00
jackpoz 6501da3c94 Core/Instances: Add assert to track down a crash 
Instance reset times are supposed to be initialized on server startup and then only updated when they expire.
Refers to #11904
 2014-10-05 14:11:31 +02:00
jackpoz b33695a2ef Core/Worldserver: Fix worldserver stuck on "Halting process" on shutdown 
Partially revert 4fe45b8c63 to fix worldserver stuck on "Halting process" on shutdown.

Fixes #13201
 2014-10-03 21:21:17 +02:00
jackpoz d828d16e9e Core/AHBot: Fix reference_loot_template being excluded from ahbot items 
Fixes #13265
 2014-10-02 22:29:45 +02:00
jackpoz fb6e635c80 Core/AH: Don't send expired auctions to clients 
Fixes #12964
 2014-10-01 21:35:31 +02:00
jackpoz 5150222f19 Revert "Core/AuctionHouse: Delete expired auctions at startup." 
This reverts commit a92038feaf which caused items of expired auctions not being mailed back to the owner and leaving those items in item_instance table.

Please refer to the forum for steps to verify the integrity of your database and remove old unneeded rows in item_instance table.

Fixes #12699
 2014-09-30 21:25:58 +02:00