Ovahlord
5f808b5247
Core/Entities: modernized several pointers and arrays in Player, Unit and Creature classes
2023-07-08 17:55:25 +02:00
Ovahlord
d6801c5dc4
Core/Misc: fixed more deprecation warnings
2023-07-07 23:52:15 +02:00
Ovahlord
d924871a2a
Core/Misc: fixed a bunch of deprecation warnings
2023-07-07 22:14:22 +02:00
Shauren
07376de9fc
Core/Spells: Always remove spell target from transport on teleport spells if spell destination does not target a position on the transport
2023-06-29 20:31:45 +02:00
Ovahlord
06d79464d3
Core/Spells: fixed rank 2 of Improved Searing pain having no effect
...
*the rank 2 spell does not have a 2nd spell effect containing the health threshold and since no glyph or talent is affecting this mechanic, we just use use the plain value instead of doing calculation shenanigans
2023-06-12 15:47:29 +02:00
Ovahlord
40ec92758c
Core/Packets: converted SMSG_EMOTE to packet class
2023-06-05 13:24:02 +02:00
Ovahlord
8821936ec6
Core/Spells: spell crit supression will no longer increase the crit chance against lower level targets
2023-02-06 10:03:46 +01:00
Ovahlord
e471f0b7da
Core/Spells: fixed a typo in ed53552995
2023-01-23 10:11:20 +01:00
Ovahlord
836e7dae18
Core/Spells: removed deprecated code for Glyph of Regrowth
2023-01-23 10:10:28 +01:00
Ovahlord
ed53552995
Core/Spells: Nourish will no longer get its bonus for active HoTs applied twice and optimized involved code
2023-01-23 10:08:52 +01:00
Shauren
674bba1cae
Core/Auras: Fully remove auras that had all of their effect suppressed with immunity
2023-01-19 19:48:46 +01:00
Shauren
f97d336d82
Core/Auras: Fixed possible iterator invalidation crashes caused by calling UpdateTargetMap inside loops iterating m_appliedAuras
2023-01-19 17:30:41 +01:00
Gosha
cb18f8970c
Core/Units: Removed duplicate call to WorldObject::UpdatePositionData ( #28731 )
2023-01-16 22:16:00 +01:00
Shauren
265c2fa508
Core/Battlefields: Refactor Battlefield creation to be linked to host map creation instead of having globally accessible objects
2022-12-26 13:24:59 +01:00
Ovahlord
9455b09518
Core/Packets: converted SMSG_PET_ACTION_SOUND to packet class and renamed its related method to Unit::SendPetActionSound
2022-12-11 20:12:35 +01:00
Ovahlord
92c9661804
Core/Packets: converted SMSG_PET_ACTION_FEEDBACK to packet class and added spellId argument to Unit::SendPetActionFeedback
2022-12-11 20:03:57 +01:00
Ovahlord
dd43ca3e6a
Core/Units: ensure that we use valid iterators when providing spell Ids in Unit::RemoveAppliedAuras and Unit::RemoveOwnedAuras
2022-11-23 21:01:09 +01:00
Ovahlord
181d1e2485
buildfix
2022-10-17 00:43:54 +02:00
Ovahlord
4b8bea57d8
Core/Units: ensure that we always have a valid caster when a charmed unit allows its charmer to cast spells directly
2022-10-16 17:58:58 +02:00
Ovahlord
6fa4c22daf
Core/Misc: fixed more crashes related to the caster dependency removal
2022-10-09 10:45:10 +02:00
Shauren
cf2bf7f77f
Core/Spells: Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED and SPELL_ATTR2_ALLOW_WHILE_INVISIBLE to use DispelType instead of checking effect types
2022-10-04 12:36:58 +02:00
Ovahlord
7d67f10f77
Core/Spells: added a missing check in Unit::IsMovementPreventedByCasting
2022-10-03 12:22:39 +02:00
Ovahlord
af71a8c9c1
Core/Units: fixed a crash in Unit::DealDamage when the attacker is no longer in world (periodic damage auras)
2022-10-03 12:01:01 +02:00
Shauren
b4a39d42a8
Core/Auras: Fixed requireImmunityPurgesEffectAttribute logic for school immunities
2022-09-30 12:50:31 +02:00
Shauren
c3b52fd29f
Core/Auras: Improve aura interactions with immunities on spell effect level
...
* Effects that target is immune to will be suppressed instead of completely removed
2022-09-30 12:49:31 +02:00
Alan Deutscher
0f4442c630
Core/Auras: Do not remove auras unaffected by invincibility
...
* Mark WSG's Focused Assault and Brutal Assault as unaffected by immunities
2022-09-30 11:33:04 +02:00
Shauren
f35e49b515
Core/Spells: Implemented SPELL_ATTR6_TAPS_IMMEDIATELY
2022-09-30 11:27:56 +02:00
Shauren
f93918ef0c
Core/Spells: Implemented SPELL_ATTR6_ABSORB_CANNOT_BE_IGNORE
2022-09-30 11:26:38 +02:00
Shauren
c78371f321
ore/Spells: Autorepeat casting fixes
...
* Fixed cast bars of ranged spells not disappearing when canceled while autoshooting
* Replaced hacky 500ms delay on non auto shot autorepeat spells with native spell cast time (wands have 500ms cast time)
* Update cooldowns before attempting to cast autorepeat spells (for cases when cooldown ends on the same server tick as cast attempt)
2022-09-30 11:08:20 +02:00
Shauren
dfc6fe6450
Core/Spells: Cleanup movement checks in spells - use correct interrupt flags
2022-09-30 11:02:52 +02:00
Shauren
1f60928a51
Core/Spells: Implemented SPELL_ATTR6_DELAY_COMBAT_TIMER_DURING_CAST
2022-09-30 10:56:37 +02:00
Shauren
b394faf376
Core/Spells: Implemented SPELL_ATTR6_NO_PUSHBACK
2022-09-30 10:55:29 +02:00
Ovahlord
eb0a5b607c
buildfix
2022-09-30 10:49:43 +02:00
Shauren
4cfd439d34
Core/Spells: Implemented SPELL_ATTR5_NOT_AVAILABLE_WHILE_CHARMED
2022-09-30 02:08:33 +02:00
Shauren
2c78751b5a
Core/Spells: Corrected implementation of SPELL_ATTR5_ALLOW_ACTIONS_DURING_CHANNEL - it allows casting other spells while channeling, not allows movement while channeling
2022-09-30 02:00:04 +02:00
Shauren
75906f3d06
Core/Auras: Added support for SPELL_ATTR5_LIMIT_N limit to other number than just 1
2022-09-30 01:57:52 +02:00
Ovahlord
8a9f5e297b
buildfix
2022-09-30 01:33:59 +02:00
Shauren
a7dc339a6a
SHA-1: 8d16a79dea4c0100d36e13b068c42499a3a48154
...
* Core/Spells: Rename SpellAttr4 to use official attribute names
* Corrected implementation of SPELL_ATTR4_CLASS_TRIGGER_ONLY_ON_TARGET
* Implemented SPELL_ATTR4_NO_HELPFUL_THREAT
* Implemented SPELL_ATTR4_NO_PARTIAL_IMMUNITY
* Implemented SPELL_ATTR4_ALLOW_PROC_WHILE_SITTING
* Implemented SPELL_ATTR4_USE_FACING_FROM_SPELL
* Implemented SPELL_ATTR4_BOUNCY_CHAIN_MISSILES
* Implemented SPELL_ATTR4_AURA_NEVER_BOUNCES
* Implemented SPELL_ATTR4_AURA_BOUNCE_FAILS_SPELL
* Implemented SPELL_ATTR4_AURA_IS_BUFF
* Implemented SPELL_ATTR5_MELEE_CHAIN_TARGETING
* Implemented SpellEffectAttributes::ChainFromInitialTarget
2022-09-30 01:16:39 +02:00
Ovahlord
34386e2b47
Core/Packets: converted SMSG_PERIODIC_AURA_LOG to packet class
2022-09-29 22:27:57 +02:00
Ovahlord
dad7c2c102
Core/Spells: minor refactor for SPELL_AURA_MOD_DAMAGE_FROM_MANA implementation
2022-09-27 12:56:09 +02:00
Ovahlord
7630711eaa
Core/Units: fixed a possible crash in Unit::MeleeDamageBonusDone
2022-09-20 21:24:48 +02:00
Ovahlord
bc1d71e589
Core/Spells: fixed totems not inheriting spell bonus effects from their creator
2022-09-20 19:44:44 +02:00
Ovahlord
ef3632109d
Core/Spells: ported SpellModOp definitions from master branch
2022-09-17 11:56:54 +02:00
Ovahlord
dbc0de1e71
Core/Units: removed PvE level delta based block chance bonus
...
* according to simulationcraft there is no sign of it being real
2022-09-14 01:06:01 +02:00
Ovahlord
19de0a1949
Core/Units: restore block chance bonus when fighting stronger creatures
2022-09-13 19:19:47 +02:00
Ovahlord
e9e2d65b42
Core/Units: allow ranged attacks to be blocked
2022-09-13 18:46:37 +02:00
Ovahlord
3057924db2
Core/Spells: corrected implementation of SPELL_ATTR3_COMPLETELY_BLOCKED
...
* it's not a bug, it's a feature :)
2022-09-13 18:19:05 +02:00
Ovahlord
a7ba9502d7
Core/Units: a587f99c30 followup
2022-09-13 16:30:15 +02:00
Ovahlord
a587f99c30
Core/Units: correct block chance and damage calculation of melee spells
...
*MeleeSpellHitResult already returns a valid block roll result so we don't need a 2nd roll in CalculateSpellDamageTaken
2022-09-13 16:14:42 +02:00
Shauren
946f928ee2
Core/Spells: Rename SpellAttr3 to use official attribute names
...
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-09-13 15:40:25 +02:00
Ovahlord