Ovahlord
6474479334
Core/Spells: fixed a regression which was causing spell_start packets to send wrong immunities
2022-09-22 15:10:16 +02:00
Ovahlord
c6711adf8b
Core/AI: ported SpellHit and SpellHitTarget refactor from 335 branch
2022-09-22 10:33:13 +02:00
Ovahlord
7630711eaa
Core/Units: fixed a possible crash in Unit::MeleeDamageBonusDone
2022-09-20 21:24:48 +02:00
Ovahlord
6d64727029
Core/Spells: fixed a crash with spell bushbacks
2022-09-20 19:51:27 +02:00
Ovahlord
bc1d71e589
Core/Spells: fixed totems not inheriting spell bonus effects from their creator
2022-09-20 19:44:44 +02:00
Ovahlord
bec87f7531
Scripts/Gilneas: fixed the gilnean crow AI not reacting to activating the traps
2022-09-17 12:03:15 +02:00
Ovahlord
ef3632109d
Core/Spells: ported SpellModOp definitions from master branch
2022-09-17 11:56:54 +02:00
Ovahlord
3de0b005d5
Core/Spells: resolve more cherrypick mistakes
2022-09-15 13:57:16 +02:00
Ovahlord
3203f04ac1
Scripts/HoO: fixed a crash in Temple Guardian Anhuur's script due to now supporting gameobject casters
2022-09-14 01:33:37 +02:00
Ovahlord
dbc0de1e71
Core/Units: removed PvE level delta based block chance bonus
...
* according to simulationcraft there is no sign of it being real
2022-09-14 01:06:01 +02:00
Ovahlord
44d22dd3b3
Revert "Core/Spells: fixed packet structure for spell_start and spell_go packets when ammo was involved"
...
This reverts commit c9baaec657 .
2022-09-13 22:57:21 +02:00
Ovahlord
13ab90d515
Core/Spells: don't send blocked delayed attacks as missed target to match sniff data
2022-09-13 22:53:28 +02:00
Ovahlord
19de0a1949
Core/Units: restore block chance bonus when fighting stronger creatures
2022-09-13 19:19:47 +02:00
Ovahlord
385846a273
Core/Spells: kill more dead ammo code
2022-09-13 19:19:17 +02:00
Ovahlord
c9baaec657
Core/Spells: fixed packet structure for spell_start and spell_go packets when ammo was involved
2022-09-13 19:18:39 +02:00
Ovahlord
e9e2d65b42
Core/Units: allow ranged attacks to be blocked
2022-09-13 18:46:37 +02:00
Ovahlord
3057924db2
Core/Spells: corrected implementation of SPELL_ATTR3_COMPLETELY_BLOCKED
...
* it's not a bug, it's a feature :)
2022-09-13 18:19:05 +02:00
Ovahlord
5253b7e677
Core/Spells: no longer consider blocked spells as missed and properly handle the melee damage reduction
...
* resolved more cherrypick mistakes while at it
* dropped dead ammo code
2022-09-13 17:59:28 +02:00
Ovahlord
a7ba9502d7
Core/Units: a587f99c30 followup
2022-09-13 16:30:15 +02:00
Ovahlord
a587f99c30
Core/Units: correct block chance and damage calculation of melee spells
...
*MeleeSpellHitResult already returns a valid block roll result so we don't need a 2nd roll in CalculateSpellDamageTaken
2022-09-13 16:14:42 +02:00
Shauren
946f928ee2
Core/Spells: Rename SpellAttr3 to use official attribute names
...
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-09-13 15:40:25 +02:00
Shauren
ea4bc6c02a
Core/Spells: Rename SpellAttr2 to use official attribute names
...
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-09-13 14:36:32 +02:00
Ovahlord
6224558c8c
Core/Packets: converted SMSG_SPELL_MISS_LOG to packet class
2022-09-12 12:18:23 +02:00
Ovahlord
5e7ee94ccc
build fix
2022-09-12 09:49:09 +02:00
Ovahlord
e3e4b2cf16
Core/Spells: dropped old dot clipping implementation and restored TC period and duration calculations in preparation of re-implementing it
2022-09-12 09:15:35 +02:00
Ovahlord
6d89d242a7
Core/Loot: no longer restrict need before greed rules to lfg parties only and no longer allow players to roll on mounts and companions they already have
2022-09-12 09:15:35 +02:00
Ovahlord
4c28aaebd6
warning fixes
2022-09-12 09:15:34 +02:00
Ovahlord
2b3477fab5
Core/Packets: ported SMSG_SPELL_DAMAGE_SHIELD to packet class and handle its missing field
2022-09-12 09:15:34 +02:00
Ovahlord
e76b43d2e9
warning fix
2022-09-12 09:15:34 +02:00
Ovahlord
037b5dfd86
fixed another C26433 warning
2022-09-12 09:15:34 +02:00
Ovahlord
18e6cd4565
Core/Units: resolved more cherrypick mistakes which caused vehciles accessories to not enter their seats
2022-09-12 09:15:34 +02:00
PolarCookie
b7f23d8e01
Core: VehicleJoinEvent crash fix
2022-09-12 09:15:33 +02:00
Ovahlord
4be112576c
nopch fix
2022-09-12 09:15:33 +02:00
Meji
4552929860
Core/Unit: Update collision height calculation
2022-09-12 09:15:33 +02:00
Ovahlord
733fe7c700
Core/Packets: corrected RideType for lfg
2022-09-12 09:15:33 +02:00
Ovahlord
bd2850cc08
Core/Players: fixed an oversight in spellmod sending that caused pct spellmods to appear clientside as flat bonus
2022-09-12 09:15:33 +02:00
Ovahlord
77cf3ebc91
Core/Spells: removed another duplicate haste application for periodic auras
2022-09-12 09:15:32 +02:00
Ovahlord
7e72ee241f
Core/Players: removed an unused spellmod helper
2022-09-12 09:15:32 +02:00
Ovahlord
0e4d77ddb1
Core/Spells: removed a duplicate haste application for auras which caused auras ending up with a shorter duration than intended
...
hi @warpten could need you to look over it so your work wont get destroyed
2022-09-12 09:15:32 +02:00
Ovahlord
6a71b6d053
Core/Units: consider summoned units with a creator guid also as party or raid member
...
the old logic was built on the false assumption that all units like totems have a ownerguid - they do not. They only have a creatorguid. Ownerguids (as the name implies) is only applied on units that the player is actively controlling. 3.3.5 has this implemented in a wrong way while 4.x does not.
*also fixed up more cherrypick mistakes while at it
2022-09-12 09:15:31 +02:00
Ovahlord
3976ae557b
Core/Spells: updated spell positivity cases and added some Cataclysm+ entries
2022-09-12 09:15:31 +02:00
Shauren
ca7d36873f
Core/Spells: Rename SpellAttr1 to use official attribute names
...
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-09-12 09:15:31 +02:00
Ovahlord
cbc2234f1b
nopch build fix
2022-09-12 09:15:31 +02:00
Kaytotes
b2d01c8d76
Core/Units: Removed incorrect facing movement packet sent with every creature autoattack
2022-09-12 09:15:30 +02:00
Jinnaix
458b841691
Core/Spells: Correct flagging spell caster for pvp when healing/buffing friendly creatures - it should only happen if target is in combat
2022-09-12 09:15:30 +02:00
Shauren
16aef47f61
Core/Spells: Fixed implementation of Spell::EffectRechargeManaGem when it is not the first effect on a spell (0 cases, sync code between branches)
2022-09-12 09:15:30 +02:00
Shauren
39b5168dbb
Core/Auras: Changed aura dot stacking rule to not ignore aura type of "existingAura"
2022-09-12 09:15:30 +02:00
Ovahlord
068e9004f5
fixed build
2022-09-12 09:15:30 +02:00
Meji
dec6c7d537
Core/Spells: Fixed spell effect 43 (SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER) ( #25945 )
2022-09-12 09:15:29 +02:00
Gildor
86121e9996
Core/Spells: Aura refresh improvements
2022-09-12 09:15:29 +02:00