Ovahlord
fcc371e453
Core/Spells: fixed mounting summoned vehicles if the seat id is o
2021-10-10 01:01:55 +02:00
Ovahlord
0a991df443
Core/Auras: cff762da69 followup
...
thanks to @meji46 for the headsup
2021-09-30 11:41:47 +02:00
Ovahlord
cff762da69
Core/Spells: apply the invisibility screen effect only for generic invisibility effects
2021-09-27 10:05:25 +02:00
Ovahlord
032b1ed2cd
Core/Spells: Blood Shield will now only proc while Blood Presence is active
2021-09-23 23:12:18 +02:00
Ovahlord
cad75cdaf3
Core/Spells: fixed an logic mistake in Runic Empowerment's spell script that was preventing the first blood or death rune from ever getting activated
2021-09-23 03:10:42 +02:00
Ovahlord
53435263e1
fixed build
2021-09-22 21:38:50 +02:00
Ovahlord
4b3302422f
Scripts/Westfall: fixed a possible crash when the westfall stew has been spawned via db (dirty db data)
2021-09-22 20:54:54 +02:00
Ovahlord
5e677b876b
Core/Spells: restored the old logic when determining when to add additional haste based ticks
2021-09-19 14:36:01 +02:00
Ovahlord
069684ffa5
Core/Spells: SPELL_AURA_MOD_CASTING_SPEED_NOT_STACK will no longer affect spell haste when its amount is too extreme to fix several exploits with instant cast auras causing haste affected dots and hots dealing insane amounts of damage
2021-09-19 14:33:02 +02:00
Ovahlord
0ef4e66c1d
make CI happy
2021-09-19 10:21:44 +02:00
Ovahlord
562e638a65
Core/Spells: Conflagrate will no longer bypass resistances and damage reducing auras
2021-09-18 23:34:15 +02:00
Ovahlord
6c7e2830c1
Core/Spells: fixed a possible null divider crash for spells with a periodic interval of 0 caused by exceptionally high haste and spell mod values
2021-09-18 23:25:33 +02:00
Ovahlord
949f92e0a1
Core/AI: ported charm updates from 335
2021-09-16 16:48:07 +02:00
Ovahlord
346ffe6e91
Scripts/Stratholme: updated Balnazzar's encounter to Cataclysm and corrected the visual appearance of the risen crusaders
2021-09-13 13:29:43 +02:00
Ovahlord
e2f388fc39
DB/Gilneas: respawned Bloodfang Worgen and tied some creatures to the correct terrain swap map for correct pathfinding and line of sight
2021-09-12 14:52:45 +02:00
Ovahlord
b03fe81f68
Revert "Core/Spells: no longer round PPM chance calculation results and stay more faithful to the original formula"
...
This reverts commit 1b91ed5424 .
2021-09-11 18:16:18 +02:00
Ovahlord
1b91ed5424
Core/Spells: no longer round PPM chance calculation results and stay more faithful to the original formula
2021-09-11 17:13:03 +02:00
Ovahlord
de82b464c8
Core/Spells: greatly simplify Runic Empowerment
...
Sniffs have shown that there is no energize spell being involved in the activation. Probably because the activate spell effect does not care about fully depleted runes so we now can slim it all down by alot
2021-09-11 14:10:53 +02:00
Ovahlord
c6fd91cd1d
Core/Spells: Runic Empowerment will now only select runes which have a base rune that can be activated
2021-09-11 12:33:23 +02:00
Ovahlord
52f45202d8
Core/Spells: Blood Rune activation no longer can activate Death Runes
2021-09-11 12:29:40 +02:00
Ovahlord
7180345f32
Core/Spells: reworked Runic Empowerment's rune selection logic. Instead of just picking any random rune that's on cooldown, it will now only proc for a rune type that is fully depleted, which means that both runes of the same type must be on cooldown
2021-09-11 11:19:42 +02:00
Ovahlord
93a252868d
Core/Packets: converted CMSG_DESTROY_ITEM to packet class
2021-09-11 11:16:25 +02:00
Ovahlord
ab194c1322
fixed a warning
2021-09-10 16:55:15 +02:00
Ovahlord
2a50d36e2d
fixed nopch build
2021-09-10 13:47:30 +02:00
Ovahlord
208e0b35f6
Core/Packets: converted CMSG_TRANSMOGRIFY_ITEMS to packet class
2021-09-10 13:40:06 +02:00
Ovahlord
532b489ffa
Core/Packets: 413a94f4b0 followup. No longer inline initialize optional members in VendorItem struct
2021-09-10 10:24:58 +02:00
Ovahlord
413a94f4b0
Core/Packets: reduce size of vendor inventory packets by not sending extended cost Ids when there is none being used
2021-09-10 10:17:12 +02:00
Ovahlord
d8753ef5d7
Core/Vendors: allow players to interact with vendors that do not have any items to sell
2021-09-10 10:04:14 +02:00
Ovahlord
c2be4c4a86
Misc: fixed issues discovered by static analysis
...
closes #290
2021-09-10 09:56:49 +02:00
Ovahlord
60c68dacca
Core/Spells: moved avoidance bonus handling to Unit::SpellDamageBonusTaken as it does affect all area attacks instead of periodic auras only
2021-09-01 21:26:12 +02:00
Ovahlord
3506dae653
Core/Spells: ported PROC_FLAG_ENTER_COMBAT implementation from master branch and handle the Worgen transformation via its proc aura
2021-08-30 19:24:36 +02:00
Ovahlord
7ac3d6fca9
Core/Players: Worgen will now transform into their altered form at engage instead of at dealing or taking damage
2021-08-29 18:36:33 +02:00
Ovahlord
a5caf1af95
Core/Units: removed now unused attacker argument from Unit::GetUnitCriticalChanceTaken
2021-08-29 02:13:16 +02:00
Ovahlord
fd815dfe33
Core/Units: remove an incorrect check for SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER from Unit::GetUnitCriticalChanceTaken as that aura is only being involved for increasing crit chance values for spells with a class mask value
2021-08-29 01:52:39 +02:00
Ovahlord
01dad8b74e
Core/Spells: Eclipse states will no longer proc while the druid has no balance specialization active
2021-08-29 00:59:51 +02:00
Ovahlord
432e57b064
Core/Spells: fixed damage formula for bear form's Maul
2021-08-29 00:34:17 +02:00
Ovahlord
4c6cfee2dd
Core/Units: normalize melee damage while in bear or cat form
2021-08-29 00:19:06 +02:00
Ovahlord
a3a7a9b181
Core/Spells: Blood Shield will now only use effective healing for its shield calculation
2021-08-28 23:34:52 +02:00
Ovahlord
cfc3f25b46
Core/Spells: corrected multiple effect value calculations for procs that should use effective healing values instead of raw healing
2021-08-28 23:05:43 +02:00
Ovahlord
1ba6fc1a6a
Core/Spells: fixed Warlocks's Decimation talent
2021-08-28 15:44:05 +02:00
Ovahlord
7fcb1c03da
Correct script name added in 9616582b05
2021-08-28 15:05:24 +02:00
Ovahlord
9616582b05
Core/Spells: load BonusCoefficient into SpellInfo and use it for Goblin's Rocket Barrage Racial spell damage calculation
2021-08-28 15:01:28 +02:00
Ovahlord
ce1901524f
Tools/VMapExtrator: ported m2 model bounds issue fix from master branch
2021-08-28 14:39:19 +02:00
Ovahlord
5ed7516280
Core/Transports: fixed a logic mistake introduced in be614ded97
2021-08-19 06:20:05 +02:00
Ovahlord
449d220ab3
DB/Stratholme: added missing questgiver npcs that have been added in Cataclysm at the two wing's entrance areas
2021-08-18 21:50:28 +02:00
Ovahlord
be614ded97
Core/Misc: fixed issues reported by pvs studio
...
closes #281
2021-08-18 21:11:20 +02:00
Ovahlord
f394bd9510
DB/Spells: renamed spell_dbc 'Comment' colulmn to 'SpellName' to reduce differences between branches
2021-08-17 15:42:26 +02:00
Ovahlord
8186f9d450
make CI happy
2021-08-17 15:38:13 +02:00
Ovahlord
da5564fa47
Core/Packets: converted SMSG_CLEAR_COOLDOWN and SMSG_CLEAR_COOLDOWNS to packet class
2021-08-16 11:02:22 +02:00
Ovahlord
8ac7e71690
Core/Spells: implement summon properties parameter types based on the leaked enumerated strings values
...
Summon spells can now be commanded to interpret their basepoints depending on the parameter type that has been assigned to the summon properties dbc record Id
* implemented SummonCreatureExtraArgs to reduce the amount of arguments in Map::SummonCreature
2021-08-15 10:35:02 +02:00
Ovahlord
c927ca98ba
Core/Spells: allow knockback spell effects to use negative misc values as well for forward knockbacks
2021-08-15 07:07:37 +02:00
Ovahlord
1568798985
Core/Spells: fixed Glyph of Shadow Word: Death
2021-08-15 06:56:32 +02:00
Ovahlord
9502e75cac
DB/Misc: fixed startup errors
2021-08-02 13:18:09 +02:00
Ovahlord
3e56f75d7c
fixed build and a typo in recent sql file
2021-08-02 13:13:50 +02:00
Ovahlord
e785b6d386
Scripts/Mulgore: several fixups for Camp Narache
...
* scripted Captured Brave's behavior when released from their cages
* respawned Armored Quillboars and got rid of duplicate spawns
* scripted Armored Quillboar's visual events, combat ability and behavior when ignited via torch
* added waypoints to Brave Windfeather
* nuked cooler's shitty sai for chief squealer thornmantle and replaced it with a c++ script to handle the death spell cast event
* corrected timers for Chief Hawkwind's ceremony texts
* spawned a missing spellfocus and removed some gameobject spawns which are suposed to be tempoary
* added some emote events to Camp Narache trainers
2021-08-01 15:21:05 +02:00
Ovahlord
280dd50af4
Core/Quests: also check previous quests when checking exclusive groups to allow chaining one quest group into another
2021-08-01 15:13:34 +02:00
Ovahlord
f9fafbab7d
Scripts/Deadmines: move entrance faction spawns to instance_spawn_groups and handle them via faction flags instead
2021-07-31 21:42:32 +02:00
Ovahlord
99a129d5bc
fixed build
2021-07-29 18:56:10 +02:00
Ovahlord
e03b2f41bf
Core/Guilds: implement weekly bonus money packet field in guild bank queries
2021-07-29 18:45:49 +02:00
Ovahlord
8cabdc6c85
Scripts/LCT: fixed Siamat's Achievement 'Headed South'
2021-07-29 17:29:36 +02:00
Ovahlord
c58d2752d3
Core/Creatures: fixed build and clamp the damage pct limit instead of blindy relying on arguments
2021-07-26 15:57:29 +02:00
Ovahlord
0dfa919f09
Core/Creatures: optimized sparring checks by handling them via variable instead of map lookups and expose its value to helpers to allow manipulation during runtime
2021-07-26 15:48:16 +02:00
Ovahlord
ae13da2159
fixed build
2021-07-25 15:03:43 +02:00
Ovahlord
7648eff6db
Core/Quests: check if a player can take the next quest provided by its query data before trying to request its details
2021-07-25 14:57:41 +02:00
Ovahlord
9c55fc66ac
Core/Packets: added some missing bit flushing to trade status packets
2021-07-23 20:32:42 +02:00
Ovahlord
7bd1afe406
Core/Units: corrected check for SPELL_ATTR7_CANT_MISS in Unit::MagicSpellHitResult
...
thx to @Jildor for the headsup
2021-07-23 19:44:14 +02:00
Ovahlord
b236bd39df
Core/Movement: updated smartAI waypoint support to use the new smooth transition field as well
2021-07-16 16:56:47 +02:00
Ovahlord
b7ab244e79
Core/Packets: converted all remaining trade packets to packet class
2021-07-13 15:56:31 +02:00
Ovahlord
81098f738f
fixed nopch build
2021-07-12 09:01:53 +02:00
Ovahlord
1a5c06b61a
Core/Packets: several updates to trading
...
* converted CMSG_INITIATE_TRADE, SMSG_TRADE_STATUS, SMSG_TRADE_UPDATED and CMSG_ACCEPT_TRADE to packet class
* fixed enchanting items via trade
* handle unknown fields in SMSG_TRADE_UPDATED
2021-07-11 23:48:50 +02:00
Ovahlord
c2279d6f60
fixed nopch build
2021-07-10 20:42:04 +02:00
Ovahlord
aef0d5c5dc
Core/Packets:
...
* converted CMSG_REQUEST_HONOR_STATS and SMSG_INSPECT_HONOR_STATS to packet class
* enabled and added handlers for CMSG_REQUEST_INSPECT_RATED_BG_STATS and SMSG_INSPECT_RATED_BG_STATS
2021-07-10 19:55:04 +02:00
Ovahlord
bd3ca6e98a
Core/Movement: fixed waypoint movement ignoring pause timers and interaction pause time
2021-07-08 00:41:54 +02:00
Ovahlord
e2237624f6
Core/Movement: no longer store negative delays for smooth transition times and let the waypoint movement generator decide when to transition when allowed via new boolean value
2021-07-07 23:42:51 +02:00
Ovahlord
4c670bce9a
Core/Movement: correctly initialize orientation values when loading script waypoints
2021-07-07 09:41:22 +02:00
Ovahlord
c926327077
Scripts/BWD: removed some unneeded checks in Omnotron's Lord Victor Nefarius script
2021-07-06 18:27:59 +02:00
Ovahlord
dbada5fcb4
fixed build²
2021-07-06 18:14:49 +02:00
Ovahlord
5614db5976
fixed build
2021-07-06 17:59:03 +02:00
Ovahlord
e8c7982362
Core/Packets: updated CMSG_UPDATE_MISSILE_TRAJECTORY to packet class and updated structure to 4.3.4
...
closes #268
2021-07-06 17:49:56 +02:00
Ovahlord
6510b2b034
Core/Spells: fixed a cherrypick typo in checking for affecting spellmods
2021-07-06 10:55:05 +02:00
Ovahlord
db46b10200
DB/Creatures: added a few cyclic spline movements to Westfall's Fleshripper
2021-06-23 16:50:02 +02:00
Ovahlord
0ec0947a06
DB/Quests: fixed startup errors
2021-06-21 23:58:45 +02:00
Ovahlord
d9cbf60fd1
Core/Quests: kick AllowableRaces and TimeAllowed from quest_template over to quest_template_addon as these fields no longer are being sent in quest query packets
2021-06-21 22:10:58 +02:00
Ovahlord
748263fe9e
Scripts/TSC: Gravity Well now uses its correct spell id to shrink in size
...
closes #267
2021-06-18 16:40:04 +02:00
Ovahlord
8270c6782f
Scripts/SFK: removed an unused enum value from Baron Ashbury's spells
2021-06-14 11:38:19 +02:00
Ovahlord
edb4df4ffc
Scripts/SFK: converted achievements to world state handling
2021-06-14 11:11:10 +02:00
Ovahlord
c80c23e5c2
fixed nopch build
2021-06-14 11:10:49 +02:00
Ovahlord
f5b9989601
Scripts/BRC: converted Ascendant Lord Obsidius' achievement to world state handling
2021-06-13 23:38:43 +02:00
Ovahlord
5741d295dd
Scripts/HoO: converted achievements to world state handling
2021-06-13 23:22:05 +02:00
Ovahlord
1e9fd012e8
Scripts/BoT: converted achievements to world state handling
2021-06-13 22:57:24 +02:00
Ovahlord
b0df1fdca3
Scripts/BWD: converted remaining achievements to world state based handling
2021-06-13 17:10:56 +02:00
Ovahlord
5fd77a3b28
Core/World: implement database support for default map and realm wide world states
2021-06-13 16:07:38 +02:00
Ovahlord
a20ce4309b
Scripts/BWD: converted Achieve-a-tron achievement to world state based handling
2021-06-13 11:40:46 +02:00
Ovahlord
be239e4458
Core/Maps: implement map based world states and implemented support for required world states in achievement criterias
...
*converted Erduax' conditional achievement to world state based handling as example
2021-06-13 10:48:41 +02:00
Ovahlord
3301b87dba
fixed a warning
2021-06-12 15:31:40 +02:00
Ovahlord
bd57f795bd
Core/Spells: send the correct cast failure reason when trying to queue up a spell cast while not being able to do so yet
...
closes #264
2021-06-12 15:18:04 +02:00
Ovahlord
ab405f6935
Core/Spells: Gouge will now have a chance of not being canceled by bleeding effects when having learned Sanguinary Vein
...
closes #263
2021-06-12 14:42:15 +02:00
Ovahlord
8011d2de29
Core/Spells: ported resistance and immunity updates from 3.3.5 branch
2021-06-12 14:10:44 +02:00
Ovahlord
1064209eaf
Scripts/HoO:
...
* Temple Guardian Anhuur's Divine Reckoning will now prefer non-tank targets above tanks
* Added missing attribute to Anhuur's heroic version of Reverberating Hymn that was causing the periodic timer to reset on each stacking
2021-05-26 22:16:01 +02:00
Ovahlord
a55bde077a
Core/Spells: updated all remaining shaman spell scripts to new register model
2021-05-26 15:44:28 +02:00