- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813) crit handling
Sniffs have shown that there is no energize spell being involved in the activation. Probably because the activate spell effect does not care about fully depleted runes so we now can slim it all down by alot
* all stats and values will now be set before summons are getting added to map
* cleaned up summon spell effect handler to reduce duplicade code
* summoner guids will no longer be set for every minion and correctly handle assigning creator guids instead. These values will serve as fallback guid if there is no summoner guid
* friendly tempsummons will now inherit the guild data of their player and pass them on to further allied summons. This fixes guild specific visuals for creatures such as Guild Battle Standards and Guild Heralds.
Todo: check for regressions
* Festering Strike will now increase the duration of Frost Fever and Blood Plague up to 6 seconds
* Diseases will now properly benefit from their mastery bonus
* Bloodshield Mastery will now stack with already existing Blood Shields up to 100% of the caster's maximum health
* updated Will of the Necropolis to 4.3.4
* update Crimson Scourge proc check
* silence proc console spam when using Improved Blood Presence
* fixed Unholy Command talent
* fixed Resilient Infection talent
* fixed Desecration casting range and make sure that it only procs against targets that are not immune to movement slowing effects