Commit Graph
1014 Commits
Author SHA1 Message Date
Shauren 74850abcfc Core/Loot: Skinning improvements
* Set skinnable flag only after all loot was taken
* Creatures are skinnable only once - after skinning, the player only has to loot the creature again if he did not take all skinning loot
2014-06-26 22:01:55 +02:00
Subv 8c944f1456 Core/Loot: Make the pickpocket loot refill every 10 minutes by default on the NPCs after they have been pickpocketed.
Configurable by Creature.PickPocketRefillDelay
Closes #935
2014-06-24 22:13:59 -05:00
Subv a0fedd1d78 Core/Skinning: Fixed the creatures becoming non-skinnable even before looting them completely.
Closes #5318
2014-06-24 20:04:26 -05:00
Trisjdc cac491bef8 Fix a warning picked by static code analysis (assignment of a temporary variable before destruction) 2014-06-25 01:03:24 +01:00
Aokromes 84e6af26e6 Merge pull request #11976 from Ascathor/master
Core/Misc: New ability to log account IP access history
2014-06-23 22:48:35 +02:00
Shauren ffcdcea13a Core/Players: Fixed Death Knight starting First Aid skill max value 2014-06-20 21:34:30 +02:00
Shauren fccdba3842 Core/Players: Fixed trainers still displaying profession skills after learning
Closes #8103
2014-06-19 15:30:07 +02:00
Ascathor 6949735098 Core/Misc:
* Fix some codestyle, fix some typos

* Change CMakeLists for: Custom (can be uncommented), Events, World
** Custom is theoretically unchanged. You can, however, uncomment the glob_recurse that initializes every file within. This might be easier for beginners.

* Introducing the IP Based Action Log System:
** On several different actions, e.g. Login, Character Login, etc., a new entry is added
** Can be logged on and off in worldserver config
*** Disabled by default to prevent increased log db size for unknowing users.

* Add a new row to account table called 'last_attempt_ip'
** Lists the last ip trying to connect to the account

* Add a new type of HookScripts: AccountScript
** Includes: OnAccountLogin, OnFailedAccountLogin, OnEmailChange, OnFailedChange, OnPasswordChange, OnFailedPasswordChange

* Added new Hook to PlayerScripts: OnFailedPlayerDelete

* Added new variables to PlayerScripts: OnPlayerDelete
2014-06-13 16:25:11 +02:00
Shauren 5804372042 Core/Transports: Fixed crash happening during teleporting transports
Closes #11793
2014-06-13 11:16:17 +02:00
Aokromes 9f4bab55ed Merge pull request #12046 from phoenixfight/fishmaster
Core/Fishing: Repair fishing spell result fish escape
2014-06-11 17:32:49 +02:00
phoenixfight ae46affe4e [core/database]Repair fishing spell result fish escape
edit fish junk sql formart

Optimized code, remove some useless brackets

fix default fish result ,just like Off the coast of Storm Peaks.

cleaned the sql part  thx Kinzcool

fix todo now
2014-06-10 11:07:15 +08:00
Trisjdc 0b3e391ac4 Merge pull request #11739 from Golrag/master
Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't
2014-06-09 00:53:28 +01:00
Vincent-Michael 1d39db16b9 Core/Misc: Kill Whitespace ... 2014-06-07 23:58:08 +02:00
Sebastian Valle Herrera 35b8874cca Merge pull request #12216 from Trisjdc/quest_item_check
Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests
2014-06-07 11:46:57 -05:00
Sebastian Valle Herrera 906abd7956 Merge pull request #12204 from Trisjdc/map_enter
Core/Maps: Allow logging players to enter in instances that have an encounter in progress
2014-06-07 11:46:37 -05:00
Trisjdc bb01c60a52 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-06 10:41:45 +01:00
Trisjdc 2a6d3fa67c Warning fix 2014-06-04 19:12:02 +01:00
Trisjdc 18868f5cbd Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-03 00:57:36 +01:00
Sebastian Valle Herrera f5e6292b48 Merge pull request #12032 from Trisjdc/haste_formula
Core/Players: Fix haste rating formulas
2014-06-02 17:23:16 -05:00
Ankso ab62fe30bc Core/Players: Update the player's zone and area after update the player's
position server side.
2014-05-30 17:18:52 +02:00
Trisjdc fd753a6105 Core/Players: Implement resting for areas with AREA_FLAG_REST_ZONE_ALLIANCE or AREA_FLAG_REST_ZONE_HORDE 2014-05-25 15:05:15 +01:00
jackpoz 1f78ff541a Merge pull request #12120 from Trisjdc/aura_exploit
Core/Auras: Solve exploit involving SPELL_AURA_MOD_DAMAGE_DONE and weapon swapping
2014-05-25 00:32:37 +02:00
jackpoz a4ba54fbdb Core/NetworkIO: Improve packet spam solution
Implement an improved packet Anti-DoS by counting how many times the same opcode has been sent in the last second and applying the policy specified in the configs if the amount of packets exceeds a reasonable amount.
Credits to the original author who decided to share this with TrinityCore team.
2014-05-24 22:34:06 +02:00
Trisjdc 51b782a91e Core/Auras: Solve exploit involving SPELL_AURA_MOD_DAMAGE_DONE and weapon swapping 2014-05-24 19:01:05 +01:00
jackpoz f091713086 Core/Misc: Fix typo
Fix typos about the word "Resurrect"
2014-05-24 18:25:53 +02:00
Shauren f9c7bb4171 Partially revert f296095191 "Fix various warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic."
Visual studio does not support constexpr
Made semicolon after "Prepare*Script" mandatory - workaround for dumb IDEs inserting extra indentation level after newline
2014-05-18 12:50:10 +02:00
Praetonus f296095191 Fix various warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic.
-Fix warnings from -Woverflow on implicit constant conversion.
-Fix warnings from -pedantic.
-Fix warnings from -pedantic.
-Fix warnings from -Wformat.

Two minor changes in addition :

-Replace a defined value equal to 2^31 - 1 by std::numeric_limits<int>::max().
-Remove useless null-check on pointer returned by new. New doesn't returns nullptr on failure, it throws std::bad_alloc.
2014-05-15 21:32:47 +02:00
Discover- 71795bf977 Core/Trade: It's no longer possible to fake the amount of gold put into the trade window. It's only visual but still an exploit, allowing scamming. 2014-05-09 17:58:04 +02:00
Trisjdc 0c0dc2fdb9 Core/Players: Fix haste rating formulas. They're supposed to be the addition, not the multiplication of all available bonuses
- This change matches client formulas
2014-05-08 13:42:55 +01:00
Aokromes d7b1405725 Merge pull request #11968 from Dehravor/cpp11
Core/Misc: Remove remaining COMPILER_HAS_CPP11_SUPPORT related macros
2014-05-03 19:25:36 +02:00
Vincent-Michael 0faf4b1b24 Core/Text: Fix typo in 5caf6aad98 2014-05-01 21:59:19 +02:00
Dehravor cbd36d5a4e Core/Misc: Remove remaining COMPILER_HAS_CPP11_SUPPORT related macros 2014-05-01 11:19:32 +02:00
Vincent-Michael 5caf6aad98 Core/Texts:
* Fix creautre text with gender female
* Small cleanUp
* ObjectMgr.cpp/ObjectMgr.h part from joschi
2014-04-30 22:15:28 +02:00
Dehravor 24ae6a6802 Core/Misc: Remove obsolete C++11 backward compatibility macros
OVERRIDE, FINAL, DELETE_MEMBER
2014-04-29 16:35:11 +02:00
Vincent-Michael ba8959b733 Core/MSVC: Remove double warning disables 2014-04-28 22:44:56 +02:00
Discover- 91c6c8a911 Merge pull request #11945 from Dehravor/trade
Core/Trade: Correction of distance checking
2014-04-27 12:32:32 +02:00
Vincent-Michael c81d6e9b4b Core/Texts:
* Enable some BroadcastTexts stuff (is not finish)
* Added reload command for broadcast_text table
ToDo:
- Enable: Sound/Emote stuff, etc.
- Auth base need refresh
2014-04-25 23:25:59 +02:00
jackpoz 2585e799f9 Core/Misc: Change how Position struct is retrieved
Update Position::GetPosition() and similar methods signatures to reflect 2a4c9bcaf9 changes by return a Position object instead of accepting a Position parameter by reference.
2014-04-25 21:19:30 +02:00
Dehravor 59a84951da Core/Trade: Correction of distance checking 2014-04-25 20:52:17 +02:00
jackpoz 9d1afbba57 Core/Player: Check Player race and class on login
Don't allow login for Players with bad race/class combination to avoid any further crash later.
2014-04-23 21:37:27 +02:00
jackpoz e830225b21 Core/Misc: Fix change faction on dead Night Elves keeping the speed buff
Fix change faction on dead Night Elves causing the new player keeping the 175% wisp speed buff.
Players will be resurrected automatically on change faction.
Closes #255
2014-04-20 15:02:19 +02:00
Vincent-Michael 89cc056a50 Fix 2014-04-18 17:02:04 +02:00
Дмитрий 5be05913e6 .cheat god should also affect on falling damage. 2014-04-08 14:40:16 +03:00
Shauren b949d0b982 Core/Misc: Defined a few fields in Map.dbc and rewritten InstanceMap::GetMaxPlayers to match what the client does to determine max players 2014-03-30 15:42:05 +02:00
Shauren 973888ea2c Core/Maps: Fixed incorrect difficulty markers shown on the interface inside Icecrown Citadel (always displaying normal mode) 2014-03-29 13:31:06 +01:00
Shauren 3fd6dd6175 Core/Loot
* Master Looter cannot freely loot items under threshold
* Update round robin looter only if loot is not empty
* Fixed loot bag icon appearing in raid frames when loot method was not Master Looter
* Fixed changing loot method reseting current round robin looter
2014-03-29 13:29:22 +01:00
Shauren dee867547d Merge pull request #11719 from Dehravor/master-loot
Core/Loot: Fix master loot
2014-03-29 13:24:48 +01:00
jackpoz 8c44259fae Core/Misc: Fix some static analysis issues
Fix uninitialized values, most of which are false positives, always initialized before being accessed.
Add some asserts and additional NULL checks as sanity checks. Use SpellMgr::EnsureSpellInfo() if the spell id is valid and always supposed to return a valid not-NULL SpellInfo* .
2014-03-27 21:43:59 +01:00
jackpoz 9e99db035f Core/Misc: Fix some static analysis issues
Add some asserts and additional NULL checks as sanity checks.
2014-03-21 22:47:58 +01:00
Golrag 53a03fc730 Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't 2014-03-18 08:07:08 +01:00