Commit Graph
100 Commits
Author SHA1 Message Date
ariel- c7e27dd511 Core/Unit: do not allow judgement spells to bypass damage immunity
3f19eea5e41fd47b571c17529e08d9f8caa91705 follow-up. Without the #16658 regression
2017-05-04 02:36:54 +01:00
ariel- 938f43302c Core/Entities: fix interaction of traps with ffa pvp and sanctuary flags 2017-05-04 02:34:25 +01:00
ariel- 6aac0c2073 Core/Entities: better support of absorb, resist and block procs 2017-05-04 02:25:01 +01:00
ariel- c62077237d Core/Spell: restore old proc system behaviour on auras self proc. 2017-05-04 02:21:58 +01:00
ariel- cb77d33cb9 Core/Spell: Added the possibility to explicitly disable auraEffect procs using attributes
- Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use
2017-05-04 02:16:50 +01:00
ariel- 39f5cfafc5 Core/Spell: spells with ignore hit result should pierce damage immunities 2017-05-04 02:16:30 +01:00
ariel- a6c7f2b98c Core/Spell: Fixed irregular handling of SPELLMOD_DOT 2017-05-04 02:15:54 +01:00
ariel- b7b69b88ba Core/Unit: damage immune improvements 2017-05-04 01:48:16 +01:00
ariel- 746cb97dce Core/Unit: don't use damage immunity to calculate hit result for the whole spell. Should be used only for damage 2017-05-04 01:45:58 +01:00
ariel- 045bf711c2 Core/Unit: improved handling of some spell attributes
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE
- SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE
- SPELL_ATTR3_IGNORE_HIT_RESULT
2017-05-04 01:44:49 +01:00
ariel- 679f5c51c5 Core/Spell: fix typos 2017-05-04 01:44:25 +01:00
ariel- 18a145e2c6 Core/Utils: build fix 2017-05-04 01:44:12 +01:00
ariel- 07a529726d Core/Globals: Load spellspecific and aurastate after loading spell ranks
Was breaking functionality (eg: stacking scroll auras)
2017-05-04 01:43:22 +01:00
ariel- 6ef6047b00 Core/Spell: Fixed immunities for some spells (they were broken before rewrite too)
- Warlord's Presence, Uncontrollable Frenzy, Free Friend
- Overload, Lightning Tendrils
- Fervor, Berserk
- Determination
2017-05-04 01:42:43 +01:00
ariel- b14b00da5c Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks 2017-05-04 01:41:35 +01:00
ariel- e6bdc58bf0 Core/Unit: misc codestyle
use typedef for constant reference
2017-05-04 01:37:04 +01:00
ariel- fcb7910533 Core/Spell: reimplemented TRIGGERED_DISALLOW_PROC_EVENTS trigger flag
Triggered spells shouldn't chain-trigger other spells

Closes #18217
2017-05-04 01:28:42 +01:00
ariel- fb6cde2730 Core/Entities: add yet another utility overload to CastSpell, fixes AppVeyor build
Ninja NULL->nullptr cleanup
2017-05-04 01:28:15 +01:00
ariel- f133041b80 Core/Spell: fix interaction of on taken damage procs with triggered casts
DB/Spell: Seal of Righteousness proc
- Lightining and Water Shield should proc with triggered

Closes #18211
2017-05-04 01:27:57 +01:00
ariel- 04b562418e Core/Spell: make a distinction between triggered flags with debugging purposes, and don't use them when casting triggered spells 2017-05-04 01:27:22 +01:00
ariel- 030224ff32 Core/Spells: do not add PROC_HIT_NORMAL/PROC_HIT_CRITICAL flags if damage is fully nullified
- Aka: full absorbs/full resists/full blocks/immune
2017-05-04 01:24:26 +01:00
ariel- c9101f6707 Core/Spells: workaround stealth interaction with Death and Decay and GameObject casts 2017-05-04 01:16:00 +01:00
ariel- e2fb7a8218 Core/Unit: send original caster in heal packet log 2017-05-04 01:13:27 +01:00
ariel- d1c915e4e1 Core/Spells: require phaseMask set for trap activation procs 2017-05-04 01:11:16 +01:00
ariel- c131f68f63 Core/Unit: allow pets and totems to drop mod charges in owner auras.
Needed for Cobra Strikes (re)implementation
2017-05-04 01:10:51 +01:00
ariel- 60b390a3e8 Core/Auras: allow damage from periodics to trigger auras if they're not fully resisted/absorbed 2017-05-04 01:08:39 +01:00
ariel- 759e19cee7 Core/Unit: CalculateMeleeDamage should use unmodified damage to compute HitInfo
d3a71a83387f757f87c7d27e1054498c8cc49c8f follow-up
2017-05-04 01:07:58 +01:00
ariel- 3d9c4fd3fc Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks 2017-05-04 01:07:05 +01:00
ariel- 8bf21ad927 Core/Unit: fix chain cc's not being diminished properly
Logic fail in 9b0fa51022fba3d5ece96dd0ac8399be01ea5b0f (now diminishing info is always initialized)
2017-05-04 01:01:44 +01:00
ariel- 21ac6296be Core/Spells: moved handling of SPELL_ATTR0_CU_DONT_BREAK_STEALTH inside proc system.
Fixes additional issues with spells that shouldn't be breaking stealth and had this attribute
2017-05-04 01:01:24 +01:00
ariel- b3eb7c121f Core/Unit: Change aura proc pair container to vector 2017-05-04 00:59:01 +01:00
ariel- 44a779ad38 Core/SpellMgr: some changes in default proc generation. Fix an issue of stealth breaking with positive and/or healing spells 2017-05-04 00:57:39 +01:00
ariel- 7ccd58615a Fix dynamic linking 2017-05-04 00:28:36 +01:00
ariel- 9b5c40a201 Mark Slice and Dice as positive 2017-05-04 00:25:18 +01:00
ariel- e0c8a379c8 Core/Spell: do not automatically set proc Family Name if no Family Flags present
Closes #18075
2017-05-04 00:21:36 +01:00
ariel- a47ee2ac5a Core/Spells: fix auto repeat spells triggering auras
Auto repeat spells are casted as triggered and didn't register procs properly if the aura can't proc with triggered
2017-05-04 00:21:13 +01:00
ariel- c71dc17135 Core/Auras: moved check for CC auras out of proc handler, and fixed its logic 2017-05-04 00:18:01 +01:00
ariel- a6b4f239a4 Add some DamageInfo null checks 2017-05-04 00:17:13 +01:00
ariel- 754c22d3d0 Core/Auras: prevent stack overflow while processing SPELL_EFFECT_ADD_EXTRA_ATTACKS 2017-05-04 00:14:02 +01:00
ariel- c6aa63536e Core/Unit: fix weapon skill up.
Closes #18044
2017-05-03 23:52:34 +01:00
ariel- a7a024d1d6 Core/Auras: reset periodic aura timers by default. Except when aura comes from triggered spell 2017-05-03 23:51:47 +01:00
ariel- 8f4fd78cbf Core/Scripts: add a workaround for Will of the Forsaken shared cooldown
Closes #7151
2017-05-03 23:45:58 +01:00
ariel- 805c10a365 Core/Spells: add proc cooldown on item equip. 2017-05-03 23:44:15 +01:00
ariel- 91c4b5edb0 Core/Scripts: add even more headers 2017-05-03 23:43:57 +01:00
ariel- 627a285a71 Core/Scripts: add more headers required for NoPCH 2017-05-03 23:43:45 +01:00
ariel- baf1f027c1 Core/Scripts: add headers required for NoPCH build 2017-05-03 23:39:34 +01:00
ariel- a40b85f8b2 Core/Scripts: convert some instance/item spells to scripts 2017-05-03 23:37:32 +01:00
ariel- 51f26dfe51 Core/Spells: Implementation of QAston proc system 2017-05-03 20:08:08 +01:00
ariel- f3246f835c Core/Scripts: remove OnDummyEffect hook/sOnDummyEffect ai hook
- Duplicated logic never used, sometimes only ScriptMgr version was called, sometimes only AI
- They only encourage bad scripting practices
- You can still use OnSpellHit or a SpellScript
2017-05-02 02:04:45 +02:00
ariel- 4e9ab055c9 DB/Spell: fix Glyph of Shadow proc
- Fixes not proccing with Imp. Devouring Plague/Mind Flay/Mind Sear
2017-04-28 12:58:53 +02:00
ariel- e53e8b8437 Core/AI: some tweaks on boundary functionality:
- Moved SetBoundary to public scope to allow for greater flexibility (ie set from external script)
- Extended to allow checking inverted boundaries
2017-04-26 13:08:01 +02:00
ariel- 8070e6ad29 Core/AI: added a function to allow 0 damage attacks (sparring) depending on target 2017-04-26 13:07:54 +02:00
ariel- 04466823e1 Core/Scripts: fix gaseous bloat proc (again)
- UNIT_STATE_CASTING removal not needed for movement now, but it's needed for melee attacking
2017-04-25 13:33:38 +02:00
ariel- c697a9de2e Core/Spell: don't make creature change orientation to 0 if channeling self 2017-04-25 13:31:11 +02:00
ariel- 8e16897073 Core/Spell: define channels without movement interrupt flags as allowed move
- Remove script hacks no longer needed
2017-04-25 13:30:58 +02:00
ariel- 2e27a1f64e Core/AI: prevent launching a new MoveChase if victim didn't change
Thanks ccrs for feedback :P
2017-04-25 13:30:44 +02:00
ariel- 469be111cd Core/Spell: implement pvp trinket immunity against Judgement of Justice
By Riztazz, closes #19484
2017-04-25 13:27:41 +02:00
ariel- e6580ad922 Core/Player: don't randomly change temporary spell status
- They shouldn't be saved in db
- Prevented temporary spell removal after a save

Closes #14373
2017-04-25 13:27:28 +02:00
ariel- 8b8bf5399d Revert "Core/Spell: don't set scaleAura for some special spells"
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.

Closes #19472
2017-04-25 13:22:41 +02:00
ariel- 3b718833c5 DB/Misc: populated version table with missing data from TDB file (again) 2017-04-20 20:01:05 +02:00
ariel- 8053766776 Core/Scripts: fix dereferencing invalid iterator
Closes #19464
2017-04-16 11:48:27 +02:00
ariel- a3538f4dbe Core/Auras: don't skip stack rule check whenever spells have same ID
- The auras might not have the same amounts due to spellmods

Closes #1626
2017-04-16 11:46:11 +02:00
ariel- dcdc9f25fa DB/Spell: Egg of mortal essence should proc with HoTs
Closes #19441
2017-04-14 13:50:34 +02:00
ariel- c17fa0bcc5 Core/Instance: stop updating the instance resettimes based on creature respawns 2017-04-14 13:50:13 +02:00
ariel- 0d6c2978ae Core/Creature: fix integer overflow in Creature::Update leading to endless thrashing of characters database
Closes #19182
2017-04-14 13:45:57 +02:00
ariel- ca900fe2b4 Core/Player: fix weapon dependent aura talents not applied on talent learn 2017-04-09 18:15:49 +02:00
ariel- 33b2ceefb1 Core/Auction: wrap item deletions from AHBot auction on a transaction
This speeds up the query execution time tremendously
Refs #19182
2017-04-09 18:11:45 +02:00
ariel- 30075e8575 Core/AHBot: fix price calc
- priceRatio is already a factor
2017-04-09 18:11:29 +02:00
ariel- a6ff258ace DB/Spells: remove some wrong spells from trainer tables
Refs #19394
2017-04-09 18:11:02 +02:00
ariel- 975ef8d8d9 Core/Spell: don't set scaleAura for some special spells
Closes #14541
2017-04-09 18:10:51 +02:00
ariel- 20af61b777 DB/Schema: add unsigned to some guid fields in characters 2017-04-09 18:06:54 +02:00
ariel- db582949b5 DB/Spell: fix Darkmoon Card: Berserker from proccing off everything 2017-04-09 18:00:00 +02:00
ariel- f7b50f51fc DB/Spell: Fix Living seed proc from non-damaging spells 2017-04-09 17:59:51 +02:00
ariel- 84cba8496c DB/Creature: fix regenerating health for vehicles in Wintergrasp and BGs
Closes #950
2017-04-01 07:11:46 +02:00
ariel- 66c0c634ad Core/AI: Build fix
- Stop exposing DoublePosition constructor versions, they're only used for internal representation
- Moved IsInBounds function to public scope
2017-04-01 07:06:53 +02:00
ariel- d3151fed8c Core/AI: AreaBoundary refactor
- Added an auxiliary function IsInBounds to base CreatureAI
- Changed container to vector. Set had no sense because we're storing new pointers, they have different addresses even if the boundary is the same
2017-04-01 07:06:35 +02:00
ariel- 661e150038 Core/Creature: added CREATURE_FLAG_EXTRA_GHOST_VISIBILITY to allowed db flags_extra mask
- Cleaned up the mask to be a much nicer enum definition
2017-04-01 07:06:12 +02:00
ariel- a3e41a3df6 Core/Global: reserve storage for script names vector 2017-04-01 07:06:02 +02:00
ariel- 402ad3dad7 Core/Auras: fix a deleted memory access crash
Closes #19319
2017-03-26 06:15:52 +02:00
ariel- 828101aa2b Core/Scripts: Updated Ulduar instance model
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)
2017-03-26 05:46:04 +02:00
ariel- d1382c5f23 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234
2017-03-20 16:55:01 +01:00
ariel- 2ce8cf4863 DB/Gameobject: add missing gameobjects to Zul'Aman
Taken from UDB
2017-03-20 16:54:53 +01:00
ariel- 35e9c27c4a Core/Entities: don't finalize movesplines before deleting.
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324
2017-03-20 16:53:54 +01:00
ariel- 5f7ac85dca Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319
2017-03-20 16:53:13 +01:00
ariel- cb8f052a65 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275
2017-03-20 16:45:17 +01:00
ariel- f2c7c5cf0c Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309
2017-03-20 16:45:09 +01:00
ariel- 045307cd6e Core/Auras: unregister AuraEffect from target list before changing amount, forces recalculation at stack change
Closes #19301
2017-03-15 23:37:08 +01:00
ariel- 7802e88ace Core/Auras: use vectors and remove HasEffect check
- Already checked in GetApplicationList
2017-03-15 23:36:56 +01:00
ariel- fc91921241 Core/Scripts: add condition check for npc_wyrmrest_defender
minor code refactors

Closes #19299
2017-03-15 23:36:36 +01:00
ariel- 553ae42111 Core/Creature: restore previous behavior of random gender on respawn
Little regression added with 253c0f3d07e05557daa3ffdd4e2a2af4256fb65e
2017-03-13 10:10:08 +01:00
ariel- 7871583016 Core/Auras: tidy up one little hack 2017-03-13 10:09:59 +01:00
ariel- d99739cd8c Core/Creature: remove some redundant code
- Display Ids are already initialized in InitEntry, no need to duplicate logic
- ModelInfo is already checked too
2017-03-13 10:09:33 +01:00
ariel- eb2526c8e2 Core/Auras: implement correct model for Bear Form (used by npcs)
Closes #7337
2017-03-13 10:09:16 +01:00
ariel- c3aaf501ab Core/Creature: don't override display id if addon tables load a morph aura
Ref #7337
2017-03-13 10:09:07 +01:00
ariel- 68c4606725 Core/Scripts: converted Argent Tournament pennants to AI
Closes #14616
2017-03-13 10:08:59 +01:00
ariel- d9c5065acc Core/Auras: Implement Roc form shapeshift
Closes #16164
2017-03-13 10:08:50 +01:00
ariel- 4a54bf7ab9 Core/Auras: make transform auras honor creature_template trigger flag and choose always invisible models
Closes #19211
2017-03-13 10:08:41 +01:00
ariel- 6d39a1db40 Core/Creatures: disabled "automatic" monster sparring
- Faction template flags weren't correct.

Closes #19245
2017-03-13 10:08:03 +01:00
ariel- 4602724be6 Core/SmartAI: Allow scripting GameObjects by spawn id too 2017-03-13 10:06:40 +01:00
ariel- 7fbe0cb1ae DB/Conditions: fix Sablemane's Sleeping Powder exploit 2017-03-13 10:05:26 +01:00