Commit Graph
100 Commits
Author SHA1 Message Date
Shauren b4adf3f5dd Core/Misc: Fixing warnings detected by Visual Studio 2015 compiler
(cherry picked from commit a22e4e121a1e54b2f4154d59623ee4a94a449176)

Conflicts:
	cmake/compiler/msvc/settings.cmake
	src/server/game/DataStores/DBCStores.cpp
	src/server/game/Entities/GameObject/GameObject.cpp
	src/server/game/Entities/Object/Object.cpp
	src/server/game/Entities/Object/Object.h
	src/server/game/Entities/Pet/Pet.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Garrison/Garrison.cpp
	src/server/game/Garrison/GarrisonMgr.cpp
	src/server/game/Globals/ObjectMgr.cpp
	src/server/game/Globals/ObjectMgr.h
	src/server/game/Guilds/GuildMgr.cpp
	src/server/game/Handlers/CharacterHandler.cpp
	src/server/game/Handlers/QueryHandler.cpp
	src/server/game/Handlers/QuestHandler.cpp
	src/server/game/Handlers/SpellHandler.cpp
	src/server/game/Server/Packets/ChannelPackets.h
	src/server/game/Server/Packets/PartyPackets.cpp
	src/server/game/Server/WorldSession.h
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellInfo.cpp
	src/server/game/Spells/SpellScript.cpp
	src/server/scripts/Commands/cs_list.cpp
2015-07-24 11:51:48 +01:00
Shauren f880f2e778 Core/Threading: Clarified comment on ProducerConsumerQueue::WaitAndPop
(cherry picked from commit 08316552b5b176e8209d7e8f15c53053d049743d)
2015-07-19 00:48:17 +01:00
Shauren 23e4472d14 Core/PacketIO: Removed timezone adjustments from ReadPackedTime - player's session timezone offset should be used there, not server offset
(cherry picked from commit aa3b05c312626d903228aa7a768a069bce5fe526)
2015-07-06 22:25:34 +01:00
Shauren efad3a3123 Core/Spells: Implemented CAST_FLAG_IMMUNITY 2015-06-30 11:44:11 +02:00
Shauren 2538a84d0c Core/Units: Changed SPELL_AURA_MOD_MINIMUM_SPEED to always be applied, not only if under a slow aura (SPELL_AURA_MOD_MINIMUM_SPEED can set the minimum speed higher than base speed)
(cherry picked from commit d2142ac380863716ecea6f4aa44f7e556e44dfd9)
2015-06-26 01:26:22 +01:00
Shauren 5fe819462f Core/GameObject: Removed unneeded argument from GameObjectModel::Relocate and renamed it to UpdatePosition
(cherry picked from commit 6e9ab38fcc9d2859393e452ef8630ee420783e47)
2015-06-26 00:53:12 +01:00
Shauren d04c9d55ac Scripts/Zul'farrak: Fixed summoning Gahz'rilla
Fixes #5782 regression

(cherry picked from commit cec05ff07d1751649b6eecff07f23f52ca5443cd)
2015-06-19 17:29:09 +02:00
Shauren 9ecef15057 Core/Auth: Fixed authserver not shutting down correctly when started as windows service 2015-06-10 00:22:34 +02:00
Shauren ee4ace8c34 Core/Auth: Implemented starting authserver as a windows service 2015-06-06 13:04:31 +02:00
Shauren b239cadf41 Core/Misc: Removed some old unused enums
(cherry picked from commit 2f0c293266837eca217d2bff1df8b78ac6e12867)
2015-06-01 00:41:54 +01:00
Shauren 79dd72ae70 Buildsystem: Removed handling for -DPREFIX shortcut for -DCMAKE_INSTALL_PREFIX cmake option, it an internal cmake variable since version 3.2
(cherry picked from commit 1987d3187d1f14cf6dfcaf4f63861db806ad06cc)
2015-06-01 00:35:02 +01:00
Shauren 1f076a395f Scripts/Icecrown Citadel: Fixed Ice Tomb during phase 3 of Sindragosa encounter
(cherry picked from commit f85605b5f78f73c53a56874161155416b64ec078)
2015-05-21 00:03:11 +02:00
Shauren ba9e0de36d Core/Misc: Removed gcc specific packing pragma syntax - only unsupported (now) versions required it
(cherry picked from commit 4c7c2abf03b692e67a89d2ba0856aec1553c8ae1)

Conflicts:
	src/server/bnetserver/Packets/BitStream.h
	src/server/shared/Common.h
2015-05-19 21:47:48 +01:00
Shauren 8a013ba0fb Core/Misc: Moved Position to its own file
(cherry picked from commit 48ee1f003347910a48183f768501c1080fc40269)

Conflicts:
	src/server/game/Entities/Object/Object.cpp
	src/server/game/Entities/Object/Object.h
	src/server/game/Spells/Spell.cpp
2015-05-19 21:44:39 +01:00
Shauren 8c61e51fe5 Core/Transports: Moved teleporting transports to Map::DelayedUpdate
(cherry picked from commit 5c5cb3e555da279b45ccff19b5ab4fc2656c75e2)
2015-05-19 11:12:14 +01:00
Shauren 970d7abf97 Core/Networking: Fixed possible msvc debug assertions in vector
(cherry picked from commit e4abbc09266d5878d0a03b04f3d72ea68549997f)
2015-05-19 11:12:03 +01:00
Shauren 88af3ffc2a Core/Socket: Removed unused synchronous read method
(cherry picked from commit 59e9bcf0bf44d89397f5a182e2ef21f7e3a3635d)

Conflicts:
	src/server/game/Server/WorldSocket.cpp
2015-04-29 00:06:19 +01:00
Shauren 8b07f1cd4d Core/GameObjects: Removed the possibility to spawn transports wih gm commands (such objects did not have any transport mechanics but could still cause crashes)
Closes #14542

(cherry picked from commit 149ff8da879a8286a01081d4ffb1f200a67ddefd)

Conflicts:
	src/server/game/Entities/GameObject/GameObject.cpp
	src/server/game/Entities/GameObject/GameObject.h
	src/server/game/Globals/ObjectMgr.cpp
2015-04-29 00:05:47 +01:00
Shauren be4b48ecaa Core/Corpses: Fixed corpses loaded from database not being visible after server restart 2015-04-27 17:25:27 +02:00
Shauren 2268f07a5f Buildsystem: Updated FindBoost macro, now finds versions 1.57 and 1.58 as well
(cherry picked from commit 5acc4b14aa81a5e9a946d11cfa9034d334ea7144)

Conflicts:
	cmake/macros/FindBoost.cmake

Signed-off-by: Naios <naios-dev@live.de>
2015-04-27 16:45:18 +02:00
Shauren ea214c223e Core/Misc: Ported relevant barbershop fixes from 4208c0d8396e10dc806939e1d17885d16ff7b84e 2015-04-24 18:40:19 +02:00
Shauren 96b7b7ced5 Build fix for GCC 4.7
(cherry picked from commit e7deae947c94eab04370b5bdaab059ac425d697d)
2015-04-05 13:57:45 +02:00
Shauren 62a3edb84a Core/Misc: Warning fixes
(cherry picked from commit cc4d79495f98006f77c68792b946a412f5e86714)

Partial cherry-picked.

Signed-off-by: Naios <naios-dev@live.de>
2015-04-05 01:20:11 +02:00
Shauren 548aa119ac Core/Networking: Fixed unsafe access to _worldSession member in WorldSocket
(cherry picked from commit bed88e0dd475af5b73cea03821f7fb7cb9ddce9d)

Core/Networking: Fixed deadlock in HandlePing if the client is about to be kicked for overspeed pings

(cherry picked from commit 3da0f7e40920b652d2222fa88dbb4b516d24725d)

Core/Networking: Cleanup CloseSocket calls from read failures in WorldSocket

(cherry picked from commit 18343a7309fbf53a3509749c0a5ca1f8ea273c57)

Conflicts:
	src/server/game/Server/WorldSocket.cpp

Ref #14474
2015-04-04 23:07:41 +01:00
Shauren 8bdd94f849 Core/DBUpdater: Fixed compile errors with boost 1.55 and VS 2013
(cherry picked from commit 495af75b7e21a2a84231b0540a6f2b9ed349ea58)
2015-03-22 00:35:05 +01:00
Shauren bba8555a29 Build fix 2015-03-18 11:47:30 +01:00
Shauren a23ad2b33c Core/Auras: Fixed possible crash in Aura::RefreshDuration - Aura::GetCaster can return NULL
(cherry picked from commit 8cd1c9514f336da3d3d9436be554fc80edb6e761)

Conflicts:
	src/server/game/Spells/Auras/SpellAuras.cpp
2015-03-15 12:57:08 +00:00
Shauren e52b46abba Core/Crypto: Fixed output of BigNumber::AsByteArray when generated array is shorter than requested size 2015-03-01 14:16:16 +01:00
Shauren 869bc4e0f7 Buildsystem/Genrev: Fixed revision generator not reading existing cmake cache variables 2015-02-24 18:51:46 +01:00
Shauren a46d201723 Core/Spells: Renamed SPELL_ATTR4_TRIGGERED to SPELL_ATTR4_CAN_CAST_WHILE_CASTING and adjusted trigger flags accordingly
(cherry picked from commit 6d70acbbd66959f7b6896a19ce3f2a25ccf94f2e)

Conflicts:
	src/server/game/Spells/Spell.cpp
2015-01-31 20:16:21 +00:00
Shauren 9ee820d83d Core/Players: Fixed loading and saving skill data PK violations
(cherry picked from commit 2dfd1594cd3cc7fdba4131d2e825885cac2bcc17)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
2015-01-31 20:14:15 +00:00
Shauren 67f9d916cb Build: Fixed game & collision depending on each other for linking 2014-10-09 23:01:31 +02:00
Shauren 2e455eee86 Core/Entities: Removed the possibility to teleport non-player objects to different maps 2014-10-08 20:24:55 +02:00
Shauren b781a4dc33 Core/Logging: Replaced direct calls to GetCounter() in logs with ToString() 2014-10-08 17:59:27 +02:00
Shauren 04b6f9111a Fixed ==25829== Thread #1: pthread_cond_{signal,broadcast}: dubious: associated lock is not held by any thread
==25829== at 0x4C2A1D5: pthread_cond_broadcast_WRK (hg_intercepts.c:891)
==25829== by 0x654A758: std::condition_variable::notify_all() (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.17)
==25829== by 0x132305A: ProducerConsumerQueue<SQLOperation*>::Cancel() (ProducerConsumerQueue.h:100)
==25829== by 0x13229A7: DatabaseWorkerPool<WorldDatabaseConnection>::~DatabaseWorkerPool() (DatabaseWorkerPool.h:70)
==25829== by 0x6C6CB21: __run_exit_handlers (exit.c:78)
==25829== by 0x6C6CB74: exit (exit.c:100)
==25829== by 0x6C54EF3: (below main) (libc-start.c:276)
2014-10-02 20:09:08 +02:00
Shauren 0781d29657 Core/GameObjects: Fixed uninitialized elevator period value 2014-09-28 21:04:18 +02:00
Shauren 48b7e0c60c Buildsystem/MSVC: Removed /SAFESEH linker option from x86 debug builds as it doesn't make sense in debug builds and interferes with Edit and Continue
Closes #13233
2014-09-28 12:03:34 +02:00
Shauren 42177d9f2c Fixed GCC build 2014-09-27 10:56:22 +02:00
Shauren 605d51533c Core/Spells: Always add threat for spells from spell_threat table, not only if target was hit. Unsuccessful cast results in 0 threat added instead of the full amount and creating threat list entry for caster. This fixes various exploits with taunt spells bugging out scripts due to taunt immunity/passive state (creatures would immediately evade resetting script state if no entries were present on threat list - entry with no threat is not the same as no entry)
Closes #11883
2014-09-26 22:26:51 +02:00
Shauren 07f47a4b91 Scripts: Fixed compiler warning 2014-09-26 20:48:10 +02:00
Shauren 71644043d2 Core/Debugging: Extended ASSERT macro to allow passing additional formatted string 2014-09-26 20:47:48 +02:00
Shauren ea4dd2c8f4 Scripts/Icecrown Citadel
* Fixed Deathbringer Saurfang faction
* Fixed Coldflame faction
2014-09-25 21:15:20 +02:00
Shauren d87c23cdaf Core/Achievements: Fixed realm first kill achievement restrictions - now only the first group will be able to complete it
Closes #2957
2014-09-20 19:07:39 +02:00
Shauren 16ecf9ec5d Core/Guilds: Fixed guild rank delete framexml event params 2014-09-20 10:47:14 +02:00
Shauren 31656c0213 Core/Trade: Fixed enchanting soulbound items in trade
Closes #12850
2014-09-18 21:15:39 +02:00
Shauren e57a63939e Core/NetworkIO: Fixed queued packets not being properly sent causing players to be stuck during loading
Closes #13120
2014-09-17 23:06:34 +02:00
Shauren 7d1d55124c Merge branch 'ObjectGuid' of https://github.com/TrinityCore/TrinityCore
Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
	src/server/game/Scripting/MapScripts.cpp
	src/server/scripts/Northrend/Naxxramas/instance_naxxramas.cpp
	src/server/scripts/Northrend/Nexus/EyeOfEternity/instance_eye_of_eternity.cpp
	src/server/scripts/Northrend/Nexus/Nexus/boss_anomalus.cpp
	src/server/scripts/Northrend/Nexus/Nexus/boss_magus_telestra.cpp
	src/server/scripts/Northrend/Nexus/Oculus/boss_varos.cpp
	src/server/scripts/Northrend/Ulduar/HallsOfStone/halls_of_stone.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_auriaya.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_freya.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_hodir.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_ignis.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_razorscale.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_svala.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_ymiron.cpp
2014-09-16 21:50:01 +02:00
Shauren 9b933b4a29 Core/Misc: Removed explicit qualifier from ObjectGuid uint64 conversion operator 2014-09-16 20:57:11 +02:00
Shauren 878073d516 Core/Logging: Fixed incorrect usage of guid in logs 2014-09-16 20:47:08 +02:00
Shauren bee9a3069b Core/Scripts: Fixed incorrect guid usage in logs 2014-09-16 19:56:33 +02:00
Shauren 6c1a33d62d Core/Scripts: Fixed incorrect guid usage in logs 2014-09-16 19:47:10 +02:00
Shauren 9b316fe689 Core/Scripts: Fixed PCH build 2014-09-16 00:44:56 +02:00
Shauren 5ac62d9ca3 Core/Scripts: Fixed build zone_* scripts 2014-09-15 23:57:03 +02:00
Shauren 48deb443f9 Core/Scripts: Fixed build of misc scripts, only zone_* and instance_* remain 2014-09-15 22:52:09 +02:00
Shauren a3d8f1d879 Core/Scripts: Fixed build of boss_* scripts 2014-09-15 22:07:11 +02:00
Shauren 6ce0a3107d Core/Scripts: Changed GetGUID/SetGUID script hooks to operate on ObjectGuid class
Fixed compile for boss scripts starting with letters B, C and D
2014-09-15 00:23:47 +02:00
Shauren 56f46e3ce5 Scripts
* Introduced GetGuidData/SetGuidData to store guids in instance scripts (GetData64/SetData64 are still there)
* CONDITION_INSTANCE_INFO: Changed existing DATA64 condition to GUID_DATA to preserve current use of this instance info type (most/all assume the data is a guid) and moved DATA64 to a different value - no db changes needed
* Fixed compile in boss scripts starting with letter A
2014-09-14 23:23:23 +02:00
Shauren d72c4085de Core/Misc: Fixed build without pch 2014-09-14 17:29:13 +02:00
Shauren 2a1a294383 Scripts/Commands: Fixed build with -DSCRIPTS=0 2014-09-14 16:54:21 +02:00
Shauren a0e50ea35f Core/Entities: Use ObjectGuid class in game project 2014-09-14 16:14:12 +02:00
Shauren ce67a097bf Core/Entities: Use new PackedGuid class 2014-09-13 01:12:16 +02:00
Shauren 2fc52b5af6 Core/Entities: Added ObjectGuid class from MaNGOS 2014-09-12 23:49:30 +02:00
Shauren b3f7210f4d Core/WorldSocket: Refactored client packet header check 2014-09-12 20:25:13 +02:00
Shauren 8f5ae1fb90 Core/Misc: Added const modifier to MessageBuffer::Write parameter 2014-09-12 20:20:35 +02:00
Shauren 6dff6b7425 Core/NetworkIO: Set non blocking mode on sockets properly 2014-09-12 19:34:26 +02:00
Shauren 5f62f1b6d2 Core/Misc: Fixed build with intel compiler 2014-09-10 21:18:28 +02:00
Shauren 946e2d0ca6 Core/Authserver: Added missing auth socket manager
Closes #13085
2014-09-10 21:17:55 +02:00
Shauren 0c40ca8574 Build fix 2014-09-09 21:32:21 +02:00
Shauren e0ce4528c5 Core/NetworkIO: Use reactor style sending on linux to reduce locking overhead 2014-09-09 19:19:25 +02:00
Shauren d5e945eec8 Core/Misc: Named an unknown creature type flag 2014-09-08 00:19:02 +02:00
Shauren 183d7f5da9 SQL: Renamed file to follow standards 2014-09-08 00:18:10 +02:00
Shauren 9ab74b3910 Core/DBLayer: Fixed GetUInt32,GetInt64 and GetUInt64 on windows when value stored in db was greater than 2147483647 2014-09-06 22:58:29 +02:00
Shauren f5115328c5 Merge pull request #12970 from Golrag/marrowgar
Scripts/ICC: Fixed Impale (Lord Marrowgar)
2014-08-29 21:12:17 +02:00
Shauren febb26d4b7 Core/Deps: MySQL sources out.
Windows users are now required to download and install mysql server with headers and libraries
2014-08-26 18:45:54 +02:00
Shauren abfd29ab61 Core/WorldSession: Added research notes about CMSG_AUTH_SESSION values and reordered checks during login to always initialize encryption first to make sure the client can read failure packet 2014-08-21 18:18:13 +02:00
Shauren 36e32cc242 Core/NetworkIO: Restored opcode and size checks lost during ace->boost changes, fixes crashes caused by players sending invalid opcodes/too big packets 2014-08-19 19:32:06 +02:00
Shauren 01b754ccc5 Merge pull request #12882 from cemak/exploit_arena
Core/Arena: Fix exploit on delete member with team during fights.
2014-08-19 19:02:55 +02:00
Shauren 7cb72c2aac Core/DBLayer: Fixed an incredibly rare memory leak happening when player started loading from database and never finished 2014-08-16 01:43:42 +02:00
Shauren 5c60976046 Core/Transports: Delayed adding transport model to next tick after teleporting to fix race conditions happening when teleporting transport happens at the same time as destination map balances its dynamic LoS tree 2014-08-16 01:06:30 +02:00
Shauren acfaf2d182 Core/Misc: Fixed loading trinity_string 2014-08-15 20:01:58 +02:00
Shauren aab4ab166d Core/Socket: Added helpers to retrieve the size of currently ready data 2014-08-15 18:43:17 +02:00
Shauren 2fdc4723c2 Core/Misc: Optimized locale loading 2014-08-15 11:36:11 +02:00
Shauren bd4edf6e22 Core/Threading: Fixed possible race condition with m_timeOutTime and fixed Thread #1: pthread_cond_{signal,broadcast}: dubious: associated lock is not held by any thread in PCQ 2014-08-12 18:18:52 +02:00
Shauren c741d2682a Core/NetworkIO: Prevent queueing more async operations when socket is already closed 2014-08-11 20:43:07 +02:00
Shauren 730ca4d9e0 Merge pull request #12818 from MrSmite/pet_spell_cooldown
Fix pet spell cooldown
2014-08-11 09:02:58 +02:00
Shauren f5bf13295c Core/NetworkIO: Prevent double closing the same socket 2014-08-10 21:32:57 +02:00
Shauren 99e36e923f Core/Misc: Removed ACE leftovers 2014-08-10 12:09:26 +02:00
Shauren 4fe45b8c63 Core/Worldserver: Replaced old hack sending key events to unblock console thread 2014-08-10 11:50:19 +02:00
Shauren 39d3480172 Core/Authserver: Fixed writing to invalid memory address 2014-08-10 11:48:43 +02:00
Shauren df11916ad5 Core/NetworkIO: Allow receiving packets bigger than buffer size and properly handle situations where not entire packet was read in one go
Core/Authserver: Restored authenticator functionality
2014-08-10 11:00:27 +02:00
Shauren d830890305 Core/Trade: Fixed putting soulbound items to "will not be traded" slot 2014-08-09 10:08:53 +02:00
Shauren 936db9d50d Core/NetworkIO: Handle exceptions thrown from socket constructor when retrieving remote address 2014-08-08 14:01:09 +02:00
Shauren 7d97b4b841 Core/Misc: Fixed textlike/hexlike methods of ByteBuffer to print properly 2014-08-06 10:00:23 +02:00
Shauren d3c6a03c3b Delete 2014_08_03_03_world_creature_template_sql
This must come together with proper damage calculations in core - to be done
2014-08-04 23:53:27 +02:00
Shauren e4d6d34f6e Core/Spells: Fixed LoS checks for spells like shadowfury 2014-08-04 18:56:17 +02:00
Shauren 58ecb73674 Core/Trade: Replaced SendNotification hacks with proper trade packets 2014-08-01 22:06:33 +02:00
Shauren 45e9ef3d93 Core/Loot: Fixed pickpocket refill timer and use send proper loot error packets to master looter 2014-07-31 21:41:41 +02:00
Shauren daecbd67e8 Core/Waypoints: Fixed memory leaks happening when loading waypoints with invalid move_type 2014-07-31 20:28:32 +02:00
Shauren d46c3bf877 Core/Authserver: Fixed invalid memory access when AsByteArray returns less bytes than expected 2014-07-29 18:26:10 +02:00
Shauren 7d4514c447 Core/Chat: Restored split alliance and horde chat channels
Closes #12664
2014-07-29 17:19:20 +02:00