Commit Graph
18235 Commits
Author SHA1 Message Date
jackpoz f1f4005ad8 Core/Quest: Fix issues reported by static analysis 2015-12-06 21:37:58 +01:00
Killyana e60bbaa7d3 DB/Quest: Great Bear Spirit
Closes #15950
2015-12-06 20:04:13 +01:00
ShinDarth 03215a2eb7 Core/Spell: fixed possible exploit in Duel Reset script
- thanks @Runico for reporting it
2015-12-06 03:44:12 +01:00
MitchesD ab831507c6 Core/Conditions: extended CONDITION_NEAR_CREATURE, condition value 3 is now used to check for dead creature entries (0 - alive, 1 - dead)
* I used 0 for alive to avoid touching all conditions with this type

(cherry picked from commit cdb5bd3eb78ea40fbd927c5662e1dad778bf12d5)
2015-12-03 21:41:03 +01:00
Shauren 94e4bddb90 Scripts/Icecrown Citadel: Professor Putricide - fixed Expunged Gas damage formula
Closes #6396
2015-12-01 19:27:17 +01:00
MitchesD 3b1f5f29c9 Merge pull request #15864 from tkrokli/hallowed_wands
Scripts/Spells: Hallow's End item Hallowed Wand
2015-12-01 15:05:15 +01:00
jackpoz c703e01471 Merge pull request #15920 from Treeston/3.3.5-MCHotkeyPos
Unit/PossessBar: Fix spell ordering on possess bar
2015-11-30 20:24:15 +01:00
treeston 1be635a025 Unit/PossessBar: Fix spell ordering on possess bar to reflect spell position in DB. Fixes Razuvious adds et al. 2015-11-29 18:41:36 +01:00
Shauren 3ab108c8ea Core/Spells: Fixed passibe talent auras targeting pets instead of player
Closes #1543
Closes #15918
2015-11-29 14:13:30 +01:00
jackpoz c1b4cd21f3 Merge pull request #15912 from Treeston/3.3.5-urandms
Core/Util: Add urandms(minMS, maxMS) helper
2015-11-29 00:07:35 +01:00
treeston c0faee0795 Core/Util: Add a urandms(min,max) helper to make urand(min*IN_MILLISECONDS, max*IN_MILLISECONDS) shorter to write for random time intervals (boss scripts). 2015-11-28 23:53:04 +01:00
jackpoz f8a3fa28bb Merge pull request #15907 from ShinDarth/fix
Core/Spells: Fix Arcane Missiles
2015-11-28 21:55:45 +01:00
jackpoz a67f378f10 Merge pull request #15904 from 'ForesterDev/instance_login_cleanup' 2015-11-28 21:45:41 +01:00
ShinDarth 5fae63804c Core/Spells fix Arcane Missiles
- close #15902
2015-11-28 00:23:34 +01:00
Vincent-Michael e266278f7d Core/Players: Fixed warning 2015-11-27 22:10:21 +01:00
Shauren ba1e00399d Core/Players: Use constant gender from PLAYER_BYTES_3 where appropriate.
Closes #15895
2015-11-27 18:30:01 +01:00
ForesterDev 9573ec52f0 Core/Player: cleanup function CheckInstanceLoginValid 2015-11-27 12:53:48 +04:00
tkrokli 66073e4403 Core/Scripts: remove redundant script npc_anchorite_truuen
The cpp script npc_anchorite_truuen has become redundant
because it has been replaced by a SAI script in commit 2cecc7b.

This script currently causes an error line in DBErrors.log:
```
Script named 'npc_anchorite_truuen' does not have a script name assigned in database.
```
2015-11-27 04:02:30 +01:00
jackpoz 5f917e2286 Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.
2015-11-26 21:54:22 +01:00
jackpoz 6e296ddaa2 Scripts/EyeOfEternity: Fix crash
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900
2015-11-26 21:47:50 +01:00
MitchesD 3b90b0368a Core/Misc: fix warning and misc codestyle fixes 2015-11-26 19:28:53 +01:00
treeston bf99630399 Scripts/Naxxramas: Thaddius follow-up:
- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)
2015-11-26 18:57:15 +01:00
jackpoz 981b871d2f Tools/MMapGenerator: Fix an edge case of infinite loop
Fix a (pseudo) infinite loop happening when generating mmaps for single tile maps (like 249) but with vmaps not present in the correct folder. This would trigger a 18446744065119600000 (uint32 max ^ 2) iterations loop.
2015-11-25 21:49:27 +01:00
Shauren e9bd786351 Merge pull request #15763 from ShinDarth/channeled
[3.3.5] Fix conflicts between duration and cast time of channeled spells
2015-11-25 18:31:33 +01:00
ShinDarth 246e568bbd Core/Spells: fix conflicts between duration and cast time of channeled spells 2015-11-25 18:21:52 +01:00
Carbenium 49a16c9fd0 Tools/MMapGenerator: Fix some warnings reported by GCC 4.9 and MSVC 14 with W4
* /var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/mmaps_generator/MapBuilder.cpp: In member function ‘void MMAP::MapBuilder::WorkerThread()’:
  /var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/mmaps_generator/MapBuilder.cpp:174:28: error: ‘mapId’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
               buildMap(mapId);

* variable redefinition warning
* remove 2 "using namespace std"

*NO reextraction of mmaps needed*
2015-11-25 12:50:28 +01:00
Carbenium f0c7061f0b Tools/MapExtractor: Fix a warning reported by gcc 4.9
/var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/map_extractor/System.cpp:113:25: error: ignoring return value of ‘int chdir(const char*)’, declared with attribute warn_unused_result [-Werror=unused-result]
             chdir("../");

*NO reextraction of dbcs/maps needed*
Binary compatibility is ensured
2015-11-24 11:37:45 +01:00
sirikfoll 5d155895a7 Core/Creature: Flying vehicles able to fly again
by @sirikfoll, closes #15861

Flying vehicles could no longer leave the ground after commit 52692c3.
This is a modification of commit 52692c3 to make flying vehicles work again.
2015-11-22 17:14:58 +01:00
jackpoz 1511855fea Merge PR #14824 'tkrokli/spell_mod_stealth_stand_state' into 3.3.5 2015-11-22 15:37:32 +01:00
jackpoz 0e9f714a09 Core/Items: Fix crash
Fix crash happening if item_template.StatsCount field in the database was higher than 10.
Fixes #15868
2015-11-19 20:23:09 +01:00
Shauren f012800751 Core/Spells: Fixed typo in ecbbcc8972 2015-11-17 17:51:09 +01:00
DevRival 3fdbcf18ae Scripts/Spells: Hallow's End item Hallowed Wand
Hallowed Wand items should cast a transformation on party members.

by @DevRival, closes  #3574

Before this patch, the following spells do not have any effect at all:
- 24717, Pirate Costume
- 24718, Ninja Costume
- 24719, Leper Gnome Costume
- 24720, Random Costume
- 24737, Ghost Costume

Details from testing on the current 3.3.5 branch (commit ecbbcc8):
- 24724 (Skeleton Costume) seems to work as intended
- 24733 (Bat Costume) only lasts 10 seconds instead of 60 minutes
- 24741 (Wisp Costume) also seems to work as intended

All the spells listed above are included in this PR.
2015-11-17 17:24:25 +01:00
Shauren 071ede8a93 Core/Misc: Fixed memory leak in trade handler
(cherry picked from commit fc852181c578e2ab8644bebfef13199a7897ebe9)

CID 1339313
CID 1339312
2015-11-16 00:11:50 +01:00
jackpoz fbaed38b5e Core/Quest: Fix issues reported by static analysis
Coverity defect IDs: 1339309, 1339310
2015-11-15 16:17:12 +01:00
jackpoz 63f2675076 Core/Player: Fix issue reported by static analysis
Coverity defect IDs: 1010154
2015-11-15 16:01:14 +01:00
Shauren ecbbcc8972 Core/Spells: Fixed Raise Dead cooldown
Closes #15862
2015-11-15 00:31:17 +01:00
Carbenium f01ef901ef Script/Naxxramas: Fix a -Winconsistent-missing-override warning reported by clang 3.6 2015-11-14 19:48:05 +01:00
Vincent-Michael 145b0b27da Core/Battleground: Fix issue reported by static analysis
Coverity defect ID: 1339311
2015-11-14 18:26:20 +01:00
Naios 1ce5a62feb Core/Worldserver: Enable the database updater by default.
* Seems like this feature is stable enough to enable it by default
  since the last missing bugs were fixed some months ago.
* The database updater is the preferred method to update the databases
  as described in the wiki: http://collab.kpsn.org/display/tc/Databases+Installation

(cherry picked from commit 25185967e8df949e0f13ec0a7ff45b14ba977c76)
2015-11-14 17:08:01 +01:00
Carbenium b292321798 Core/Player: Move KillRewarder to its own file
(cherry picked from commit 4e76974ce5ba3f6ebd73d6dd96860b60d50a19f4)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
2015-11-14 15:06:47 +01:00
Shauren 7631ec444e Core/DBLayer: Improve error message from 0a27f8bce264b8f6d8c55efa8ebc97f6e9cb7d11
(cherry picked from commit d31706b07e5e4a4d632f5deea7076e864b467bbe)
2015-11-14 13:54:36 +01:00
Carbenium 1438c841ed Core/Player: Move TradeData to its own file
(cherry picked from commit 2d7d6f505c6e4e08b5fbbd0bc88b46753191c7aa)

Conflicts:
	src/server/game/Entities/Item/Item.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
	src/server/game/Handlers/TradeHandler.cpp
	src/server/game/Spells/Spell.cpp
2015-11-14 13:40:32 +01:00
tkrokli 95d6f09243 Scripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)
Coverity scan defects CID 1339315, 1339316 and 1339317:
- CID 1339315: boss_thaddius.cpp: 542
- CID 1339316: boss_thaddius.cpp: 811
- CID 1339317: boss_thaddius.cpp: 398

Added missing break; statements.
2015-11-14 05:12:25 +01:00
Vincent-Michael d0c28c66eb Core: Fix warning 2015-11-14 01:23:28 +01:00
Vincent-Michael d188960216 Core/Condition: Fix issue reported by static analysis
Coverity defect ID: 1339314
2015-11-14 00:56:44 +01:00
Vincent-Michael 2ee01a7b3d Core: Fix non pch build 2015-11-13 20:19:16 +01:00
Shauren 536365a70f Fix build for mysql versions older than 5.7
(cherry picked from commit 5604aed5f130a48a660fa2a2f957489f6a3024ea)
2015-11-13 09:28:14 +01:00
MitchesD e14e291ef6 Merge pull request #15523 from Treeston/3.3.5-thaddius
Scripts/Naxxramas: Thaddius: Complete rewrite
2015-11-12 19:46:46 +01:00
MitchesD a1150ce20f Merge pull request #15732 from ShinDarth/reset-health-mana
Scripts/Duel: implement duel reset of health and mana and improve duel reset
2015-11-12 19:40:26 +01:00
Shauren 9bc5088a81 Core/DBLayer: Ensure that MySQL version used when compiling is the same as libmysql.dll version used for running the server.
Ref #15848

(cherry picked from commit 0a27f8bce264b8f6d8c55efa8ebc97f6e9cb7d11)
2015-11-12 17:55:10 +01:00