Commit Graph
536 Commits
Author SHA1 Message Date
ariel- fcb7910533 Core/Spell: reimplemented TRIGGERED_DISALLOW_PROC_EVENTS trigger flag
Triggered spells shouldn't chain-trigger other spells

Closes #18217
2017-05-04 01:28:42 +01:00
ariel- fb6cde2730 Core/Entities: add yet another utility overload to CastSpell, fixes AppVeyor build
Ninja NULL->nullptr cleanup
2017-05-04 01:28:15 +01:00
ariel- 04b562418e Core/Spell: make a distinction between triggered flags with debugging purposes, and don't use them when casting triggered spells 2017-05-04 01:27:22 +01:00
ariel- 3d9c4fd3fc Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks 2017-05-04 01:07:05 +01:00
ariel- b3eb7c121f Core/Unit: Change aura proc pair container to vector 2017-05-04 00:59:01 +01:00
roc13x d30237fb1e Core/Globals: compute aura diminishing return info at startup and cache it 2017-05-04 00:57:24 +01:00
ariel- a7a024d1d6 Core/Auras: reset periodic aura timers by default. Except when aura comes from triggered spell 2017-05-03 23:51:47 +01:00
ariel- 51f26dfe51 Core/Spells: Implementation of QAston proc system 2017-05-03 20:08:08 +01:00
Shauren 1f96c1f268 Merge 1e1fcd6847619629f4b6642faaccb81c4cf3755e 2017-05-03 17:26:32 +01:00
Shauren a9d5fab271 Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures 2017-05-03 17:14:00 +01:00
Aokromes acd63b4259 Core/Entities: moved PetAura handling to Player where it belongs 2017-05-02 02:10:32 +02:00
Aokromes c015a5cf10 Core/Misc: camelize GetFaction/SetFaction properly 2017-05-02 02:02:31 +02:00
ccrs a17849bcfe Core/Unit: 2170541a51 followup
use true as default value since pretty much all the script calls will expect that
2017-04-28 12:57:38 +02:00
Aokromes 83623e0f7e Core/Spells: Add duration argument to Unit::SendPlaySpellVisualKit 2017-04-23 15:36:46 +02:00
Aokromes 92816c0f17 Core/Gameobject: destroy test 2017-04-03 12:20:06 +02:00
ccrs 5d79ac9275 Core/Unit: cleanup UnitState enum 2017-03-26 06:15:09 +02:00
ariel- 7871583016 Core/Auras: tidy up one little hack 2017-03-13 10:09:59 +01:00
Aokromes 41c30413c9 Core/Misc: Minimize branch differences 2017-03-13 09:52:07 +01:00
ariel- 6cd253ff8f Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h 2017-03-03 01:19:28 +01:00
xinef1 01b43b3da0 Core/Pets: Fixed flashing pet attack button (#18906) 2017-02-05 01:57:37 +01:00
Aokromes f0db5c7e8b Core/Entities: Moved PITCH movement flags into TURNING mask
(they do not cause movement in any direction alone, only combined with forward/backward/strafe)
2017-01-30 02:56:12 +01:00
Aokromes b7432bc39a Compile fix try 2017-01-18 15:09:57 +01:00
Aokromes 719a317a67 Update copyright note for 2017 2017-01-02 07:26:38 +01:00
Aokromes 949ce2d576 Core/Units: Cleanup hardcoded magic numbers for byte field offsets
(cherry picked from commit ac1dc75)
2016-12-16 19:54:22 +01:00
ariel- eb3a90a4e8 Core/Spell: implemented dispel reflection
Closes #18323
2016-12-16 19:24:01 +01:00
Aokromes 0737ea9b6e Core/Spells: Fixed logic related to movement while channeling 2016-11-27 15:47:21 +01:00
Aokromes e4dd97765e Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)
2016-11-19 06:10:14 +01:00
ariel- b4ceb798e0 Core/AI: initial support for monster sparring (#17673) 2016-10-24 13:30:22 +02:00
Aokromes 114db3b9a4 Revert "Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures"
This reverts commit a3e5afc027.
2016-10-21 07:27:15 +02:00
Aokromes 57d0a5d16d Revert "Core/Spells: Implementation of QAston proc system"
This reverts commit a70e4e26b3.
2016-10-21 07:27:04 +02:00
Aokromes f9ebb50a8a Revert "Typo fix"
This reverts commit 32277391cc.
2016-10-21 07:26:42 +02:00
Aokromes 32277391cc Typo fix 2016-10-05 17:16:30 +02:00
Aokromes a70e4e26b3 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-05 13:19:51 +02:00
Shauren a3e5afc027 Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures 2016-10-05 08:01:38 +02:00
treeston 8a402b9f6b Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true 2016-09-20 20:28:45 +02:00
ariel- f4957850e1 Core/Spell: no need to bloat existing parameter lists. (f81754a306a8b1f24f0b130ded3c8170e9b146c5 follow up) 2016-09-02 10:47:41 +02:00
ariel- 8e96d7fc8e Core/Spells: register SPELLMOD_CRITICAL_CHANCE in casting spell modifiers. 2016-09-01 15:19:49 +02:00
Aokromes 9feafe00bb Entities/Unit: Add overload to NearTeleportTo taking Position const&. 2016-08-27 09:30:32 +02:00
SnapperRy ca98eaf408 Core/Unit: do not refresh last damaged timer if hit by SPELL_AURA_DAMAGE_SHIELD.
Fixes spells like Retribution Aura, Thorns and Damage Shield that were preventing units from evading.
2016-08-26 00:01:57 +02:00
Treeston a29913187b Core/Spells: Fix orientation- and targeting-related issues if the creature isn't currently engaged in combat. (#17120)
Also disable spell focus system for vehicle control auras.

Closes #16572
Closes #17016
2016-08-21 13:16:30 +02:00
Aokromes 32d3f380bb more picks 2016-08-21 01:33:04 +02:00
Aokromes 375b7a61c4 Core/Units: Fixed melee range check
* Split Spell::CheckRange() into 2 methods since that method had more than one responsibility.
* Moved melee range logic into its own function
* Moved melee range logic method GetMeleeRange from Spell to Unit class. Unit::IsWithinMeleeRange() and Spell::GetMinMaxRange() both use that method.
2016-08-16 12:25:53 +02:00
robinsch c406fb2a73 Core/Spell: Remove all raid auras on party leave (#17663)
Core/Spell: Remove all raid auras on party leave
2016-08-15 00:03:33 +02:00
Aokromes 5302d9112b Core/Game: Converted the game library to a shared library.
* There is still the possibility to static link against game.
2016-08-08 20:11:29 +02:00
Aokromes 69e1738554 Add missing overrides. 2016-08-05 01:12:48 +02:00
ariel- badef62df4 Core/Spells: ported helper function from 3f28fd304d833eadefff8d343ab45caf8d0575c2
Core/Spells: Reimplemented automatic spell learning
2016-08-01 03:54:31 -03:00
ariel- 0c51829cc4 Core/Auras: Implemented aura 321 SPELL_AURA_MOD_NO_ACTIONS
(cherry picked from commit 55d5cd37df8f3415b71dac1e50ecc970873d6deb)
2016-08-01 03:54:28 -03:00
ariel- fa8662e617 Core/Movement: Clean up and improvements on Unit::SetSpeed (#16843)
- Clean up of Unit::SetSpeed (mostly cherry picks from the 6.x branch):
- the opcode sent depends on the unit. until now, MSG_MOVE_SET_* were sent for every units which isn't like retail behavior.
- Removed the unused method parameter "forced" from Unit::SetSpeed
- Renamed Unit::SetSpeed to SetSpeedRate
- Removed the unused method parameter "forced" from Unit::UpdateSpeed
- Added utility method Unit::SetSpeed which take the new flat value.
Conflicts:
	src/server/game/Entities/Unit/Unit.cpp
	src/server/scripts/Commands/cs_modify.cpp
	src/server/scripts/EasternKingdoms/ZulAman/boss_zuljin.cpp
	src/server/scripts/Kalimdor/zone_azshara.cpp
	src/server/scripts/Kalimdor/zone_durotar.cpp
	src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
2016-07-23 07:02:25 -03:00
Shauren 8a5e7eba70 Core/Units: Fixed autoattack range
Closes #17539
2016-07-20 19:12:44 +02:00
Shauren fa7026cee3 Core/Spells: Fixed spell range check
Closes #17060
2016-07-20 18:26:18 +02:00