Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
37,661 Commits 2 Branches 1 Tag
2b2237b7bc829d4d2ae5dbca3150d653735f170e
Commit Graph
37661 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Giacomo Pozzoni 2b2237b7bc Fixes/3.3.5 aura infinite loop 
* Core/Auras: Attempt to fix infinite loop with aura 18950 on map unload

* Core/Auras: Log a detailed error and assert when failing to remove all auras after a few tries

* Code cleanup
 2022-09-12 09:15:28 +02:00
joshwhedon eb181ca99f Removing a duplicate item combat spell handling causing poisons (and others) to proc twice. (#24627) 2022-09-12 09:15:28 +02:00
Gildor 1f1e1b3a66 Core/Spells: Improve check for non damage/heal spells in Spell::TargetInfo::DoDamageAndTriggers (#24467) 
* this prevent cases like full absorb damage that override proper hitMask
 2022-09-12 09:15:27 +02:00
Keader 4fc1d30dc4 Core/Spells: Fixed Ice Block / Divine Shield cast in Cyclone (#24465) 
(cherry picked from commit c41ae890693676c25cf58f448da9a914fcb9aaf1)
 2022-09-12 09:15:27 +02:00
Gildor eab8e4aefb Core/Gameobjects: Improve stealth detection 2022-09-12 09:15:27 +02:00
Shauren eeef100e08 Core/Spells: Fixed checking free inventory space for some spells that have bad dbc data 2022-09-12 09:15:27 +02:00
jackpoz c237b056b3 Core/Spells: Fix missing "Inventory is full" with spells that create more than 1 item 2022-09-12 09:15:26 +02:00
Ovahlord 5724e4c578 Core/Spells: fixed more cherrypick mistakes 2022-09-12 09:15:26 +02:00
Giacomo Pozzoni b052d23c4f Core/Creatures: Fix spell_school_immune_mask being applied against positive spells too (#23999) 2022-09-12 09:15:26 +02:00
Giacomo Pozzoni d2918d2138 Core/Spells: Fix Spellsteal stealing Silence buff of Arcane Torrent (#23992) 2022-09-12 09:15:26 +02:00
Ovahlord ec09a4830a Core/Spells: resolved a couple cherrypick mistakes 2022-09-12 09:15:25 +02:00
Wyrserth 86749679c8 Core/Spell: honor IsStackableOnOneSlotWithDifferentCasters() when deciding if an aura should stack from different casters or not. (#23579) 
Fixes #23387 and #22818.
 2022-09-12 09:15:25 +02:00
Treeston ce662d1ad7 Core/Spells: Spell pushback now only affects players (as it should) 
# Conflicts:
#	src/server/game/Spells/Spell.cpp
 2022-09-12 09:15:25 +02:00
Wyrserth 3fe6b49575 Core/Loot: fix issue that prevented players from rolling for an unique-category item while an equipped item shares the same unique-category. 
# Conflicts:
#	src/server/game/Groups/Group.cpp
 2022-09-12 09:15:25 +02:00
Wyrserth b5e177edbc Core/Spell: fix some issues with taunt spells 2022-09-12 09:15:25 +02:00
Wyrserth 2fefbc800b Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction. 2022-09-12 09:15:24 +02:00
Wyrserth 66112dff81 Core/Loot: implement automatic pass in group loot for items that cannot be looted. 2022-09-12 09:15:24 +02:00
Wyrserth 2f5fd3f227 Core/Spells: don't allow spells with SPELL_EFFECT_CREATE_ITEM_2 to be cast if there isn't enough space in inventory 2022-09-12 09:15:24 +02:00
Gildor 85893e9a44 Core/Spells: Fix spells with Health Leech effect, now check damage absorb when calculate Heal 2022-09-12 09:15:24 +02:00
brotalnia 7cc33f1bb7 Core/Spells: Return CheckCast result from CastSpell (#23236) 
* Return CheckCast result from CastSpell

* Return cast result from UnitAI methods too.
 2022-09-12 09:15:23 +02:00
Trond B. Krokli 89d0f363cf Core/Spells: make Four Horsemen debuffs negative (#23253) 
By Riztazz
Closes #23248
 2022-09-12 09:15:23 +02:00
PolarCookie 81e5943bd0 Core/Spell: SpellAura Redux (#22794) 
* typo and correction

* spell aura no longer shared between targets

_spellAura isolated

* SPELL_AURA_CONTROL_VEHICLE is not strictly single target spell

Steam Tank Control and Wyrmrest Commander

units can reseat themselves again

* Rename 9999_99_99_99_world.sql to 2019_03_08_00_world.sql
 2022-09-12 09:15:23 +02:00
jackpoz 068d7f826e Core/Spells: Fix assert triggered 
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the aura owner, then processing the main spell effects. The triggered spell can kill the aura owner, changing its death state to CORPSE and removing auras created.

Fix #21856
Ref 518e6299ca08a362bc3709daaaa5e5d5633d1bf1
 2022-09-12 09:15:23 +02:00
jackpoz e35c68c548 Core/MapScripts: Allow GameObjects to be caster of SCRIPT_COMMAND_CAST_SPELL 2022-09-12 09:15:22 +02:00
jackpoz 1180c43bac Core/Spells: Fix assert triggered 
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the target, then processing the main spell effects. The triggered spell can kill the target, changing its death state to CORPSE and removing auras created.
Fix #22306
 2022-09-12 09:15:22 +02:00
Shauren e395af341a Core/Spells: Fixed crash with some gameobject spell casters 2022-09-12 09:15:22 +02:00
Shauren 54b65fc2ac Core/Objects: Properly ASSERT when trying to access invalid updatefields 2022-09-12 09:15:22 +02:00
Shauren 96c4a1b1f9 Core/Spells: Fixed unapplying rockbiter weapon 2022-09-12 09:15:21 +02:00
Shauren 5ceba73504 Core/Spells: Corrected haste affecting GCDs to match 3.3.5 client logic 2022-09-12 09:15:21 +02:00
Shauren dc8bf301bb Core/Auras: Fixed saving auras with same spell id but different item source 2022-09-12 09:15:21 +02:00
PolarCookie b4b8fffa22 Core/Spells: fix issues with delayed spells and auras 2022-09-12 09:15:20 +02:00
HelloKitty 1d013e5d3f Core/Spells: Include RealPointsPerLevel when determining if aura is negative (#22427) 2022-09-12 09:15:20 +02:00
Shauren adfeaa7666 Core/PacketIO: Fixed SMSG_SPELLNONMELEEDAMAGELOG structure 2022-09-12 09:15:20 +02:00
ariel- b1adc269fb Core/Player: partial revert of m_items handling as it's cause of a exploit 2022-09-12 09:15:20 +02:00
ariel- 3a3e70f2b6 Core/Spells: all bleed effects should ignore armor 2022-09-12 09:15:19 +02:00
ariel- f6bb4241f6 Core/Spells: fix another regression with arcane missiles being marked positive 2022-09-12 09:15:19 +02:00
ariel- 80b256795c Core/Spells: always initialize hitinfo aura 
Ref 437c5c7b9d2122f7b1f46fd4e0f502c8be1e3091
 2022-09-12 09:15:19 +02:00
ariel- 1d1787f70a Scripts/Spells: fix Seaforium Blast script crash 2022-09-12 09:15:19 +02:00
ariel- 82ffeb587b Core/Spells: fix delayed hit aura crash 2022-09-12 09:15:18 +02:00
ariel- 58e418574e Core/Player: properly clear m_items array when unequipping items from the bag 
- Also cleanup weapon damage ap mult when direct destroying a equipped weapon
 2022-09-12 09:15:18 +02:00
Ovahlord f75fdfef6f warning fix 2022-09-12 09:15:18 +02:00
ariel- 082121cb38 Core/Entities: cleanup of weapon damage 
- ScalingStatDistribution/Value (ie heirlooms): apply bonuses in all cases, some calls used nullptr (like after disarm) and item wasn't regaining them
- AP multiplier wasn't correctly reflected after unequipping a weapon
- Correctly set base damages at unequip
 2022-09-12 09:15:18 +02:00
ariel- 460c317399 Core/Spells: fix issues with delayed spells and auras 
- Was losing info of delayed targets due to remove_if move-assigning targets, it needs to be saved into delayed target vector before returning from lambda
- Delayed auras applying on many targets are now handled gracefully
 2022-09-12 09:15:17 +02:00
ariel- 427582b0f7 Core/Spells: only apply aura effects when needed. 2022-09-12 09:15:17 +02:00
ariel- ae23b5d45a Core/Auras: fix nopch 2022-09-12 09:15:17 +02:00
ariel- ee99e76fa9 Core/Auras: fix auras apply on player when loading. Fixes Ghost aura flags and player deathstate 2022-09-12 09:15:17 +02:00
ariel- 55577ad85b Core/Spells: Fix some issues with channeled spells and aura duration mods 2022-09-12 09:15:16 +02:00
ariel- 1725fa9006 Core/Entities: fix creatures ignoring immune flags. 2022-09-12 09:15:16 +02:00
ariel- b3c8d78fa2 Core/Spell: fix SendSpellMiss requiring caster Unit 2022-09-12 09:15:16 +02:00
ariel- c889b81f2c Core/Spell: fix target checks 
- Aura will be applied at last moment possible (after damage) to prevent regressions on #18395
- Partial revert of 9b38a6352c0fe2499de54fd769aa1c721a410bda as it wasnt handling correctly checks without spells
 2022-09-12 09:15:15 +02:00