Commit Graph
1746 Commits
Author SHA1 Message Date
xinef1 2c05a59815 Core/Misc: Fix various crashes, also related to multithreading (#19012)
* When iterating groups we have to either do it not in multithreaded context (map updates) or start with checking maps (they are guaranteed to change in single thread update).
* Properly clear ComboPoint references on player remove 
* remove some possible references item may have when it is deleted during save. 
* Also clear all hostile references when unit is removed from map.
2017-02-05 01:58:11 +01:00
xinef1 f6baed105d Core/Loot: Only allow the roll winner to loot the item he won in case it cannot be added to inventory instantly (full or any other reason) (#19037) 2017-02-05 01:55:10 +01:00
Aokromes b083a07dfa missing parts 2017-02-04 02:36:43 +01:00
Aokromes 8bb777ef5c Few small optimizations here and there 2017-02-01 16:51:21 +01:00
Aokromes 30eced8380 Core/Spells: Properly send autorepeat cancel packet to self and fix s…
…ome problems with autoshot
2017-02-01 15:18:54 +01:00
Aokromes 8a63c4919e Core/Packets: updated some contactlist packets
(cherry picked from commit e01bb91)
2017-02-01 02:11:56 +01:00
Aokromes c5f17620df Core/Quest: Fix SMSG_QUESTGIVER_STATUS_MULTIPLE
By Davide
2017-02-01 00:22:45 +01:00
Aokromes 1289e66d44 Core/Player: Fix ghost players water walking visual bug
Fix bug of ghost players appearing as swimming to other players instead of water walking.
2017-01-30 02:57:09 +01:00
Aokromes f0db5c7e8b Core/Entities: Moved PITCH movement flags into TURNING mask
(they do not cause movement in any direction alone, only combined with forward/backward/strafe)
2017-01-30 02:56:12 +01:00
sevi af7827dfa7 Core/Player: add SendNotifyCurrencyLootRemoved
from Arkcore
2017-01-25 21:43:37 +01:00
xinef1 adfdc05d42 Core/Units: Drop hostile world references that are out of our sight (fixes combat bug) (#18591) 2017-01-21 14:47:28 +01:00
Shauren 5ac6ed25d1 Core/Player: Removed unneeded distance check from Player::ActivateTaxiPathTo, it is already checked by HandleActivateTaxi* methods (and taxis started serverside should not have such requirements)
Closes #15398
2017-01-21 14:36:46 +01:00
Aokromes 55aba887f7 more missing part 2017-01-18 15:21:28 +01:00
Aokromes b6e84ddc38 Missing part 2017-01-18 15:15:52 +01:00
Aokromes b7432bc39a Compile fix try 2017-01-18 15:09:57 +01:00
Staleness89 1101db1573 Core/Player: Add another config option for IsGroupVisibleFor() (#18723) 2017-01-07 07:23:18 +01:00
Aokromes 719a317a67 Update copyright note for 2017 2017-01-02 07:26:38 +01:00
ariel- 001e7f8212 Core/Player: Recast lost by death item obtain spells of any items held in the inventory when resurrecting
I HAS BUKKIT

Closes #5184
2017-01-01 13:35:15 +01:00
xinef1 1ba5a92343 Core/Items: Fixed problem where item dependent auras are not properly updated (#18592)
-  Introduced in 7e83d7e22a82104e53f872758fc7fe835472782c

Closes #18506
2017-01-01 13:34:34 +01:00
xinef1 8e824d0b32 Core/Items: Fixed empty slots handling in equipment manager (#18613) 2016-12-28 16:08:43 +01:00
Aokromes 949ce2d576 Core/Units: Cleanup hardcoded magic numbers for byte field offsets
(cherry picked from commit ac1dc75)
2016-12-16 19:54:22 +01:00
ariel- f32fe0cd0e Core/Player: prevent early aura removal when swapping weapons
Closes #18428
2016-12-16 19:28:06 +01:00
Aokromes 7904cf0191 typo fix 2016-11-27 05:18:54 +01:00
Aokromes 90dc4159b2 Core/Player: fix regression with EquippedItemClass requiring spells 2016-11-27 03:15:05 +01:00
Aokromes f2fdbd81d6 fix build 2016-11-27 03:12:08 +01:00
ariel- 6283cce52f Core/Player: fix build 2016-11-27 03:10:07 +01:00
Aokromes c0ba6c2dfe Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CR…
…IT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras

* Now the entire aura is removed when changing equipment
* All aura types can now depend on equipped items
2016-11-27 03:09:29 +01:00
Aokromes b2c17b4881 Core/Guild: avoid data integrity problems wrapping delete+insert statements in a transaction 2016-11-27 02:41:25 +01:00
Aokromes ba8791ddcd Core/Player: recheck shapeshift bonus auras when switching spec.
- Fixes Leader of the Pack stuck when switching specs while shapeshifted
2016-11-27 01:53:19 +01:00
Aokromes 6c76eff031 Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being …
…applied more than once

No more overpowered dps for you
2016-11-27 01:36:22 +01:00
Richard b66a4f8dcb [3.3.5] Core/Loot: Fix conditional Master Loot (#17943)
* Core/Loot: Fix master looting of conditional items

follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.

The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"

* Core/Loot: Rename QuestItem to NotNormalItem

QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items

* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly

* Core/Loot: Rename NotNormalItem to NotNormalLootItem
2016-11-04 12:26:09 +01:00
Aokromes 6d49df2635 Core/GameObject: added possibilty for gameobjects to contain money loot 2016-11-02 05:47:52 +01:00
Aokromes fa05752893 Core/Quest: Only delete all quest bound items from inventory on turn …
…in if the quest is not repeatable
2016-11-02 03:46:16 +01:00
Aokromes a81a44174b Core/Auras: don't save auras casted by items
- Drop useless field from DB (itemGuid was being saved, but never used, see Prepared Statements)
- This type of auras (like Water Bucket, Precious Ribbon, etc) will be recasted on login anyways.
2016-11-02 03:36:16 +01:00
ariel- 469870a141 Core/Player: cleanup single target auras on spec switch
Closes #806
2016-11-02 03:12:09 +01:00
Aokromes 6e191748ab Core/Conditions: merge CONDITION_SOURCE_TYPE_QUEST_SHOW_MARK with CONDITION_SOURCE_TYPE_QUEST_ACCEPT 2016-11-02 03:01:05 +01:00
Aokromes eaa2533ded another compile fix try 2016-10-24 16:44:16 +02:00
Aokromes cb052ff0f3 another compile fix try 2016-10-24 16:29:25 +02:00
SnapperRy 4f313746e0 Core/Quest: show DIALOG_STATUS_AVAILABLE instead of DIALOG_STATUS_REWARD for non-repeatable autocomplete quests. 2016-10-24 13:55:18 +02:00
SnapperRy 51c6209922 Core/Quest: send correct packet when a quest cannot be rewarded for item-related errors. 2016-10-24 13:55:04 +02:00
SnapperRy d77b366703 Core/Quest: do not set a quest to failed if it's rewarded or has no status at all (not taken). 2016-10-24 13:47:32 +02:00
SnapperRy adb3889885 Core/Item: fix wrong error message triggered when trying to equip two items with the same ItemLimitCategory. 2016-10-24 13:12:58 +02:00
Aokromes 2057e6de4a Core/Items: Defined all item flags
(cherry picked from commit ef29f32)
2016-10-24 13:01:00 +02:00
SnapperRy a6eb8d9b11 Core/Wintergrasp: cleanup and codestyle. 2016-10-22 10:53:40 +02:00
Aokromes 7315052d34 Core/Channel: revamp channel system (#17980)
* Core/Channel: change the way channels are stored and sent to client.

- Fixes multiple channels per zone when using different locales
- Connected clients will receive locally the name of the channel for their apropiate locale (if available)
- In other cases default locale name will be sent, so as to prevent breaking channel chat for those players
2016-10-22 10:21:18 +02:00
Aokromes 57d0a5d16d Revert "Core/Spells: Implementation of QAston proc system"
This reverts commit a70e4e26b3.
2016-10-21 07:27:04 +02:00
Aokromes a70e4e26b3 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-05 13:19:51 +02:00
SnapperRy 828026bede Core/Quest: send INVALIDREASON_QUEST_ALREADY_DONE if player tries to accept a quest that is already rewarded. 2016-10-04 06:35:17 +02:00
ariel- 6ee820afe4 Core/Player: correct logic for IsUsingTwoHandedWeaponInOneHand
Fixes penalty not being applied when we are using a 2H in offhand, and a unarmed MH.
MH may do unarmed attacks in this case. (reciprocal of 2H MH, unarmed OH, only uses MH normally, OH doesn't unarmed attack)
2016-10-03 14:57:51 +02:00
Aokromes 576cfa8328 Core/Player: unconditionally remove Titan's grip penalty aura on Spel…
…l removal

Was causing an issue when switching spec, because off hand weapon was still equipped
2016-10-03 14:53:39 +02:00