Commit Graph
10077 Commits
Author SHA1 Message Date
ariel- 4e61ff8c9c Core/Unit: consistency fix 2016-11-02 03:12:25 +01:00
ariel- 469870a141 Core/Player: cleanup single target auras on spec switch
Closes #806
2016-11-02 03:12:09 +01:00
ariel- 7a0647ec46 Core/Unit: fix warning reported by VS2015
C4146: unary minus operator applied to unsigned type, result still unsigned
2016-11-02 03:01:30 +01:00
Aokromes 6e191748ab Core/Conditions: merge CONDITION_SOURCE_TYPE_QUEST_SHOW_MARK with CONDITION_SOURCE_TYPE_QUEST_ACCEPT 2016-11-02 03:01:05 +01:00
ariel- c0ef2ba55c Core/Unit: fix logic error in DamageInfo::ModifyDamage.
Previous code did not protect against m_damage underflow, rather only allow up to duplicate damage.
It now should work as intended.

Closes #18154
2016-11-02 02:56:40 +01:00
Aokromes 0be1e9c4d5 Core/SpellMgr: overwrite DBC RangeEntry for Safeguard 2016-11-02 02:54:50 +01:00
SnapperRy fe4da7ede8 Core/SAI: remove wrong DB errors.
It is normal to have events applicable only to certain instance difficulties.

Closes #18082.
2016-11-02 02:50:57 +01:00
ariel- 00b7cabd80 Core/Globals: abort server startup if there are wrong factions in DB
Closes #18127
2016-11-02 02:46:39 +01:00
Aokromes f88d3935fc Core/Unit: fix chain cc's not being diminished properly 2016-11-02 02:45:27 +01:00
Aokromes 1f1defedc0 Core/Chat: Fix crash when creating a new character
By ariel-
2016-10-27 18:25:50 +02:00
Aokromes 59053a099b Compile fix 2016-10-24 19:28:03 +02:00
Aokromes 16c340fdb6 more compile fix try 2016-10-24 17:05:32 +02:00
Aokromes c5d2bc544f And another compile fix try 2016-10-24 16:59:27 +02:00
Aokromes 4ad4326c53 another compile try fix 2016-10-24 16:53:19 +02:00
Aokromes 4b541233da More compile fix try 2016-10-24 16:49:33 +02:00
Aokromes eaa2533ded another compile fix try 2016-10-24 16:44:16 +02:00
Aokromes cb052ff0f3 another compile fix try 2016-10-24 16:29:25 +02:00
Aokromes 29cd5e0f6b another compile fix try 2016-10-24 16:11:11 +02:00
Aokromes c22a378f8e Another compile fix try 2016-10-24 15:53:35 +02:00
Aokromes 0874bf5037 Another compile fix try 2016-10-24 15:38:35 +02:00
Aokromes 0b60befee5 Compile fix try 2016-10-24 15:35:24 +02:00
Aokromes 1792e6f138 Core/Misc: Partial compile fix 2016-10-24 15:12:50 +02:00
Aokromes 7763d40846 Core/Unit: prematurely abort GetFactionTemplateEntry instead of retur…
…ning a null pointer

Factions should never be invalid for players/spawned creatures anyways
2016-10-24 14:06:59 +02:00
Gustavo a7ea5be3f0 Core/GameObject Also spawn trap for GAMEOBJECT_TYPE_BUTTON (#18083) 2016-10-24 14:03:34 +02:00
ariel- 7d04331322 Core/Spell: do positivity spell checks only against actually hitted effects instead of the whole spell
Closes #18097
2016-10-24 14:03:08 +02:00
ariel- 162eaad0ee Core/Spell: clear auras of channeled spells if channeling is cancelled due to invalid targets (dead or w/e)
Closes #14859
Closes #15186
2016-10-24 13:59:54 +02:00
ariel- 657aea3d5b Core/Spells: mark Arcane Missiles aura as negative. Was downranking the spell when targetting low level mobs due to effect 1 flagged as possitive.
Closes #12152
2016-10-24 13:59:38 +02:00
ariel- d8f310e2a1 Core/AuctionHouseBot: ahbot characters subsystem shake-up
Bonus: fix moar static analysis issues
2016-10-24 13:57:56 +02:00
SnapperRy f28c778788 Core/Spell: allow SPELL_EFFECT_QUEST_COMPLETE to set a quest to rewarded only if that quest is used as internal flag by the server (has flag 1024 - QUEST_FLAGS_TRACKING). 2016-10-24 13:55:33 +02:00
SnapperRy 4f313746e0 Core/Quest: show DIALOG_STATUS_AVAILABLE instead of DIALOG_STATUS_REWARD for non-repeatable autocomplete quests. 2016-10-24 13:55:18 +02:00
SnapperRy 51c6209922 Core/Quest: send correct packet when a quest cannot be rewarded for item-related errors. 2016-10-24 13:55:04 +02:00
treeston 5d0a5951a1 Entities/Creature: Fix an edge case issue where creatures would re-acquire target after respawn if they despawned while spell focusing.
Instance/AzjolNerub: Fix Anub'arak wall and add sequence break info. Fixes and closes #18013.
2016-10-24 13:54:20 +02:00
SnapperRy 28aba933d6 Core/Text: allow GENDER_NONE to use FemaleText in broadcast_text if not empty.
Otherwise it would only use MaleText, which breaks cases where female NPCs change model to one that has no gender.
2016-10-24 13:52:08 +02:00
SnapperRy d77b366703 Core/Quest: do not set a quest to failed if it's rewarded or has no status at all (not taken). 2016-10-24 13:47:32 +02:00
treeston e5f2fe7b7b Fix _DespawnAtEvade for other creatures to actually respawn said other creatures.
Also fix add aggro for Hadronox.
Fixes and closes #18012.
2016-10-24 13:45:01 +02:00
treeston 0ba8f4c955 Core/Creature: Fix respawn logic to call reset react state BEFORE calling Reset(). Fixes Krik'thir behavior after a wipe (and maybe some others).
Fixes and closes #18011.
2016-10-24 13:44:08 +02:00
ariel- b4ceb798e0 Core/AI: initial support for monster sparring (#17673) 2016-10-24 13:30:22 +02:00
iridinite d364576cce [3.3.5] AHBot Characters (#17885) 2016-10-24 13:27:54 +02:00
Keader 1e60c73ad9 Core/Unit: Remove incorrect check that dont allow units attack your vehicle/passenger (#17932) 2016-10-24 13:27:40 +02:00
SnapperRy 4fc4c81e89 Core/SAI: always use DespawnOrUnsummon() for SMART_ACTION_FORCE_DESPAWN.
SmartAI uses that same method internally, so there's no need to handle it in two different ways.

Does not affect functionality, but prevents useless SAI error log in case the target creature is not using SAI.
2016-10-24 13:27:26 +02:00
ariel- 9b74762644 Core/SmartScripts: fixup SMART_EVENT_FLAG_WHILE_CHARMED behaviour to only mean charmed creatures (#17738 follow-up)
Unit::IsControlledByPlayer is a expected value for TempSummons (like some triggers used in quests, summoned by spells).
Previous logic broke a lot of quests which use triggers to do stuff.

Allow JustSummoned and events linked from other events with flag set also in charmed (prevents breaking event chains)
Allow vehicles (needed for vehicles with SmartAI, eg Iron Rune Constructs and You: Rocket Jumping)
2016-10-24 13:18:45 +02:00
ariel- a2c88b2468 Core/AI: added container independent wrappers for WorldObject::GetxxxInGrid 2016-10-24 13:16:12 +02:00
SnapperRy adb3889885 Core/Item: fix wrong error message triggered when trying to equip two items with the same ItemLimitCategory. 2016-10-24 13:12:58 +02:00
Aokromes 3a4b951299 Core/Entities: extend available containers for WorldObject::GetxxxInGrid 2016-10-24 13:10:01 +02:00
SnapperRy 5497eebe29 Script/Quest: Stop the Ascension! 2016-10-24 13:02:50 +02:00
ariel- 171738b70e Core/Auras: don't ignore SPELL_ATTR3_ONLY_TARGET_PLAYERS in area auras.
Also, start abusing the arbitrary containers for searchers introduced in 8775f8b28a5ad4403371577787131ff81f14332b
2016-10-24 13:01:59 +02:00
Aokromes 2057e6de4a Core/Items: Defined all item flags
(cherry picked from commit ef29f32)
2016-10-24 13:01:00 +02:00
SnapperRy 4a4142747b Core/Loot: revert unique item check introduced in ea69115.
Proven to be wrong in its current form. Will reintroduce later either in the same method or via db conditions.
2016-10-24 11:17:17 +02:00
SnapperRy 8707ff2425 Core/Loot: limit unique items check introduced in ea69115 to affect only items that start a quest.
Turns out epic and legendary items are excluded from this limitation (or it could be just instanced content that is immune to this). Other qualities are affected as normal. Sorry for the mishap.
2016-10-24 11:16:47 +02:00
ariel- 3944dc25b9 Core/Creature: Call SetSpawnHealth after JustReachedHome in HomeMovementGenerator
Fixes issues with quests that rely on this behaviour (eg Free your Mind)

Also updated SetSpawnHealth so it doesn't do anything in case spawn is manual (SetHealth(GetHealth()) does modify things depending on deathstate)
2016-10-24 11:10:41 +02:00