Commit Graph
10618 Commits
Author SHA1 Message Date
Aokromes 4e95a6b4ad Group creation again (follow-up to 132538d). Groups now only disband if all members reject the invitation (as opposed to if any member rejects the invitation). 2017-06-17 11:41:57 +02:00
Aokromes 461ba1cb56 Fix (C) for multiple files 2017-06-15 08:46:45 +02:00
treeston 4cd2ff6ae4 Fixes to all-reputation and all-skill custom option handling:
- Move on-create customs (all explored, all reputations) to CharacterHandler::HandlePlayerLogin for first login.

- Add Wrath and cata factions to all reputations custom (it only had BC factions).

- Remove unused ReputationMgr::SendStates. Add ReputationMgr::SendState handling for sending all updated states in arbitrary order if nullptr is passed (used in point 1).

- Fix all weapon skills max custom to properly apply on learning new weapon skills.
2017-06-15 08:08:49 +02:00
treeston 5812c6559f build fix 2017-06-15 07:49:57 +02:00
Aokromes 29cbbc50d3 Core/Player: Keep shared quests through map changes instead of getting stuck in busy state 2017-06-15 07:40:14 +02:00
Gustavo 288aca3d15 Core/Spells Allow bosses to receive KnockBack under certain conditions (#19312)
Conditions: Not player, not controlled by player and not hunter's pet
2017-06-15 07:28:59 +02:00
Aokromes 234adeaafd Build fix 2017-06-14 05:22:31 +02:00
Aokromes 70fc19951c Modify group invite behavior while creating group to be blizzlike:
- Leader can invite multiple people before the first invite is accepted
- Leader can cancel group formation by sending CMSG_GROUP_DISBAND (using /run LeaveParty() or similar)
2017-06-14 05:11:47 +02:00
Aokromes 5b1121af3c Add new command 'npc showloot'. Does exactly what it says on the tin. 2017-06-12 19:37:41 +02:00
Aokromes e0ad514328 Build fix 2017-06-12 18:39:53 +02:00
treeston f3aeaf990e dynamic_spawning conflict avoidance, part deux: World.h enums 2017-06-12 18:27:39 +02:00
Aokromes 57841569e5 - Add new commands .group set assistant, .group set maintank and .gro…
…up set mainassist to toggle raid member flags.

- Fix 2017_05_29_00_auth.sql to be reapply safe.
2017-06-12 18:23:57 +02:00
Aokromes 558bbbcf98 Make some adjustments to .summon and .group summon behavior to make t…
…hem more permissive:

- Now only requires the either target's group leader or target itself to be on your map
- Now summons all applicable group members even if one member fails checks
- No longer has some truly weird edge case instance unbind code that could cause exploit behavior (Really, I have no idea why this existed, because it certainly didn't do what it might've been meant to do.)
2017-06-12 18:03:01 +02:00
Aokromes 5c4153ba98 Core/OutdoorPvP: refactor using Position and Quat to pack parameters
- Moved statics to cpp
- Save scriptids into an array
2017-06-12 17:40:47 +02:00
Aokromes 9057cae219 So, I came in trying to fix gameobject LoS. So I restructured some stuff.
Then it turned out that gameobject LoS is already fixed. So all this does, really, is restructure some stuff.

And remove the hack from Sapphiron because I could.
2017-06-11 19:02:07 +02:00
ariel- 85c9907b07 Core/Spell: fix some spells that shouldn't allow stealth or invisibility
- Touch of Zanzil
- Glowing Blood
- Lambent Blood
- Vibrant Blood
- Black Blood
- Perpetual Instability
2017-06-11 17:50:32 +02:00
ariel- 206c82ead4 Core/SmartAI: implemented SMART_EVENT_EVENT_PHASE_CHANGE
- Use instead of Update + event_phase_mask when action needs to be synchronized
2017-06-11 17:50:24 +02:00
treeston e20bc3d4bf Added new BoundaryUnionBoundary subclass of AreaBoundary, which does what it says on the tin. Hi, sirikfoll. 2017-06-11 17:49:35 +02:00
Stanislaus Teals 53ef52a638 Fix build on GCC 7.1 (#19869) 2017-06-11 17:49:27 +02:00
Aokromes 543a25d367 typo fix 2017-06-09 14:26:49 +02:00
Aokromes ec49af7b59 Build fix 2017-06-09 14:11:36 +02:00
treeston a17af751bc Reserve RBAC permission entries 856-860 for dynamic_spawning branch to minimize future conflicts. 2017-06-09 13:30:15 +02:00
Aokromes 572021e0b3 Core/Maps: Corrected GetWaterOrGroundLevel
* When a gameobject was above water like in ToC. It would return water level
2017-06-09 13:29:18 +02:00
Aokromes be80e08ac6 Core/Misc: Fix typo in UNDERWARER_INDARKWATER 2017-06-09 13:25:35 +02:00
treeston 4b073c7354 Fixed a potential crash when resuming a SplineChainMovementGenerator. 2017-06-09 13:22:32 +02:00
Aokromes f8d9d954d1 Get zone/area IDs from vmap data in the liquid update
* Add new method Map::getFullVMapDataForPosition to get area info and liquid info in a single vmap lookup
* Use this lookup in Map:: relocation methods to update m_areaId and m_zoneId fields on WorldObject
* Adjust GetZoneId/GetAreaId on WorldObject to always return these cached fields
* Clean up liquid state handling on Unit and Player
* Hand floor's Z coord up through GetFullTerrainStatusForPosition, use it to update a new field in WorldObject, and use that to feed a new GetFloorZ call on WorldObject.
2017-06-09 13:20:37 +02:00
Aokromes ac3dbcb880 Core/Utilities: Rename RandomResizeList->RandomResize as it is no longer restricted to a list 2017-06-07 09:53:04 +02:00
Aokromes 0bb27ecd4b Pet/Guardian AI hook re-organizing (#19824)
* Pet/Guardian AI hook re-organizing:
- Adjust OwnerAttacked/OwnerAttackedBy hooks on CreatureAI to fire for all owned units, not just player pets. This should allow guardians to more reliably recognize valid targets.
- Kill off the AttackedBy hook. While it was defined in CreatureAI.h as virtual, it was only ever invoked for player pets in specific situations. This makes it classic developer bait.
  - Adjust PetAI to use DamageTaken instead of AttackedBy.
  - Adjust behavior of AttackStart on PetAI to compensate.
2017-06-07 02:50:14 +02:00
treeston 2b721ca16c SAI fixes follow-up: I missed one. 2017-06-06 22:22:01 +02:00
treeston 3cc2419c2f Fix a whole set of possible infinite loop crashes in SAI (events triggering themselves even with cooldown set). 2017-06-06 22:14:22 +02:00
treeston 24c89fba76 Re-check target evade state on projectile impact and adjust accordingly. This fixes the incorrect message ("Absorb" instead of "Evade"), and also removes the root cause of the original evade follow bug (that was prevented in 1945874). 2017-06-06 19:32:18 +02:00
Shauren 900a2da03d Core/Instances: Fixed and optimized instance id reuse 2017-06-06 08:00:10 +02:00
Keader bc1887c5df Core/Spells: Allows Dispersion under Freeze (stun by hunter trap) 2017-06-06 07:55:49 +02:00
Keader 1051412e50 Core/Spells: Allows Dispersion and Barkskin to be used under death coil 2017-06-06 07:53:19 +02:00
Aokromes 80c0d0ce8a Merge branch 'broadcast_text_fix' into '4.3.4'
Use sound id from BroadcastText template if one is specified in creature_text

See merge request !46
2017-06-04 22:32:33 +00:00
Krudor 206af48400 Use BroadcastText sound id if one was found 2017-06-04 20:50:07 +02:00
ariel- 2e3197f944 Core/Globals: add more AIName and MovementType checks to ObjectMgr
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)

Closes #19831
2017-06-02 10:23:44 +02:00
Shauren 0a61a3ffb5 Core/Groups: Fixed calculating canReset attribute
Broken in d6df19cd99.
2017-06-02 00:23:00 +02:00
Shauren 080fd33e13 Revert "Core/Groups: fix wrong query for loading group instance data. canReset attribute was calculated in the wrong way"
This reverts commit 0c1dd398bd.

Closes #19745
2017-06-02 00:22:46 +02:00
Keader 4292ac7039 Core/Spells: Removed duplicated check again followup 3a0417f7128292995a4085a0114ed59fbfa64325
to send some info to client
2017-06-01 14:05:32 +02:00
Keader 52551be039 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt
2017-06-01 14:05:14 +02:00
Aokromes 1c6021ba96 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code
2017-06-01 13:22:24 +02:00
treeston aef568cdd1 Fix an issue where CanSpawn would never get invoked on creatures without per-guid script. 2017-05-31 16:10:04 +02:00
treeston a83b77485a Add another helper to ScriptedGossip.h for resolving listId -> action. 2017-05-31 16:09:56 +02:00
Aokromes dff1518ac2 Scripts/Command: implement .debug play music command 2017-05-30 09:55:45 +02:00
Treeston 16e60ba408 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)
2017-05-30 09:21:38 +02:00
ariel- e778c4c628 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit 2017-05-30 09:21:03 +02:00
Treeston e80602f048 Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.
2017-05-30 09:20:49 +02:00
Aokromes 6021c8d29c typo fix on previous commit 2017-05-29 19:20:32 +02:00
Ryan 79661eeb39 Fix build 2017-05-28 20:19:48 +01:00