Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
37,682 Commits 2 Branches 1 Tag
733fe7c70085bac07e2e2fbd5fe136bc679648bb
Commit Graph
37682 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ovahlord 733fe7c700 Core/Packets: corrected RideType for lfg 2022-09-12 09:15:33 +02:00
Ovahlord bd2850cc08 Core/Players: fixed an oversight in spellmod sending that caused pct spellmods to appear clientside as flat bonus 2022-09-12 09:15:33 +02:00
Ovahlord 77cf3ebc91 Core/Spells: removed another duplicate haste application for periodic auras 2022-09-12 09:15:32 +02:00
Ovahlord 7e72ee241f Core/Players: removed an unused spellmod helper 2022-09-12 09:15:32 +02:00
Ovahlord 0e4d77ddb1 Core/Spells: removed a duplicate haste application for auras which caused auras ending up with a shorter duration than intended 
hi @warpten could need you to look over it so your work wont get destroyed
 2022-09-12 09:15:32 +02:00
Ovahlord 6a71b6d053 Core/Units: consider summoned units with a creator guid also as party or raid member 
the old logic was built on the false assumption that all units like totems have a ownerguid - they do not. They only have a creatorguid. Ownerguids (as the name implies) is only applied on units that the player is actively controlling. 3.3.5 has this implemented in a wrong way while 4.x does not.

*also fixed up more cherrypick mistakes while at it
 2022-09-12 09:15:31 +02:00
Ovahlord 3976ae557b Core/Spells: updated spell positivity cases and added some Cataclysm+ entries 2022-09-12 09:15:31 +02:00
Shauren ca7d36873f Core/Spells: Rename SpellAttr1 to use official attribute names 
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
 2022-09-12 09:15:31 +02:00
Ovahlord cbc2234f1b nopch build fix 2022-09-12 09:15:31 +02:00
Kaytotes b2d01c8d76 Core/Units: Removed incorrect facing movement packet sent with every creature autoattack 2022-09-12 09:15:30 +02:00
Jinnaix 458b841691 Core/Spells: Correct flagging spell caster for pvp when healing/buffing friendly creatures - it should only happen if target is in combat 2022-09-12 09:15:30 +02:00
Shauren 16aef47f61 Core/Spells: Fixed implementation of Spell::EffectRechargeManaGem when it is not the first effect on a spell (0 cases, sync code between branches) 2022-09-12 09:15:30 +02:00
Shauren 39b5168dbb Core/Auras: Changed aura dot stacking rule to not ignore aura type of "existingAura" 2022-09-12 09:15:30 +02:00
Ovahlord 068e9004f5 fixed build 2022-09-12 09:15:30 +02:00
Meji dec6c7d537 Core/Spells: Fixed spell effect 43 (SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER) (#25945) 2022-09-12 09:15:29 +02:00
Gildor 86121e9996 Core/Spells: Aura refresh improvements 2022-09-12 09:15:29 +02:00
HoustonandMoki 02b79f42a0 Core/Totem: Immune to all positive spells. (#25326) 
* Core/Totem: Immune to all positive spells.

* Fix tabs

* Avoid using magic numbers

* Remove whitespace

Co-authored-by: Moki <moki.play@mail.ru>
 2022-09-12 09:15:29 +02:00
Ovahlord 099cb8876b Core/Spells: fixed another cherrypick mistake that was causing ownerless traps to crash 2022-09-12 09:15:29 +02:00
Gildor 862a9fded9 Core/Gameobjects: Improve IsValidAttackTarget faction check for traps that hasn't owner or have NPC owner 2022-09-12 09:15:29 +02:00
Gildor d45f4b0059 Core/Gameobjects: Traps shouldn't ignore IsImmuneToNPC/IsImmuneToPC and IsInSanctuary rules if has owner 2022-09-12 09:15:28 +02:00
Shauren b28ff89c5d Core/Spells: Prevent manual cancelling of channelled spells that have SPELL_ATTR0_CANT_CANCEL 2022-09-12 09:15:28 +02:00
Giacomo Pozzoni 2b2237b7bc Fixes/3.3.5 aura infinite loop 
* Core/Auras: Attempt to fix infinite loop with aura 18950 on map unload

* Core/Auras: Log a detailed error and assert when failing to remove all auras after a few tries

* Code cleanup
 2022-09-12 09:15:28 +02:00
joshwhedon eb181ca99f Removing a duplicate item combat spell handling causing poisons (and others) to proc twice. (#24627) 2022-09-12 09:15:28 +02:00
Gildor 1f1e1b3a66 Core/Spells: Improve check for non damage/heal spells in Spell::TargetInfo::DoDamageAndTriggers (#24467) 
* this prevent cases like full absorb damage that override proper hitMask
 2022-09-12 09:15:27 +02:00
Keader 4fc1d30dc4 Core/Spells: Fixed Ice Block / Divine Shield cast in Cyclone (#24465) 
(cherry picked from commit c41ae890693676c25cf58f448da9a914fcb9aaf1)
 2022-09-12 09:15:27 +02:00
Gildor eab8e4aefb Core/Gameobjects: Improve stealth detection 2022-09-12 09:15:27 +02:00
Shauren eeef100e08 Core/Spells: Fixed checking free inventory space for some spells that have bad dbc data 2022-09-12 09:15:27 +02:00
jackpoz c237b056b3 Core/Spells: Fix missing "Inventory is full" with spells that create more than 1 item 2022-09-12 09:15:26 +02:00
Ovahlord 5724e4c578 Core/Spells: fixed more cherrypick mistakes 2022-09-12 09:15:26 +02:00
Giacomo Pozzoni b052d23c4f Core/Creatures: Fix spell_school_immune_mask being applied against positive spells too (#23999) 2022-09-12 09:15:26 +02:00
Giacomo Pozzoni d2918d2138 Core/Spells: Fix Spellsteal stealing Silence buff of Arcane Torrent (#23992) 2022-09-12 09:15:26 +02:00
Ovahlord ec09a4830a Core/Spells: resolved a couple cherrypick mistakes 2022-09-12 09:15:25 +02:00
Wyrserth 86749679c8 Core/Spell: honor IsStackableOnOneSlotWithDifferentCasters() when deciding if an aura should stack from different casters or not. (#23579) 
Fixes #23387 and #22818.
 2022-09-12 09:15:25 +02:00
Treeston ce662d1ad7 Core/Spells: Spell pushback now only affects players (as it should) 
# Conflicts:
#	src/server/game/Spells/Spell.cpp
 2022-09-12 09:15:25 +02:00
Wyrserth 3fe6b49575 Core/Loot: fix issue that prevented players from rolling for an unique-category item while an equipped item shares the same unique-category. 
# Conflicts:
#	src/server/game/Groups/Group.cpp
 2022-09-12 09:15:25 +02:00
Wyrserth b5e177edbc Core/Spell: fix some issues with taunt spells 2022-09-12 09:15:25 +02:00
Wyrserth 2fefbc800b Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction. 2022-09-12 09:15:24 +02:00
Wyrserth 66112dff81 Core/Loot: implement automatic pass in group loot for items that cannot be looted. 2022-09-12 09:15:24 +02:00
Wyrserth 2f5fd3f227 Core/Spells: don't allow spells with SPELL_EFFECT_CREATE_ITEM_2 to be cast if there isn't enough space in inventory 2022-09-12 09:15:24 +02:00
Gildor 85893e9a44 Core/Spells: Fix spells with Health Leech effect, now check damage absorb when calculate Heal 2022-09-12 09:15:24 +02:00
brotalnia 7cc33f1bb7 Core/Spells: Return CheckCast result from CastSpell (#23236) 
* Return CheckCast result from CastSpell

* Return cast result from UnitAI methods too.
 2022-09-12 09:15:23 +02:00
Trond B. Krokli 89d0f363cf Core/Spells: make Four Horsemen debuffs negative (#23253) 
By Riztazz
Closes #23248
 2022-09-12 09:15:23 +02:00
PolarCookie 81e5943bd0 Core/Spell: SpellAura Redux (#22794) 
* typo and correction

* spell aura no longer shared between targets

_spellAura isolated

* SPELL_AURA_CONTROL_VEHICLE is not strictly single target spell

Steam Tank Control and Wyrmrest Commander

units can reseat themselves again

* Rename 9999_99_99_99_world.sql to 2019_03_08_00_world.sql
 2022-09-12 09:15:23 +02:00
jackpoz 068d7f826e Core/Spells: Fix assert triggered 
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the aura owner, then processing the main spell effects. The triggered spell can kill the aura owner, changing its death state to CORPSE and removing auras created.

Fix #21856
Ref 518e6299ca08a362bc3709daaaa5e5d5633d1bf1
 2022-09-12 09:15:23 +02:00
jackpoz e35c68c548 Core/MapScripts: Allow GameObjects to be caster of SCRIPT_COMMAND_CAST_SPELL 2022-09-12 09:15:22 +02:00
jackpoz 1180c43bac Core/Spells: Fix assert triggered 
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the target, then processing the main spell effects. The triggered spell can kill the target, changing its death state to CORPSE and removing auras created.
Fix #22306
 2022-09-12 09:15:22 +02:00
Shauren e395af341a Core/Spells: Fixed crash with some gameobject spell casters 2022-09-12 09:15:22 +02:00
Shauren 54b65fc2ac Core/Objects: Properly ASSERT when trying to access invalid updatefields 2022-09-12 09:15:22 +02:00
Shauren 96c4a1b1f9 Core/Spells: Fixed unapplying rockbiter weapon 2022-09-12 09:15:21 +02:00
Shauren 5ceba73504 Core/Spells: Corrected haste affecting GCDs to match 3.3.5 client logic 2022-09-12 09:15:21 +02:00