Commit Graph
1571 Commits
Author SHA1 Message Date
Ovahlord ab482d2d4f Core/Spells: fixed Pandemic talent 2021-05-23 14:27:34 +02:00
Ovahlord 47d984d538 Core/Spells: converted some missing spell scripts that sneaked through the first iteration 2021-05-23 13:48:51 +02:00
Ovahlord d47141ba98 Core/Spells: updated most warlock spell scripts to new scripting model 2021-05-23 13:46:18 +02:00
Ovahlord 76cee22609 Core/Spells: Pain and Suffering will now also recalculate the periodic tick interval of Shadow Word: Pain 2021-05-23 13:27:20 +02:00
Ovahlord 254b4eb011 Core/Spells: Drain Life's healing effect will no longer benefit from Soul Siphon and updated Soul Siphon's bonus check to Cataclysm 2021-05-23 12:59:39 +02:00
Ovahlord 7919cdf0b6 Core/Spells: Pain and Suffering's proc effect will now also recalculate the damage of Shadow Word: Pain 2021-05-23 11:19:07 +02:00
Ovahlord e17761777c Core/Spells: as of Patch 4.3.0 Death Strike will now heal the Death Knight whenever the ability hits or not 2021-04-20 22:29:02 +02:00
Ovahlord b571624894 Core/Spells:
* Conviction may now also proc from critical healing effects
* Enlightened Judgement will now heal the caster when casting Judgement
* Repentance will no longer get canceled by Censure
2021-04-20 22:21:45 +02:00
Ovahlord 109f696183 Core/Spells: Kill Command will now require the caster's pet to have a attacking target
closes #248
2021-04-16 21:00:39 +02:00
Ovahlord ad9b2b0aba Core/Spells: fixed Seal of Insight's mana gain bonus and moved heal formula to spell script for consistency 2021-03-13 12:07:19 +01:00
Ovahlord a52bc1798c Core/Spells: fixed Hunter's Sic 'Em talent 2021-03-08 20:26:22 +01:00
Ovahlord fcce0355d5 Core/Spells: cleaned Earth Shield's spell script up 2021-02-27 13:50:00 +01:00
Ovahlord 6e3539df30 Core/Spells:
* corrected implementation of SPELL_AURA_MOD_SPELL_POWER_PCT
* ported implementation of SPELL_AURA_OVERRIDE_SPELL_POWER_BY_AP_PCT from master branch
* dropped some deprecated class script handlings and moved Nourish 20% healing bonus to spell script
2021-02-27 12:37:14 +01:00
Ovahlord b0101ecb67 Scripts/Quest:
* fixed a typo that was preventing Paladins from receiving kill credits for practicing Judgement on training dummys
* added spell script to Wounded spell for wounded healing targets and fixed quest 'Healing the Wounded' in Northshire
2021-02-25 13:30:16 +01:00
Ovahlord 42f3e722f6 Core/Spells: fixed a typo that caused Divine Aegis to absorb 0 damage in all cases and corrected proc behavior 2021-02-21 11:23:17 +01:00
Ovahlord 3d20971d01 Core/Spells: Seal of Insight will no longer proc on AOE attacks and updated proc data for Cataclysm instead of MoP 2021-02-19 17:51:07 +01:00
Ovahlord 63f2dcd05e Core/Spells: dropped Fingers of Frost charge drop spell script and use the new proc attribute instead. 2021-02-19 12:56:01 +01:00
Ovahlord f91c30868f Core/Spells: 6c0cf9580b followup and improved readability of the code
superceeds #223
2021-01-19 14:18:48 +01:00
Ovahlord 6c0cf9580b Core/Spells: block Bandit's Guile procs when the rogue has reached deep insight 2021-01-18 23:57:19 +01:00
Ovahlord 8204a3e93d Core/Spells: Bandit's Guile will now require a certain amount of successful procs before gaining the Insight buffs
closes #221
2021-01-18 19:01:48 +01:00
Ovah 4a158fdf22 Core/Spells: Ancestral Vigor will now stack it's health bonus values up to 10% of their target's maximum health
closes #212
2021-01-13 05:54:54 +01:00
Ovahlord 4a28a9d700 Core/Spells: added visual indicator when reaching max Maelstrom Weapon stacks 2020-11-14 21:42:38 +01:00
Ovahlord 754c138f89 Core/Spells: ported CastSpell unclusterfucking from 3.3.5 branch 2020-11-04 22:37:11 +01:00
Ovahlord 3926de0ba5 Core/Spells: fixed Euphoria's mana energize effect when entering an Eclipse state 2020-10-30 22:54:31 +01:00
Ovahlord 23d56d3bc6 Core/Spells: fixed warnings 2020-10-23 00:07:37 +02:00
Ovahlord 6d37b9a455 Core/Spells: Arcane Missiles will now proc on spell cast instead of spell hit and may proc from triggered missiles 2020-10-22 23:53:51 +02:00
Ovahlord 6335bccb72 Core/Spells: reworked Druid's Eclipse Handling 2020-10-22 23:51:34 +02:00
Ovahlord 973d4a139a Core/Spells: fixed DK T12 dps 2p and 4p bonus effects 2020-10-01 22:20:29 +02:00
Ovahlord 84a5437001 Core/Spells: updated Lava Surge spell scripts to new model and added db proc entry 2020-09-28 21:05:34 +02:00
Ovahlord 6594fb650d Core/Spells: fixed Relentless Strikes talent 2020-09-27 17:21:37 +02:00
Ovahlord 35b07faf2b Scripts/Quests: scripted Launch Quest spells and use them to launch the 'A Personal Summon' quests when entering Stormwind or Orgrimmar 2020-09-26 19:57:05 +02:00
Ovahlord d2790a4c32 Core/Spells: cleaned up and updated Envenom spell script to Cataclysm
* fixed the spell script not changing the dealt damage at all
2020-09-23 20:48:45 +02:00
Ovahlord c3eda5eb45 Core/Spells: updated Holy Shock spell script to Cataclysm
* fixed T11 Holy set bonus for Paladins not proccing from Holy Shock heal effects
2020-09-11 22:07:55 +02:00
Ovahlord b2bddb2921 Core/Spells: fixed an issue that was preventing Bandit's Guile's Deep Insight not getting removed when switching combat targets 2020-09-11 21:42:14 +02:00
Ovahlord 9df379b30a Core/Spells: fixed Druid's Skull Bash abilities and Brutal Impact talent
closes #97
2020-09-11 20:16:49 +02:00
Ovahlord d57332ca5d Core/Spells: Selfless Healer's damage bonus will now scale with the amount of holy power 2020-08-31 18:06:15 +02:00
Ovahlord 32cf373719 Core/Spells: updated Focus Magic spell script to Cataclysm 2020-08-30 17:28:32 +02:00
Ovahlord 27bbba32aa Core/Spells:
* fixed Protector of the Innocent talent
* fixed Tower of Radiance talent
* fixed Blessed Life talent
* fixed Gift of the Earthmother Rejuvenation instant heal effect
2020-08-29 21:33:16 +02:00
Ovahlord 89fdfd5d7f Core/Spells: corrected Furor behaivior and fixed an exploit that was allowing druids to get full energy when turning into cat form 2020-08-28 15:51:29 +02:00
Warpten 2b2fc5fb8a Core/Spells: remove PrepareSpellScript and PrepareAuraScript macros and make Hooklist use emplace behaivior (#174) 2020-08-28 15:40:26 +02:00
Ovahlord 6e257a5123 Core/Spells: Warrior's Deep Wounds periodic damage is now based on normalized weapon damage and will only use the mainhand weapon as reference 2020-08-25 15:18:44 +02:00
Ovahlord d8478b689c Core/Spells:
* fixed Glyph of Dazing Shield proc
* fixed Glyph of Colossus Smash
* fixed Glyph of Divinity
* updated Glyph of Heroic Throw to Cataclysm
2020-08-24 23:18:51 +02:00
Ovahlord 75a0e1c011 Core/Spells: updated Bloodworm's Blood Gorged behaivior to Cataclysm 2020-08-24 18:32:31 +02:00
Shauren 44e0d6c0f9 Scripts/Spells: Replace RegisterAuraScript with RegisterSpellScript and remove it 2020-08-23 17:44:48 +02:00
Ovahlord 5be03870b5 Core/Spells:
* fixed Hunter Fervor talent
* fixed Hunter Killing Streak talent
* fixed Crouching Tiger, Hidden Chimera talent
* allow controlled units to proc the auras of their owner when dealing spell damage
2020-08-23 00:51:52 +02:00
Ovahlord 9f6a7f6671 DB/Spells: added missing scriptname to Druid's bear form Vengeance proc 2020-07-26 18:23:41 +02:00
Ovahlord a31111ebbb Core/Spells: allow Rune Strike to be permanently used while in Blood Presence 2020-07-23 22:52:55 +02:00
Ovahlord 7bbc603efa Core/Spells: feign death react state cleanup 2020-07-22 17:23:58 +02:00
Treeston 942c3a77da Core: Combat/threat system rewrite (PR #19930)
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
  - They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
  - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
  - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.

Closes #7951 and #19998.
2020-07-22 16:49:37 +02:00
treeston a09db6b4ba Hi, I'm Treeston, and welcome to Combat PR Prep Refactors.
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedEscortAI.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Spells/SpellEffects.cpp
#	src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/boss_tomb_of_seven.cpp
#	src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp
#	src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp
#	src/server/scripts/EasternKingdoms/ShadowfangKeep/instance_shadowfang_keep.cpp
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp
#	src/server/scripts/EasternKingdoms/zone_tirisfal_glades.cpp
#	src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/culling_of_stratholme.cpp
#	src/server/scripts/Kalimdor/WailingCaverns/wailing_caverns.cpp
#	src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp
#	src/server/scripts/Kalimdor/zone_stonetalon_mountains.cpp
#	src/server/scripts/Kalimdor/zone_tanaris.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp
#	src/server/scripts/Northrend/Naxxramas/boss_thaddius.cpp
#	src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
#	src/server/scripts/Outland/TempestKeep/arcatraz/boss_harbinger_skyriss.cpp
2020-07-22 14:35:53 +02:00