Commit Graph
7018 Commits
Author SHA1 Message Date
Shauren ea214c223e Core/Misc: Ported relevant barbershop fixes from 4208c0d8396e10dc806939e1d17885d16ff7b84e 2015-04-24 18:40:19 +02:00
w1sht0l1v3 837a0a7524 Core/LFG: Move code to a better place.
(the case where the last player left inside a dungeon would not be removed from lfg&group when he ports outside)
2015-04-23 22:10:15 +03:00
jackpoz c3b8800cf7 Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1023036, 1022620
2015-04-19 17:45:55 +02:00
Northstrider 1566f45c31 Core/Creatures: remove virtual mounts from creatures on death
Closes https://github.com/TrinityCore/TrinityCore/pull/14396

(cherry picked from commit b5393d4b9b)
2015-04-19 15:42:05 +02:00
MitchesD 7836a4a418 Core/Unit: fixed removing UNIT_FLAG_PET_IN_COMBAT from guardians
Closes https://github.com/TrinityCore/TrinityCore/issues/14566

(cherry picked from commit 8096edec15dc2c51d2c9f57b618cd0ced569f793)
2015-04-19 14:49:29 +02:00
jackpoz 5b5c0938da Core/Misc: Fix issues reported by static analysis
Properly fix Coverity defect ID 1227434
2015-04-18 17:33:14 +02:00
Kittnz 5f8db04761 Core/Condition: Add In Water Condition
Updates #7019
2015-04-18 17:11:03 +02:00
w1sht0l1v3 1019649f93 Core/LFGMgr: One more addition to fix the crash on logout. 2015-04-15 20:37:18 +03:00
w1sht0l1v3 f56cdd4496 Core/LFGMgr: Attempt to leave LFG the right way...i think... 2015-04-13 19:27:12 +03:00
click adb39317fa Core: Follow codingstyle guidelines (CamelCase for functions, lowerCamel for vars and local stuff) 2015-04-10 04:14:50 +02:00
click a09eafa104 Core: Whitespace/tab2spaces cleanup 2015-04-10 04:12:06 +02:00
WishToDie 08a62f19b8 Update LFGMgr.cpp
Core/LFGMgr: Fix crash in e743f4a479
2015-04-09 18:29:20 +03:00
click 6c1e4bc20d Core/Spells: Reinstate helperfunction removed in commit 0e3607df (with a new functionname to make more sense out of it), and adjust the remaining code slightly to accomodate that. 2015-04-07 23:51:19 +02:00
click 0e3607df5b Core/Spells: Allow non-skill-based flying mounts to be used in designated areas.
- Flying mounts that are not in the "SKILL_MOUNT"-tree and area-restricted can now be used properly (ex. 64749 - Loaned Gryphon).
- Remove isKnowHowFlyIn()-function (useless and deprecated since this is handled properly in the spellsystem).
Massive thanks to rat for extremely good help and support on fixing this (most of this is his work).
2015-04-07 21:26:23 +02:00
w1sht0l1v3 e743f4a479 Core/LFGMgr: Fix the case where the last player left in a lfg group would be stuck in party when porting out of the instance.
If you find a better way or think this is wrong feel free to remove it or improve it.
2015-04-05 22:03:40 +03:00
Shauren 96b7b7ced5 Build fix for GCC 4.7
(cherry picked from commit e7deae947c94eab04370b5bdaab059ac425d697d)
2015-04-05 13:57:45 +02:00
Carbenium 67238e2166 Rename variables to fix C++11 keyword collision
(cherry picked from commit 573cda7b524ee4d7d23cefd026b056181f451a8b)
2015-04-05 00:36:33 +02:00
Carbenium bdc9beacbd Merge pull request #13862 from ariel-/pr_tmp
Implement CharSections.dbc and Serverside Checks.
2015-04-05 00:09:03 +02:00
Shauren 548aa119ac Core/Networking: Fixed unsafe access to _worldSession member in WorldSocket
(cherry picked from commit bed88e0dd475af5b73cea03821f7fb7cb9ddce9d)

Core/Networking: Fixed deadlock in HandlePing if the client is about to be kicked for overspeed pings

(cherry picked from commit 3da0f7e40920b652d2222fa88dbb4b516d24725d)

Core/Networking: Cleanup CloseSocket calls from read failures in WorldSocket

(cherry picked from commit 18343a7309fbf53a3509749c0a5ca1f8ea273c57)

Conflicts:
	src/server/game/Server/WorldSocket.cpp

Ref #14474
2015-04-04 23:07:41 +01:00
jackpoz d23538ce56 Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1227510, 1227434, 1023036, 1062426, 1062425, 1062424, 1062423, 1062422
2015-04-04 20:20:04 +02:00
click f44555500b Core: Comment out unused parameter in DBCStructure.h (removes a warning) 2015-04-04 18:21:15 +02:00
jackpoz 76986880c9 Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1267938, 1267937, 1267933, 1267932, 1267929
2015-04-04 16:40:01 +02:00
jackpoz 2dc97e3f3d Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1292769, 1292768, 1292765, 1292763, 1267939
2015-04-04 15:28:13 +02:00
jackpoz c38d4f57b3 Core/Dungeon Finder: Add additional logs for SMSG_LFG_QUEUE_STATUS
Log the current LfgState of the target player when sending SMSG_LFG_QUEUE_STATUS packet.
2015-04-04 14:01:11 +02:00
jackpoz 25e86f75f8 Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1292760, 1292761, 1292762, 1292771, 1292770
2015-04-04 12:44:56 +02:00
Duarte Duarte 20bc2c51f6 Merge pull request #14083 from Gooyeth/3.3.5_sample_satisfaction
Core/Spells: Fixed Sample satisfaction not entering combat
2015-04-03 18:32:02 +01:00
MitchesD 93fa363d9a Core/SAI: fix typo
(cherry picked from commit 9ed21eb5b176986dd73c2a467e665fe449499155)
2015-04-02 21:30:39 +02:00
Naios c9b0c8a0ca Core/World: Remove va_list from World::RecordTimeDiff.
* also split it in ResetTimeDiffRecord() and RecordTimeDiff() to avoid passing of null values.
2015-04-02 21:07:46 +02:00
MitchesD 8d58bb93c9 Core/SAI: fix merge conflict
it's good to use CTRL + S
2015-04-02 18:34:31 +02:00
MitchesD 1de02764c7 Core/SmartScripts: added SMART_ACTION_SET_COUNTER and SMART_EVENT_COUNTER_SET
as per request of DB developers

(cherry picked from commit 23b1c042adbe3a460457aa11f017c90e6600bfa2)

Conflicts:
	src/server/game/AI/SmartScripts/SmartScript.h
2015-04-02 18:30:27 +02:00
click d8ef63040a Core/Packet: Correction to packetsize for SMSG_WEATHER 2015-04-02 02:46:25 +02:00
leak 7010671931 Core/Misc: Remove unused headers 2015-03-30 17:16:50 +02:00
click 50bbfeebb9 Core/Entities: Add player name and ID to GetXPrestBonus calculation-log 2015-03-30 02:06:07 +02:00
click e040c56d45 Core/Logger: Add basic account-info to addon-scans to make them a little bit more useful (@Aokromes, you can stop asking for this now...) 2015-03-29 19:19:45 +02:00
Naios c386711972 CMake: Use source_groups to represent the source tree
* It let ide's (like vs) display the source tree.
* Disabled by default.
* Soft requirement is cmake >= 2.8.12 .
* Offers 2 modes: flat & hierarchical.
* For detailed description see #14471
* Thanks @click for help and advises.
* Closes #14471
2015-03-29 16:08:28 +02:00
Naios 71c0d4f792 Core/Log: Fix linker errors that occur on msvc 12 lower then update 4
* http://stackoverflow.com/questions/4891067/weird-undefined-symbols-of-static-constants-inside-a-struct-class
* http://www-01.ibm.com/support/knowledgecenter/SSGH3R_8.0.0/com.ibm.xlcpp8a.doc/language/ref/cplr038.htm%23cplr038
* closes #14463
* ref #14317

(cherry picked from commit 9b0b1185e4f9eb48cd16237f7622204687b9c01a)

Conflicts:
	src/server/game/Server/WorldSocketMgr.cpp
2015-03-28 17:29:43 +01:00
cr4st 81dcfa4077 Core/Creature: fixed trigger visibility of vehicles
(cherry picked from commit 5cee106524d8d7e0048270042be9fd02ce399a21)
2015-03-25 17:52:10 +01:00
tkrokli d1221e3433 [Core/Quest] Update quest Objective status Client side
by @untaught; closes #12172

AreaExploredOrEventHappens does not update client side, only server side.
Before adding this fix, it is necessary to complete the required number of kills
to receive the "discovery" Quest Objective Credit in player's Quest Log and on screen.
2015-03-22 06:32:18 +01:00
jackpoz d888e4c7ad Scripts/Ulduar: Fix some Flame Leviathan issues
Fix some Flame Leviathan issues:
- Fix boss evading all the time due to bad Doors check
- Opened "Lightning Door" to other bosses only after boss dies
- Eject players from the vehicles when boss dies, make them untargetable and despawn them after 5 minutes (adjust the time to the blizzlike time of choice)
2015-03-21 23:57:49 +01:00
Naios 2bd1c8541d Core/Updates: Add an automatic database update system. Automatically detects new and edited sql updates through file lists and hashing. Detects renames, deletes and is able to create and auto import full databases. * cleanups in main.cpp of world & bnetserver * refactoring in DatabaseWorkerPool.h & MySQLConnection.cpp
Make sure you re-run cmake, because boost::iostreams was added as dependency.
Maybe you need to install libboost-iostreams1.55-dev on unix as well.

Import every update manual until (included) those INSERT IGNORE updates for each database.

Thanks DDuarte and Shauren for your amazing ideas, help and advises.

In hope that nobody gets a "Your database structure is not up to date..." anymore ,-)

(cherry picked from commit 352012e53173372ebc82898e1b6854c983b01b25)
(cherry picked from commit 1f7f9feafc3f5017d617634ae993d2cdf4430920)

For 3.3.5:
* Synchronized ConfigureBoost.cmake with 6.x, libboost-filesystem1.55-dev also added as dependency!

Signed-off-by: Naios <naios-dev@live.de>
Signed-off-by: Nayd <dnpd.dd@gmail.com>
2015-03-21 20:54:54 +00:00
ariel- 461daadcaf Split up LANG_MAP_POSITION to fix a crash when issuing .gps command 2015-03-19 06:08:27 -03:00
Nayd 2ac40775a2 Core/Spells: Implement HasAttribute() helper for SpellInfo for easier readability
Original code by @Shocker (6.x branch)
2015-03-18 23:16:39 +00:00
Naios e96676aedd Core/Misc: Fix some issues detected by static analysis
* Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
  -> This argument is passed by value, it makes no sence so set it to null here.

* Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor.

(cherry picked from commit 433bc289c2c82b7377ad0189e415a3ca070d220f)
2015-03-18 20:23:47 +01:00
Shauren bba8555a29 Build fix 2015-03-18 11:47:30 +01:00
Carbenium 03176662d1 Merge pull request #14317 from Naios/typesafelog
Type safe logging
(cherry picked from commit cc0c9add5a3f3a17e19029ddcaa7e711040f4fc5)

Conflicts:
	src/server/bnetserver/CMakeLists.txt
	src/server/game/Server/WorldSocketMgr.cpp
	src/server/shared/Logging/AppenderDB.cpp
	src/server/worldserver/CMakeLists.txt
2015-03-18 02:59:40 +01:00
Naios 301ec0be56 Core/Game: Fix some issues detected by static analysis.
* Possible inefficient checking for 'list' emptiness.

* Variable '_scheduledScripts' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Variable 'Text' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Possible inefficient checking for 'm_loadedScripts' emptiness.

(cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667)

Conflicts:
	src/server/game/Server/Packets/TicketPackets.cpp
2015-03-18 01:13:47 +00:00
Duarte Duarte 769acfbd02 Merge pull request #14370 from Kittnz/realm_achievement
Core/Condition: Realm Achievement condition
2015-03-17 12:42:35 +00:00
Kittnz e50489c010 Core/Condition: Added Realm Achievement condition
- Partly Fixes https://github.com/TrinityCore/TrinityCore/issues/5754
@DRJ has SQL examples
2015-03-16 20:03:49 +01:00
joschiwald d3ad87b1cf Core: silence broadcasttext startup errors 2015-03-16 14:18:31 +01:00
click cf14e9051d Merge pull request #14371 from Kittnz/movecirclepath_003
Core: Move FillCirclePath function to MotionMaster
Closes #14371
2015-03-15 21:32:35 +01:00