Subv
25acef2572
* Batch of fixes for issues found by static analysis.
2013-05-17 21:11:18 -05:00
horn
0a0698b1d4
Scripts/Ulduar: Yogg-Saron
...
Known issues:
- encounter doesn't start immediately after you enter the room, you need to go closer
- players standing outside of the room are not turned Insane after 15 seconds
- encounter resets if the last living player is gripped by Constrictor Tentacle or encased in Hodir's Flash Freeze
- Hodir won't freeze multiple players when they die at the same moment
- Flash Freeze missile (64176) won't hit anybody, probably cast too soon (cosmetic issue)
- there are some unused spells, don't know when or why they should be cast
- some spell animations hit multiple players, but they shouldn't do that
2013-05-14 17:52:37 +02:00
Spp
d1677b2db0
Core/Logging: Performance-related tweaks to logging system
...
All sLog->out* functions (except outCommand atm) are replaced with TC_LOG_* macros.
Memleak fix
2013-05-13 15:07:36 +02:00
Spp
243c325ca4
Core: Declare some functions const and remove use of "using" directive in a couple of files
2013-05-13 15:04:05 +02:00
Shauren
45bae8d4b7
Core/Players: Fixed tabard championing in normal modes of WotLK level 80 dungeons
...
Closes #9227
2013-05-04 20:50:14 +02:00
Spp
7c36e3a298
Core/Misc: Minor optimizations (+ code changes to reduce differences with 4.3.4 branch)
2013-03-25 10:36:30 +01:00
Spp
69e81d46b1
Core/Misc: Define multiple functions const (+ code cleanup here and there)
2013-03-20 14:20:17 +01:00
Gacko
59bc6ed0ae
Core/Unit: Fall after exiting vehicle if is in air and can not fly
2013-03-15 19:36:50 +01:00
Gacko
44553d3fd4
Fix some engrish
2013-03-15 16:50:40 +01:00
Shauren
2c169bcca5
Core/Vehicles
...
* Fixed crash happening when passenger died on vehicle he was controlling
* Fixed crash happening if vehicle control aura was removed before passenger is fully added to vehicle
Closes #7160
2013-03-13 11:34:58 +01:00
Shauren
b3b66a8d02
Core/Vehicles: Fixed a possible crash if vehicle is deleted before its passenger runs Abort on pending join event
...
Closes #9392
2013-03-09 23:42:54 +01:00
Nefarion
49fd11ab5a
First step of comment style refactoring to doxygen-style.
2013-03-08 21:55:37 +01:00
Vincent_Michael
5d4e657e91
Core: Whitespace cleanup
2013-03-04 19:14:58 +01:00
QAston
4eec72c986
Core/Entities: Move complex function implementations from Player.h to Player.cpp
2013-03-04 15:56:00 +01:00
QAston
2e96f8192c
Move complex functions from Unit.h to Unit.cpp
2013-03-04 09:38:38 +01:00
Shauren
bed73397b6
Core/Spells: Improved facing setting for creature casts
2013-03-03 23:15:54 +01:00
Shauren
4a6f5d2b54
Core/Spells: Defined & implemented SPELL_ATTR6_IGNORE_CATEGORY_COOLDOWN_MODS
2013-02-28 20:46:50 +01:00
Shauren
f3e7886934
Core/Spells: Defined two spell attributes
2013-02-28 20:25:20 +01:00
Nay
3b1410e798
Core/Player: Rename PLAYER_FLAGS_UNK19 to PLAYER_FLAGS_UBER
2013-02-26 20:58:13 +00:00
QAston
c6d6cb7e74
Merge pull request #9062 from Chaplain/origin
...
Core/Spells: Rename wrong spell attribute
2013-02-25 07:52:37 -08:00
QAston
6e55e3f352
Merge pull request #9260 from ille/randomtypos03
...
Core/Conditions: add missing break
2013-02-25 07:49:33 -08:00
Shauren
06257d1034
Core/Movement: Do not attempt to pathfind for stop/turn movement
2013-02-24 14:48:03 +01:00
Shauren
16f9a9d1b4
Core/Vehicles: Fixed a crash that happened if someone called ExitVehicle during seat changing
2013-02-24 14:38:47 +01:00
ille
4657cb896f
Core/Conditions: add missing break
...
Core/Units: use attackers MeleeDamageSchoolMask to calculate benefit/mod for auras with SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_DAMAGE_PERCENT_TAKEN in Unit::MeleeDamageBonusTaken()
thx bonitas for pointing
2013-02-20 20:41:48 +01:00
Vincent_Michael
9004d39c09
Core: Whitespace cleanup
2013-02-18 00:56:25 +01:00
Machiavelli
01fbbf3b93
Core/Vehicles: Refactor some parts of vehicle system
...
- Fix a few crashes:
Closes #9235
- Simplify and get rid of lots of redundant and silly code
- Optimisations in Unit::ChangeSeat
- More documentation
2013-02-18 00:39:58 +01:00
Machiavelli
0049e580eb
Core/Auras: Restore part of 1845ab79 that was accidentally reverted
2013-02-17 14:48:14 +01:00
Machiavelli
6590cf4f9e
Core/Vehicles: Fix another crash
...
Don't set Unit::m_vehicle until VehicleJoinEvent::Execute
2013-02-17 08:03:27 +01:00
Shauren
e49aaab6f6
Scripts/Icecrown Citadel: Improvements to Shadowmourne quest line
2013-02-17 02:10:08 +01:00
Shauren
1845ab7918
Core/Auras: Only auras that are stackable to use the same slot
2013-02-16 15:40:47 +01:00
Shauren
f74b874e93
Core/Auras: Allow auras that cannot create a separate stack for each caster to stack on one slot
2013-02-15 18:08:15 +01:00
Vincent_Michael
2c2fe7d464
Core/Misc: Small code optimisations
2013-02-02 19:06:47 +01:00
Vincent_Michael
9d7d68395c
Core/SmartAI: Implement SMART_ACTION_SET_ROOT (103)
2013-02-02 18:18:27 +01:00
Chaplain
1459de81e0
Core/Spells: rename wrong spell attribute
...
*SPELL_ATTR0_BREAKABLE_BY_DAMAGE -> SPELL_ATTR0_HEARTBEAT_RESIST_CHECK
2013-01-25 23:40:22 +03:00
blub
a6f587a3b1
Merge pull request #9016 from joschiwald/spellscripts4
...
Core/Spell: convert more spells to SpellScripts
2013-01-23 11:19:39 -08:00
joschiwald
af50ce6223
Core/Spell: convert more spells to SpellScripts
2013-01-22 23:36:51 +01:00
Vincent_Michael
224b4480a7
Merge branch 'master' of github.com:TrinityCore/TrinityCore into mmaps
2013-01-16 23:43:07 +01:00
Trista
8081704c66
Merge pull request #8879 from joschiwald/spell_proc_scripts
...
Core/SpellScripts: Implement Spell Proc Hooks and use them in old and new ...
2013-01-15 14:56:45 -08:00
Nay
e6a07076c3
Merge remote-tracking branch 'origin/master' into mmaps
...
Conflicts:
src/server/game/Entities/Unit/Unit.cpp
src/server/game/Movement/MotionMaster.cpp
src/server/game/Movement/MovementGenerators/FleeingMovementGenerator.cpp
src/server/game/Movement/MovementGenerators/HomeMovementGenerator.cpp
src/server/game/Movement/MovementGenerators/PointMovementGenerator.cpp
src/server/game/Movement/MovementGenerators/RandomMovementGenerator.cpp
src/server/game/Movement/MovementGenerators/TargetedMovementGenerator.cpp
src/server/game/Movement/Spline/MoveSplineInit.cpp
2013-01-14 13:58:34 +00:00
Spp
802657250c
Core/Misc: Apply codestyle to multiple files
2013-01-14 09:50:59 +01:00
Vincent_Michael
d6d2cb0490
Merge branch 'master' of github.com:TrinityCore/TrinityCore into mmaps
2013-01-11 14:58:57 +01:00
Nay
efa094e893
Merge pull request #8581 from Butterfly69/patch-9
...
Core/Spells:Beacon of Light
2013-01-10 23:29:51 -08:00
joschiwald
89490e4d7f
Core/SpellScripts: implement Spell Proc Hooks and use it in old and new proc system
...
Hooks:
- DoCheckProc: executed when aura checks if it can proc
- DoPrepareProc: executed before aura procs (possibility to prevent charge drop/cooldown)
- OnProc: executed when aura procs
- OnEffectProc: executed when aura effect procs
- AfterEffectProc: executed after aura effect proced
- AfterProc: executed after aura proced and charges removed
using PreventDefaultAction() in DoPrepareProc will prevent charge drop and cooldown
default execution of a proc can prevented in OnEffectProc with PreventDefaultAction()
Now we should be able to convert almost all procs from Unit::ProcDamageAndSpellFor to SpellScripts
Notes to old proc system:
- if a proc has a cooldown we must check it in spellscript and add it when we handle the proc
- behavior with charge drops is possible undefined (use PreventDefaultAction() in OnEffectProc to notify that the script is executed)
2013-01-11 01:21:44 +01:00
Vincent_Michael
b69dff28db
Merge branch 'master' of github.com:TrinityCore/TrinityCore into mmaps
...
Conflicts:
src/server/game/World/World.cpp
src/server/worldserver/worldserver.conf.dist
2013-01-07 16:57:39 +01:00
Nay
5f28502c0a
Merge pull request #8738 from joschiwald/spell_proc_conditions
...
Core/Conditions: implement CONDITION_SOURCE_TYPE_SPELL_PROC and use it i...
2013-01-06 18:29:55 -08:00
Valcorb
8743e9d368
Fix a small typo
2013-01-07 00:55:11 +01:00
Valcorb
8d9476fd9c
Make sure that "guardians" also gain the owner's speed
2013-01-06 22:35:25 +01:00
Vincent_Michael
24e0eb1812
Merge branch 'master' of github.com:TrinityCore/TrinityCore into mmaps
...
Conflicts:
src/server/game/Movement/Spline/MoveSplineInit.cpp
2013-01-05 16:55:17 +01:00
Nay
8ac5b3b7d6
Core/Player: Prevent a crash in CastedCreatureOrGO and add an assertion to KilledMonster
2013-01-04 21:15:18 +00:00
Subv
ef9f2aca0d
Merge pull request #8753 from MrSmite/Pet_SpeedFix
...
Fix pets lagging behind and despawning
2013-01-03 17:04:50 -08:00