Commit Graph
100 Commits
Author SHA1 Message Date
Shauren c7d5c24bfe fix typo 2017-02-10 05:26:49 +01:00
Shauren 9d4a1ddc10 Core/Maps: Adjusted WorldObject::GetGridActivationRange() to never be less than map visibility distance for active objects to ensure equal ranges for activation/deactivation of grids
Updates #19072
2017-02-10 05:26:38 +01:00
Shauren fae31bf07d Core/Auras: Prevent infinite stacking of passive auras with the same id from the same caster on the same target
Closes #18475

(cherry picked from commit 88676120586df7581677eca8d5e2724579c69482)
2017-02-10 05:25:16 +01:00
Shauren 043b4de635 Fixed clang segmentation fault in nopch mode
(cherry picked from commit 787adc24b2d1a7a3c03ecfed57de27631359ef65)
2017-02-05 01:54:34 +01:00
Shauren b80a8dd9fa Core/DBLayer: Refine new query callback for chaining
(cherry picked from commit 73e61fa652d1233bfff1db91fa2bca8c317c8caf)
2017-02-01 01:21:10 +01:00
Shauren 7f91c34200 Core/DBLayer: Added new async query callback api
(cherry picked from commit fcabeed7544285f3244465ccfc5337c59e63c6b0)
2017-02-01 01:20:52 +01:00
Shauren dc2deb8602 Core/Vmaps: Changed error message when loading outdated vmaps
Closes #18431
Closes #18857
2017-01-23 00:17:17 +01:00
Shauren bbcd694155 Fix static analysis issues
CID 1291964
CID 1292775

(cherry picked from commit 6767bbc95f46df4b62c8131a39a132d3f9bb8a26)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Spells/SpellHistory.h
	src/server/game/Spells/SpellInfo.cpp
2017-01-23 00:15:36 +01:00
Shauren 5ac6ed25d1 Core/Player: Removed unneeded distance check from Player::ActivateTaxiPathTo, it is already checked by HandleActivateTaxi* methods (and taxis started serverside should not have such requirements)
Closes #15398
2017-01-21 14:36:46 +01:00
Shauren 9401fd3621 Tools/mmaps_generator: Mak percentage progress slightly more accurate
#18832
2017-01-15 06:23:30 +01:00
Shauren 5ddf50bdee Core/Auras: Fixed removing auras triggered by aurastates
Closes #17868

(cherry picked from commit f94e6cee38241e10daed711247a18b8706cb8924)
2016-11-15 05:43:30 +01:00
Shauren a618a6b121 Core/Transports: Fixed crash added in b88cecb656c62cd3bcc3ae2a171b173eb64a28c9 2016-11-02 03:47:20 +01:00
Shauren bf19fe3e26 Core/Transports: Added extra transport position update just when it stops moving
Closes #17952
2016-11-02 03:46:52 +01:00
Shauren 93fd8f2511 Core/GameObjects: Fixed Frozen Trap target selection
Closes #14238
Closes #17517
2016-11-02 03:23:23 +01:00
Shauren a3e5afc027 Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures 2016-10-05 08:01:38 +02:00
Shauren f5a980be9b Core/Units: Clear UNIT_NPC_EMOTESTATE on death (blizzlike)
Closes #15263
Closes #18027
2016-10-04 18:07:59 +02:00
Shauren b1f20ced7a Core/Creatures: Exclude despawned creatures from being found by "nearest entry" searchers
Updates #11418
Closes #17706
2016-08-22 21:11:14 +02:00
Shauren a3d4957150 Typo fix 2016-08-22 20:54:59 +02:00
Shauren 89a630b1e4 Dynamic linking build fix 2016-08-22 20:53:56 +02:00
Shauren a778c8033f Core/Spells: Fixed possible null pointer dereference
Coverity CID 1357406

(cherry picked from commit cc07a491f64fa958c8a27079bd2def84c577f816)
2016-08-20 15:54:14 +02:00
Shauren f1c84639b5 Core/Misc: Warning fixes (/W4)
(cherry picked from commit c9ba5ce591a8b4ef5dc0e73d0ce107b6acf5e969)
2016-08-10 06:41:59 +02:00
Shauren ea918e1b69 Core/Utils: Added additional argument to Tokenizer class to make it behave like strtok - not returning empty tokens in case of multiple consecutive separators in input string
(cherry picked from commit dd1533b315bda37e1d43ebe0fb8bde87381c6e66)
2016-08-07 21:28:29 +02:00
Shauren 3d991107e2 Core/Commands: Cooldown command should fall back to targeting self in case of no valid selection 2016-07-20 19:34:45 +02:00
Shauren 792f48b554 Core/Commands: Allow .cooldown command to work on player pets 2016-07-20 19:34:04 +02:00
Shauren 286e796a55 Core/Quests: Failing/abandoning a quest should not unconditionally remove required items, non-quest specific items such as crafting reagents should remain in inventory 2016-07-20 19:31:30 +02:00
Shauren 8a5e7eba70 Core/Units: Fixed autoattack range
Closes #17539
2016-07-20 19:12:44 +02:00
Shauren 00cc84a51d And another typo fix 2016-07-20 18:44:49 +02:00
Shauren 6e755d05d8 Typo fix 2016-07-20 18:44:38 +02:00
Shauren 684fb69d0d Core/Spells: Fixed spell dest range check failing on 0 distance max range requirement even if standing directly on top of destination 2016-07-20 18:38:18 +02:00
Shauren fa7026cee3 Core/Spells: Fixed spell range check
Closes #17060
2016-07-20 18:26:18 +02:00
Shauren 05f11a46ba build fix 2016-07-20 16:05:51 +02:00
Shauren 5942d4da0a Core/Scripts: build fix 2016-07-20 14:15:04 +02:00
Shauren e58f0e805c Core/Units: Renamed and documented UNIT_FLAG_DISABLE_MOVE to prevent people from trying to use this flag to root a creature leaving them wondering why it doesn't do anything 2016-07-20 13:56:16 +02:00
Shauren 85e2bf54eb Core/Loot: Fixed resaving looted items from containers
Closes #15299
2016-07-20 13:51:07 +02:00
Shauren 1aed8daf9a Core/Spells: Implemented SPELL_ATTR1_DISMISS_PET
Closes #7372
2016-07-20 13:50:29 +02:00
Shauren f11a9a31c2 Core/Containers: Warning fixes and RandomResizeList with predicate optimization 2016-07-20 13:28:41 +02:00
Shauren 0233ced55e Core/Auras: Implemented auras SPELL_AURA_PREVENT_DURABILITY_LOSS and SPELL_AURA_PREVENT_DURABILITY_LOSS_FROM_COMBAT
(cherry picked from commit 17118f4832d527f160dc300a52db7ba6c255bce2)
2016-07-20 13:21:47 +02:00
Shauren 5c6802d509 Core/Spells: Fixed flat SPELLMOD_DAMAGE_MULTIPLIER calculation
(cherry picked from commit 35ab476f1691870a67c8ede78e9c37618f6bd383)
2016-07-20 13:04:59 +02:00
Shauren 0bf6e30f44 Build fix 2016-07-20 10:30:36 +02:00
Shauren a4498c7cab Core/Auras: Renamed fields of SpellProcEntry structure and change types to more appropriate ones 2016-07-20 10:25:03 +02:00
Shauren 60817bca50 Core/Random: Removed ancient and unused MAP_BASED_RAND_GEN 2016-05-12 09:22:46 +02:00
Shauren 763c1548f1 Core/Auras: SPELL_AURA_PERIODIC_LEECH can now properly overkill 2016-05-12 09:21:30 +02:00
Shauren f6824d1207 Core/Auras: Implemented AURA_INTERRUPT_FLAG_LEAVE_COMBAT
(cherry picked from commit d621023192a6480aa0f338908a353002fc6accf1)
2016-05-12 09:19:01 +02:00
Shauren af17e23204 Core/Misc: Fixed -Wmisleading-indentation warnings
(cherry picked from commit 3ac33163db2786cbd18f2158fc81d6ea9fa66316)

# Conflicts:
#	src/server/game/Server/Protocol/PacketLog.cpp
2016-05-12 09:10:53 +02:00
Shauren ff4da3acaa Core/Misc: Fixed warnings found by GCC 6
(cherry picked from commit 67fd3ee726cbd509e6a15f81f4780e757a78a8b5)

# Conflicts:
#	src/server/game/Spells/Auras/SpellAuras.cpp
2016-05-12 09:09:30 +02:00
Shauren 2aa7dff892 Core/Misc: Use steady_clock instead of system_clock for calculating ms timers. This makes update diffs immune to systemwide time changes
(cherry picked from commit 406ac4f4b492e8733d0c1e6142838b3fff8c80a3)
2016-05-12 09:09:13 +02:00
Shauren 4801f77b3c Core/Auras: Fixed a visual issue with combat log appearing to deal negative damage with SPELL_AURA_PERIODIC_LEECH if the spell does more damage than target has health (before calculating resist) and any damage is resisted.
Closes #16495
2016-05-12 08:33:11 +02:00
Shauren e0f6b24c93 Core/Spells: Don't report spell errors to client when spell was triggered and failed some internal condition 2016-05-12 08:30:38 +02:00
Shauren b7f52184c2 Travis: Configure fake user for tagging
(cherry picked from commit 373d7104c14f1e4fc64c41e25eee0f7f672c2b74)
2016-05-12 08:29:40 +02:00
Shauren cd7537e1f4 Travis: Fixed git version info output
(cherry picked from commit 03917c79cdecb906912d9a94ac5ccdaecc8f62e1)
2016-05-12 08:29:21 +02:00
Shauren 4c3db96715 Core/Common: Moved MessageBuffer to common
(cherry picked from commit a81a204678f4cbd8b8a53333600f50f0b494706a)
2016-05-12 08:28:38 +02:00
Shauren a7f68c489a Properly rename the stand state method... 2016-05-12 08:27:48 +02:00
Shauren a12493fd84 Core/Misc: Renamed getStandState to minimize differences between branches 2016-05-12 08:27:29 +02:00
Shauren 0fbcff44df Core/DataStores: Fixed creating entries in sEmotesTextSoundMap if passed invalid arguments (also a data race, if done in multiple threads) 2016-05-12 08:26:26 +02:00
Shauren b68437da60 Core/Util: Extracted GetPID to separate function
(cherry picked from commit e3af42e05cdf9e4c959d4e038349008da4faca27)
2016-05-12 08:04:52 +02:00
Shauren 049d20fdb7 Core/Networking: Added new AsyncRead method to Socket class allowing to pass a custom completion handler
(Partially cherry-picked from f123c396591ffb50fa7e02365235740df618f579)
2016-05-05 03:41:02 +02:00
Shauren 702d19039e Core/Debugging: Make abort() less bad on windows by forcing crash log generation
(cherry picked from commit dea7d429abe5143672154784f93e4b19020062d5)

# Conflicts:
#	src/server/bnetserver/Main.cpp
2016-05-05 03:40:04 +02:00
Shauren fe64bdddb3 Core/Logging: Force synchronous logging after io_service shutdown - fixes logging on worldserver shutdown
(cherry picked from commit a0b2be6c1d0ae17ad8a17692d77f2020bbb9296e)
2016-05-05 03:35:07 +02:00
Shauren 9d4e537a62 Core/PacketIO: Requeue packets handled with STATUS_LOGGEDIN received before player is fully loaded in one step after packet processing loop - reduces used locks from 3 per packet to 1 per packet
(cherry picked from commit 8086a39210659c44d52fb463f5a39f047aa45685)
2016-05-05 03:34:42 +02:00
Shauren 07ba043eae Warning fix
(cherry picked from commit 983635458bbe84b359713693da0be2bfdcd55536)
2016-05-05 03:34:21 +02:00
Shauren 3be8fba942 Core/Misc: Removed unneccessary boost/asio/buffer.hpp include
(cherry picked from commit 01be486f2f0f35e8421d1a1919bd037194756932)
2016-05-05 03:33:40 +02:00
Shauren c2abc2df38 Core/Logging: Include more info in bad realm log
(cherry picked from commit a6dd6d7841d6ab3e496d492d225c5541721c8dfd)
2016-05-05 03:32:43 +02:00
Shauren 3c6e9fe8b6 Core/Auth: Fixed login for accounts with accented characters
Closes #16770

Conflicts:
	src/server/database/Database/Implementation/LoginDatabase.cpp
2016-05-04 02:56:53 +02:00
Shauren ddb85e242a Core/Networking: Fixed DelayedCloseSocket when compiled without TC_SOCKET_USE_IOCP (linux)
Closes #16769

(cherry picked from commit 0daba931ef8e57777ed98a94a0a51c0690ba3d9c)
2016-05-04 02:52:03 +02:00
Shauren 7fe5a77f5e Warning fix 2016-03-05 20:17:37 +01:00
Shauren 3d0b065135 Core/Commands: Fixed a crash in .wp mod by @Magnifikator
Closes #16732
2016-03-05 20:16:42 +01:00
Shauren e73d5a7bf4 Core/Commands: Fixed incorrect use of GetGUID instead of GetSpawnId in waypoint commands
Updates #16732
2016-03-05 20:14:58 +01:00
Shauren 0e9b34ff05 Merge pull request #16711 from ariel-/conditionmerge
[3.3.5 only] Core/Conditions: Improved mergeability between branches
2016-03-02 16:55:22 +01:00
Shauren 85c912c404 Core/Misc: Added Convenience methods removing auras by predicate
(cherry picked from commit 0953bcf73f01ab5d85bb8665fbf8451d0ed460b3)
2016-02-25 21:01:38 +01:00
Shauren 2345e84855 Final build fix for gcc 4.7 (no longer supported in 8 days) 2016-02-21 14:13:00 +01:00
Shauren e60f575ac8 Core/Misc: Fixed a crash happening when a db string array was NULL
Closes #15670
2016-02-20 13:13:29 +01:00
Shauren b2e03a7448 Core/Networking: Rewrite networking threading model
Each network thread has its own io_service - this means that all operations on a given socket except queueing packets run from a single thread, removing the need for locking
Sending packets now writes to a lockfree intermediate queue directly, encryption is applied in network thread if it was required at the time of sending the packet

(cherry picked from commit 97a79af4701621ec04b88c8b548dbc35d120e99e)
2016-02-20 13:08:03 +01:00
Shauren e4dfbb60fd Rename 2016_02_15_01_world_335.sql to 2016_02_19_01_world_335.sql 2016-02-19 15:03:21 +01:00
Shauren 2ee36facad Merge pull request #16622 from P-Kito/3.3.5
[3.3.5] Core/Spells: Fix Glyph of Arcane Shot
2016-02-19 15:02:17 +01:00
Shauren 655fc0135f Core/Auth: Cancel ban expiry check timer on shutdown 2016-02-16 00:16:31 +01:00
Shauren 811c8bbd69 Build fix 2016-02-15 19:40:34 +01:00
Shauren dfbb3bec56 Core/Auth: Moved expiring bans to background task - no longer blocking queries during login by default running every minute (configurable) 2016-02-15 19:38:53 +01:00
Shauren ce6221b10b Warning fix 2016-02-14 18:47:12 +01:00
Shauren 5bf90b3338 Core/Auth: Performance/security improvements
* Changed all db queries to async
* Added buffer length checks
* Only allow one challenge/proof packet per socket lifetime

Closes #13217
Closes #16602
2016-02-14 18:41:25 +01:00
Shauren 101c3f9303 Merge pull request #16585 from Treeston/3.3.5-flightform
Core/Spells: Disallow druid flight form while shapeshifted
2016-02-13 23:56:11 +01:00
Shauren ff45a422c5 Warning fix. 2016-02-12 20:45:09 +01:00
Shauren fa3f106693 Core/Maps: Use map.dbc zone fallback if no area is found in grid files, not only if grid files don't exist
Closes #16583
Closes #16584

Extracting new maps is NOT needed.
2016-02-12 20:39:25 +01:00
Shauren 9f6a7c7526 Merge pull request #16548 from Keader/omen
[3.3.5][6.x]Core/Scripts Fix multiple summon of Omen (Lunar Festival)
2016-02-12 10:04:49 +01:00
Shauren 7f817a4fc0 Core/Scripts: Fixed calling UnitScript hooks
Closes #16543

(cherry picked from commit f809e5e13eac66add49d361ffb1634ff2ba6d4aa)
2016-02-11 16:36:08 +01:00
Shauren 89d8d50b2e Core/Maps: Moved min height calculation to worldserver for more precise results
Closes #16530
2016-02-10 21:25:28 +01:00
Shauren 9d81ef2af2 Core/Creatures: Improved creature text selection to be "more random" instead of favoring first entry
(cherry picked from commit 41d6460c75ce094e8ade92c88b603231aaa8e8a5)

# Conflicts:
#	src/server/game/Texts/CreatureTextMgr.cpp
2016-02-09 19:26:43 +01:00
Shauren 55ef8d80a3 Core/Utils: Moved rng functions to separate header and added utility functions to select a random element from a container where each element can have different chance of being selected
(cherry picked from commit ae20b2ab561bc07d85f443ae914bc597c9d6ac6e)
(cherry picked from commit 921d893c2a82eb6ac0762bf7001df87911b44611)
(cherry picked from commit 9ab10d6e680ca835d1dfdfbceb9f18f330f994fc)
(cherry picked from commit 00c878e73a8c6b8ce3339d224ab5611df3bbd07c)
(cherry picked from commit ff9c999334d87acc3fcea9737753c30b7f1abe25)
(cherry picked from commit bc94bacce404401a480b6871eaa7bc38d766014c)
(cherry picked from commit d5b0ffbe9b0c07beb8d0dfc52a6532c2da805285)
2016-02-09 19:26:29 +01:00
Shauren 761c82e65a Core/Maps: Use IsValidMapCoord for checking Z coord instead of just std::isfinite - only acceptable values are between -17066.6656 and 17066.6656
(cherry picked from commit 4d956c89fc6f20c546a396573cf42aa97b844c09)
2016-02-09 19:18:05 +01:00
Shauren 25cdc5d980 Core/Maps: Parse MFBO adt chunk to properly handle height where player counts as falling under the map
* This fixes the height at which player is instantly killed when falling from The Frozen Throne
* Set PLAYER_FLAGS_IS_OUT_OF_BOUNDS on players under the map to enable release spirit button while still falling

Note: Extracting new maps is required
(cherry picked from commit 4f78efd4633f79285f176b61367a067b2cd90e2b)

# Conflicts:
#	dep/PackageList.txt
#	src/server/game/DataStores/DBCStructure.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Handlers/MovementHandler.cpp
#	src/tools/map_extractor/CMakeLists.txt
#	src/tools/map_extractor/System.cpp
#	src/tools/map_extractor/adt.h
#	src/tools/map_extractor/loadlib.cpp
2016-02-09 18:44:19 +01:00
Shauren aa432db36d Core/Maps: Changed the way area data is stored in maps, it now uses ID field from AreaTable.dbc instead AreaBit used for exploration marker (and is not unique anymore on top of simply being stupidly confusing)
Note: Extracting maps is required
(cherry picked from commit db0b8bf24e2b8eb87e6aed7b031ebe138717403d)

# Conflicts:
#	src/server/game/Achievements/AchievementMgr.cpp
#	src/server/game/Chat/Chat.cpp
#	src/server/game/Conditions/ConditionMgr.cpp
#	src/server/game/DataStores/DBCStores.cpp
#	src/server/game/DataStores/DBCStores.h
#	src/server/game/DataStores/DBCfmt.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Globals/ObjectMgr.cpp
#	src/server/game/Handlers/BattleGroundHandler.cpp
#	src/server/game/Handlers/MiscHandler.cpp
#	src/server/game/Maps/Map.cpp
#	src/server/game/Spells/Spell.cpp
#	src/server/game/Spells/SpellEffects.cpp
#	src/server/scripts/Commands/cs_go.cpp
#	src/server/scripts/Commands/cs_group.cpp
#	src/server/scripts/Commands/cs_lookup.cpp
#	src/server/scripts/Commands/cs_misc.cpp
#	src/tools/map_extractor/System.cpp
#	src/tools/mmaps_generator/TerrainBuilder.cpp
2016-02-09 18:19:28 +01:00
Shauren 9b796ddf0b Merge branch 'Keader-shamant6' into 3.3.5 2016-02-08 22:29:10 +01:00
Shauren fb9a686672 SQL: Rename file with proper date 2016-02-08 22:26:38 +01:00
Shauren 4611125339 Merge pull request #16465 from Keader/rapture
Core/Spells: Fixed cooldown check for Rapture (Priest) talent
2016-02-03 15:57:11 +01:00
Shauren cb8f64cb63 Merge pull request #16417 from Keader/kinetic
Core/Scripts Fix Kinetic Bomb stuck after knockback effect
2016-01-29 08:47:12 +01:00
Shauren 3f886025a2 Core/Spells: Ignore category cooldowns for triggered spells.
* This fixes weird issues where triggered spell fails because it has the same category as the spell triggering it

Closes #15794
Closes #15048

(cherry picked from commit 044edced9a5b8f0a53640bfea4727eb9d38eae7f)
2016-01-22 22:14:28 +01:00
Shauren b605f1cc81 Core/Maps: Restored DataDir functionality accidendally removed earlier
(cherry picked from commit 7e801595f42be692fcbd8cbfd3cf6652c75e5db6)
2016-01-20 08:04:58 -03:00
Shauren 354c262683 Core/DBLayer: Added compile time validation for prepared statement indexes passed to DatabaseWorkerPool::GetPreparedStatement turning mistakes like the one fixed in 0327927fa61434d432f9749fd9242ae5dce9a5cd into compiler errors.
(cherry picked from commit 7c75160f590812f0c5d70fd9c68441068e2ded48)

Conflicts:
	src/server/database/Database/Implementation/HotfixDatabase.h
	src/server/database/Database/QueryResult.cpp
	src/server/shared/DataStores/DB2StorageLoader.cpp
	src/server/shared/DataStores/DB2StorageLoader.h
	src/server/shared/DataStores/DB2Store.h
2016-01-13 01:38:29 -03:00
Shauren 48940e292f Core/Quests: Fixed party accept quests 2016-01-12 19:41:27 +01:00
Shauren 3c3cde028c Core/Quests: Fixed quest sharing
Closes #12304
Closes #16183
2016-01-12 19:08:37 +01:00
Shauren 6b7c6f4366 Core/Players: Implemented serverside validation of reserved/profane names
Closes #15357

New library dependency: Boost.Regex

(cherry picked from commit b564c10b13effed63c7b7dae25117e2e0a2c64e4)
(cherry picked from commit 1de03cf107)

Conflicts:
	src/server/game/DataStores/DBCStores.cpp
	src/server/game/DataStores/DBCStructure.h
	src/server/game/DataStores/DBCfmt.h
2016-01-11 23:27:43 -03:00