Commit Graph
423 Commits
Author SHA1 Message Date
Ovahlord 83958342d9 Core/Spells: ported spellMod handling from master branch 2025-03-09 13:20:40 +01:00
Meji a601976e4c Core/Spells: Fixed target radius calculation for TARGET_DEST_*_RANDOM 2023-12-08 16:37:27 +01:00
Shauren 7d57ef7299 Core/Random: Changed random functions returning doubles to return floats
* They were all cast to float at use anyway
* Improves roll_chance_f performance (rand32() is now called internally by uniform_real_distribution once instead of twice)
2023-10-31 22:00:52 +01:00
Shauren 388c504047 Core/Spells: Named and implemented most of SpellAttr8 2023-10-23 18:07:05 +02:00
Shauren 3c0cf32b43 Core/Spells: Named and implemented most of SpellAttr7 2023-10-21 20:32:32 +02:00
Traesh 4e67618e5f Core/Spells: Fix CheckLocation for multi-level zone/area 2023-10-09 20:55:55 +02:00
Jeremy f8aa09f253 Core/Areas: Update AreaFlags from EnumeratedStings values 2023-10-09 20:41:30 +02:00
Ovahlord 86a06a5a5d Core/Spells: use already stored spell scaling values for coefficient calculation instead of accessing dbc data every single time 2023-08-19 18:50:56 +02:00
Ovahlord a57e27e6d3 Core/Spells: implement reputation requirements for spells (mostly used in guild spells such as Guild Page) 2023-08-13 11:48:20 +02:00
Ovahlord e936684e78 Core/Spells: converted FacingCasterFlags of spell casting requirements to enumflag 2023-08-13 11:38:09 +02:00
Ovahlord 2bcc645cd3 Core/Spells: ported radius entry indexing from master branch and dropped several now deprecated spell 'fixes' from spellMgr 2023-08-06 12:54:05 +02:00
Ovahlord 4e397e76d0 Core/Spells: implement TARGET_DIR_SUMMON and use it to properly support TARGET_DEST_CASTER_SUMMON
This fixes positions for pet summons and gameobject summons such as Campfires
2023-07-17 01:23:56 +02:00
Ovahlord a3dd0d75cf Core/Quests: ported quest flag and visbility update changes from master branch 2023-07-11 15:21:09 +02:00
Ovahlord 6cbc8119f1 Core/Spells: added underlying type to SpellEffects enum to fix a couple mismatching sign warnings 2023-06-02 21:06:55 +02:00
Shauren 47048f3dc5 Core/Misc: Future msvc warning fixes 2023-06-01 20:49:58 +02:00
Ovahlord 283d9cf84f Core/Spells: fixed value calculation for combo points bonus damage 2023-02-20 20:08:49 +01:00
Ovahlord c5046b0fec Core/Spells: corrected a normalization in SpellEffectInfo::CalcValue to match it's client function counterpart 2023-02-01 09:51:50 +01:00
Shauren f97d336d82 Core/Auras: Fixed possible iterator invalidation crashes caused by calling UpdateTargetMap inside loops iterating m_appliedAuras 2023-01-19 17:30:41 +01:00
Ovahlord eeecf8780e Core/Spells: mark SPELL_AURA_MOD_ATTACKER_SPELL_CRIT_CHANCE as negative effect 2022-11-18 22:49:01 +01:00
Ovahlord 139d4e8447 Core/Spells: fixed spell scaling class selection 2022-11-18 22:43:47 +01:00
Ovahlord 906cf8a3e9 Core/Spells: fixed accessing ImmunityInfo in SpellInfo::ApplyAllSpellImmunitiesTo 2022-11-10 17:45:59 +01:00
Carbenium 45e1e8c282 Core/Misc: Create new enum for AreaIds
Move Wintergrasp BF related values there
2022-10-08 23:59:21 +02:00
Shauren 0ca955897f Core/Spells: Remove all hardcoded restrictions for pick pocket spell effect and rely only on presence of pickpocket loot in db 2022-10-04 12:42:10 +02:00
Ovahlord 3d529f2d7d Core/Spells: refactored duration and period calculations
* fixed sending hit targets in spell_go packet
2022-10-01 19:13:01 +02:00
Ovahlord b6f8a68d61 Core/Spells: fixed duration clamping for haste based periodic auras and added support for rolling any tick over
* roll over remaining time until next tick over into a refreshed periodic aura's duration
* this behavior is now being used for stackable spells, all HoTs and DoTs
* fixed adding extra ticks when at certain tick thresholds
* corrected implementation of SPELL_ATTR8_HASTE_AFFECTS_DURATION
* implemented SPELL_ATTR8_MELEE_HASTE_AFFECTS_PERIODIC
2022-10-01 13:47:14 +02:00
Shauren c3b52fd29f Core/Auras: Improve aura interactions with immunities on spell effect level
* Effects that target is immune to will be suppressed instead of completely removed
2022-09-30 12:49:31 +02:00
Alan Deutscher 0f4442c630 Core/Auras: Do not remove auras unaffected by invincibility
* Mark WSG's Focused Assault and Brutal Assault as unaffected by immunities
2022-09-30 11:33:04 +02:00
Shauren 050300771d Core/Spells: Rename SpellAttr6 to use official attribute names 2022-09-30 10:45:17 +02:00
Shauren 0f6cac2373 Core/Spells: Implemented SPELL_ATTR5_TREAT_AS_AREA_EFFECT 2022-09-30 02:12:19 +02:00
Shauren 8fa4b57925 Core/Spells: Implemented SPELL_ATTR5_NOT_ON_PLAYER and SPELL_ATTR5_NOT_ON_PLAYER_CONTROLLED_NPC 2022-09-30 02:05:54 +02:00
Shauren 75906f3d06 Core/Auras: Added support for SPELL_ATTR5_LIMIT_N limit to other number than just 1 2022-09-30 01:57:52 +02:00
Shauren 70c76a166a Core/Spells: Removed SPELL_SPECIFIC_JUDGEMENT 2022-09-30 01:35:50 +02:00
Shauren d1700ba5fa Core/Spells: Rename SpellAttr5 to use official attribute names
* Implemented SPELL_ATTR8_HASTE_AFFECTS_DURATION
2022-09-30 01:30:14 +02:00
Shauren a7dc339a6a SHA-1: 8d16a79dea4c0100d36e13b068c42499a3a48154
* Core/Spells: Rename SpellAttr4 to use official attribute names

* Corrected implementation of SPELL_ATTR4_CLASS_TRIGGER_ONLY_ON_TARGET
* Implemented SPELL_ATTR4_NO_HELPFUL_THREAT
* Implemented SPELL_ATTR4_NO_PARTIAL_IMMUNITY
* Implemented SPELL_ATTR4_ALLOW_PROC_WHILE_SITTING
* Implemented SPELL_ATTR4_USE_FACING_FROM_SPELL
* Implemented SPELL_ATTR4_BOUNCY_CHAIN_MISSILES
* Implemented SPELL_ATTR4_AURA_NEVER_BOUNCES
* Implemented SPELL_ATTR4_AURA_BOUNCE_FAILS_SPELL
* Implemented SPELL_ATTR4_AURA_IS_BUFF
* Implemented SPELL_ATTR5_MELEE_CHAIN_TARGETING

* Implemented SpellEffectAttributes::ChainFromInitialTarget
2022-09-30 01:16:39 +02:00
Ovahlord ef3632109d Core/Spells: ported SpellModOp definitions from master branch 2022-09-17 11:56:54 +02:00
Shauren 946f928ee2 Core/Spells: Rename SpellAttr3 to use official attribute names
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-09-13 15:40:25 +02:00
Shauren ea4bc6c02a Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-09-13 14:36:32 +02:00
Ovahlord e3e4b2cf16 Core/Spells: dropped old dot clipping implementation and restored TC period and duration calculations in preparation of re-implementing it 2022-09-12 09:15:35 +02:00
Ovahlord 3976ae557b Core/Spells: updated spell positivity cases and added some Cataclysm+ entries 2022-09-12 09:15:31 +02:00
Shauren ca7d36873f Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-09-12 09:15:31 +02:00
Giacomo Pozzoni d2918d2138 Core/Spells: Fix Spellsteal stealing Silence buff of Arcane Torrent (#23992) 2022-09-12 09:15:26 +02:00
Trond B. Krokli 89d0f363cf Core/Spells: make Four Horsemen debuffs negative (#23253)
By Riztazz
Closes #23248
2022-09-12 09:15:23 +02:00
HelloKitty 1d013e5d3f Core/Spells: Include RealPointsPerLevel when determining if aura is negative (#22427) 2022-09-12 09:15:20 +02:00
ariel- f6bb4241f6 Core/Spells: fix another regression with arcane missiles being marked positive 2022-09-12 09:15:19 +02:00
ariel- 9b54c3f842 Core/Spells: tweak 'neutral' spell positivity
- Fixes Mind Control dummy self aura appearing as a debuff
2022-09-12 09:15:15 +02:00
ariel- b6fac86b71 Core/Spells: rework part 5: GameObject casting 2022-09-12 09:15:14 +02:00
ariel- 4bb8c93df8 Core/Spells: rework part 4: iterate over effects first
Implement far spell queue processing

# Conflicts:
#	src/server/game/Spells/Spell.cpp
2022-09-12 09:15:13 +02:00
ariel- 98a988a77a Core/Spells: rework part 2: Split up target selection logic
Target check only determines what kind of entities we can target, spell positivity determines if that entity is valid for attack/assist
2022-09-12 09:15:13 +02:00
ariel- 95bc5dcc40 Core/Spells: rework part 1: Improved positive detection logic
# Conflicts:
#	src/server/game/Spells/SpellInfo.cpp
2022-09-12 09:15:12 +02:00
Shauren d448ea4370 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-09-12 09:15:04 +02:00