ariel-
00628e94b0
Dep/gSOAP: Update gSOAP to 2.8.49
...
Closes #20039
2017-07-19 20:26:34 +02:00
ariel-
698697d9e8
Core/Tools: fix whitespace
2017-07-19 20:26:20 +02:00
ariel-
5e37e99ffa
Core/Scripts: fix array out of bounds in Pit of Saron doorData
2017-06-18 10:43:37 +02:00
ariel-
85c9907b07
Core/Spell: fix some spells that shouldn't allow stealth or invisibility
...
- Touch of Zanzil
- Glowing Blood
- Lambent Blood
- Vibrant Blood
- Black Blood
- Perpetual Instability
2017-06-11 17:50:32 +02:00
ariel-
206c82ead4
Core/SmartAI: implemented SMART_EVENT_EVENT_PHASE_CHANGE
...
- Use instead of Update + event_phase_mask when action needs to be synchronized
2017-06-11 17:50:24 +02:00
ariel-
e05083ad4b
Core/Scripts: remove non-player objects (ie corpses) from Sindragosa's Fury targetlist
2017-06-11 17:50:11 +02:00
ariel-
987f0bda82
Core/Vmaps: build fix mk II
2017-06-09 13:30:07 +02:00
ariel-
3914ace3ba
Core/Vmaps: build fix
2017-06-09 13:30:01 +02:00
ariel-
307cc1e36f
Core/Scripts: filter out corpses from Sindragosa's Fury targetlist
...
- This would incur in a crash after attempting to convert the Corpse object into Player
Closes #19227
Closes #19862
2017-06-09 13:22:40 +02:00
ariel-
c7e617b689
DB/Spell: prevent Vile Gas (H Rotface version) from hitting non-players
2017-06-06 08:42:48 +02:00
ariel-
2e3197f944
Core/Globals: add more AIName and MovementType checks to ObjectMgr
...
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)
Closes #19831
2017-06-02 10:23:44 +02:00
ariel-
8ebe95f3ac
DB/Spell: fix Deep Freeze proc
...
Closes #19780
2017-05-30 09:21:19 +02:00
ariel-
e778c4c628
Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit
2017-05-30 09:21:03 +02:00
ariel-
3d5584fb86
Core/Pools: fix VS dynamic linking
2017-05-28 03:18:59 +02:00
ariel-
da65d89129
Core/Misc: fix some clang 5 warnings
2017-05-28 03:18:50 +02:00
ariel-
8082b3165e
Core/Spell: abort channeling if no valid targets are found after searching
...
Closes #17624
2017-05-28 03:11:57 +02:00
ariel-
f8a222aab9
Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
...
Closes #19514
2017-05-28 03:11:40 +02:00
ariel-
70f3879c32
Core/Player: update interaction checks, some info taken from client
2017-05-26 14:26:43 +02:00
ariel-
ddb787482c
Core/Unit: don't clear low health aura states on death
...
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening
Closes #19754
2017-05-16 06:50:39 +02:00
ariel-
4eaa6b50b6
Core/Entities: allow guardian pets to inherit spellmods
2017-05-07 06:06:34 +02:00
ariel-
1e475a6942
Core/Scripts: implemented enchant Blade Warding
2017-05-05 04:02:32 +01:00
ariel-
ea20370fce
Core/Scripts: kill a warning
2017-05-05 03:59:01 +01:00
ariel-
e2ac33fdc2
Core/Scripts: Victory Rush and Rune Strike proc correction
...
(d0f760420a671bc255c0d3ebec75e6837507a541 follow up)
Closes #19192
2017-05-05 03:58:50 +01:00
ariel-
07a182f1d3
Core/Spell: register spell mod owner properly on spell cast
...
- This fixes pets and totems getting mods from owner
2017-05-04 05:04:19 +01:00
ariel-
2ed7602af2
Core/Spell: fix broken Unit::GetHighestExclusiveSameEffectSpellGroupValue
...
- Affects 3 aura effects currently, should be rewritten with GetTotalAuraModifier maybe?
2017-05-04 05:03:08 +01:00
ariel-
d2d7a2cb14
Core/Spell: fix nopch build
2017-05-04 05:02:36 +01:00
ariel-
eee81e3748
Core/Spell: fix nopch build x2
2017-05-04 05:02:26 +01:00
ariel-
9dbbe92875
Core/Spell: build fix
2017-05-04 05:02:05 +01:00
ariel-
76349ea8ce
Core/Spell: fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to actually check effects
...
- This commit enables stack rule 3 to be properly used to fix auras that should be active but only one providing effects, even if the spell has multiple auras
Closes #19454
2017-05-04 05:01:47 +01:00
ariel-
091100f795
Core/Spell: check aura positivity per effect on spell hit
...
- Fixes applying DR to positive effects, and changing duration of whole aura
Closes #19447
2017-05-04 05:01:17 +01:00
ariel-
ba2e4d90ec
Core/Spell: fix SPELL_ATTR3_IGNORE_HIT_RESULT bypassing reflects
...
Closes #19440
2017-05-04 05:00:28 +01:00
ariel-
e9599d136b
Core/Aura: fix SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE unapply case for dead players
2017-05-04 04:49:50 +01:00
ariel-
1689db1451
Core/Spells: fix some db errors
2017-05-04 04:43:55 +01:00
ariel-
9f5b3920e2
Core/Spells: fix Hand of Justice proc chance and reduce it past level 60.
...
Ref #7789
2017-05-04 04:35:28 +01:00
ariel-
288a13861d
Core/Spell: properly add SPELLMOD_COOLDOWN to spells without initial cooldown
...
Closes #15605
2017-05-04 04:26:09 +01:00
ariel-
1f6fa54465
Core/Spell: build fix
2017-05-04 04:14:12 +01:00
ariel-
3ccdf57f4a
Core/Spell: unified handling of SPELL_ATTR5_USABLE_WHILE_* attributes
...
Allowed mechanic mask is calculated on startup and auras checked against those mechanics
Closes #18798
2017-05-04 04:13:49 +01:00
ariel-
abae912986
Core/Spell: modified HitMask for new default procs
2017-05-04 04:12:45 +01:00
ariel-
7f4557c943
Core/Spell: add more aura types to default procs
...
Ref #18542
2017-05-04 04:12:29 +01:00
ariel-
921efdc1fa
Core/Spell: consider spells with no targets for the purpose of finish procs
...
Closes #18799
2017-05-04 04:10:22 +01:00
ariel-
948335f911
Core/Spell: add missing null caster check
...
01d272d6cb348c968c531620c341f760e50cb97b follow-up
Closes #18875
2017-05-04 04:09:07 +01:00
ariel-
69625f32fe
Core/Spell: kill old charge restoring system. Mods are fully handled by proc system now.
...
- Fixes an edge case of spell failing due to out of range and re-adding charges to an existing aura.
2017-05-04 04:00:58 +01:00
ariel-
c1accd4537
Core/Player: fix some PCT_MOD charge consumption
...
By xinef1
Closes #18516
2017-05-04 04:00:36 +01:00
ariel-
a15aaf68c3
Core/Spell: reverted changes for NO_TARGET handling
...
Partial revert of 584d347b70be521d7431dfe1694b80f2e95b957b
Closes #18666
2017-05-04 03:59:55 +01:00
ariel-
c89bf30b4d
Missing change
2017-05-04 03:59:33 +01:00
ariel-
71e3339636
Core/Spell: Prevent NO_TARGET auras from actually selecting target
2017-05-04 03:51:44 +01:00
ariel-
0814834492
Core/Spell: reverted stun aura handling
...
Partial revert of 50a3ce5703bdaa4fe16e2e773eabafa9a4818083
Closes #18487
Closes #18490
Closes #18497
2017-05-04 03:47:21 +01:00
ariel-
be418d3671
Core/Spell: fix for hitmask being ignored in finish phase procs
2017-05-04 03:45:37 +01:00
ariel-
85cfc406dd
Core/Script: Implement Paralytic Poison
...
Closes #16905
2017-05-04 03:45:26 +01:00
ariel-
d7876762f0
Core/Spell: add an exception for Cyclone ignoring it's own immunity using dispel type
...
- Unsure of what is the correct check, most generic thing I could make
Closes #18479
2017-05-04 03:44:41 +01:00
ariel-
62f9b5a0a1
Core/Misc: readd some codestyle changes inadvertently reverted
2017-05-04 03:42:24 +01:00
ariel-
4f3f455de4
Core/Spell: partial revert of SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE immunity handling
...
- Bonus: without breaking Banish... yay!
Closes #18370
2017-05-04 03:35:47 +01:00
ariel-
aee4958ed8
Core/Unit: added GetTotalAuraXXX overloads taking a predicate
2017-05-04 03:33:13 +01:00
ariel-
f12035a600
Core/Unit: added missing nullptr check in IsImmunedToSpellEffect
...
Closes #18461
2017-05-04 03:29:20 +01:00
ariel-
6e62130e96
Core/Spell: improved immunity logic for dispels
2017-05-04 03:26:54 +01:00
ariel-
307b736768
Core/Spell: Undefined SPELL_ATTR7_USABLE_IN_STUN_FEAR_CONFUSION attr for now
2017-05-04 03:18:14 +01:00
ariel-
50c04aad05
Core/SpellMgr: added a startup error for possibly unhandled procs
2017-05-04 03:06:55 +01:00
ariel-
1cffe99136
Core/Spells: proc spells after damage apply, not before. Fixes #13025
2017-05-04 02:57:40 +01:00
ariel-
c7e27dd511
Core/Unit: do not allow judgement spells to bypass damage immunity
...
3f19eea5e41fd47b571c17529e08d9f8caa91705 follow-up. Without the #16658 regression
2017-05-04 02:36:54 +01:00
ariel-
938f43302c
Core/Entities: fix interaction of traps with ffa pvp and sanctuary flags
2017-05-04 02:34:25 +01:00
ariel-
6aac0c2073
Core/Entities: better support of absorb, resist and block procs
2017-05-04 02:25:01 +01:00
ariel-
c62077237d
Core/Spell: restore old proc system behaviour on auras self proc.
2017-05-04 02:21:58 +01:00
ariel-
cb77d33cb9
Core/Spell: Added the possibility to explicitly disable auraEffect procs using attributes
...
- Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use
2017-05-04 02:16:50 +01:00
ariel-
39f5cfafc5
Core/Spell: spells with ignore hit result should pierce damage immunities
2017-05-04 02:16:30 +01:00
ariel-
a6c7f2b98c
Core/Spell: Fixed irregular handling of SPELLMOD_DOT
2017-05-04 02:15:54 +01:00
ariel-
b7b69b88ba
Core/Unit: damage immune improvements
2017-05-04 01:48:16 +01:00
ariel-
746cb97dce
Core/Unit: don't use damage immunity to calculate hit result for the whole spell. Should be used only for damage
2017-05-04 01:45:58 +01:00
ariel-
045bf711c2
Core/Unit: improved handling of some spell attributes
...
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE
- SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE
- SPELL_ATTR3_IGNORE_HIT_RESULT
2017-05-04 01:44:49 +01:00
ariel-
679f5c51c5
Core/Spell: fix typos
2017-05-04 01:44:25 +01:00
ariel-
18a145e2c6
Core/Utils: build fix
2017-05-04 01:44:12 +01:00
ariel-
07a529726d
Core/Globals: Load spellspecific and aurastate after loading spell ranks
...
Was breaking functionality (eg: stacking scroll auras)
2017-05-04 01:43:22 +01:00
ariel-
6ef6047b00
Core/Spell: Fixed immunities for some spells (they were broken before rewrite too)
...
- Warlord's Presence, Uncontrollable Frenzy, Free Friend
- Overload, Lightning Tendrils
- Fervor, Berserk
- Determination
2017-05-04 01:42:43 +01:00
ariel-
b14b00da5c
Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks
2017-05-04 01:41:35 +01:00
ariel-
e6bdc58bf0
Core/Unit: misc codestyle
...
use typedef for constant reference
2017-05-04 01:37:04 +01:00
ariel-
fcb7910533
Core/Spell: reimplemented TRIGGERED_DISALLOW_PROC_EVENTS trigger flag
...
Triggered spells shouldn't chain-trigger other spells
Closes #18217
2017-05-04 01:28:42 +01:00
ariel-
fb6cde2730
Core/Entities: add yet another utility overload to CastSpell, fixes AppVeyor build
...
Ninja NULL->nullptr cleanup
2017-05-04 01:28:15 +01:00
ariel-
f133041b80
Core/Spell: fix interaction of on taken damage procs with triggered casts
...
DB/Spell: Seal of Righteousness proc
- Lightining and Water Shield should proc with triggered
Closes #18211
2017-05-04 01:27:57 +01:00
ariel-
04b562418e
Core/Spell: make a distinction between triggered flags with debugging purposes, and don't use them when casting triggered spells
2017-05-04 01:27:22 +01:00
ariel-
030224ff32
Core/Spells: do not add PROC_HIT_NORMAL/PROC_HIT_CRITICAL flags if damage is fully nullified
...
- Aka: full absorbs/full resists/full blocks/immune
2017-05-04 01:24:26 +01:00
ariel-
c9101f6707
Core/Spells: workaround stealth interaction with Death and Decay and GameObject casts
2017-05-04 01:16:00 +01:00
ariel-
e2fb7a8218
Core/Unit: send original caster in heal packet log
2017-05-04 01:13:27 +01:00
ariel-
d1c915e4e1
Core/Spells: require phaseMask set for trap activation procs
2017-05-04 01:11:16 +01:00
ariel-
c131f68f63
Core/Unit: allow pets and totems to drop mod charges in owner auras.
...
Needed for Cobra Strikes (re)implementation
2017-05-04 01:10:51 +01:00
ariel-
60b390a3e8
Core/Auras: allow damage from periodics to trigger auras if they're not fully resisted/absorbed
2017-05-04 01:08:39 +01:00
ariel-
759e19cee7
Core/Unit: CalculateMeleeDamage should use unmodified damage to compute HitInfo
...
d3a71a83387f757f87c7d27e1054498c8cc49c8f follow-up
2017-05-04 01:07:58 +01:00
ariel-
3d9c4fd3fc
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
2017-05-04 01:07:05 +01:00
ariel-
8bf21ad927
Core/Unit: fix chain cc's not being diminished properly
...
Logic fail in 9b0fa51022fba3d5ece96dd0ac8399be01ea5b0f (now diminishing info is always initialized)
2017-05-04 01:01:44 +01:00
ariel-
21ac6296be
Core/Spells: moved handling of SPELL_ATTR0_CU_DONT_BREAK_STEALTH inside proc system.
...
Fixes additional issues with spells that shouldn't be breaking stealth and had this attribute
2017-05-04 01:01:24 +01:00
ariel-
b3eb7c121f
Core/Unit: Change aura proc pair container to vector
2017-05-04 00:59:01 +01:00
ariel-
44a779ad38
Core/SpellMgr: some changes in default proc generation. Fix an issue of stealth breaking with positive and/or healing spells
2017-05-04 00:57:39 +01:00
ariel-
7ccd58615a
Fix dynamic linking
2017-05-04 00:28:36 +01:00
ariel-
9b5c40a201
Mark Slice and Dice as positive
2017-05-04 00:25:18 +01:00
ariel-
e0c8a379c8
Core/Spell: do not automatically set proc Family Name if no Family Flags present
...
Closes #18075
2017-05-04 00:21:36 +01:00
ariel-
a47ee2ac5a
Core/Spells: fix auto repeat spells triggering auras
...
Auto repeat spells are casted as triggered and didn't register procs properly if the aura can't proc with triggered
2017-05-04 00:21:13 +01:00
ariel-
c71dc17135
Core/Auras: moved check for CC auras out of proc handler, and fixed its logic
2017-05-04 00:18:01 +01:00
ariel-
a6b4f239a4
Add some DamageInfo null checks
2017-05-04 00:17:13 +01:00
ariel-
754c22d3d0
Core/Auras: prevent stack overflow while processing SPELL_EFFECT_ADD_EXTRA_ATTACKS
2017-05-04 00:14:02 +01:00
ariel-
c6aa63536e
Core/Unit: fix weapon skill up.
...
Closes #18044
2017-05-03 23:52:34 +01:00
ariel-
a7a024d1d6
Core/Auras: reset periodic aura timers by default. Except when aura comes from triggered spell
2017-05-03 23:51:47 +01:00
ariel-
8f4fd78cbf
Core/Scripts: add a workaround for Will of the Forsaken shared cooldown
...
Closes #7151
2017-05-03 23:45:58 +01:00