Ovahlord
6cbc8119f1
Core/Spells: added underlying type to SpellEffects enum to fix a couple mismatching sign warnings
2023-06-02 21:06:55 +02:00
Shauren
47048f3dc5
Core/Misc: Future msvc warning fixes
2023-06-01 20:49:58 +02:00
Ovahlord
283d9cf84f
Core/Spells: fixed value calculation for combo points bonus damage
2023-02-20 20:08:49 +01:00
Ovahlord
c5046b0fec
Core/Spells: corrected a normalization in SpellEffectInfo::CalcValue to match it's client function counterpart
2023-02-01 09:51:50 +01:00
Shauren
f97d336d82
Core/Auras: Fixed possible iterator invalidation crashes caused by calling UpdateTargetMap inside loops iterating m_appliedAuras
2023-01-19 17:30:41 +01:00
Ovahlord
eeecf8780e
Core/Spells: mark SPELL_AURA_MOD_ATTACKER_SPELL_CRIT_CHANCE as negative effect
2022-11-18 22:49:01 +01:00
Ovahlord
139d4e8447
Core/Spells: fixed spell scaling class selection
2022-11-18 22:43:47 +01:00
Ovahlord
906cf8a3e9
Core/Spells: fixed accessing ImmunityInfo in SpellInfo::ApplyAllSpellImmunitiesTo
2022-11-10 17:45:59 +01:00
Carbenium
45e1e8c282
Core/Misc: Create new enum for AreaIds
...
Move Wintergrasp BF related values there
2022-10-08 23:59:21 +02:00
Shauren
0ca955897f
Core/Spells: Remove all hardcoded restrictions for pick pocket spell effect and rely only on presence of pickpocket loot in db
2022-10-04 12:42:10 +02:00
Ovahlord
3d529f2d7d
Core/Spells: refactored duration and period calculations
...
* fixed sending hit targets in spell_go packet
2022-10-01 19:13:01 +02:00
Ovahlord
b6f8a68d61
Core/Spells: fixed duration clamping for haste based periodic auras and added support for rolling any tick over
...
* roll over remaining time until next tick over into a refreshed periodic aura's duration
* this behavior is now being used for stackable spells, all HoTs and DoTs
* fixed adding extra ticks when at certain tick thresholds
* corrected implementation of SPELL_ATTR8_HASTE_AFFECTS_DURATION
* implemented SPELL_ATTR8_MELEE_HASTE_AFFECTS_PERIODIC
2022-10-01 13:47:14 +02:00
Shauren
c3b52fd29f
Core/Auras: Improve aura interactions with immunities on spell effect level
...
* Effects that target is immune to will be suppressed instead of completely removed
2022-09-30 12:49:31 +02:00
Alan Deutscher
0f4442c630
Core/Auras: Do not remove auras unaffected by invincibility
...
* Mark WSG's Focused Assault and Brutal Assault as unaffected by immunities
2022-09-30 11:33:04 +02:00
Shauren
050300771d
Core/Spells: Rename SpellAttr6 to use official attribute names
2022-09-30 10:45:17 +02:00
Shauren
0f6cac2373
Core/Spells: Implemented SPELL_ATTR5_TREAT_AS_AREA_EFFECT
2022-09-30 02:12:19 +02:00
Shauren
8fa4b57925
Core/Spells: Implemented SPELL_ATTR5_NOT_ON_PLAYER and SPELL_ATTR5_NOT_ON_PLAYER_CONTROLLED_NPC
2022-09-30 02:05:54 +02:00
Shauren
75906f3d06
Core/Auras: Added support for SPELL_ATTR5_LIMIT_N limit to other number than just 1
2022-09-30 01:57:52 +02:00
Shauren
70c76a166a
Core/Spells: Removed SPELL_SPECIFIC_JUDGEMENT
2022-09-30 01:35:50 +02:00
Shauren
d1700ba5fa
Core/Spells: Rename SpellAttr5 to use official attribute names
...
* Implemented SPELL_ATTR8_HASTE_AFFECTS_DURATION
2022-09-30 01:30:14 +02:00
Shauren
a7dc339a6a
SHA-1: 8d16a79dea4c0100d36e13b068c42499a3a48154
...
* Core/Spells: Rename SpellAttr4 to use official attribute names
* Corrected implementation of SPELL_ATTR4_CLASS_TRIGGER_ONLY_ON_TARGET
* Implemented SPELL_ATTR4_NO_HELPFUL_THREAT
* Implemented SPELL_ATTR4_NO_PARTIAL_IMMUNITY
* Implemented SPELL_ATTR4_ALLOW_PROC_WHILE_SITTING
* Implemented SPELL_ATTR4_USE_FACING_FROM_SPELL
* Implemented SPELL_ATTR4_BOUNCY_CHAIN_MISSILES
* Implemented SPELL_ATTR4_AURA_NEVER_BOUNCES
* Implemented SPELL_ATTR4_AURA_BOUNCE_FAILS_SPELL
* Implemented SPELL_ATTR4_AURA_IS_BUFF
* Implemented SPELL_ATTR5_MELEE_CHAIN_TARGETING
* Implemented SpellEffectAttributes::ChainFromInitialTarget
2022-09-30 01:16:39 +02:00
Ovahlord
ef3632109d
Core/Spells: ported SpellModOp definitions from master branch
2022-09-17 11:56:54 +02:00
Shauren
946f928ee2
Core/Spells: Rename SpellAttr3 to use official attribute names
...
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-09-13 15:40:25 +02:00
Shauren
ea4bc6c02a
Core/Spells: Rename SpellAttr2 to use official attribute names
...
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-09-13 14:36:32 +02:00
Ovahlord
e3e4b2cf16
Core/Spells: dropped old dot clipping implementation and restored TC period and duration calculations in preparation of re-implementing it
2022-09-12 09:15:35 +02:00
Ovahlord
3976ae557b
Core/Spells: updated spell positivity cases and added some Cataclysm+ entries
2022-09-12 09:15:31 +02:00
Shauren
ca7d36873f
Core/Spells: Rename SpellAttr1 to use official attribute names
...
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-09-12 09:15:31 +02:00
Giacomo Pozzoni
d2918d2138
Core/Spells: Fix Spellsteal stealing Silence buff of Arcane Torrent ( #23992 )
2022-09-12 09:15:26 +02:00
Trond B. Krokli
89d0f363cf
Core/Spells: make Four Horsemen debuffs negative ( #23253 )
...
By Riztazz
Closes #23248
2022-09-12 09:15:23 +02:00
HelloKitty
1d013e5d3f
Core/Spells: Include RealPointsPerLevel when determining if aura is negative ( #22427 )
2022-09-12 09:15:20 +02:00
ariel-
f6bb4241f6
Core/Spells: fix another regression with arcane missiles being marked positive
2022-09-12 09:15:19 +02:00
ariel-
9b54c3f842
Core/Spells: tweak 'neutral' spell positivity
...
- Fixes Mind Control dummy self aura appearing as a debuff
2022-09-12 09:15:15 +02:00
ariel-
b6fac86b71
Core/Spells: rework part 5: GameObject casting
2022-09-12 09:15:14 +02:00
ariel-
4bb8c93df8
Core/Spells: rework part 4: iterate over effects first
...
Implement far spell queue processing
# Conflicts:
# src/server/game/Spells/Spell.cpp
2022-09-12 09:15:13 +02:00
ariel-
98a988a77a
Core/Spells: rework part 2: Split up target selection logic
...
Target check only determines what kind of entities we can target, spell positivity determines if that entity is valid for attack/assist
2022-09-12 09:15:13 +02:00
ariel-
95bc5dcc40
Core/Spells: rework part 1: Improved positive detection logic
...
# Conflicts:
# src/server/game/Spells/SpellInfo.cpp
2022-09-12 09:15:12 +02:00
Shauren
d448ea4370
Core/Spells: Rename SpellAttr0 to use official attribute names
2022-09-12 09:15:04 +02:00
Ovahlord
bf306d133a
Core/Spells: refactored scaling code in SpellEffectInfo::CalcValue to reduce differences with master branch
2022-09-12 09:15:02 +02:00
Chaouki Dhib
a588f62838
Core/Spells: Change the radius of PBAoEs following the feedback received on ( #16290 )
...
# Conflicts:
# src/server/game/Spells/Spell.cpp
2022-06-16 22:44:09 +02:00
AG
7e343ab03b
Core/Spells: Druid's Pounce bleeding effect will no longer be affected by diminishing returns ( #349 )
...
closes #76
2022-04-13 20:47:14 +02:00
Ovahlord
367c120231
Core/Spells: make SpellInfo::CausesInitialThreat respect SPELL_ATTR0_CU_NO_INITIAL_THREAT as well
2022-04-01 12:21:11 +02:00
Ovahlord
fd22ea32e6
Core/Spells: merged master version of checking for cast immunities
2022-03-10 20:41:47 +01:00
ariel-
4c658cf2da
Revert "Core/Spell: don't set scaleAura for some special spells"
...
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e.
Closes #19472
(cherry picked from commit c296d255e25a2d0eb7155f64eea32cc36fed280a)
2022-02-16 04:49:24 +01:00
ariel-
14a95ff976
Core/Spell: don't set scaleAura for some special spells
...
Closes #14541
(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2022-02-16 04:49:24 +01:00
Chaouki Dhib
17c4d8f6d9
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] ( #16290 )
...
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.
(cherry picked from commit a1f2f30c145f6ad9c4baeffeff32618e71ff537c)
2022-02-16 04:49:24 +01:00
xinef1
716487fefc
Corrected points per level calculation for some spells ( #19105 )
...
(cherry picked from commit 9142c778dd861eda188ba868433af05038c4e13c)
2022-02-16 04:49:24 +01:00
xinef1
9da4acce08
Core/Spells: Remade trajectory target selection ( #19048 )
...
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received
(cherry picked from commit c6060dd0c511ddad3cb1f0423aa9ccf2de7aedec)
2022-01-22 22:29:20 +01:00
Ovahlord
9892d239a8
Core/Spells: renamed SPELL_ATTR5_INCLUDE_MELEE_RANGE to SPELL_ATTR5_TREAT_AS_AREA_EFFECT and handle the attribute in SpellInfo::IsAffectingArea
2022-01-16 11:44:49 +01:00
Ovahlord
520b53a5e0
Core/Spells: added a helper to determine whenever a periodic aura should roll over its duration on refresh
...
* introduce another custom spell attribute to grant full control over when or when not to roll over ticks
2022-01-14 18:46:03 +01:00
Ovahlord
2dc07876ea
Core/Spells: implement spellpower and attackpower coefficient scaling
2022-01-05 20:19:06 +01:00