Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
25,200 Commits 2 Branches 1 Tag
7680c90abd4c36d3808246792c83c52530e1eb65
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jackpoz a147770702 Core/Player: Additional fixes related to https://github.com/TrinityCore/TrinityCore/commit/ee5eaab598e445e3926edf6e12b1b2b4477c2594 
Fix whispers to players on loading screen and few other cases.
 2014-10-17 22:59:53 +02:00
jackpoz ee5eaab598 Core/Players: Fix players not being notified if on loading screen 
Fix packets not being sent to players on loading screen even if the system supports these packets to be queued and sent till the player is in world.
There might be additional cases where this applies, please report back if you find any.

Fixes #11339
 2014-10-17 22:35:28 +02:00
jackpoz 40cff79b25 Merge pull request https://github.com/TrinityCore/TrinityCore/pull/12779 from PortgasDAce/8 
Core/Spells: Fixed Range Weapon durability loss
 2014-10-15 21:07:42 +02:00
jackpoz c3276ed27c Merge pull request #13327 from Nyeriah/patch-3 
Scripts/ICC: Register Rotface's summons so they can be despawned later
 2014-10-14 17:52:56 +02:00
jackpoz 86e3737d11 Core/Movement: Fix evade issue 
Fix evade issue happening when an evading creature assists another one, causing it to stay in evading state forever.
Fix #4943
 2014-10-13 22:38:59 +02:00
jackpoz bb046ce4ed Core/Maps: Apply const-correctness to GridMap::loadData() 2014-10-12 20:01:27 +02:00
jackpoz db88bf02b5 Core/LFG: Fix Leader flag being ignored 
Fix bug added in 5ca00bc14d that removed Leader flag of LFG without ever adding it back, giving leadership to players who didn't want it.
 2014-10-07 22:15:01 +02:00
jackpoz 6501da3c94 Core/Instances: Add assert to track down a crash 
Instance reset times are supposed to be initialized on server startup and then only updated when they expire.
Refers to #11904
 2014-10-05 14:11:31 +02:00
jackpoz b33695a2ef Core/Worldserver: Fix worldserver stuck on "Halting process" on shutdown 
Partially revert 4fe45b8c63 to fix worldserver stuck on "Halting process" on shutdown.

Fixes #13201
 2014-10-03 21:21:17 +02:00
jackpoz d828d16e9e Core/AHBot: Fix reference_loot_template being excluded from ahbot items 
Fixes #13265
 2014-10-02 22:29:45 +02:00
jackpoz fb6e635c80 Core/AH: Don't send expired auctions to clients 
Fixes #12964
 2014-10-01 21:35:31 +02:00
jackpoz 5150222f19 Revert "Core/AuctionHouse: Delete expired auctions at startup." 
This reverts commit a92038feaf which caused items of expired auctions not being mailed back to the owner and leaving those items in item_instance table.

Please refer to the forum for steps to verify the integrity of your database and remove old unneeded rows in item_instance table.

Fixes #12699
 2014-09-30 21:25:58 +02:00
jackpoz 6daba66baf Core/LootMgr: Fix GCC warning 2014-09-30 20:58:50 +02:00
jackpoz 7e2ef67936 Core/LootMgr: Fix wrong bit fields padding 2014-09-30 20:38:43 +02:00
jackpoz 4ed3254aa8 Core/Scripts: Fix invalid memory write 
Fix invalid memory write caused by calling "delete this;" in a base class constructor.
 2014-09-29 20:12:03 +02:00
jackpoz c23c66f719 Core/AH: Fix Auction House items not deleted from database 
Fix some cases where Auction House items were not deleted from item_instance table of character database, for example if the owner didn't exist anymore or if the owner was the AHBot.

Updates #12699
Updates #13232
 2014-09-28 21:13:19 +02:00
jackpoz 02d497165a WorldServer/Misc: Log possible errors on shutdown 
Log possible error on shutdown happening when trying to cancel any I/O sync operation in CliThread, refers to #13201
 2014-09-28 13:49:44 +02:00
jackpoz 0af6d3a16d Core/Misc: Refactor scripts to fix static analysis warnings 
Last issue to be fixed, fixes #12960
 2014-09-26 22:58:15 +02:00
jackpoz 79b9ca4a58 Scripts/Misc: Make InstanceScript::Initialize() obsolete 
Move all InstanceScript initialization code from Initialize() to the constructor.
InstanceScript::Initialize() is now obsolete, please don't use it anymore. The only reason it's still in the sources is for backward compatibility.
 2014-09-25 22:28:20 +02:00
jackpoz 16a884d999 Core/Misc: Refactor scripts to fix static analysis warnings 
Eighth batch of fixes targeting 80 issues reported by Coverity
 2014-09-25 21:19:34 +02:00
jackpoz e77f503336 Scripts/Examples: Remove some more code related to example scripts 2014-09-22 20:25:11 +02:00
jackpoz 84efd8b92b Scripts/Examples: Remove outdated example scripts 
Remove outdated misleading example scripts not following anymore current TC codestyle and standards. Please refer to the wiki or forum for up to date examples and documentation.
 2014-09-21 22:42:50 +02:00
jackpoz 6e27841382 Core/Misc: Refactor scripts to fix static analysis warnings 
Seventh batch of fixes targeting 100 issues reported by Coverity
 2014-09-21 22:15:04 +02:00
jackpoz b71f8367e4 Scripts/Shadowmoon Valley: Fix static analysis issues added in cd48ee01c0 
Fix static analysis issues added in cd48ee01c0 about uninitialized values and pointers possibly point to free'd memory being dereferenced.
In memory of all the developers who got banned from IRC in the process of fixing these issues.
 2014-09-21 17:21:04 +02:00
jackpoz 38952576f8 Core/Misc: Update helgrind suppressions 2014-09-20 22:41:49 +02:00
jackpoz a209fc30ff Core/Misc: Avoid Helgrind reporting libstdc++ false positive race conditions 2014-09-20 22:35:13 +02:00
jackpoz b5e3535dbf Core/Misc: Refactor scripts to fix static analysis warnings 
Sixth batch of fixes targeting 100 issues reported by Coverity
 2014-09-20 20:21:54 +02:00
jackpoz 08069dfba7 Shared/Logging: Use standard format specifier for size_t 
Use standard format specified PRIuPTR for printing/logging size_t type that can be either uint32_t or uint64_t depending on platform/build configuration
 2014-09-18 21:24:40 +02:00
jackpoz 9337e257fc Merge branch 'mik1893/fear-vs-stun' 
Merge PR #13095 into master
 2014-09-14 21:03:17 +02:00
jackpoz 7d26a2ccd4 Scripts/Commands: Fix ".npc info" immune mask output 
Fix ".npc info" showing wrong immune mask list
Fixes #12358
 2014-09-14 20:58:17 +02:00
jackpoz 16f0f05d44 Core/Misc: Fix issues reported by static analysis 2014-09-14 16:34:15 +02:00
jackpoz f5a3913d95 Core/Misc: Refactor scripts to fix static analysis warnings 
Fifth batch of fixes targeting 100 issues reported by Coverity
 2014-09-13 00:01:34 +02:00
jackpoz 8bb4f33852 Core/DB: Fix crash on shutdown 
Fix race condition crash on shutdown, closing MySQL connections with queries still being executed
 2014-09-10 22:39:03 +02:00
jackpoz df7f188cfe Core/Misc: Refactor scripts to fix static analysis warnings 
Fourth batch of fixes targeting 100 issues reported by Coverity
 2014-09-07 20:12:54 +02:00
jackpoz 29b9e5f0d5 Scripts/Commands: Fix issues reported by static analysis 
Fix possible buffer overflow in ".server shutdown" and NULL-dereference/Triggered Debug Assert.
 2014-09-06 20:43:08 +02:00
jackpoz 6df2ff5efa Core/Misc: Refactor scripts to fix static analysis warnings 
Third batch of fixes targeting 100 issues reported by Coverity
 2014-09-05 22:44:24 +02:00
jackpoz 53d3becf3c Core/Misc: Refactor scripts to fix static analysis warnings 2014-09-03 22:11:41 +02:00
jackpoz 1ef0bc4d23 Core/AuctionHouse: Fix issues reported by Coverity 2014-09-02 22:11:28 +02:00
jackpoz dd4dbdcd16 Core/Misc: Refactor scripts to fix static analysis warnings 
First batch of fixes targeting 100 issues reported by Coverity
 2014-08-31 20:42:02 +02:00
jackpoz c5f475c114 Core/AuctionHouse: Fix issues reported by Coverity 2014-08-31 00:33:37 +02:00
jackpoz 04ddbc374a Core/Misc: Remove unneeded NULL checks 2014-08-28 23:07:04 +02:00
jackpoz cb591634b4 Core/AuctionHouse: Merge last changes of PR #12917 
Merge last changes of PR #12917 and fix a NULL dereference crash
 2014-08-28 22:49:45 +02:00
jackpoz 9cceb458d9 Merge branch 'Rochet2/ahbot' into master 
Close pull request #12917
 2014-08-28 22:01:58 +02:00
jackpoz 66f4b51d6f Core/RA: Workaround for telnet active mode 
Add a workaround for telnet connections with active mode. A proper fix would require boost tcp::socket to support timeout on receive.
 2014-08-27 22:10:07 +02:00
jackpoz 4d9f8b926a Scripts/Commands: Change "few" commands to target current Player by default 2014-08-25 22:00:04 +02:00
jackpoz 10b7480e70 Merge branch 'trickerer/mulreflect' into master 
Close pull request #11288
 2014-08-25 19:59:19 +02:00
jackpoz 7fa49c8d62 Scripts/Ruby Sanctum: Fix Halion event ai not being updated 
Fix Halion event ai not being updated due to private member hiding base class member.
Fixes #12835
 2014-08-24 20:35:44 +02:00
jackpoz a3b14db015 Merge 'Numielle/master' into master 
This is a workaround required by the current spell system limitations.
Close pull request #11915 .
 2014-08-24 17:11:51 +02:00
jackpoz 42c230adab Core/Spells: Fix Prayer of Mending visual bounce 
Close #12855 , thanks @P-Kito
 2014-08-24 17:05:59 +02:00
jackpoz c20f92c08c Merge branch 'Rochet2/questreward' 
Close pull request #12657
 2014-08-24 14:38:55 +02:00
jackpoz 54d28af46d Merge branch 'PortgasDAce/1' into 4.3.4 
Close pull request #12731
 2014-08-24 14:04:54 +02:00
jackpoz 05d9dcd37f Merge branch 'Xanvia/ShoR' into 4.3.4 
Close pull request #9071
 2014-08-24 13:38:54 +02:00
jackpoz f2fa1533d9 Core/Dependencies: Fix some -Wconversion warnings in G3D 2014-08-23 19:56:42 +02:00
jackpoz 7d4801750b Core/Misc: Fix Mac OS X no-pch build 2014-08-23 19:56:42 +02:00
jackpoz 7fe7f30521 Core/Misc: Fix some -Wconversion warnings 2014-08-23 19:56:41 +02:00
jackpoz 5e8277e923 Core/Dependencies: Update G3D to v9.0 r4036 2014-08-22 21:00:56 +02:00
jackpoz 4a3416627d Core/Creatures: Fixed an arithmetic error in respawn code 
Creatures should now respawn correctly in their correct time.
Issue was caused by single-precision floating-point format losing precision on lower digits with high numbers, for reference http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
Closes #12428
 2014-08-19 00:00:54 +02:00
jackpoz cb53d64191 Merge pull request #12847 from ShinDarth/tc_fix_mount_abuse_after_bg 
Core/Battleground: fixed possible mount abuse after leaving BG
 2014-08-16 18:17:46 +02:00
jackpoz f8a7d537ec Tools/MMAPs: Fix log message if mmaps folder is not found 
Fixes #12787
 2014-08-10 17:25:48 +02:00
jackpoz 272b9d3d16 Core/WorldSession: Fix socket not being closed on clean logout 
Close the WorldSession socket if Player didn't even login or logged out successfully and then closed the client.
 2014-08-09 19:37:57 +02:00
jackpoz 8402570bb8 Scripts/Misc: Fix static analysis issues 
Replace CAST_AI() macro with ENSURE_AI() when dynamic_cast is not supposed to return NULL.
 2014-08-09 00:12:20 +02:00
jackpoz 78af80230d Core/Misc: Fix static analysis issues 2014-08-08 21:14:12 +02:00
jackpoz f25a87cda0 Core/Misc: Remove unused variable 2014-08-07 19:23:01 +02:00
jackpoz d3100edccb Tools/MMAPs: Fix uninitialized value in mmap_generator 
Fix uninitialized value in mmap_generator. This fixes mmaps_generator broken in some build configurations.
Fixes #12644
 2014-08-07 18:58:21 +02:00
jackpoz 0f07dcfea6 Core/Scripts: Fix possible crash 
Fix possible NULL dereference crash spotted by Coverity.
 2014-08-06 20:55:43 +02:00
jackpoz 6c7ad9bc0b Delete 2014_08_03_03_world_creature_template.sql 2014-08-05 00:28:39 +02:00
jackpoz 15b1d41740 Core/NetworkIO: Adjust more packet throttling values 
Adjust more packet throttling values by increasing some limits, this might fix some random kicks.
 2014-08-04 18:43:15 +02:00
jackpoz 4190d84c5b Tools/MMaps: Fix static analysis issues 
Fix static analysis issue spotted by Coverity "Structurally dead code found"
 2014-07-30 20:22:32 +02:00
jackpoz 3388587b7a Core/Misc: Replace rand() calls with SFMT 2014-07-22 21:43:19 +02:00
jackpoz fe1289ed1a Core/Misc: Fix abort() on shutdown on *nix 
Wait for cliThead to exit before deleting it to about std::abort() triggered on *nix systems.
 2014-07-17 20:54:32 +02:00
jackpoz fe5d38ae7d Fix mmaps_generator build 
Remove old unneeded file breaking mmaps_generator build.
 2014-07-14 22:25:05 +02:00
jackpoz 5a84448ed7 Core/InstanceScript: Fix possible crash 
Store Boss doors/minions as GUID instead of GameObject*/Creature* to avoid accessing pointers to free'd memory.
 2014-07-13 22:47:22 +02:00
jackpoz a6494375f9 Core/Wintergrasp: Spawn npcs only after initial map configs have been set 
Spawn BATTLEFIELD_WG_NPC_STALKER only after the MapID has been set otherwise it will try to spawn it on map 0
 2014-07-06 18:32:27 +02:00
jackpoz 0f8c1d4a47 Core/Maps: Don't load vmaps/mmaps if disabled in configs 
Don't try to load vmaps/mmaps if they are disabled in the configs.
Fixes #12392
 2014-07-06 18:27:32 +02:00
jackpoz 4302226a85 Core/Spells: Fix Charge pathing 
Fallback to "straight path" pathing when raycast doesn't find a valid path.
Fixes #7931
 2014-07-04 22:00:46 +02:00
jackpoz 519d76c194 Core/VMAPs: Fix object orientation 
Merge https://github.com/249CAAFE40/mangos-wotlk/commit/2f8b8e55d99122d34be2a08cbdbd2d2b1ae172d1
Quoting original commit log:
This patch fixes 2 issues with the vmap extractor. 1) Incorrectly converts vertex coordinates. 2) Forgets to convert coordinates on triangle indices.

The effects of [1] causes models to be flipped. This isn't very noticeable on most trees as flipping a cylinder results in the same cylinder, but it's very noticeable on any non-symmetrical geometry (which, even includes trees, it's just harder to notice). [2] Didn't seem to be a problem when the coordinates were incorrectly converted, but when applying the correct conversion caused some triangles to be flipped (i.e. facing inwards).

You will need to re-extract vmaps and re-generate mmaps for these changes to take effect.

Fixes #417
 2014-07-03 22:52:36 +02:00
jackpoz c674f229cb Core/Mail: Fix exploit that didn't allow recipient to delete the email 2014-06-29 15:51:34 +02:00
jackpoz ee4602db3d Core/Battleground: Fix crash added in c28345e279 
Fix a double-delete crash added in c28345e279 caused by copy-constructor copying pointers across different Battleground instances.

Valgrind log:
 Invalid read of size 8
  at : Battleground::~Battleground() (Battleground.cpp:231)
  by : BattlegroundWS::~BattlegroundWS() (BattlegroundWS.cpp:74)
  by : BattlegroundWS::~BattlegroundWS() (BattlegroundWS.cpp:74)
  by : BattlegroundMgr::Update(unsigned int) (BattlegroundMgr.cpp:103)
  by : World::Update(unsigned int) (World.cpp:2067)
 Address 0x5675d140 is 0 bytes inside a block of size 24 free'd
  at : operator delete(void*) (vg_replace_malloc.c:509)
  by : ArenaTeamScore::~ArenaTeamScore() (ArenaScore.h:64)
  by : Battleground::~Battleground() (Battleground.cpp:231)
  by : BattlegroundWS::~BattlegroundWS() (BattlegroundWS.cpp:74)
  by : BattlegroundWS::~BattlegroundWS() (BattlegroundWS.cpp:74)
  by : BattlegroundMgr::Update(unsigned int) (BattlegroundMgr.cpp:103)
 2014-06-29 14:03:29 +02:00
jackpoz b9ec488fd1 Core/Mail: Do not allow to create multiple copies of mail 2014-06-28 19:15:20 +02:00
jackpoz e77c6fc98b Core/Mails: Fix exploit that allowed to take COD items without paying 2014-06-28 18:23:10 +02:00
jackpoz 82df3f090b Auth/Misc: Move OpenSSL version log from Warning to Information 2014-06-28 17:55:40 +02:00
jackpoz f3852d19e7 COre/Mail: Don't allow to mark delete mails as read. 2014-06-28 17:53:17 +02:00
jackpoz 22c26548f3 Merge pull request #12382 from TrinityCore/revert-12268-patch_mimironnew 
Revert "Scripts/Ulduar: Implement Mimiron"
 2014-06-28 13:49:42 +02:00
jackpoz 1bd4ff6cb9 Revert "Scripts/Ulduar: Implement Mimiron" 2014-06-28 13:49:34 +02:00
jackpoz df164bf2d7 Core/Misc: Fix gcc warnings 2014-06-27 20:55:37 +02:00
jackpoz c9a129708f Core/Mail: Fix exploit that allowed to send free emails 2014-06-26 23:11:12 +02:00
jackpoz ed5e3fceed Core/MMAPs: Update recast 
Update recast to https://github.com/memononen/recastnavigation/commit/42b96b7306d39bb7680ddb0f89d480a8296c83ff
Previous MMAPs might still work but it's recommended to re-extract them.
 2014-06-25 22:04:06 +02:00
jackpoz ff25736338 Tools/MMapsGenerator: Improve mmaps generation time on multi-core CPUs 
Queue biggest maps first for mmaps generation to avoid waiting for last map, usually map id 571.
Fix wrong maps count being printed on startup.
 2014-06-25 22:01:44 +02:00
jackpoz 7b83213521 Core/Items: Fix disenchant/refund exploit 
Fix exploit that allowed to refund an item after disenchanting it.
Closes #11227
 2014-06-23 22:40:26 +02:00
jackpoz ae80fdcb51 Core/Loot: Fix disenchant exploit 
Fix exploit that allowed to disenchant the same item multiple times.
Fixes #12116
 2014-06-22 21:47:30 +02:00
jackpoz 4fb56fbfe0 Core/Calendar: Fix memory leak in CMSG_CALENDAR_ADD_EVENT handler. 
Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received.
This properly fixes the memory leak that 51e38872c7 tried to fix, reverted in 927f16de49.
 2014-06-22 19:25:17 +02:00
jackpoz ec8cccffe9 Core/Groups: Fix UpdatePlayerOutOfRange() not updating some out of range group members 
Fix UpdatePlayerOutOfRange() not updating some out of range group members on different maps by also checking if both player and member are on same map.
 2014-06-22 14:24:51 +02:00
jackpoz 0892c71a16 Core/Dependencies: Clean up recastnavigation folder 
Remove old files from recastnavigation folder and update the structure to the same of https://github.com/memononen/recastnavigation/ to allow easier updates.
 2014-06-20 23:30:44 +02:00
jackpoz 57069b393d Core/Dependencies: Upgrade to jemalloc-3.6.0 2014-06-19 22:20:55 +02:00
jackpoz 4688676f3e Shared/Misc: Improve Windows crash report 
Improve WheatyExceptionReport Windows crash report to write a cleaner and more readable crash report, in particular:
- Fix missing variable Type in some cases
- Fix missing variable Name in some cases
- Properly format each member to avoid confusion when reading the log
- Add support for double pointers, e.g. Type**
- Add initial support for arrays, logging the number of elements and the first 10 elements for now. UDT members of array elements are not supported yet
- Skip static members, SymTagVTable and other not needed types
- Skip SymTagUDT with no children
- Fix possible stack overflows when logging strings/char*/char[] values.
- Fix "punting on symbol" error happening when trying to dereference bad pointers.
- Fix <user defined> type being logged instead of the correct type when reaching WER_MAX_NESTING_LEVEL or with pointer types with invalid addresses.
 2014-06-15 18:46:20 +02:00
jackpoz 26a7916faf Core/Misc: Fix gcc build 2014-06-11 21:40:50 +02:00
jackpoz d1d91d193d Merge commit https://github.com/Unholychick/TrinityCore/commit/52c0fc96bb4a8a62218bd383f360c0e1350ef62a 2014-06-11 21:00:16 +02:00
jackpoz f19c6f4091 Core/PetAI: Fix memory leak 
Fix memory leak added in e7f0808d46

Valgrind log:
395,712 (390,216 direct, 5,496 indirect) bytes in 229 blocks are definitely lost in loss record 65 of 67
 at operator new(unsigned long) (vg_replace_malloc.c:320)
 by PetAI::UpdateAI(unsigned int) (PetAI.cpp:167)
 by Creature::Update(unsigned int) (Creature.cpp:541)
 by TempSummon::Update(unsigned int) (TemporarySummon.cpp:47)
 2014-06-10 22:50:24 +02:00
jackpoz 5ebf24281c Core/NetworkIO: Adjust more packet throttling values 
Ignore some opcodes that don't cause any trouble.
Remove old Allow/Disable Anti-DoS system since it's no longer required.
 2014-06-09 23:11:10 +02:00
jackpoz bd4be27aeb Core/Calendar: Sanitize calendar event parameters 
Prevent events added in the past which in some conditions would cause an infinite loop in the client.
 2014-06-09 23:11:05 +02:00