Nico/Viano-Core
1
0 Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity
34,817 Commits 2 Branches 1 Tag
53968d31aa64d170cdf3bdfd61266def906a91a2
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jackpoz ebaafd20cd Core/Loot: Fix group loot if player loot recipient disconnects 
Fixes #13300
 2019-05-27 16:08:06 +02:00
jackpoz 6f19b3980f Dep/Jemalloc: Update to Jemalloc 5.2.0 2019-05-12 01:23:06 +02:00
jackpoz 836e52479b Core/Misc: Apply fatigue when flying too 
Fix #22856
 2019-05-12 01:21:36 +02:00
jackpoz 950eff5fda Core/LFG: Remove dungeon cooldown when completing random dungeons 2019-05-05 00:26:13 +02:00
jackpoz 4da12422eb Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ChaseMovementGenerator in 386b5a6fd948b4866cbd9a8a9892e8777922e9c9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned. 
The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.

# Conflicts:
#	src/server/game/Movement/MovementGenerators/ChaseMovementGenerator.cpp
 2019-04-29 08:44:37 +02:00
jackpoz 66f2bd91bb Shared/Metric: Fix a rare memory leak 
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread.
 2019-04-27 21:10:05 +02:00
jackpoz a730e17a37 Core/Commands: Fix .cheat god command letting you die 
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
 2019-04-27 21:09:46 +02:00
jackpoz 0020ea9f92 Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon() 
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).
 2019-04-27 21:08:52 +02:00
jackpoz 738aa92782 Core/Spells: Adjust range checks to GameObject targets 2019-04-26 18:01:19 +02:00
jackpoz 85bf4daf45 Core/Spells: Adjust range checks to GameObject targets 2019-04-26 18:01:12 +02:00
jackpoz d99de4db33 Core/Spells: Add range checks to GameObject targets 
Close #23062
Patch by robinsch
 2019-04-26 18:01:05 +02:00
jackpoz 5ef08fa5e8 Core/GameObject: Code cleanup 
(cherry picked from commit 16a154c4e87ff1ff89323a8960bf601e6c18589b)
 2019-04-26 17:53:43 +02:00
jackpoz 237901719a Core/MMaps: Fix crash added in 386b5a6fd948b4866cbd9a8a9892e8777922e9c9 
# Conflicts:
#	src/server/game/Movement/MovementGenerators/ChaseMovementGenerator.cpp

* fixed cherrypick conflicts
 2019-04-14 12:27:49 +02:00
jackpoz 5cb3e69e1e Core/MMaps: Simplify d182e5f7e73e614185f4470429467befd6e03981 and handle PATHFIND_INCOMPLETE in ChaseMovementGenerator as "cannot reach the target" 
# Conflicts:
#	src/server/game/Movement/MovementGenerators/ChaseMovementGenerator.cpp
 2019-04-14 12:13:59 +02:00
jackpoz 6552a00208 Core/MMaps: Fallback to shortcut for flying units if Detour returned an incomplete path. 
Fallback to shortcut for flying units if Detour returned an incomplete path. This is needed when a flying unit should fly to the floor below to reach the target, but since Recastnavigation doesn't support "jumping down" the unit would not find a path to the target.
 2019-04-14 12:12:15 +02:00
jackpoz 6fbf6d73db Dep/Recast: Update recastnavigation to https://github.com/recastnavigation/recastnavigation/commit/54bb0943e5174a71eeeca11919920f685760a4f0 
(cherry picked from commit e061663508191f7782dd62c7e13b5ea804f58f67)

# Conflicts:
#	dep/recastnavigation/Detour/Source/DetourCommon.cpp
 2019-04-14 12:11:34 +02:00
jackpoz 927d7518ca Dep/Jemalloc: Update to Jemalloc 5.1.0 2018-05-12 13:24:51 +02:00
jackpoz a5cad33ba0 Scripts/Icecrown Citadel: Fix "intended" crash 
Change an assert (that can happen easily using ".npc add") to a sanity check
 2018-05-12 13:23:44 +02:00
jackpoz 7df6a6bbcb Dep/Boost: Fix crash in Boost 
Work around a NULL dereference exception happening in boost::asio::ip::tcp::resolver::results_type, resulting in a crash when trying to bind on an address that cannot be resolved.
Fixes #21884
 2018-04-29 17:46:44 +02:00
jackpoz 19ce97eae4 Core/SmartScripts: Code cleanup 2018-03-12 12:40:23 +01:00
jackpoz 86f03d79cc Core/Spells: Revert SPELL_ATTR2_IGNORE_ITEM_CHECK to unknown 
Revert SPELL_ATTR2_IGNORE_ITEM_CHECK to unknown, too many spells unrelated to items have this attribute and the current handling was causing exploits with "Mote of Water" and other elements.
Fix #19547
 2018-02-18 18:37:00 +01:00
jackpoz bb70a60ba7 Core/Misc: Add PERFORMANCE_PROFILING CMake option 
Add a new CMake option called PERFORMANCE_PROFILING that should be used only when profiling the performance.
This option is unsupported, do not report any issue happening when enabling this option.
 2018-02-18 18:36:32 +01:00
jackpoz 4a7089b10a Core/Misc: ASSERT() cleanup 
Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.
 2018-02-18 18:00:27 +01:00
jackpoz bee461eda8 Core/Player: Add some asserts 
Assert PlayerInfo for race/class pair in a few Player functions
 2018-02-16 01:04:11 +01:00
jackpoz 46467499f3 Scripting/Obsidian Sanctum: Fix crash 
Fix crash caused by calling Reset() in constructor (which is not allowed)
 2018-02-16 01:03:56 +01:00
jackpoz d1df97db23 Shared/Database: Improve dead-lock error handling 
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times
 2018-02-10 16:16:14 +01:00
jackpoz 8e5c1d012d Core/Misc: Fix no-pch build 2018-02-10 11:34:26 +01:00
jackpoz 57314740da Core/AI: Fix assertion triggered with PetAI derived scripts (#21254) 
* Core/AI: Fix assertion triggered with PetAI derived scripts

Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.
 2018-02-10 11:33:51 +01:00
jackpoz b263e63a50 Core/Crash reporting: Add support to char* arrays 
Add support to char* array showing the string value instead of the pointer address
 2018-01-01 16:14:37 +01:00
jackpoz e72f6e31be Core/Misc: Removed unneeded checks 2018-01-01 16:13:59 +01:00
jackpoz 5a61b3ce5e Core/Misc: Fix static analysis issues 2018-01-01 15:50:42 +01:00
jackpoz ff26ce4f97 Core/CreatureAI: Disable PetAI from database 2017-12-26 17:28:29 +01:00
jackpoz 4283252731 Shared/Metric: Fix crash on shutdown 
Fix crash on shutdown with metrics enabled but InfluxDB stopping before worldserver
 2017-12-17 15:37:30 +01:00
jackpoz 90344d2dd8 Core/Spells: Fixed Naxx Anub Scarab Summoning Spell 
Reduce spell radius of 28864 and 29105 from 100 yards to 10 yards to spawn scarabs closer
 2017-12-17 10:50:37 +01:00
jackpoz 21cad46097 Core/Misc: Fix static analysis issues 2017-12-08 15:24:13 +01:00
jackpoz 814d938194 Core/Misc: Fix static analysis issues 
Fix coverity id 1382860
 2017-12-08 12:50:28 +01:00
jackpoz 84abf3a1a6 Shared/Metric: Stop metrics on shutdown 
Properly stop metric information gathering and sending on shutdown.
Issue reported by AddressSanitizer.
 2017-12-03 17:12:20 +01:00
jackpoz d9501acb3f Core/Spell: Validate spell_dbc DB data on startup 
Validate spell_dbc DB data on startup (max effect type, max aura type, max target type).
Delete some invalid spells from spell_dbc table. Make sure to apply the SQL script or worldserver will assert on startup.
 2017-12-03 17:11:41 +01:00
jackpoz 081e7aa708 Core/Misc: Fix out of bounds access on startup 
Fix out of bound access on startup trying to access SpellEffects with ID greater than max allowed/known.
Reported by AddressSanitizer .
 2017-12-02 12:58:34 +01:00
jackpoz 27be32968d Core/Crash reporting: Fix buffer overflow 2017-12-02 05:11:07 +01:00
jackpoz 2507d601b7 Core/CreatureAI: Disable TotemAI from database 
Disable TotemAI set in creature_template, triggering an assert when spawning the creature
 2017-12-02 05:10:57 +01:00
jackpoz a693169a7e Dep/Jemalloc: Enable MADV_FREE if available 2017-11-30 08:44:33 +01:00
jackpoz 05b568813f Dep/Jemalloc: Temporarily disable MADV_FREE 
Temporarily disable MADV_FREE until CMake file is modified to check if MADV_FREE is available on the current system.
This fixes the build on older systems.
 2017-11-30 08:44:16 +01:00
jackpoz 52a53ea2ab Core/Maps: Fix memory leak in BoundaryUnionBoundary 
Add missing destructor in BoundaryUnionBoundary to avoid reporting a memory leak (even if it's used only in a global variable)
 2017-11-26 12:31:36 +01:00
jackpoz 55637dc00d Core/Quests: Fix memory leak in Quest Greeting 2017-11-26 11:53:49 +01:00
jackpoz 41469a4161 Dep/Jemalloc: Update to Jemalloc 5.0.1 2017-11-25 14:03:02 +01:00
jackpoz 5dee28845c Dep/Jemalloc: Update to Jemalloc 4.0.4 2017-11-19 19:24:08 +01:00
jackpoz 259e534cca Tools/MMaps: Improve MMaps quality 
Lower Detail Sample Distance and Detail Sample Max Error to get more accurate MMap data, in particular mmap height.
More info about Detail Mesh at http://digestingduck.blogspot.it/2009_07_01_archive.html and http://digestingduck.blogspot.it/2009_08_01_archive.html
 2017-11-19 18:03:35 +01:00
jackpoz c62b81dd8b Dep/Recast: Update recastnavigation to recastnavigation/recastnavigation@2c85309 2017-11-19 18:03:17 +01:00
jackpoz 67dc6a7576 Core/Misc: Fix static analysis issues 2017-11-12 13:24:42 +01:00
jackpoz 790c2b6e80 Dep/G3D: Add static assert checks for Array functions being used with non-POD types 2017-11-12 13:20:51 +01:00
jackpoz 3410edfdae Core/Misc: Fix static analysis issues 2017-07-17 18:51:56 +02:00
jackpoz 2102bd28a3 Core/Scripts: Simplify code 
Partially revert 753e7074d84b5a2e8d3c3e92d25c54bb25ba477e and 12c680f9b1f1068099c3b19443d93d456690ac56 to simplify the code and to only remove GMs from the target list.
 2017-06-09 13:25:59 +02:00
jackpoz 1664c1bd2e Core/Misc: Fix static analysis issues 2017-04-26 05:09:44 +02:00
jackpoz d01f1d31bd Core/Misc: Fix static analysis issues 2017-04-26 05:09:21 +02:00
jackpoz 53939cd14e Core/Misc: Fix static analysis issues 2017-04-09 18:17:51 +02:00
jackpoz d64db19d82 Core/Crash: Refactor and fixes 
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.
 2017-03-20 16:53:22 +01:00
jackpoz e36790b312 Core/Misc: Fix static analysis issues 2017-03-03 01:26:40 +01:00
jackpoz 175339c9d2 Dep/G3D: Backport warning fix from G3D10 2016-10-24 11:08:18 +02:00
jackpoz 2dfa3298c8 Scripts/Azjol-Nerub: fix static analysis issues 2016-10-22 10:50:37 +02:00
jackpoz 71d4d34d33 Scripts/ICC: Fix chest loot exploit 
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.
 2016-09-25 10:10:57 +02:00
jackpoz 58e4568c36 Core/Commands: Code cleanup 
Remove commented out code
 2016-08-21 13:14:27 +02:00
jackpoz 8fcb5ace9d Core/Battleground: Fix crash happening when reporting afk a nonexistent player 2016-08-20 14:43:15 +02:00
jackpoz bb2db482da Revert "Core/Battlegrounds: Properly readd player to Battleground containers after a login." 
This reverts commit fbc521084cdd57d8e33071961aa3100e0fab2596.
Fixes #17810
 2016-08-20 06:15:27 +02:00
jackpoz 90b22c6cd4 Core/MMAPs: Update recast 
Update recast to recastnavigation/recastnavigation@64385e9
 2016-08-18 09:46:18 +02:00
jackpoz e6c7894be1 Tools/MMapGenerator: Avoid saving uninitialized padding bytes to disk 
Initialize padding bytes in MmapTileHeader struct to avoid saving uninitialized data to disk, causing issues when binary-comparing *.mmtile files.
 2016-08-18 09:35:04 +02:00
jackpoz 1d6adef396 Common/Common: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-12 11:58:55 +02:00
jackpoz 0f965a530e Common/Threading: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-04 23:48:39 +02:00
jackpoz 44165712ca Common/Logging: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-04 21:56:30 +02:00
jackpoz e8bc203651 Common/Debugging: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-04 20:57:38 +02:00
jackpoz 5dcb395e90 Common/Crypto: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-03 23:35:34 +02:00
jackpoz 3c66feafcc Common/Maps: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-03 22:39:59 +02:00
jackpoz 8cd5cefaf6 Common/Maps: Reduce differences between 3.3.5 and 6.x branches 
Code functionality shouldn't have been modified.
 2016-08-03 19:48:38 +02:00
jackpoz 242917e461 Core/Group: Do not allow a player to invite himself 
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix #17664
 2016-08-03 11:56:29 +02:00
jackpoz 648b8859d5 Core/Crash reporting: Better handle max nesting level setting 
Fix wheaty exception report counting reference symbols as 2 nesting levels, not logging child objects in some cases, i.e. spell id in SpellEvent crash.
 2016-07-20 18:30:50 +02:00
jackpoz d255975122 Core/Creature: Fix assertion triggered 
Fix assertion triggered when a Creature was summoned at an invalid position with Auras loaded as Creature addons.
Fix #17415
 2016-07-20 18:13:32 +02:00
jackpoz 4aa993607a Core/Player: Fix duel edge case crash 
Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.
 2016-07-20 15:50:04 +02:00
jackpoz d9f485273c Core/VMaps: Fix some vmap height edge cases 
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.
 2016-07-20 15:45:05 +02:00
jackpoz 5fa4faac38 Core/Creatures: Fix dead creatures spawn position on restart 
Fix dead flying creatures ignoring being spawned below the floor in instances on server restart because of not taking into account vmap height.
Fix #16777
 2016-05-12 00:19:58 +02:00
jackpoz 510bb30b2c Scripts/Misc: Fix issues reported by static analysis 2016-03-06 16:11:55 +01:00
jackpoz 31cd082833 Scripts/Ulduar: Fix crash 
Change an assert to a NULL check on Flame Leviathan vehicle kit, it can be NULL on map unload.
Close #16662
 2016-02-27 12:02:32 +01:00
jackpoz d75469e31f Scripts/Deadmines: Fix issues reported by static analysis 
Fix Coverity issue id 1022474
 2016-01-30 00:13:22 +01:00
jackpoz 0e76d67e49 Scripts/Misc: Fix issues reported by static analysis 2016-01-23 17:42:37 +01:00
jackpoz 1a5b0067a3 Core/Commands: Fix NULL dereference crash 
Closes #15833

(cherry picked from commit abd4e2e0f1)

Conflicts:
	src/server/game/Chat/Chat.cpp
 2016-01-11 01:51:49 -03:00
jackpoz 5ebfe5a297 Scripts/EyeOfEternity: Fix crash 
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900

(cherry picked from commit 6e296ddaa2)
 2016-01-11 01:51:46 -03:00
jackpoz 308d30417c Core/Player: Fix crash related to vehicles 
Fix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix #15953

(cherry picked from commit 2cb54d5606)
 2016-01-11 01:51:42 -03:00
jackpoz 9fe26765b4 Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login 
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.

(cherry picked from commit 5f917e2286)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
 2016-01-11 01:51:28 -03:00
jackpoz e59b4324b8 Merge pull request #15977 from tkrokli/landmine_knockback_achievement 
Scripts/Spells: Mine Sweeper achievement
 2016-01-09 23:19:09 +01:00
jackpoz 4191bb868a Scripts/ICC: Fix static analysis issue 
Fix an issue reported by static analysis
 2016-01-09 21:53:53 +01:00
jackpoz e138e094a9 Scripts/Commands: Modify ".setskill" command to target current Player by default 2016-01-09 18:37:17 +01:00
jackpoz b39216eed3 Merge pull request #16186 from ariel-/spellmodcharges 
Core/Spells: Fix redundant mod charge drop and spell crit calc
 2016-01-09 16:51:39 +01:00
jackpoz b1d0855624 Core/Spells: Fix static analysis issues and a crash 
Fix confusing NULL checks in Raise Ally check cast.
Fix a crash in Raise Ally triggered by executing ".cast back 61999" command targeting a pet in raid while being dead.
 2016-01-08 23:13:15 +01:00
jackpoz 2a50ea5cf1 Merge pull request #16193 from Goatform/3.3.5 
Core/GameObjects: Fixed an issue where traps were not redirected to Grounding Totem
 2016-01-07 19:27:40 +01:00
jackpoz 1c89b4dcdf Merge pull request #16188 from Asterc/3.3.5 
Core/Player: Fix profession specialization being re-learnt on login after unlearning it
 2016-01-05 22:10:20 +01:00
jackpoz 841ce54a0d Scripts/Commands: Fix ".help" command to show commands in alphabetical order 2016-01-04 23:30:46 +01:00
jackpoz f22b1938db Scripts/Commands: Modify ".learn" command to target current Player by default 2016-01-04 22:44:19 +01:00
jackpoz e6903fdffa Merge pull request #15852 from Golrag/icc_boss_aggro 2015-12-15 21:29:10 +01:00
jackpoz bf5419e28e Merge pull request #16006 from rockz1152/3.3.5 
Core/Player: Fix Weapon Skillup on low level mobs

Remove check for skill up on grey level mobs
 2015-12-15 21:07:05 +01:00
jackpoz b96704774b Merge pull request #15919 from Treeston/3.3.5-razuvious 2015-12-14 20:34:12 +01:00
jackpoz 263f127d07 Merge pull request #14896 from Ofinka/dupl 2015-12-12 17:43:35 +01:00