Commit Graph
1702 Commits
Author SHA1 Message Date
Aokromes 7315052d34 Core/Channel: revamp channel system (#17980)
* Core/Channel: change the way channels are stored and sent to client.

- Fixes multiple channels per zone when using different locales
- Connected clients will receive locally the name of the channel for their apropiate locale (if available)
- In other cases default locale name will be sent, so as to prevent breaking channel chat for those players
2016-10-22 10:21:18 +02:00
Aokromes 57d0a5d16d Revert "Core/Spells: Implementation of QAston proc system"
This reverts commit a70e4e26b3.
2016-10-21 07:27:04 +02:00
Aokromes a70e4e26b3 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-05 13:19:51 +02:00
SnapperRy 828026bede Core/Quest: send INVALIDREASON_QUEST_ALREADY_DONE if player tries to accept a quest that is already rewarded. 2016-10-04 06:35:17 +02:00
ariel- 6ee820afe4 Core/Player: correct logic for IsUsingTwoHandedWeaponInOneHand
Fixes penalty not being applied when we are using a 2H in offhand, and a unarmed MH.
MH may do unarmed attacks in this case. (reciprocal of 2H MH, unarmed OH, only uses MH normally, OH doesn't unarmed attack)
2016-10-03 14:57:51 +02:00
Aokromes 576cfa8328 Core/Player: unconditionally remove Titan's grip penalty aura on Spel…
…l removal

Was causing an issue when switching spec, because off hand weapon was still equipped
2016-10-03 14:53:39 +02:00
Aokromes d9ae70396b Core/Player: Implemented Titan's Grip damage reduction 2016-10-03 14:51:20 +02:00
joschiwald de1322f134 Core/Player: fixed math error
(cherry picked from commit cc1e2fd452e83281a6fe4c60ed1ee277a0e7a16d)
2016-10-03 14:42:19 +02:00
SnapperRy 83dafd5886 Core/Spell: set quest to rewarded instead of complete when targeted by SPELL_EFFECT_QUEST_COMPLETE. (#18021)
Prevents people from ending up with strange quests in their quest logs.
2016-10-01 16:47:49 +02:00
SnapperRy 7dff45e2af Core/Gossip: improve gossips related to Dual Talent Specialization 2016-09-24 07:01:49 +02:00
Aokromes 9182a19aa5 Core/Fishing: implement retail-like fishing skill-up functionality 2016-09-14 15:13:04 +02:00
Rochet2 19ed813f6b Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865) 2016-09-10 14:25:57 +02:00
Aokromes df2c6972c4 Whitespace clean-up 2016-08-29 01:20:31 +02:00
Ryan e344fc9cbf Core/Instance: Fix GetInstanceSave sometimes checking the wrong map (#17856) 2016-08-26 00:01:40 +02:00
ariel- f404226fb1 Channel Followup: avoid setting an invisible gm as Channel owner (#17597)
* Core/Chat: avoid setting an invisible gm (as in .gm visible off) as channel owner, giving it away to other players.

- This can now only happen if the channel is empty or every other member is an invisible gm, too.

Fixes #17424

* Feedback based changes
2016-08-25 15:00:55 +02:00
ariel- 716ad14257 Core/Entities: fix a crash that would happen whenever a player logged back in to an ended arena battle. Thanks Nawuko for the input
Closes #17825
2016-08-21 13:15:52 +02:00
SnapperRy c2f65d822b Core/SpellArea: only check against spell_area entries for the current quest when updating quest status
Closes #17804
2016-08-20 18:26:31 +02:00
Aokromes 8d12a82f5b Core/Player: readd player to battleground after a login (but only after adding it to map, preventing a crash). 2016-08-20 06:18:56 +02:00
treeston 77e4a1e487 Revert "Creature/Loot: Fix a bug that prevented players from looting creatures that only had gold on them (no items)."
This reverts commit 63f577a7ef4df2d6ebf90fc137c3cb8902b29d0a.

See discussion in commit comments.
2016-08-16 23:34:40 +02:00
treeston 0ffd02f540 Creature/Loot: Fix a bug that prevented players from looting creatures that only had gold on them (no items). 2016-08-16 15:35:01 +02:00
ariel- b92ba1e11d Core/Player: Do not kick AFK player from BG if it's a GM 2016-08-16 12:26:54 +02:00
Aokromes 34c249458f Fix compile after coding style 2016-08-14 21:04:15 +02:00
Aokromes 6443c02225 Compile fix 2016-08-14 20:26:57 +02:00
PORTELAS Michael 6f22ed66c3 Update Player.cpp 2016-08-14 18:04:41 +00:00
PORTELAS Michael 41fbfa3b14 Update Player.cpp 2016-08-14 17:05:08 +00:00
treeston 1fc6f18024 Entities/Player: Fixed an edge case bug that could cause a character to get stuck in forced recustomization indefinitely if two or more appearance properties were out of bounds. 2016-08-14 10:16:32 +02:00
Aokromes 0852050e68 Core/Logs: Fine tune more logs
And move others to more logical appenders
2016-08-12 12:18:19 +02:00
Aokromes 6a9c753029 Build fix, this time yes 2016-08-12 07:51:26 +02:00
Aokromes 7ab4915b13 compile fix 2016-08-11 05:05:33 +02:00
Aokromes 64a693a4ae Core/Chat: general cleanup and revamping: (#17576)
- Remove duplicate ObjectGuid in Channel (both as key and value member)
- Add const-ness to Channel methods
- NULL->nullptr
- const type* -> type const*
- Removed all instances of std::map::operator[] except where it is actually INTENDED to insert an element
- Use Trinity::StringFormat instead of snprintf
2016-08-11 03:56:10 +02:00
Aokromes e51220bf87 Core/Handlers: actually check allowed trainer classes and races to avoid spoofing 2016-08-10 21:04:30 +02:00
Aokromes da3f7d464c Core/PVP: Move report AFK requirement to config (#17699) 2016-08-03 11:42:59 +02:00
Aokromes 4bc52061e6 Core/Quests: Delete all quest bound items on quest reward, failure or abandoning
By runningnak3d
2016-07-30 12:13:01 +02:00
Nyeriah fd1a0cd4f0 Core/Player: Actually close tickets when characters are deleted
* Solves issue with tickets being open indefinitely if characters are deleted while tickets are still open
2016-07-30 12:05:27 +02:00
ariel- 88bb891a71 Core/Misc: fix issues reported by static analysis 2016-07-26 03:15:20 -03:00
ariel- 4a96106d60 Core/Spells: finish porting SPELL_AURA_MOD_SPELL_CATEGORY_COOLDOWN handling from 6.x 2016-07-23 06:11:56 -03:00
ariel- 1eeff3a295 Core/Player: misc codestyle 2016-07-23 04:20:44 -03:00
ariel- 65d6a4cca1 Core/Player: Misc codestyle 2016-07-20 19:51:39 +02:00
SnapperRy 836b9180fe Core/Mail: implement a way to specify NPC sender for mails when they should be different from the quest ender (#17601) 2016-07-20 19:46:37 +02:00
ariel- ef8e83f99d Core/Player: silence warning 2016-07-20 19:40:53 +02:00
Aokromes 79c5d21d36 Core/Conditions: implement CONDITION_DAILY_QUEST_DONE to check whethe…
…r or not a daily quest has been completed by a player in that day.

Also use it to fix two quest chains broken in commit 7905651. Should be the only ones of their kind.
2016-07-20 19:40:21 +02:00
Shauren 286e796a55 Core/Quests: Failing/abandoning a quest should not unconditionally remove required items, non-quest specific items such as crafting reagents should remain in inventory 2016-07-20 19:31:30 +02:00
Brian 43686f2c7f Core/Quests: Remove quest items that were looted if they are unique, bound, quest items, when abandoning a quest. (#17556) 2016-07-20 19:31:09 +02:00
SnapperRy 3fa8965fff Core/SpellArea: iterate spell_area entries by player's current area instead of quest id. (#17509) 2016-07-20 19:22:25 +02:00
Snapper c82ecf4976 Core/Misc: use enum for UNIIT_NPC_FLAGS' zero values 2016-07-20 19:17:06 +02:00
Aokromes 543953fb75 Core/Player: Move few logs of loglevel and add few notes (#17554) 2016-07-20 19:16:43 +02:00
Snapper 429a4bc13b Core/Misc: kill whitespace and use enum instead of hardcoded value. 2016-07-20 19:16:18 +02:00
SnapperRy 6f7dc7e86d Core/Quest: don't save queststatus for autocomplete quests (#17487) 2016-07-20 19:15:50 +02:00
SnapperRy a8a8ff596d Core/Quest: do not save/load Dungeon Finder/daily/repeatable quests as completed (#17458)
* Core/Quest: do not save/load Dungeon Finder/daily/repeatable quests as completed
2016-07-20 18:33:33 +02:00
Treeston 257a0b5f6f Creature/Loot: Do not display "lootable" sparkles for player even if others in the group still have quest items to be looted from creature. (#16265) 2016-07-20 18:05:51 +02:00